* [PATCH v2] drm/i915/gem: Pin the L-shape quirked object as unshrinkable
@ 2021-05-13 12:07 ` Matthew Auld
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Auld @ 2021-05-13 12:07 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, Chris Wilson
From: Chris Wilson <chris@chris-wilson.co.uk>
When instantiating a tiled object on an L-shaped memory machine, we mark
the object as unshrinkable to prevent the shrinker from trying to swap
out the pages. We have to do this as we do not know the swizzling on the
individual pages, and so the data will be scrambled across swap out/in.
Not only do we need to move the object off the shrinker list, we need to
mark the object with shrink_pin so that the counter is consistent across
calls to madvise.
v2: in the madvise ioctl we need to check if the object is currently
shrinkable/purgeable, not if the object type supports shrinking
Fixes: 0175969e489a ("drm/i915/gem: Use shrinkable status for unknown swizzle quirks")
References: https://gitlab.freedesktop.org/drm/intel/-/issues/3293
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 ++
drivers/gpu/drm/i915/i915_gem.c | 11 +++++------
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index aed8a37ccdc9..7361971c177d 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -63,6 +63,8 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj,
i915->quirks & QUIRK_PIN_SWIZZLED_PAGES) {
GEM_BUG_ON(i915_gem_object_has_tiling_quirk(obj));
i915_gem_object_set_tiling_quirk(obj);
+ GEM_BUG_ON(!list_empty(&obj->mm.link));
+ atomic_inc(&obj->mm.shrink_pin);
shrinkable = false;
}
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index d0018c5f88bd..cffd7f4f87dc 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1009,12 +1009,11 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
obj->mm.madv = args->madv;
if (i915_gem_object_has_pages(obj)) {
- struct list_head *list;
+ unsigned long flags;
- if (i915_gem_object_is_shrinkable(obj)) {
- unsigned long flags;
-
- spin_lock_irqsave(&i915->mm.obj_lock, flags);
+ spin_lock_irqsave(&i915->mm.obj_lock, flags);
+ if (!list_empty(&obj->mm.link)) {
+ struct list_head *list;
if (obj->mm.madv != I915_MADV_WILLNEED)
list = &i915->mm.purge_list;
@@ -1022,8 +1021,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
list = &i915->mm.shrink_list;
list_move_tail(&obj->mm.link, list);
- spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
}
+ spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
}
/* if the object is no longer attached, discard its backing storage */
--
2.26.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/gem: Pin the L-shape quirked object as unshrinkable
@ 2021-05-13 12:07 ` Matthew Auld
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Auld @ 2021-05-13 12:07 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, Chris Wilson
From: Chris Wilson <chris@chris-wilson.co.uk>
When instantiating a tiled object on an L-shaped memory machine, we mark
the object as unshrinkable to prevent the shrinker from trying to swap
out the pages. We have to do this as we do not know the swizzling on the
individual pages, and so the data will be scrambled across swap out/in.
Not only do we need to move the object off the shrinker list, we need to
mark the object with shrink_pin so that the counter is consistent across
calls to madvise.
v2: in the madvise ioctl we need to check if the object is currently
shrinkable/purgeable, not if the object type supports shrinking
Fixes: 0175969e489a ("drm/i915/gem: Use shrinkable status for unknown swizzle quirks")
References: https://gitlab.freedesktop.org/drm/intel/-/issues/3293
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 ++
drivers/gpu/drm/i915/i915_gem.c | 11 +++++------
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index aed8a37ccdc9..7361971c177d 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -63,6 +63,8 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj,
i915->quirks & QUIRK_PIN_SWIZZLED_PAGES) {
GEM_BUG_ON(i915_gem_object_has_tiling_quirk(obj));
i915_gem_object_set_tiling_quirk(obj);
+ GEM_BUG_ON(!list_empty(&obj->mm.link));
+ atomic_inc(&obj->mm.shrink_pin);
shrinkable = false;
}
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index d0018c5f88bd..cffd7f4f87dc 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1009,12 +1009,11 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
obj->mm.madv = args->madv;
if (i915_gem_object_has_pages(obj)) {
- struct list_head *list;
+ unsigned long flags;
- if (i915_gem_object_is_shrinkable(obj)) {
- unsigned long flags;
-
- spin_lock_irqsave(&i915->mm.obj_lock, flags);
+ spin_lock_irqsave(&i915->mm.obj_lock, flags);
+ if (!list_empty(&obj->mm.link)) {
+ struct list_head *list;
if (obj->mm.madv != I915_MADV_WILLNEED)
list = &i915->mm.purge_list;
@@ -1022,8 +1021,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
list = &i915->mm.shrink_list;
list_move_tail(&obj->mm.link, list);
- spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
}
+ spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
}
/* if the object is no longer attached, discard its backing storage */
--
2.26.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Pin the L-shape quirked object as unshrinkable (rev2)
2021-05-13 12:07 ` [Intel-gfx] " Matthew Auld
(?)
@ 2021-05-13 13:07 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-05-13 13:07 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 11689 bytes --]
== Series Details ==
Series: drm/i915/gem: Pin the L-shape quirked object as unshrinkable (rev2)
URL : https://patchwork.freedesktop.org/series/90065/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10074 -> Patchwork_20121
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/index.html
Known issues
------------
Here are the changes found in Patchwork_20121 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +6 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_fence@nb-await@vecs0:
- fi-bsw-nick: [PASS][2] -> [FAIL][3] ([i915#3457]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-bsw-nick/igt@gem_exec_fence@nb-await@vecs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-bsw-nick/igt@gem_exec_fence@nb-await@vecs0.html
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][4] -> [FAIL][5] ([i915#1888])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_wait@wait@all:
- fi-bsw-kefka: [PASS][7] -> [FAIL][8] ([i915#3457]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-bsw-kefka/igt@gem_wait@wait@all.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-bsw-kefka/igt@gem_wait@wait@all.html
* igt@i915_module_load@reload:
- fi-kbl-soraka: NOTRUN -> [DMESG-WARN][9] ([i915#1982] / [i915#3457])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-kbl-soraka/igt@i915_module_load@reload.html
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][10] ([i915#2782] / [i915#3462] / [i915#794])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][11] ([i915#1886] / [i915#2291])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@mman:
- fi-kbl-soraka: NOTRUN -> [DMESG-WARN][12] ([i915#3457])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-kbl-soraka/igt@i915_selftest@live@mman.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#533])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-elk-e7500: [PASS][15] -> [FAIL][16] ([i915#53]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-elk-e7500/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-elk-e7500/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
* igt@runner@aborted:
- fi-kbl-soraka: NOTRUN -> [FAIL][17] ([i915#1436] / [i915#2426] / [i915#3363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-kbl-soraka/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_fence@basic-await@rcs0:
- fi-elk-e7500: [FAIL][18] ([i915#3457]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-elk-e7500/igt@gem_exec_fence@basic-await@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-elk-e7500/igt@gem_exec_fence@basic-await@rcs0.html
* igt@gem_exec_fence@basic-await@vcs0:
- fi-bsw-kefka: [FAIL][20] ([i915#3457]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-bsw-kefka/igt@gem_exec_fence@basic-await@vcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-bsw-kefka/igt@gem_exec_fence@basic-await@vcs0.html
* igt@gem_exec_fence@nb-await@bcs0:
- fi-bsw-nick: [FAIL][22] ([i915#3457]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-bsw-nick/igt@gem_exec_fence@nb-await@bcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-bsw-nick/igt@gem_exec_fence@nb-await@bcs0.html
* igt@gem_wait@wait@all:
- fi-pnv-d510: [FAIL][24] ([i915#3457]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-pnv-d510/igt@gem_wait@wait@all.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-pnv-d510/igt@gem_wait@wait@all.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-elk-e7500: [FAIL][26] ([i915#53]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-elk-e7500/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-elk-e7500/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-ilk-650: [FAIL][28] ([i915#53]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-ilk-650/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-ilk-650/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
#### Warnings ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][30] ([i915#3457]) -> [FAIL][31] ([i915#3457] / [i915#3472])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
- fi-ilk-650: [FAIL][32] ([i915#3457]) -> [FAIL][33] ([i915#3472])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-ilk-650/igt@gem_exec_gttfill@basic.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-ilk-650/igt@gem_exec_gttfill@basic.html
* igt@i915_module_load@reload:
- fi-elk-e7500: [DMESG-WARN][34] ([i915#3457]) -> [DMESG-FAIL][35] ([i915#3457])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-elk-e7500/igt@i915_module_load@reload.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-elk-e7500/igt@i915_module_load@reload.html
- fi-bsw-kefka: [DMESG-WARN][36] ([i915#1982] / [i915#3457]) -> [DMESG-FAIL][37] ([i915#1982] / [i915#3457])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-bsw-kefka/igt@i915_module_load@reload.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-bsw-kefka/igt@i915_module_load@reload.html
- fi-bsw-nick: [DMESG-FAIL][38] ([i915#3457]) -> [DMESG-WARN][39] ([i915#3457])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-bsw-nick/igt@i915_module_load@reload.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-bsw-nick/igt@i915_module_load@reload.html
* igt@i915_selftest@live@mman:
- fi-bwr-2160: [DMESG-FAIL][40] ([i915#3457]) -> [DMESG-WARN][41] ([i915#3457])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-bwr-2160/igt@i915_selftest@live@mman.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-bwr-2160/igt@i915_selftest@live@mman.html
* igt@runner@aborted:
- fi-skl-6600u: [FAIL][42] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][43] ([i915#1436] / [i915#3363])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-skl-6600u/igt@runner@aborted.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-skl-6600u/igt@runner@aborted.html
- fi-bdw-5557u: [FAIL][44] -> [FAIL][45] ([i915#1602] / [i915#2029])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-bdw-5557u/igt@runner@aborted.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-bdw-5557u/igt@runner@aborted.html
- fi-skl-6700k2: [FAIL][46] ([i915#1436] / [i915#3363]) -> [FAIL][47] ([i915#1436] / [i915#2426] / [i915#3363])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/fi-skl-6700k2/igt@runner@aborted.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/fi-skl-6700k2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
[i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3457]: https://gitlab.freedesktop.org/drm/intel/issues/3457
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[i915#3472]: https://gitlab.freedesktop.org/drm/intel/issues/3472
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794
Participating hosts (43 -> 28)
------------------------------
Additional (1): fi-kbl-soraka
Missing (16): fi-kbl-7567u fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-icl-u2 fi-cfl-8700k fi-tgl-1115g4 fi-kbl-7500u fi-bsw-cyan fi-hsw-4770 fi-cfl-guc fi-dg1-1 fi-kbl-x1275 fi-cfl-8109u fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10074 -> Patchwork_20121
CI-20190529: 20190529
CI_DRM_10074: 5aefdc1f23734b6a3d545c8497b098ba4d704a0c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6083: d28aee5c5f528aa6c352c3339f20aaed4d698ffa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_20121: b759221a9170ef753c8796370848d5f75e099bf2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b759221a9170 drm/i915/gem: Pin the L-shape quirked object as unshrinkable
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/index.html
[-- Attachment #1.2: Type: text/html, Size: 15194 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Pin the L-shape quirked object as unshrinkable (rev2)
2021-05-13 12:07 ` [Intel-gfx] " Matthew Auld
(?)
(?)
@ 2021-05-13 18:27 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-05-13 18:27 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30290 bytes --]
== Series Details ==
Series: drm/i915/gem: Pin the L-shape quirked object as unshrinkable (rev2)
URL : https://patchwork.freedesktop.org/series/90065/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10074_full -> Patchwork_20121_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20121_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20121_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20121_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-snb: NOTRUN -> [INCOMPLETE][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
* igt@kms_flip_tiling@flip-changes-tiling@hdmi-a-1-pipe-c:
- shard-glk: [PASS][2] -> [FAIL][3] +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk8/igt@kms_flip_tiling@flip-changes-tiling@hdmi-a-1-pipe-c.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk5/igt@kms_flip_tiling@flip-changes-tiling@hdmi-a-1-pipe-c.html
* igt@kms_plane_cursor@pipe-a-overlay-size-256:
- shard-snb: NOTRUN -> [FAIL][4] +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@kms_plane_cursor@pipe-a-overlay-size-256.html
#### Warnings ####
* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-skl: [INCOMPLETE][5] ([i915#3468]) -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-skl7/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl7/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
* igt@gem_mmap_gtt@fault-concurrent-y:
- shard-iclb: [INCOMPLETE][7] ([i915#3468]) -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-iclb7/igt@gem_mmap_gtt@fault-concurrent-y.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb3/igt@gem_mmap_gtt@fault-concurrent-y.html
Known issues
------------
Here are the changes found in Patchwork_20121_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@delta-check:
- shard-apl: NOTRUN -> [DMESG-WARN][9] ([i915#3457])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl6/igt@api_intel_bb@delta-check.html
* igt@api_intel_bb@offset-control:
- shard-snb: NOTRUN -> [DMESG-WARN][10] ([i915#3457]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@api_intel_bb@offset-control.html
- shard-skl: NOTRUN -> [DMESG-WARN][11] ([i915#3457])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl8/igt@api_intel_bb@offset-control.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: NOTRUN -> [DMESG-WARN][12] ([i915#180] / [i915#3457]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl3/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#1099]) +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed-process.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][14] -> [FAIL][15] ([i915#2842] / [i915#3457])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb6/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@bcs0:
- shard-glk: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#3457])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk4/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#3209] / [i915#3457])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk3/igt@gem_exec_fair@basic-pace@vcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk3/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][19] ([i915#2842] / [i915#3457])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_flush@basic-uc-ro-default:
- shard-glk: [PASS][20] -> [INCOMPLETE][21] ([i915#2944] / [i915#3457])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk9/igt@gem_exec_flush@basic-uc-ro-default.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk4/igt@gem_exec_flush@basic-uc-ro-default.html
* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-skl: NOTRUN -> [FAIL][22] ([i915#2389] / [i915#3457]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl8/igt@gem_exec_reloc@basic-wide-active@bcs0.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][23] ([i915#2389] / [i915#3457]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb5/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_exec_schedule@preempt-self@vcs0:
- shard-apl: [PASS][24] -> [FAIL][25] ([i915#3457]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-apl3/igt@gem_exec_schedule@preempt-self@vcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl7/igt@gem_exec_schedule@preempt-self@vcs0.html
* igt@gem_exec_schedule@u-fairslice@vecs0:
- shard-glk: NOTRUN -> [FAIL][26] ([i915#3457]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk5/igt@gem_exec_schedule@u-fairslice@vecs0.html
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([i915#180]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-kbl1/igt@gem_exec_suspend@basic-s3.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl4/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [PASS][29] -> [DMESG-WARN][30] ([i915#118] / [i915#95])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk5/igt@gem_exec_whisper@basic-contexts-all.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk5/igt@gem_exec_whisper@basic-contexts-all.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy:
- shard-glk: [PASS][31] -> [INCOMPLETE][32] ([i915#3468]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk4/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk5/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-apl: NOTRUN -> [INCOMPLETE][33] ([i915#3468]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl8/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-tglb: [PASS][34] -> [INCOMPLETE][35] ([i915#3468])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-tglb6/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-tglb1/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
* igt@gem_mmap_gtt@cpuset-medium-copy-xy:
- shard-iclb: [PASS][36] -> [INCOMPLETE][37] ([i915#3468])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-iclb6/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb3/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
* igt@gem_mmap_gtt@fault-concurrent-y:
- shard-skl: NOTRUN -> [INCOMPLETE][38] ([i915#3468])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl7/igt@gem_mmap_gtt@fault-concurrent-y.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][39] ([i915#2658])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@yf-tiled-ccs-to-linear:
- shard-skl: NOTRUN -> [INCOMPLETE][40] ([i915#198] / [i915#3468])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl1/igt@gem_render_copy@yf-tiled-ccs-to-linear.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109312])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@gem_softpin@evict-snoop-interruptible.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3323])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl3/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@set-cache-level:
- shard-kbl: NOTRUN -> [FAIL][43] ([i915#3324])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl6/igt@gem_userptr_blits@set-cache-level.html
* igt@gem_wait@await@rcs0:
- shard-apl: NOTRUN -> [FAIL][44] ([i915#3457]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl7/igt@gem_wait@await@rcs0.html
* igt@gem_workarounds@suspend-resume:
- shard-skl: [PASS][45] -> [INCOMPLETE][46] ([i915#198] / [i915#3457]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-skl4/igt@gem_workarounds@suspend-resume.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl1/igt@gem_workarounds@suspend-resume.html
- shard-kbl: [PASS][47] -> [DMESG-WARN][48] ([i915#180] / [i915#3457])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-kbl2/igt@gem_workarounds@suspend-resume.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl4/igt@gem_workarounds@suspend-resume.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [PASS][49] -> [DMESG-WARN][50] ([i915#3389])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-snb7/igt@i915_module_load@reload-with-fault-injection.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@cursor-dpms:
- shard-iclb: [PASS][51] -> [DMESG-WARN][52] ([i915#3457])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-iclb3/igt@i915_pm_rpm@cursor-dpms.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@i915_pm_rpm@cursor-dpms.html
* igt@i915_pm_rpm@gem-mmap-type@uc:
- shard-glk: [PASS][53] -> [DMESG-WARN][54] ([i915#3475])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk5/igt@i915_pm_rpm@gem-mmap-type@uc.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk7/igt@i915_pm_rpm@gem-mmap-type@uc.html
- shard-kbl: [PASS][55] -> [DMESG-WARN][56] ([i915#3475])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-kbl2/igt@i915_pm_rpm@gem-mmap-type@uc.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl2/igt@i915_pm_rpm@gem-mmap-type@uc.html
- shard-apl: [PASS][57] -> [DMESG-WARN][58] ([i915#3475])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-apl7/igt@i915_pm_rpm@gem-mmap-type@uc.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl7/igt@i915_pm_rpm@gem-mmap-type@uc.html
* igt@i915_pm_rpm@gem-mmap-type@wc:
- shard-apl: [PASS][59] -> [DMESG-WARN][60] ([i915#3457]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-apl7/igt@i915_pm_rpm@gem-mmap-type@wc.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl7/igt@i915_pm_rpm@gem-mmap-type@wc.html
* igt@i915_pm_rps@reset:
- shard-kbl: NOTRUN -> [DMESG-WARN][61] ([i915#3457]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl2/igt@i915_pm_rps@reset.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-iclb: NOTRUN -> [SKIP][62] ([fdo#110723])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109284] / [fdo#111827]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +13 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [fdo#111827]) +8 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl7/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-c-ctm-green-to-red:
- shard-snb: NOTRUN -> [SKIP][66] ([fdo#109271] / [fdo#111827]) +21 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@kms_color_chamelium@pipe-c-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-d-ctm-green-to-red:
- shard-skl: NOTRUN -> [SKIP][67] ([fdo#109271] / [fdo#111827]) +4 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl8/igt@kms_color_chamelium@pipe-d-ctm-green-to-red.html
* igt@kms_content_protection@atomic-dpms:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109300] / [fdo#111066])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_content_protection@atomic-dpms.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen:
- shard-skl: NOTRUN -> [FAIL][69] ([i915#3444] / [i915#3457]) +5 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding:
- shard-snb: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#3457]) +47 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding.html
* igt@kms_cursor_crc@pipe-a-cursor-max-size-random:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#3457]) +8 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-max-size-random.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen:
- shard-snb: NOTRUN -> [FAIL][72] ([i915#3457]) +6 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-512x170-onscreen:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109278] / [fdo#109279] / [i915#3457])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_cursor_crc@pipe-b-cursor-512x170-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-onscreen:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#3457]) +7 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-512x512-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
- shard-apl: NOTRUN -> [FAIL][75] ([i915#3444] / [i915#3457]) +4 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl7/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
* igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
- shard-kbl: [PASS][76] -> [FAIL][77] ([i915#3444] / [i915#3457]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-random:
- shard-apl: [PASS][78] -> [FAIL][79] ([i915#3444] / [i915#3457]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
* igt@kms_cursor_crc@pipe-c-cursor-64x64-offscreen:
- shard-kbl: NOTRUN -> [FAIL][80] ([i915#3444] / [i915#3457]) +8 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-64x64-offscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-64x64-random:
- shard-glk: [PASS][81] -> [FAIL][82] ([i915#3444] / [i915#3457]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk9/igt@kms_cursor_crc@pipe-c-cursor-64x64-random.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk4/igt@kms_cursor_crc@pipe-c-cursor-64x64-random.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-sliding:
- shard-kbl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#3457]) +16 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl6/igt@kms_cursor_crc@pipe-d-cursor-256x256-sliding.html
* igt@kms_cursor_crc@pipe-d-cursor-256x85-random:
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109278] / [i915#3457])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_cursor_crc@pipe-d-cursor-256x85-random.html
* igt@kms_cursor_edge_walk@pipe-c-128x128-left-edge:
- shard-glk: [PASS][85] -> [FAIL][86] ([i915#70])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk5/igt@kms_cursor_edge_walk@pipe-c-128x128-left-edge.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk7/igt@kms_cursor_edge_walk@pipe-c-128x128-left-edge.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][87] ([fdo#109271]) +346 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-snb6/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
- shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271]) +57 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl8/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109274] / [fdo#109278])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic.html
* igt@kms_cursor_legacy@pipe-d-torture-move:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109278])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_cursor_legacy@pipe-d-torture-move.html
* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109274])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [PASS][92] -> [FAIL][93] ([i915#2122])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2672])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109280]) +6 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-pwrite:
- shard-tglb: [PASS][96] -> [INCOMPLETE][97] ([i915#750])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-pwrite.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-pwrite.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- shard-glk: [PASS][98] -> [FAIL][99] ([i915#53]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk5/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#533])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl3/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [PASS][101] -> [INCOMPLETE][102] ([i915#198])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][103] ([fdo#108145] / [i915#265]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
- shard-apl: NOTRUN -> [FAIL][104] ([fdo#108145] / [i915#265]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
- shard-kbl: NOTRUN -> [FAIL][105] ([fdo#108145] / [i915#265]) +2 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_cursor@pipe-a-primary-size-128:
- shard-kbl: NOTRUN -> [FAIL][106] ([i915#2657]) +2 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl2/igt@kms_plane_cursor@pipe-a-primary-size-128.html
* igt@kms_plane_cursor@pipe-a-primary-size-64:
- shard-skl: NOTRUN -> [FAIL][107] ([i915#2657] / [i915#3457] / [i915#3461])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl7/igt@kms_plane_cursor@pipe-a-primary-size-64.html
* igt@kms_plane_cursor@pipe-a-viewport-size-128:
- shard-skl: NOTRUN -> [FAIL][108] ([i915#2657] / [i915#3457])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl8/igt@kms_plane_cursor@pipe-a-viewport-size-128.html
* igt@kms_plane_cursor@pipe-a-viewport-size-256:
- shard-iclb: NOTRUN -> [FAIL][109] ([i915#2657] / [i915#3461])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_plane_cursor@pipe-a-viewport-size-256.html
* igt@kms_plane_cursor@pipe-b-viewport-size-64:
- shard-glk: [PASS][110] -> [FAIL][111] ([i915#2657])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk3/igt@kms_plane_cursor@pipe-b-viewport-size-64.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk3/igt@kms_plane_cursor@pipe-b-viewport-size-64.html
* igt@kms_plane_cursor@pipe-c-primary-size-128:
- shard-iclb: [PASS][112] -> [FAIL][113] ([i915#2657] / [i915#3461])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-iclb2/igt@kms_plane_cursor@pipe-c-primary-size-128.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb7/igt@kms_plane_cursor@pipe-c-primary-size-128.html
* igt@kms_plane_cursor@pipe-c-primary-size-64:
- shard-kbl: NOTRUN -> [FAIL][114] ([i915#2657] / [i915#3457])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl2/igt@kms_plane_cursor@pipe-c-primary-size-64.html
* igt@kms_plane_multiple@atomic-pipe-d-tiling-x:
- shard-kbl: NOTRUN -> [SKIP][115] ([fdo#109271]) +109 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl6/igt@kms_plane_multiple@atomic-pipe-d-tiling-x.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-iclb: NOTRUN -> [SKIP][116] ([i915#658])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#658]) +2 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
- shard-skl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#658]) +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#658]) +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][120] -> [DMESG-WARN][121] ([i915#180] / [i915#295])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-glk: [PASS][122] -> [FAIL][123] ([i915#43])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk8/igt@kms_vblank@pipe-c-accuracy-idle.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk5/igt@kms_vblank@pipe-c-accuracy-idle.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][124] ([fdo#109271] / [i915#2437])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl8/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-iclb: NOTRUN -> [SKIP][125] ([i915#2437])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@kms_writeback@writeback-fb-id.html
* igt@perf@per-context-mode-unprivileged:
- shard-iclb: NOTRUN -> [SKIP][126] ([fdo#109289])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@perf@per-context-mode-unprivileged.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][127] -> [FAIL][128] ([i915#1542])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-skl4/igt@perf@polling-parameterized.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-skl9/igt@perf@polling-parameterized.html
* igt@perf_pmu@busy-check-all@vcs0:
- shard-glk: [PASS][129] -> [FAIL][130] ([i915#3457]) +29 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10074/shard-glk5/igt@perf_pmu@busy-check-all@vcs0.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-glk5/igt@perf_pmu@busy-check-all@vcs0.html
* igt@perf_pmu@busy-idle-no-semaphores@vecs0:
- shard-apl: NOTRUN -> [WARN][131] ([i915#3457]) +3 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl6/igt@perf_pmu@busy-idle-no-semaphores@vecs0.html
* igt@prime_mmap_coherency@read:
- shard-kbl: NOTRUN -> [INCOMPLETE][132] ([i915#3468])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-kbl3/igt@prime_mmap_coherency@read.html
* igt@prime_nv_pcopy@test3_5:
- shard-apl: NOTRUN -> [SKIP][133] ([fdo#109271]) +63 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-apl8/igt@prime_nv_pcopy@test3_5.html
* igt@prime_nv_test@nv_i915_sharing:
- shard-iclb: NOTRUN -> [SKIP][134] ([fdo#109291])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/shard-iclb8/igt@prime_nv_test@nv_i915_sharing.html
* igt@prime_vgem@sync@bcs0:
- shard-tglb: [PASS][135] -> [INCOMPLET
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20121/index.html
[-- Attachment #1.2: Type: text/html, Size: 33633 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/i915/gem: Pin the L-shape quirked object as unshrinkable
2021-05-13 12:07 ` [Intel-gfx] " Matthew Auld
@ 2021-05-14 13:20 ` Ville Syrjälä
-1 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2021-05-14 13:20 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx, dri-devel, Chris Wilson
On Thu, May 13, 2021 at 01:07:56PM +0100, Matthew Auld wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> When instantiating a tiled object on an L-shaped memory machine, we mark
> the object as unshrinkable to prevent the shrinker from trying to swap
> out the pages. We have to do this as we do not know the swizzling on the
> individual pages, and so the data will be scrambled across swap out/in.
>
> Not only do we need to move the object off the shrinker list, we need to
> mark the object with shrink_pin so that the counter is consistent across
> calls to madvise.
>
> v2: in the madvise ioctl we need to check if the object is currently
> shrinkable/purgeable, not if the object type supports shrinking
>
> Fixes: 0175969e489a ("drm/i915/gem: Use shrinkable status for unknown swizzle quirks")
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/3293
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
This one seems to fare better than v1.
Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 ++
> drivers/gpu/drm/i915/i915_gem.c | 11 +++++------
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
> index aed8a37ccdc9..7361971c177d 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
> @@ -63,6 +63,8 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj,
> i915->quirks & QUIRK_PIN_SWIZZLED_PAGES) {
> GEM_BUG_ON(i915_gem_object_has_tiling_quirk(obj));
> i915_gem_object_set_tiling_quirk(obj);
> + GEM_BUG_ON(!list_empty(&obj->mm.link));
> + atomic_inc(&obj->mm.shrink_pin);
> shrinkable = false;
> }
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index d0018c5f88bd..cffd7f4f87dc 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1009,12 +1009,11 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
> obj->mm.madv = args->madv;
>
> if (i915_gem_object_has_pages(obj)) {
> - struct list_head *list;
> + unsigned long flags;
>
> - if (i915_gem_object_is_shrinkable(obj)) {
> - unsigned long flags;
> -
> - spin_lock_irqsave(&i915->mm.obj_lock, flags);
> + spin_lock_irqsave(&i915->mm.obj_lock, flags);
> + if (!list_empty(&obj->mm.link)) {
> + struct list_head *list;
>
> if (obj->mm.madv != I915_MADV_WILLNEED)
> list = &i915->mm.purge_list;
> @@ -1022,8 +1021,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
> list = &i915->mm.shrink_list;
> list_move_tail(&obj->mm.link, list);
>
> - spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
> }
> + spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
> }
>
> /* if the object is no longer attached, discard its backing storage */
> --
> 2.26.3
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/gem: Pin the L-shape quirked object as unshrinkable
@ 2021-05-14 13:20 ` Ville Syrjälä
0 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2021-05-14 13:20 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx, dri-devel, Chris Wilson
On Thu, May 13, 2021 at 01:07:56PM +0100, Matthew Auld wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> When instantiating a tiled object on an L-shaped memory machine, we mark
> the object as unshrinkable to prevent the shrinker from trying to swap
> out the pages. We have to do this as we do not know the swizzling on the
> individual pages, and so the data will be scrambled across swap out/in.
>
> Not only do we need to move the object off the shrinker list, we need to
> mark the object with shrink_pin so that the counter is consistent across
> calls to madvise.
>
> v2: in the madvise ioctl we need to check if the object is currently
> shrinkable/purgeable, not if the object type supports shrinking
>
> Fixes: 0175969e489a ("drm/i915/gem: Use shrinkable status for unknown swizzle quirks")
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/3293
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
This one seems to fare better than v1.
Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 ++
> drivers/gpu/drm/i915/i915_gem.c | 11 +++++------
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
> index aed8a37ccdc9..7361971c177d 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
> @@ -63,6 +63,8 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj,
> i915->quirks & QUIRK_PIN_SWIZZLED_PAGES) {
> GEM_BUG_ON(i915_gem_object_has_tiling_quirk(obj));
> i915_gem_object_set_tiling_quirk(obj);
> + GEM_BUG_ON(!list_empty(&obj->mm.link));
> + atomic_inc(&obj->mm.shrink_pin);
> shrinkable = false;
> }
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index d0018c5f88bd..cffd7f4f87dc 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1009,12 +1009,11 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
> obj->mm.madv = args->madv;
>
> if (i915_gem_object_has_pages(obj)) {
> - struct list_head *list;
> + unsigned long flags;
>
> - if (i915_gem_object_is_shrinkable(obj)) {
> - unsigned long flags;
> -
> - spin_lock_irqsave(&i915->mm.obj_lock, flags);
> + spin_lock_irqsave(&i915->mm.obj_lock, flags);
> + if (!list_empty(&obj->mm.link)) {
> + struct list_head *list;
>
> if (obj->mm.madv != I915_MADV_WILLNEED)
> list = &i915->mm.purge_list;
> @@ -1022,8 +1021,8 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
> list = &i915->mm.shrink_list;
> list_move_tail(&obj->mm.link, list);
>
> - spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
> }
> + spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
> }
>
> /* if the object is no longer attached, discard its backing storage */
> --
> 2.26.3
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-14 13:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 12:07 [PATCH v2] drm/i915/gem: Pin the L-shape quirked object as unshrinkable Matthew Auld
2021-05-13 12:07 ` [Intel-gfx] " Matthew Auld
2021-05-13 13:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Pin the L-shape quirked object as unshrinkable (rev2) Patchwork
2021-05-13 18:27 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-05-14 13:20 ` [PATCH v2] drm/i915/gem: Pin the L-shape quirked object as unshrinkable Ville Syrjälä
2021-05-14 13:20 ` [Intel-gfx] " Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.