From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70CAFC433ED for ; Thu, 13 May 2021 13:18:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CF0461433 for ; Thu, 13 May 2021 13:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233957AbhEMNTv (ORCPT ); Thu, 13 May 2021 09:19:51 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:58478 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233908AbhEMNSk (ORCPT ); Thu, 13 May 2021 09:18:40 -0400 Date: Thu, 13 May 2021 13:17:26 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1620911847; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=05xg9LBO1PrI50ZNRoniTyWkX247WTmcQVM2MRXgyBg=; b=DJjR9OV9d/3x8kVs6qMPZQXxxXB4PtX7xycgESJSClLelHIS7XnZUHmnK5Nv7QdSSsLWIK DAsHt0znpbVYqsLzIYhfbJvw1GgPiSwJ57WO2r5HPnQyiYreziGHDX95QjgApzN8AZYkT9 l5A6ONg37CrXDxHz09to49dqtX4VTh0CKMD+IqOdBYn1itkUr5vCMhLspm5ZsAIrRYeNQC Wi9/55JeP9l5xcp4ojG2aMe1kx6pVw8F6NEqGQ/3KTzLN5MqeGHemNmOLcRvev/P9l0G2J XcQ/ZUfq1aXxP3ZSvFVhRmLBI1OAb6eUSwn3DYb3OwAzhY6b6WoFoZScY2Ielg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1620911847; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=05xg9LBO1PrI50ZNRoniTyWkX247WTmcQVM2MRXgyBg=; b=dQufZow39I3k81O9wu9U6dt1lrDxA2IZ791GdsdQ28R2tpumxkTCazFJv4XWNqa5JbUlcU 7SSEUz/n1oIp54BQ== From: "tip-bot2 for Peter Zijlstra" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/nohz] tick/nohz: Call tick_nohz_task_switch() with interrupts disabled Cc: Peter Zijlstra , Frederic Weisbecker , Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20210512232924.150322-10-frederic@kernel.org> References: <20210512232924.150322-10-frederic@kernel.org> MIME-Version: 1.0 Message-ID: <162091184636.29796.12181915470545082709.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the timers/nohz branch of tip: Commit-ID: 0fdcccfafcffac70b452b3127cc3d981f0117655 Gitweb: https://git.kernel.org/tip/0fdcccfafcffac70b452b3127cc3d981f0117655 Author: Peter Zijlstra AuthorDate: Thu, 13 May 2021 01:29:23 +02:00 Committer: Ingo Molnar CommitterDate: Thu, 13 May 2021 14:21:23 +02:00 tick/nohz: Call tick_nohz_task_switch() with interrupts disabled Call tick_nohz_task_switch() slightly earlier after the context switch to benefit from disabled IRQs. This way the function doesn't need to disable them once more. Signed-off-by: Peter Zijlstra Signed-off-by: Frederic Weisbecker Signed-off-by: Ingo Molnar Link: https://lore.kernel.org/r/20210512232924.150322-10-frederic@kernel.org --- kernel/sched/core.c | 2 +- kernel/time/tick-sched.c | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 78e480f..8f86ac2 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4212,6 +4212,7 @@ static struct rq *finish_task_switch(struct task_struct *prev) vtime_task_switch(prev); perf_event_task_sched_in(prev, current); finish_task(prev); + tick_nohz_task_switch(); finish_lock_switch(rq); finish_arch_post_lock_switch(); kcov_finish_switch(current); @@ -4257,7 +4258,6 @@ static struct rq *finish_task_switch(struct task_struct *prev) put_task_struct_rcu_user(prev); } - tick_nohz_task_switch(); return rq; } diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 197a3bd..6ea619d 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -487,13 +487,10 @@ void tick_nohz_dep_clear_signal(struct signal_struct *sig, enum tick_dep_bits bi */ void __tick_nohz_task_switch(void) { - unsigned long flags; struct tick_sched *ts; - local_irq_save(flags); - if (!tick_nohz_full_cpu(smp_processor_id())) - goto out; + return; ts = this_cpu_ptr(&tick_cpu_sched); @@ -502,8 +499,6 @@ void __tick_nohz_task_switch(void) atomic_read(¤t->signal->tick_dep_mask)) tick_nohz_full_kick(); } -out: - local_irq_restore(flags); } /* Get the boot-time nohz CPU list from the kernel parameters. */