[Intel-gfx] [PATCH v2 1/4] drm/i915/display: Fix fastsets involving PSR

[Intel-gfx] [PATCH v2 1/4] drm/i915/display: Fix fastsets involving PSR

[José Roberto de Souza]

Commit 78b772e1a01f ("drm/i915/display: Fill PSR state during hardware
configuration read out") is not allowing fastsets to happen when PSR
states changes but PSR is a feature that can be enabled and disabled
during fastsets.

So here moving the PSR pipe conf checks to a block that is only
executed when checking if HW state matches with requested state, not
during the phase where it checks if fastset is possible or not.

There still a state mismatch not allowing fastsets between states
turning off or on PSR because of crtc_state->infoframes.enable
BIT(DP_SDP_VSC) but at least for now it will allow a fastset between
PSR1 <-> PSR2, that is a case heavilly used by CI due to pipe CRC not
work with PSR2, but the remaning issue will be fixed in a future patch.

Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: 78b772e1a01f ("drm/i915/display: Fill PSR state during hardware configuration read out")
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 0c2b194006f8..51f499271cc8 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -8548,6 +8548,11 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 		bp_gamma = intel_color_get_gamma_bit_precision(pipe_config);
 		if (bp_gamma)
 			PIPE_CONF_CHECK_COLOR_LUT(gamma_mode, hw.gamma_lut, bp_gamma);
+
+		PIPE_CONF_CHECK_BOOL(has_psr);
+		PIPE_CONF_CHECK_BOOL(has_psr2);
+		PIPE_CONF_CHECK_BOOL(enable_psr2_sel_fetch);
+		PIPE_CONF_CHECK_I(dc3co_exitline);
 	}
 
 	PIPE_CONF_CHECK_BOOL(double_wide);
@@ -8631,11 +8636,6 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 	PIPE_CONF_CHECK_I(vrr.flipline);
 	PIPE_CONF_CHECK_I(vrr.pipeline_full);
 
-	PIPE_CONF_CHECK_BOOL(has_psr);
-	PIPE_CONF_CHECK_BOOL(has_psr2);
-	PIPE_CONF_CHECK_BOOL(enable_psr2_sel_fetch);
-	PIPE_CONF_CHECK_I(dc3co_exitline);
-
 #undef PIPE_CONF_CHECK_X
 #undef PIPE_CONF_CHECK_I
 #undef PIPE_CONF_CHECK_BOOL
-- 
2.31.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2 2/4] drm/i915/display: Allow fastsets when DP_SDP_VSC infoframe do not match with PSR enabled

[José Roberto de Souza]

When PSR is enabled it handles DP_SDP_VSC, changing revision and all
the other fields as necessary.
It can also enabled and disable this SDP as needed without a full
modeset.

So here masking DP_SDP_VSC bit when previous and future state PSR
enabled, it will still be checked when comparing the asked state
to what was programmed to hardware.

Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: 78b772e1a01f ("drm/i915/display: Fill PSR state during hardware configuration read out"
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 51f499271cc8..ebac1bd5cfe5 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -8260,6 +8260,16 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 	} \
 } while (0)
 
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+	if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+		pipe_config_mismatch(fastset, crtc, __stringify(name), \
+				     "(expected 0x%08x, found 0x%08x)", \
+				     current_config->name & (mask), \
+				     pipe_config->name & (mask)); \
+		ret = false; \
+	} \
+} while (0)
+
 #define PIPE_CONF_CHECK_I(name) do { \
 	if (current_config->name != pipe_config->name) { \
 		pipe_config_mismatch(fastset, crtc, __stringify(name), \
@@ -8606,7 +8616,12 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 		PIPE_CONF_CHECK_I(min_voltage_level);
 	}
 
-	PIPE_CONF_CHECK_X(infoframes.enable);
+	if (fastset && (current_config->has_psr || pipe_config->has_psr))
+		PIPE_CONF_CHECK_X_WITH_MASK(infoframes.enable,
+					    ~intel_hdmi_infoframe_enable(DP_SDP_VSC));
+	else
+		PIPE_CONF_CHECK_X(infoframes.enable);
+
 	PIPE_CONF_CHECK_X(infoframes.gcp);
 	PIPE_CONF_CHECK_INFOFRAME(avi);
 	PIPE_CONF_CHECK_INFOFRAME(spd);
-- 
2.31.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2 3/4] drm/i915/display: Nuke has_infoframe

[José Roberto de Souza]

This was only reduntant information has_hdmi_sink can do the same job.
set_infoframes() hooks will call intel_write_infoframe() for the
supported infoframes types and it will only be enabled if given type
is set in crtc_state->infoframes.enable.

While at it also fixing the style of dig_port->set_infoframes() calls.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/g4x_hdmi.c       | 22 ++++++-------------
 drivers/gpu/drm/i915/display/intel_ddi.c      | 17 +++++---------
 drivers/gpu/drm/i915/display/intel_display.c  |  6 ++---
 .../drm/i915/display/intel_display_types.h    |  3 ---
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |  4 ++--
 drivers/gpu/drm/i915/display/intel_hdmi.c     | 13 +++++------
 6 files changed, 22 insertions(+), 43 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c b/drivers/gpu/drm/i915/display/g4x_hdmi.c
index be352e9f0afc..f35db96e6239 100644
--- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
+++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
@@ -105,9 +105,6 @@ static void intel_hdmi_get_config(struct intel_encoder *encoder,
 	pipe_config->infoframes.enable |=
 		intel_hdmi_infoframes_enabled(encoder, pipe_config);
 
-	if (pipe_config->infoframes.enable)
-		pipe_config->has_infoframe = true;
-
 	if (tmp & HDMI_AUDIO_ENABLE)
 		pipe_config->has_audio = true;
 
@@ -343,9 +340,7 @@ static void intel_disable_hdmi(struct intel_atomic_state *state,
 		intel_set_pch_fifo_underrun_reporting(dev_priv, PIPE_A, true);
 	}
 
-	dig_port->set_infoframes(encoder,
-				       false,
-				       old_crtc_state, old_conn_state);
+	dig_port->set_infoframes(encoder, false, old_crtc_state, old_conn_state);
 
 	intel_dp_dual_mode_set_tmds_output(intel_hdmi, false);
 }
@@ -390,9 +385,8 @@ static void intel_hdmi_pre_enable(struct intel_atomic_state *state,
 
 	intel_hdmi_prepare(encoder, pipe_config);
 
-	dig_port->set_infoframes(encoder,
-				       pipe_config->has_infoframe,
-				       pipe_config, conn_state);
+	dig_port->set_infoframes(encoder, pipe_config->has_hdmi_sink,
+				 pipe_config, conn_state);
 }
 
 static void vlv_hdmi_pre_enable(struct intel_atomic_state *state,
@@ -410,9 +404,8 @@ static void vlv_hdmi_pre_enable(struct intel_atomic_state *state,
 				 0x2b245f5f, 0x00002000,
 				 0x5578b83a, 0x2b247878);
 
-	dig_port->set_infoframes(encoder,
-			      pipe_config->has_infoframe,
-			      pipe_config, conn_state);
+	dig_port->set_infoframes(encoder, pipe_config->has_hdmi_sink,
+				 pipe_config, conn_state);
 
 	g4x_enable_hdmi(state, encoder, pipe_config, conn_state);
 
@@ -487,9 +480,8 @@ static void chv_hdmi_pre_enable(struct intel_atomic_state *state,
 	/* Use 800mV-0dB */
 	chv_set_phy_signal_level(encoder, pipe_config, 128, 102, false);
 
-	dig_port->set_infoframes(encoder,
-			      pipe_config->has_infoframe,
-			      pipe_config, conn_state);
+	dig_port->set_infoframes(encoder, pipe_config->has_hdmi_sink,
+				 pipe_config, conn_state);
 
 	g4x_enable_hdmi(state, encoder, pipe_config, conn_state);
 
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index b7a2fce684c9..5bc5528f3091 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2722,9 +2722,8 @@ static void intel_ddi_pre_enable_hdmi(struct intel_atomic_state *state,
 
 	intel_ddi_enable_pipe_clock(encoder, crtc_state);
 
-	dig_port->set_infoframes(encoder,
-				 crtc_state->has_infoframe,
-				 crtc_state, conn_state);
+	dig_port->set_infoframes(encoder, crtc_state->has_hdmi_sink, crtc_state,
+				 conn_state);
 }
 
 static void intel_ddi_pre_enable(struct intel_atomic_state *state,
@@ -2765,9 +2764,8 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
 		/* FIXME precompute everything properly */
 		/* FIXME how do we turn infoframes off again? */
 		if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink)
-			dig_port->set_infoframes(encoder,
-						 crtc_state->has_infoframe,
-						 crtc_state, conn_state);
+			dig_port->set_infoframes(encoder, true, crtc_state,
+						 conn_state);
 	}
 }
 
@@ -2813,8 +2811,8 @@ static void intel_ddi_post_disable_dp(struct intel_atomic_state *state,
 	enum phy phy = intel_port_to_phy(dev_priv, encoder->port);
 
 	if (!is_mst)
-		intel_dp_set_infoframes(encoder, false,
-					old_crtc_state, old_conn_state);
+		intel_dp_set_infoframes(encoder, false, old_crtc_state,
+					old_conn_state);
 
 	/*
 	 * Power down sink before disabling the port, otherwise we end
@@ -3569,9 +3567,6 @@ static void intel_ddi_read_func_ctl(struct intel_encoder *encoder,
 		pipe_config->infoframes.enable |=
 			intel_hdmi_infoframes_enabled(encoder, pipe_config);
 
-		if (pipe_config->infoframes.enable)
-			pipe_config->has_infoframe = true;
-
 		if (temp & TRANS_DDI_HDMI_SCRAMBLING)
 			pipe_config->hdmi_scrambling = true;
 		if (temp & TRANS_DDI_HIGH_TMDS_CHAR_RATE)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index ebac1bd5cfe5..5d68b253bdfe 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7594,9 +7594,8 @@ static void intel_dump_pipe_config(const struct intel_crtc_state *pipe_config,
 	}
 
 	drm_dbg_kms(&dev_priv->drm,
-		    "audio: %i, infoframes: %i, infoframes enabled: 0x%x\n",
-		    pipe_config->has_audio, pipe_config->has_infoframe,
-		    pipe_config->infoframes.enable);
+		    "audio: %i, infoframes enabled: 0x%x\n",
+		    pipe_config->has_audio, pipe_config->infoframes.enable);
 
 	if (pipe_config->infoframes.enable &
 	    intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL))
@@ -8508,7 +8507,6 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 
 	PIPE_CONF_CHECK_BOOL(hdmi_scrambling);
 	PIPE_CONF_CHECK_BOOL(hdmi_high_tmds_clock_ratio);
-	PIPE_CONF_CHECK_BOOL(has_infoframe);
 	/* FIXME do the readout properly and get rid of this quirk */
 	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_BIGJOINER_SLAVE))
 		PIPE_CONF_CHECK_BOOL(fec_enable);
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 9c0adfc60c6f..669c5d8a2131 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -952,9 +952,6 @@ struct intel_crtc_state {
 	 * between pch encoders and cpu encoders. */
 	bool has_pch_encoder;
 
-	/* Are we sending infoframes on the attached port */
-	bool has_infoframe;
-
 	/* CPU Transcoder for the pipe. Currently this can only differ from the
 	 * pipe on Haswell and later (where we have a special eDP transcoder)
 	 * and Broxton (where we have special DSI transcoders). */
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 332d2f9fda5c..1eb54f8ed51a 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -435,8 +435,8 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state,
 	 * the transcoder clock select is set to none.
 	 */
 	if (last_mst_stream)
-		intel_dp_set_infoframes(&dig_port->base, false,
-					old_crtc_state, NULL);
+		intel_dp_set_infoframes(&dig_port->base, false, old_crtc_state,
+					old_conn_state);
 	/*
 	 * From TGL spec: "If multi-stream slave transcoder: Configure
 	 * Transcoder Clock Select to direct no clock to the transcoder"
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 4a1b2d863b0c..4b970587067d 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -712,7 +712,7 @@ intel_hdmi_compute_avi_infoframe(struct intel_encoder *encoder,
 	struct drm_connector *connector = conn_state->connector;
 	int ret;
 
-	if (!crtc_state->has_infoframe)
+	if (!crtc_state->has_hdmi_sink)
 		return true;
 
 	crtc_state->infoframes.enable |=
@@ -766,7 +766,7 @@ intel_hdmi_compute_spd_infoframe(struct intel_encoder *encoder,
 	struct hdmi_spd_infoframe *frame = &crtc_state->infoframes.spd.spd;
 	int ret;
 
-	if (!crtc_state->has_infoframe)
+	if (!crtc_state->has_hdmi_sink)
 		return true;
 
 	crtc_state->infoframes.enable |=
@@ -796,7 +796,7 @@ intel_hdmi_compute_hdmi_infoframe(struct intel_encoder *encoder,
 		&conn_state->connector->display_info;
 	int ret;
 
-	if (!crtc_state->has_infoframe || !info->has_hdmi_infoframe)
+	if (!crtc_state->has_hdmi_sink || !info->has_hdmi_infoframe)
 		return true;
 
 	crtc_state->infoframes.enable |=
@@ -827,7 +827,7 @@ intel_hdmi_compute_drm_infoframe(struct intel_encoder *encoder,
 	if (DISPLAY_VER(dev_priv) < 10)
 		return true;
 
-	if (!crtc_state->has_infoframe)
+	if (!crtc_state->has_hdmi_sink)
 		return true;
 
 	if (!conn_state->hdr_output_metadata)
@@ -1018,7 +1018,7 @@ static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
 {
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 
-	if (IS_G4X(dev_priv) || !crtc_state->has_infoframe)
+	if (IS_G4X(dev_priv) || !crtc_state->has_hdmi_sink)
 		return;
 
 	crtc_state->infoframes.enable |=
@@ -2172,9 +2172,6 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
 	pipe_config->has_hdmi_sink = intel_has_hdmi_sink(intel_hdmi,
 							 conn_state);
 
-	if (pipe_config->has_hdmi_sink)
-		pipe_config->has_infoframe = true;
-
 	if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK)
 		pipe_config->pixel_multiplier = 2;
 
-- 
2.31.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

[José Roberto de Souza]

intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will
take care to disable all enabled infoframes.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 5bc5528f3091..d3bc5a1a936a 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
 					conn_state);
 
 		/* FIXME precompute everything properly */
-		/* FIXME how do we turn infoframes off again? */
 		if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink)
 			dig_port->set_infoframes(encoder, true, crtc_state,
 						 conn_state);
-- 
2.31.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR

[Patchwork]

== Series Details ==

Series: series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR
URL   : https://patchwork.freedesktop.org/series/90184/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f2ee45fe2883 drm/i915/display: Fix fastsets involving PSR
9b3671205d77 drm/i915/display: Allow fastsets when DP_SDP_VSC infoframe do not match with PSR enabled
-:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:8263:
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+	if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+		pipe_config_mismatch(fastset, crtc, __stringify(name), \
+				     "(expected 0x%08x, found 0x%08x)", \
+				     current_config->name & (mask), \
+				     pipe_config->name & (mask)); \
+		ret = false; \
+	} \
+} while (0)

-:33: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:8263:
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+	if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+		pipe_config_mismatch(fastset, crtc, __stringify(name), \
+				     "(expected 0x%08x, found 0x%08x)", \
+				     current_config->name & (mask), \
+				     pipe_config->name & (mask)); \
+		ret = false; \
+	} \
+} while (0)

-:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:8263:
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+	if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+		pipe_config_mismatch(fastset, crtc, __stringify(name), \
+				     "(expected 0x%08x, found 0x%08x)", \
+				     current_config->name & (mask), \
+				     pipe_config->name & (mask)); \
+		ret = false; \
+	} \
+} while (0)

total: 0 errors, 0 warnings, 3 checks, 29 lines checked
6c94b1f31bee drm/i915/display: Nuke has_infoframe
bc53eeffc17b drm/i915/display: Drop FIXME about turn off infoframes


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR

[Patchwork]

== Series Details ==

Series: series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR
URL   : https://patchwork.freedesktop.org/series/90184/
State : warning

== Summary ==

$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_display.c:1887:21:    expected struct i915_vma *[assigned] vma
+drivers/gpu/drm/i915/display/intel_display.c:1887:21:    got void [noderef] __iomem *[assigned] iomem
+drivers/gpu/drm/i915/display/intel_display.c:1887:21: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_reset.c:1329:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block
+./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080)
+./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080)
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 8831 bytes --]

== Series Details ==

Series: series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR
URL   : https://patchwork.freedesktop.org/series/90184/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10085 -> Patchwork_20130
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_20130 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_20130, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_20130:

### IGT changes ###

#### Possible regressions ####

  * igt@runner@aborted:
    - fi-elk-e7500:       NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-elk-e7500/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in Patchwork_20130 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fence@basic-await@bcs0:
    - fi-bsw-kefka:       [PASS][2] -> [FAIL][3] ([i915#3457])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-kefka/igt@gem_exec_fence@basic-await@bcs0.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-kefka/igt@gem_exec_fence@basic-await@bcs0.html

  * igt@gem_exec_fence@basic-await@rcs0:
    - fi-bsw-nick:        [PASS][4] -> [FAIL][5] ([i915#3457])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-nick/igt@gem_exec_fence@basic-await@rcs0.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-nick/igt@gem_exec_fence@basic-await@rcs0.html

  * igt@gem_exec_fence@basic-await@vcs0:
    - fi-bsw-n3050:       [PASS][6] -> [FAIL][7] ([i915#3457]) +1 similar issue
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-n3050/igt@gem_exec_fence@basic-await@vcs0.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-n3050/igt@gem_exec_fence@basic-await@vcs0.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a:
    - fi-bwr-2160:        [PASS][8] -> [FAIL][9] ([i915#53])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bwr-2160/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bwr-2160/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-b:
    - fi-ilk-650:         [PASS][10] -> [FAIL][11] ([i915#53])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-b.html

  
#### Possible fixes ####

  * igt@gem_exec_fence@basic-await@vecs0:
    - fi-bsw-kefka:       [FAIL][12] ([i915#3457]) -> [PASS][13] +2 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-kefka/igt@gem_exec_fence@basic-await@vecs0.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-kefka/igt@gem_exec_fence@basic-await@vecs0.html

  * igt@gem_exec_fence@nb-await@rcs0:
    - fi-bsw-n3050:       [FAIL][14] ([i915#3457]) -> [PASS][15] +1 similar issue
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-n3050/igt@gem_exec_fence@nb-await@rcs0.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-n3050/igt@gem_exec_fence@nb-await@rcs0.html

  * igt@gem_exec_fence@nb-await@vcs0:
    - fi-bsw-nick:        [FAIL][16] ([i915#3457]) -> [PASS][17] +3 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-nick/igt@gem_exec_fence@nb-await@vcs0.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-nick/igt@gem_exec_fence@nb-await@vcs0.html

  * igt@gem_wait@busy@all:
    - fi-bsw-nick:        [FAIL][18] ([i915#3177] / [i915#3457]) -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-nick/igt@gem_wait@busy@all.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-nick/igt@gem_wait@busy@all.html
    - fi-bsw-kefka:       [FAIL][20] ([i915#3177] / [i915#3457]) -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-kefka/igt@gem_wait@busy@all.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-kefka/igt@gem_wait@busy@all.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
    - fi-bsw-kefka:       [FAIL][22] ([i915#53]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-kefka/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-kefka/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-ilk-650:         [FAIL][24] ([i915#53]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-ilk-650/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-ilk-650/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
#### Warnings ####

  * igt@gem_exec_gttfill@basic:
    - fi-pnv-d510:        [FAIL][26] ([i915#3472]) -> [FAIL][27] ([i915#3457] / [i915#3472])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-pnv-d510/igt@gem_exec_gttfill@basic.html

  * igt@i915_module_load@reload:
    - fi-cml-s:           [DMESG-WARN][28] ([i915#1982] / [i915#3457]) -> [DMESG-WARN][29] ([i915#3457])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-cml-s/igt@i915_module_load@reload.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-cml-s/igt@i915_module_load@reload.html
    - fi-bsw-kefka:       [DMESG-FAIL][30] ([i915#1982] / [i915#3457]) -> [DMESG-WARN][31] ([i915#1982] / [i915#3457])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-kefka/igt@i915_module_load@reload.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bsw-kefka/igt@i915_module_load@reload.html

  * igt@i915_selftest@live@mman:
    - fi-pnv-d510:        [DMESG-FAIL][32] ([i915#3457]) -> [DMESG-WARN][33] ([i915#3457])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-pnv-d510/igt@i915_selftest@live@mman.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-pnv-d510/igt@i915_selftest@live@mman.html

  * igt@runner@aborted:
    - fi-bdw-5557u:       [FAIL][34] -> [FAIL][35] ([i915#1602] / [i915#2029])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bdw-5557u/igt@runner@aborted.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/fi-bdw-5557u/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
  [i915#3177]: https://gitlab.freedesktop.org/drm/intel/issues/3177
  [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
  [i915#3457]: https://gitlab.freedesktop.org/drm/intel/issues/3457
  [i915#3472]: https://gitlab.freedesktop.org/drm/intel/issues/3472
  [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53


Participating hosts (33 -> 30)
------------------------------

  Missing    (3): fi-rkl-11500t fi-bsw-cyan fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_10085 -> Patchwork_20130

  CI-20190529: 20190529
  CI_DRM_10085: d8f31093420f3d54afebdd3d2a11c14acd17c973 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6084: 5c5734d8ee1afac871b69c4554ff14e9b56100e4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_20130: bc53eeffc17b8f3dedded041cee3859d1f3ab8bd @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

bc53eeffc17b drm/i915/display: Drop FIXME about turn off infoframes
6c94b1f31bee drm/i915/display: Nuke has_infoframe
9b3671205d77 drm/i915/display: Allow fastsets when DP_SDP_VSC infoframe do not match with PSR enabled
f2ee45fe2883 drm/i915/display: Fix fastsets involving PSR

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20130/index.html

[-- Attachment #1.2: Type: text/html, Size: 11235 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)
URL   : https://patchwork.freedesktop.org/series/90184/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
acbf2a345c71 drm/i915/display: Fix fastsets involving PSR
ff9e8e892816 drm/i915/display: Allow fastsets when DP_SDP_VSC infoframe do not match with PSR enabled
-:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:8263:
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+	if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+		pipe_config_mismatch(fastset, crtc, __stringify(name), \
+				     "(expected 0x%08x, found 0x%08x)", \
+				     current_config->name & (mask), \
+				     pipe_config->name & (mask)); \
+		ret = false; \
+	} \
+} while (0)

-:33: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:8263:
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+	if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+		pipe_config_mismatch(fastset, crtc, __stringify(name), \
+				     "(expected 0x%08x, found 0x%08x)", \
+				     current_config->name & (mask), \
+				     pipe_config->name & (mask)); \
+		ret = false; \
+	} \
+} while (0)

-:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:8263:
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+	if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+		pipe_config_mismatch(fastset, crtc, __stringify(name), \
+				     "(expected 0x%08x, found 0x%08x)", \
+				     current_config->name & (mask), \
+				     pipe_config->name & (mask)); \
+		ret = false; \
+	} \
+} while (0)

total: 0 errors, 0 warnings, 3 checks, 29 lines checked
72e3be54f41d drm/i915/display: Nuke has_infoframe
d343f6fd5bb6 drm/i915/display: Drop FIXME about turn off infoframes


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)
URL   : https://patchwork.freedesktop.org/series/90184/
State : warning

== Summary ==

$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_display.c:1887:21:    expected struct i915_vma *[assigned] vma
+drivers/gpu/drm/i915/display/intel_display.c:1887:21:    got void [noderef] __iomem *[assigned] iomem
+drivers/gpu/drm/i915/display/intel_display.c:1887:21: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_reset.c:1329:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block
+./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080)
+./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080)
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 9161 bytes --]

== Series Details ==

Series: series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)
URL   : https://patchwork.freedesktop.org/series/90184/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10085 -> Patchwork_20131
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/index.html

Known issues
------------

  Here are the changes found in Patchwork_20131 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fence@basic-await@bcs0:
    - fi-bsw-kefka:       [PASS][1] -> [FAIL][2] ([i915#3457])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-kefka/igt@gem_exec_fence@basic-await@bcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bsw-kefka/igt@gem_exec_fence@basic-await@bcs0.html

  * igt@gem_exec_fence@basic-await@vecs0:
    - fi-bxt-dsi:         [PASS][3] -> [FAIL][4] ([i915#3457])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bxt-dsi/igt@gem_exec_fence@basic-await@vecs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bxt-dsi/igt@gem_exec_fence@basic-await@vecs0.html

  * igt@gem_wait@wait@all:
    - fi-pnv-d510:        [PASS][5] -> [FAIL][6] ([i915#3457])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-pnv-d510/igt@gem_wait@wait@all.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-pnv-d510/igt@gem_wait@wait@all.html

  * igt@kms_busy@basic@modeset:
    - fi-tgl-y:           [PASS][7] -> [DMESG-WARN][8] ([i915#1982] / [i915#3457])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-tgl-y/igt@kms_busy@basic@modeset.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-tgl-y/igt@kms_busy@basic@modeset.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-a:
    - fi-elk-e7500:       [PASS][9] -> [FAIL][10] ([i915#53]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-elk-e7500/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-elk-e7500/igt@kms_pipe_crc_basic@read-crc-pipe-a.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-b:
    - fi-ilk-650:         [PASS][11] -> [FAIL][12] ([i915#53])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-b.html

  
#### Possible fixes ####

  * igt@gem_busy@busy@all:
    - fi-elk-e7500:       [FAIL][13] ([i915#3457]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-elk-e7500/igt@gem_busy@busy@all.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-elk-e7500/igt@gem_busy@busy@all.html

  * igt@gem_exec_fence@nb-await@vecs0:
    - fi-bsw-nick:        [FAIL][15] ([i915#3457]) -> [PASS][16] +2 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-nick/igt@gem_exec_fence@nb-await@vecs0.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bsw-nick/igt@gem_exec_fence@nb-await@vecs0.html

  * igt@gem_wait@busy@all:
    - fi-bsw-nick:        [FAIL][17] ([i915#3177] / [i915#3457]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-nick/igt@gem_wait@busy@all.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bsw-nick/igt@gem_wait@busy@all.html
    - fi-bsw-kefka:       [FAIL][19] ([i915#3177] / [i915#3457]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-kefka/igt@gem_wait@busy@all.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bsw-kefka/igt@gem_wait@busy@all.html

  * igt@gem_wait@wait@all:
    - fi-bwr-2160:        [FAIL][21] ([i915#3457]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bwr-2160/igt@gem_wait@wait@all.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bwr-2160/igt@gem_wait@wait@all.html
    - fi-bsw-kefka:       [FAIL][23] ([i915#3457]) -> [PASS][24] +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-kefka/igt@gem_wait@wait@all.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bsw-kefka/igt@gem_wait@wait@all.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
    - fi-elk-e7500:       [FAIL][25] ([i915#53]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-elk-e7500/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-elk-e7500/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
    - fi-bsw-kefka:       [FAIL][27] ([i915#53]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bsw-kefka/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bsw-kefka/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-bwr-2160:        [FAIL][29] ([i915#53]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bwr-2160/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bwr-2160/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
#### Warnings ####

  * igt@i915_module_load@reload:
    - fi-cml-s:           [DMESG-WARN][31] ([i915#1982] / [i915#3457]) -> [DMESG-WARN][32] ([i915#3457])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-cml-s/igt@i915_module_load@reload.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-cml-s/igt@i915_module_load@reload.html
    - fi-elk-e7500:       [DMESG-FAIL][33] ([i915#3457]) -> [DMESG-WARN][34] ([i915#3457])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-elk-e7500/igt@i915_module_load@reload.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-elk-e7500/igt@i915_module_load@reload.html

  * igt@i915_selftest@live@mman:
    - fi-pnv-d510:        [DMESG-FAIL][35] ([i915#3457]) -> [DMESG-WARN][36] ([i915#3457])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-pnv-d510/igt@i915_selftest@live@mman.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-pnv-d510/igt@i915_selftest@live@mman.html

  * igt@runner@aborted:
    - fi-bdw-5557u:       [FAIL][37] -> [FAIL][38] ([i915#1602] / [i915#2029])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-bdw-5557u/igt@runner@aborted.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-bdw-5557u/igt@runner@aborted.html
    - fi-kbl-soraka:      [FAIL][39] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][40] ([i915#1436] / [i915#3363])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/fi-kbl-soraka/igt@runner@aborted.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/fi-kbl-soraka/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
  [i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
  [i915#3177]: https://gitlab.freedesktop.org/drm/intel/issues/3177
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3457]: https://gitlab.freedesktop.org/drm/intel/issues/3457
  [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53


Participating hosts (33 -> 30)
------------------------------

  Missing    (3): fi-bsw-cyan fi-bdw-samus fi-bsw-n3050 


Build changes
-------------

  * Linux: CI_DRM_10085 -> Patchwork_20131

  CI-20190529: 20190529
  CI_DRM_10085: d8f31093420f3d54afebdd3d2a11c14acd17c973 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6084: 5c5734d8ee1afac871b69c4554ff14e9b56100e4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_20131: d343f6fd5bb646d6acad566c5dbf3d7b7e1cacaa @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

d343f6fd5bb6 drm/i915/display: Drop FIXME about turn off infoframes
72e3be54f41d drm/i915/display: Nuke has_infoframe
ff9e8e892816 drm/i915/display: Allow fastsets when DP_SDP_VSC infoframe do not match with PSR enabled
acbf2a345c71 drm/i915/display: Fix fastsets involving PSR

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/index.html

[-- Attachment #1.2: Type: text/html, Size: 11653 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30304 bytes --]

== Series Details ==

Series: series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)
URL   : https://patchwork.freedesktop.org/series/90184/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10085_full -> Patchwork_20131_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_20131_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_20131_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_20131_full:

### IGT changes ###

#### Possible regressions ####

  * igt@api_intel_bb@intel-bb-blit-none:
    - shard-glk:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk7/igt@api_intel_bb@intel-bb-blit-none.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk9/igt@api_intel_bb@intel-bb-blit-none.html

  * igt@kms_plane_cursor@pipe-a-viewport-size-128:
    - shard-snb:          NOTRUN -> [FAIL][3] +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@kms_plane_cursor@pipe-a-viewport-size-128.html

  
#### Warnings ####

  * igt@gem_mmap_gtt@fault-concurrent-x:
    - shard-glk:          [INCOMPLETE][4] ([i915#3468]) -> [INCOMPLETE][5]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk3/igt@gem_mmap_gtt@fault-concurrent-x.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@gem_mmap_gtt@fault-concurrent-x.html

  * igt@kms_plane_cursor@pipe-b-viewport-size-64:
    - shard-tglb:         [FAIL][6] ([i915#3457]) -> [FAIL][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb5/igt@kms_plane_cursor@pipe-b-viewport-size-64.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb7/igt@kms_plane_cursor@pipe-b-viewport-size-64.html

  
Known issues
------------

  Here are the changes found in Patchwork_20131_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@api_intel_bb@blit-noreloc-purge-cache:
    - shard-apl:          NOTRUN -> [DMESG-FAIL][8] ([i915#3457]) +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@api_intel_bb@blit-noreloc-purge-cache.html
    - shard-skl:          NOTRUN -> [DMESG-WARN][9] ([i915#3457])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@api_intel_bb@blit-noreloc-purge-cache.html

  * igt@api_intel_bb@blit-noreloc-purge-cache-random:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][10] ([i915#3457]) +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@api_intel_bb@blit-noreloc-purge-cache-random.html

  * igt@gem_create@create-clear:
    - shard-skl:          [PASS][11] -> [FAIL][12] ([i915#3160])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-skl4/igt@gem_create@create-clear.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl1/igt@gem_create@create-clear.html

  * igt@gem_create@create-massive:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][13] ([i915#3002])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl7/igt@gem_create@create-massive.html

  * igt@gem_ctx_persistence@legacy-engines-queued:
    - shard-snb:          NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#1099]) +4 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@gem_ctx_persistence@legacy-engines-queued.html

  * igt@gem_eio@in-flight-contexts-10ms:
    - shard-tglb:         [PASS][15] -> [TIMEOUT][16] ([i915#3063] / [i915#3457])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb1/igt@gem_eio@in-flight-contexts-10ms.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb7/igt@gem_eio@in-flight-contexts-10ms.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-tglb:         [PASS][17] -> [FAIL][18] ([i915#2842] / [i915#3457])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-glk:          NOTRUN -> [FAIL][19] ([i915#3457]) +3 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs0:
    - shard-iclb:         [PASS][20] -> [FAIL][21] ([i915#2842] / [i915#3457]) +1 similar issue
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb7/igt@gem_exec_fair@basic-pace@vcs0.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][22] ([i915#2842] / [i915#3457])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
    - shard-kbl:          [PASS][23] -> [FAIL][24] ([i915#2842] / [i915#3457])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_fence@syncobj-export:
    - shard-glk:          [PASS][25] -> [FAIL][26] ([i915#3457]) +23 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk7/igt@gem_exec_fence@syncobj-export.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk4/igt@gem_exec_fence@syncobj-export.html

  * igt@gem_exec_params@no-vebox:
    - shard-tglb:         NOTRUN -> [SKIP][27] ([fdo#109283])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@gem_exec_params@no-vebox.html

  * igt@gem_mmap_gtt@big-copy:
    - shard-glk:          [PASS][28] -> [FAIL][29] ([i915#307])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk4/igt@gem_mmap_gtt@big-copy.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@gem_mmap_gtt@big-copy.html

  * igt@gem_mmap_gtt@cpuset-basic-small-copy:
    - shard-tglb:         [PASS][30] -> [INCOMPLETE][31] ([i915#3468])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb3/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb8/igt@gem_mmap_gtt@cpuset-basic-small-copy.html

  * igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
    - shard-snb:          NOTRUN -> [INCOMPLETE][32] ([i915#3468])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb5/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html

  * igt@gem_mmap_gtt@cpuset-big-copy-odd:
    - shard-iclb:         [PASS][33] -> [FAIL][34] ([i915#307])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy-odd.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-snb:          NOTRUN -> [WARN][35] ([i915#2658])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_render_copy@mixed-tiled-to-yf-tiled-ccs:
    - shard-glk:          NOTRUN -> [INCOMPLETE][36] ([i915#3468])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@gem_render_copy@mixed-tiled-to-yf-tiled-ccs.html

  * igt@gem_render_copy@yf-tiled-ccs-to-linear:
    - shard-apl:          NOTRUN -> [INCOMPLETE][37] ([i915#3468]) +2 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@gem_render_copy@yf-tiled-ccs-to-linear.html

  * igt@gem_render_copy@yf-tiled-ccs-to-x-tiled:
    - shard-skl:          NOTRUN -> [INCOMPLETE][38] ([i915#3468]) +1 similar issue
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl1/igt@gem_render_copy@yf-tiled-ccs-to-x-tiled.html

  * igt@gem_render_copy@yf-tiled-ccs-to-y-tiled:
    - shard-tglb:         NOTRUN -> [INCOMPLETE][39] ([i915#3468])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@gem_render_copy@yf-tiled-ccs-to-y-tiled.html

  * igt@gem_spin_batch@engines@vcs0:
    - shard-apl:          NOTRUN -> [FAIL][40] ([i915#2898] / [i915#3457]) +3 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@gem_spin_batch@engines@vcs0.html

  * igt@gem_userptr_blits@set-cache-level:
    - shard-apl:          NOTRUN -> [FAIL][41] ([i915#3324])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@gem_userptr_blits@set-cache-level.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-snb:          NOTRUN -> [FAIL][42] ([i915#2724] / [i915#3457])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@gem_userptr_blits@vma-merge.html

  * igt@i915_hangman@engine-error@vcs1:
    - shard-iclb:         NOTRUN -> [DMESG-WARN][43] ([i915#3457])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb4/igt@i915_hangman@engine-error@vcs1.html

  * igt@i915_hangman@error-state-capture@vcs1:
    - shard-tglb:         NOTRUN -> [DMESG-WARN][44] ([i915#3457]) +4 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@i915_hangman@error-state-capture@vcs1.html

  * igt@i915_pm_rpm@cursor:
    - shard-glk:          [PASS][45] -> [DMESG-WARN][46] ([i915#3457]) +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk8/igt@i915_pm_rpm@cursor.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@i915_pm_rpm@cursor.html

  * igt@i915_pm_rpm@gem-mmap-type@uc:
    - shard-apl:          NOTRUN -> [DMESG-WARN][47] ([i915#3475])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@i915_pm_rpm@gem-mmap-type@uc.html

  * igt@i915_pm_rpm@gem-mmap-type@wc:
    - shard-tglb:         [PASS][48] -> [DMESG-WARN][49] ([i915#2411] / [i915#3457])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb3/igt@i915_pm_rpm@gem-mmap-type@wc.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb2/igt@i915_pm_rpm@gem-mmap-type@wc.html

  * igt@i915_pm_rpm@modeset-lpsp-stress:
    - shard-apl:          NOTRUN -> [SKIP][50] ([fdo#109271]) +116 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@i915_pm_rpm@modeset-lpsp-stress.html

  * igt@i915_pm_rps@min-max-config-idle:
    - shard-glk:          NOTRUN -> [DMESG-WARN][51] ([i915#3457])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@i915_pm_rps@min-max-config-idle.html

  * igt@i915_pm_sseu@full-enable:
    - shard-apl:          NOTRUN -> [DMESG-WARN][52] ([i915#3457]) +1 similar issue
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@i915_pm_sseu@full-enable.html

  * igt@i915_selftest@live@hangcheck:
    - shard-snb:          NOTRUN -> [INCOMPLETE][53] ([i915#2782])
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@mman:
    - shard-snb:          NOTRUN -> [DMESG-WARN][54] ([i915#3457]) +1 similar issue
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@i915_selftest@live@mman.html

  * igt@kms_atomic@plane-immutable-zpos:
    - shard-glk:          [PASS][55] -> [FAIL][56] ([i915#2657] / [i915#3457])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk4/igt@kms_atomic@plane-immutable-zpos.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@kms_atomic@plane-immutable-zpos.html

  * igt@kms_big_fb@yf-tiled-64bpp-rotate-90:
    - shard-tglb:         NOTRUN -> [SKIP][57] ([fdo#111615])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_big_fb@yf-tiled-64bpp-rotate-90.html

  * igt@kms_big_joiner@basic:
    - shard-glk:          NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2705])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_big_joiner@basic.html

  * igt@kms_color@pipe-a-ctm-0-75:
    - shard-skl:          [PASS][59] -> [DMESG-WARN][60] ([i915#1982]) +1 similar issue
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@kms_color@pipe-a-ctm-0-75.html

  * igt@kms_color_chamelium@pipe-a-ctm-0-25:
    - shard-snb:          NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +26 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-b-ctm-max:
    - shard-kbl:          NOTRUN -> [SKIP][62] ([fdo#109271] / [fdo#111827]) +2 similar issues
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_color_chamelium@pipe-b-ctm-max.html

  * igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
    - shard-tglb:         NOTRUN -> [SKIP][63] ([fdo#109284] / [fdo#111827]) +2 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html

  * igt@kms_color_chamelium@pipe-c-ctm-0-25:
    - shard-apl:          NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +12 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_color_chamelium@pipe-c-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-c-ctm-0-5:
    - shard-skl:          NOTRUN -> [SKIP][65] ([fdo#109271] / [fdo#111827]) +3 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl8/igt@kms_color_chamelium@pipe-c-ctm-0-5.html

  * igt@kms_color_chamelium@pipe-d-ctm-0-25:
    - shard-glk:          NOTRUN -> [SKIP][66] ([fdo#109271] / [fdo#111827]) +4 similar issues
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_color_chamelium@pipe-d-ctm-0-25.html

  * igt@kms_content_protection@lic:
    - shard-apl:          NOTRUN -> [TIMEOUT][67] ([i915#1319]) +1 similar issue
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_content_protection@lic.html

  * igt@kms_cursor_crc@pipe-a-cursor-32x32-random:
    - shard-tglb:         NOTRUN -> [SKIP][68] ([i915#3319] / [i915#3457])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-32x32-random.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding:
    - shard-apl:          NOTRUN -> [FAIL][69] ([i915#3444] / [i915#3457]) +3 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
    - shard-iclb:         [PASS][70] -> [FAIL][71] ([i915#3457]) +1 similar issue
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html

  * igt@kms_cursor_crc@pipe-a-cursor-dpms:
    - shard-glk:          NOTRUN -> [FAIL][72] ([i915#3444] / [i915#3457]) +1 similar issue
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_cursor_crc@pipe-a-cursor-dpms.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-skl:          NOTRUN -> [INCOMPLETE][73] ([i915#2828] / [i915#300])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-random:
    - shard-snb:          NOTRUN -> [FAIL][74] ([i915#3457]) +11 similar issues
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding:
    - shard-skl:          NOTRUN -> [FAIL][75] ([i915#3444] / [i915#3457]) +3 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html

  * igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen:
    - shard-tglb:         NOTRUN -> [FAIL][76] ([i915#2124] / [i915#3457]) +3 similar issues
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen.html

  * igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement:
    - shard-skl:          NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#3457]) +3 similar issues
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement.html

  * igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
    - shard-skl:          [PASS][78] -> [FAIL][79] ([i915#3444] / [i915#3457]) +2 similar issues
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html

  * igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen:
    - shard-apl:          [PASS][80] -> [FAIL][81] ([i915#3444] / [i915#3457]) +1 similar issue
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen:
    - shard-kbl:          NOTRUN -> [FAIL][82] ([i915#3444] / [i915#3457]) +4 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen:
    - shard-glk:          NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#3457]) +5 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding:
    - shard-tglb:         NOTRUN -> [SKIP][84] ([fdo#109279] / [i915#3359] / [i915#3457])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding.html

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen:
    - shard-glk:          [PASS][85] -> [FAIL][86] ([i915#3444] / [i915#3457]) +3 similar issues
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk6/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk6/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html

  * igt@kms_cursor_crc@pipe-d-cursor-256x85-rapid-movement:
    - shard-apl:          NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#3457]) +19 similar issues
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@kms_cursor_crc@pipe-d-cursor-256x85-rapid-movement.html

  * igt@kms_cursor_crc@pipe-d-cursor-32x10-rapid-movement:
    - shard-snb:          NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#3457]) +49 similar issues
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@kms_cursor_crc@pipe-d-cursor-32x10-rapid-movement.html

  * igt@kms_cursor_crc@pipe-d-cursor-64x21-offscreen:
    - shard-tglb:         [PASS][89] -> [FAIL][90] ([i915#2124] / [i915#3457]) +4 similar issues
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-64x21-offscreen.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-64x21-offscreen.html

  * igt@kms_cursor_crc@pipe-d-cursor-max-size-sliding:
    - shard-kbl:          NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#3457]) +6 similar issues
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_cursor_crc@pipe-d-cursor-max-size-sliding.html

  * igt@kms_cursor_edge_walk@pipe-b-64x64-bottom-edge:
    - shard-glk:          [PASS][92] -> [FAIL][93] ([i915#70]) +1 similar issue
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk8/igt@kms_cursor_edge_walk@pipe-b-64x64-bottom-edge.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@kms_cursor_edge_walk@pipe-b-64x64-bottom-edge.html

  * igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible:
    - shard-tglb:         NOTRUN -> [SKIP][94] ([fdo#111825]) +12 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend@b-dp1:
    - shard-kbl:          [PASS][95] -> [DMESG-WARN][96] ([i915#180]) +2 similar issues
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-kbl3/igt@kms_flip@flip-vs-suspend@b-dp1.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl4/igt@kms_flip@flip-vs-suspend@b-dp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-apl:          NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2642])
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt:
    - shard-skl:          NOTRUN -> [SKIP][98] ([fdo#109271]) +29 similar issues
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl1/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
    - shard-kbl:          NOTRUN -> [SKIP][99] ([fdo#109271]) +48 similar issues
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
    - shard-glk:          NOTRUN -> [SKIP][100] ([fdo#109271]) +21 similar issues
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff:
    - shard-snb:          NOTRUN -> [SKIP][101] ([fdo#109271]) +391 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - shard-apl:          NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#533])
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
    - shard-apl:          NOTRUN -> [FAIL][103] ([fdo#108145] / [i915#265])
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
    - shard-kbl:          NOTRUN -> [FAIL][104] ([fdo#108145] / [i915#265] / [i915#3457])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
    - shard-apl:          NOTRUN -> [FAIL][105] ([i915#265])
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
    - shard-skl:          NOTRUN -> [FAIL][106] ([fdo#108145] / [i915#265])
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html

  * igt@kms_plane_cursor@pipe-a-primary-size-64:
    - shard-snb:          NOTRUN -> [FAIL][107] ([i915#3461]) +1 similar issue
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@kms_plane_cursor@pipe-a-primary-size-64.html

  * igt@kms_plane_cursor@pipe-b-overlay-size-64:
    - shard-iclb:         [PASS][108] -> [FAIL][109] ([i915#2657] / [i915#3457])
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb2/igt@kms_plane_cursor@pipe-b-overlay-size-64.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb7/igt@kms_plane_cursor@pipe-b-overlay-size-64.html

  * igt@kms_plane_cursor@pipe-b-primary-size-64:
    - shard-skl:          NOTRUN -> [FAIL][110] ([i915#2657] / [i915#3457]) +1 similar issue
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl8/igt@kms_plane_cursor@pipe-b-primary-size-64.html

  * igt@kms_plane_lowres@pipe-b-tiling-none:
    - shard-glk:          [PASS][111] -> [FAIL][112] ([i915#3457] / [i915#899])
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk8/igt@kms_plane_lowres@pipe-b-tiling-none.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@kms_plane_lowres@pipe-b-tiling-none.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
    - shard-apl:          NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#658]) +4 similar issues
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
    - shard-glk:          NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#658])
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
    - shard-kbl:          NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#658]) +2 similar issues
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
    - shard-skl:          NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#658]) +2 similar issues
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl1/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [PASS][117] -> [SKIP][118] ([fdo#109441])
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb7/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_writeback@writeback-fb-id:
    - shard-apl:          NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2437])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_writeback@writeback-fb-id.html

  * igt@nouveau_crc@pipe-b-ctx-flip-detection:
    - shard-tglb:         NOTRUN -> [SKIP][120] ([i915#2530])
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@nouveau_crc@pipe-b-ctx-flip-detection.html

  * igt@perf_pmu@busy-idle@bcs0:
    - shard-apl:          NOTRUN -> [FAIL][121] ([i915#3457]) +3 similar issues
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@perf_pmu@busy-idle@bcs0.html

  * igt@perf_pmu@busy-idle@vecs0:
    - shard-apl:          NOTRUN -> [WARN][122] ([i915#3457]) +2 similar issues
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@perf_pmu@busy-idle@vecs0.html

  * igt@prime_nv_test@i915_import_cpu_mmap:
    - shard-tglb:         NOTRUN -> [SKIP][123] ([fdo#109291])
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@prime_nv_test@i915_import_cpu_mmap.html

  * igt@prime_vgem@fence-flip-hang:
    - shard-tglb:         NOTRUN -> [SKIP][124] ([fdo#109295])
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@prime_vgem@fence-flip-hang.html

  * igt@sysfs_clients@recycle-many:
    - shard-glk:          NOTRUN -> [SKIP][125] ([fdo#109271] / [i915#2994])
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@sysfs_clients@recycle-many.html

  * igt@sysfs_clients@split-50:
    - shard-kbl:          NOTRUN -> [SKIP][126] ([fdo#109271] / [i915#2994]) +1 similar issue
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@sysfs_clients@split-50.html
    - shard-apl:          NOTRUN -> [SKIP][127] ([fdo#109271] / [i915#2994])
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@sysfs_clients@split-50.html

  * igt@sysfs_heartbeat_interval@mixed@vcs1:
    - shard-kbl:          [PASS][128] -> [INCOMPLETE][129] ([i915#1731] / [i915#3457])
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-kbl7/igt@sysfs_heartbeat_interval@mixed@vcs1.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl4/igt@sysfs_heartbeat_interval@mixed@vcs1.html

  * igt@sysfs_heartbeat_interval@mixed@vecs0:
    - shard-apl:          NOTRUN -> [FAIL][130] ([i915#1731] / [i915#3457]) +3 similar issues
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@sysfs_heartbeat_interval@mixed@vecs0.html

  * igt@sysfs_preempt_timeout@timeout@vecs0:
    - shard-apl:          [PASS][131] -> [FAIL][132] ([i915#1755] / [i915#3457]) +1 similar issue
   [131]: https://intel-gfx-ci.01

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/index.html

[-- Attachment #1.2: Type: text/html, Size: 33788 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Nuke has_infoframe

[Mun, Gwan-gyeong]

On Fri, 2021-05-14 at 16:22 -0700, José Roberto de Souza wrote:
> This was only reduntant information has_hdmi_sink can do the same job.
> set_infoframes() hooks will call intel_write_infoframe() for the
> supported infoframes types and it will only be enabled if given type
> is set in crtc_state->infoframes.enable.
> 
> While at it also fixing the style of dig_port->set_infoframes() calls.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/display/g4x_hdmi.c       | 22 ++++++-------------
>  drivers/gpu/drm/i915/display/intel_ddi.c      | 17 +++++---------
>  drivers/gpu/drm/i915/display/intel_display.c  |  6 ++---
>  .../drm/i915/display/intel_display_types.h    |  3 ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |  4 ++--
>  drivers/gpu/drm/i915/display/intel_hdmi.c     | 13 +++++------
>  6 files changed, 22 insertions(+), 43 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> index be352e9f0afc..f35db96e6239 100644
> --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> @@ -105,9 +105,6 @@ static void intel_hdmi_get_config(struct
> intel_encoder *encoder,
>         pipe_config->infoframes.enable |=
>                 intel_hdmi_infoframes_enabled(encoder, pipe_config);
>  
> -       if (pipe_config->infoframes.enable)
> -               pipe_config->has_infoframe = true;
> -
"pipe_config->infoframes.enable" is set with information about the
infoframes currently active in the hardware through "pipe_config-
>infoframes.enable |= intel_hdmi_infoframes_enabled(encoder,
pipe_config);".

Therefore, when calling set_infoframes() semantically, the
has_infoframe information set by "if (pipe_config->infoframes.enable)
pipe_config->has_infoframe = true;" is more clear.

>         if (tmp & HDMI_AUDIO_ENABLE)
>                 pipe_config->has_audio = true;
>  
> @@ -343,9 +340,7 @@ static void intel_disable_hdmi(struct
> intel_atomic_state *state,
>                 intel_set_pch_fifo_underrun_reporting(dev_priv, PIPE_A,
> true);
>         }
>  
> -       dig_port->set_infoframes(encoder,
> -                                      false,
> -                                      old_crtc_state, old_conn_state);
> +       dig_port->set_infoframes(encoder, false, old_crtc_state,
> old_conn_state);
>  
>         intel_dp_dual_mode_set_tmds_output(intel_hdmi, false);
>  }
> @@ -390,9 +385,8 @@ static void intel_hdmi_pre_enable(struct
> intel_atomic_state *state,
>  
>         intel_hdmi_prepare(encoder, pipe_config);
>  
> -       dig_port->set_infoframes(encoder,
> -                                      pipe_config->has_infoframe,
> -                                      pipe_config, conn_state);
> +       dig_port->set_infoframes(encoder, pipe_config->has_hdmi_sink,
> +                                pipe_config, conn_state);
>  }
>  
>  static void vlv_hdmi_pre_enable(struct intel_atomic_state *state,
> @@ -410,9 +404,8 @@ static void vlv_hdmi_pre_enable(struct
> intel_atomic_state *state,
>                                  0x2b245f5f, 0x00002000,
>                                  0x5578b83a, 0x2b247878);
>  
> -       dig_port->set_infoframes(encoder,
> -                             pipe_config->has_infoframe,
> -                             pipe_config, conn_state);
> +       dig_port->set_infoframes(encoder, pipe_config->has_hdmi_sink,
> +                                pipe_config, conn_state);
>  
>         g4x_enable_hdmi(state, encoder, pipe_config, conn_state);
>  
> @@ -487,9 +480,8 @@ static void chv_hdmi_pre_enable(struct
> intel_atomic_state *state,
>         /* Use 800mV-0dB */
>         chv_set_phy_signal_level(encoder, pipe_config, 128, 102,
> false);
>  
> -       dig_port->set_infoframes(encoder,
> -                             pipe_config->has_infoframe,
> -                             pipe_config, conn_state);
> +       dig_port->set_infoframes(encoder, pipe_config->has_hdmi_sink,
> +                                pipe_config, conn_state);
>  
>         g4x_enable_hdmi(state, encoder, pipe_config, conn_state);
>  
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> b/drivers/gpu/drm/i915/display/intel_ddi.c
> index b7a2fce684c9..5bc5528f3091 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2722,9 +2722,8 @@ static void intel_ddi_pre_enable_hdmi(struct
> intel_atomic_state *state,
>  
>         intel_ddi_enable_pipe_clock(encoder, crtc_state);
>  
> -       dig_port->set_infoframes(encoder,
> -                                crtc_state->has_infoframe,
> -                                crtc_state, conn_state);
> +       dig_port->set_infoframes(encoder, crtc_state->has_hdmi_sink,
> crtc_state,
> +                                conn_state);
>  }
>  
>  static void intel_ddi_pre_enable(struct intel_atomic_state *state,
> @@ -2765,9 +2764,8 @@ static void intel_ddi_pre_enable(struct
> intel_atomic_state *state,
>                 /* FIXME precompute everything properly */
>                 /* FIXME how do we turn infoframes off again? */
>                 if (dig_port->lspcon.active && dig_port-
> >dp.has_hdmi_sink)
> -                       dig_port->set_infoframes(encoder,
> -                                                crtc_state-
> >has_infoframe,
> -                                                crtc_state,
> conn_state);
> +                       dig_port->set_infoframes(encoder, true,
> crtc_state,
> +                                                conn_state);
>         }
>  }
>  
> @@ -2813,8 +2811,8 @@ static void intel_ddi_post_disable_dp(struct
> intel_atomic_state *state,
>         enum phy phy = intel_port_to_phy(dev_priv, encoder->port);
>  
>         if (!is_mst)
> -               intel_dp_set_infoframes(encoder, false,
> -                                       old_crtc_state,
> old_conn_state);
> +               intel_dp_set_infoframes(encoder, false, old_crtc_state,
> +                                       old_conn_state);
>  
>         /*
>          * Power down sink before disabling the port, otherwise we end
> @@ -3569,9 +3567,6 @@ static void intel_ddi_read_func_ctl(struct
> intel_encoder *encoder,
>                 pipe_config->infoframes.enable |=
>                         intel_hdmi_infoframes_enabled(encoder,
> pipe_config);
>  
> -               if (pipe_config->infoframes.enable)
> -                       pipe_config->has_infoframe = true;
> -
>                 if (temp & TRANS_DDI_HDMI_SCRAMBLING)
>                         pipe_config->hdmi_scrambling = true;
>                 if (temp & TRANS_DDI_HIGH_TMDS_CHAR_RATE)
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index ebac1bd5cfe5..5d68b253bdfe 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7594,9 +7594,8 @@ static void intel_dump_pipe_config(const struct
> intel_crtc_state *pipe_config,
>         }
>  
>         drm_dbg_kms(&dev_priv->drm,
> -                   "audio: %i, infoframes: %i, infoframes enabled:
> 0x%x\n",
> -                   pipe_config->has_audio, pipe_config->has_infoframe,
> -                   pipe_config->infoframes.enable);
> +                   "audio: %i, infoframes enabled: 0x%x\n",
> +                   pipe_config->has_audio, pipe_config-
> >infoframes.enable);
>  
>         if (pipe_config->infoframes.enable &
>            
> intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL))
> @@ -8508,7 +8507,6 @@ intel_pipe_config_compare(const struct
> intel_crtc_state *current_config,
>  
>         PIPE_CONF_CHECK_BOOL(hdmi_scrambling);
>         PIPE_CONF_CHECK_BOOL(hdmi_high_tmds_clock_ratio);
> -       PIPE_CONF_CHECK_BOOL(has_infoframe);
>         /* FIXME do the readout properly and get rid of this quirk */
>         if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_BIGJOINER_SLAVE))
>                 PIPE_CONF_CHECK_BOOL(fec_enable);
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 9c0adfc60c6f..669c5d8a2131 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -952,9 +952,6 @@ struct intel_crtc_state {
>          * between pch encoders and cpu encoders. */
>         bool has_pch_encoder;
>  
> -       /* Are we sending infoframes on the attached port */
> -       bool has_infoframe;
> -
>         /* CPU Transcoder for the pipe. Currently this can only differ
> from the
>          * pipe on Haswell and later (where we have a special eDP
> transcoder)
>          * and Broxton (where we have special DSI transcoders). */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 332d2f9fda5c..1eb54f8ed51a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -435,8 +435,8 @@ static void intel_mst_post_disable_dp(struct
> intel_atomic_state *state,
>          * the transcoder clock select is set to none.
>          */
>         if (last_mst_stream)
> -               intel_dp_set_infoframes(&dig_port->base, false,
> -                                       old_crtc_state, NULL);
> +               intel_dp_set_infoframes(&dig_port->base, false,
> old_crtc_state,
> +                                       old_conn_state);
>         /*
>          * From TGL spec: "If multi-stream slave transcoder: Configure
>          * Transcoder Clock Select to direct no clock to the
> transcoder"
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
> b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 4a1b2d863b0c..4b970587067d 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -712,7 +712,7 @@ intel_hdmi_compute_avi_infoframe(struct
> intel_encoder *encoder,
>         struct drm_connector *connector = conn_state->connector;
>         int ret;
>  
> -       if (!crtc_state->has_infoframe)
> +       if (!crtc_state->has_hdmi_sink)
>                 return true;
>  
>         crtc_state->infoframes.enable |=
> @@ -766,7 +766,7 @@ intel_hdmi_compute_spd_infoframe(struct
> intel_encoder *encoder,
>         struct hdmi_spd_infoframe *frame = &crtc_state-
> >infoframes.spd.spd;
>         int ret;
>  
> -       if (!crtc_state->has_infoframe)
> +       if (!crtc_state->has_hdmi_sink)
>                 return true;
>  
>         crtc_state->infoframes.enable |=
> @@ -796,7 +796,7 @@ intel_hdmi_compute_hdmi_infoframe(struct
> intel_encoder *encoder,
>                 &conn_state->connector->display_info;
>         int ret;
>  
> -       if (!crtc_state->has_infoframe || !info->has_hdmi_infoframe)
> +       if (!crtc_state->has_hdmi_sink || !info->has_hdmi_infoframe)
>                 return true;
>  
>         crtc_state->infoframes.enable |=
> @@ -827,7 +827,7 @@ intel_hdmi_compute_drm_infoframe(struct
> intel_encoder *encoder,
>         if (DISPLAY_VER(dev_priv) < 10)
>                 return true;
>  
> -       if (!crtc_state->has_infoframe)
> +       if (!crtc_state->has_hdmi_sink)
>                 return true;
>  
>         if (!conn_state->hdr_output_metadata)
> @@ -1018,7 +1018,7 @@ static void
> intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
>  {
>         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
>  
> -       if (IS_G4X(dev_priv) || !crtc_state->has_infoframe)
> +       if (IS_G4X(dev_priv) || !crtc_state->has_hdmi_sink)
>                 return;
>  
>         crtc_state->infoframes.enable |=
> @@ -2172,9 +2172,6 @@ int intel_hdmi_compute_config(struct
> intel_encoder *encoder,
>         pipe_config->has_hdmi_sink = intel_has_hdmi_sink(intel_hdmi,
>                                                          conn_state);
>  
> -       if (pipe_config->has_hdmi_sink)
> -               pipe_config->has_infoframe = true;
> -
>         if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK)
>                 pipe_config->pixel_multiplier = 2;
>  

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Nuke has_infoframe

[Souza, Jose]

On Fri, 2021-05-21 at 16:27 +0100, Mun, Gwan-gyeong wrote:
> On Fri, 2021-05-14 at 16:22 -0700, José Roberto de Souza wrote:
> > This was only reduntant information has_hdmi_sink can do the same job.
> > set_infoframes() hooks will call intel_write_infoframe() for the
> > supported infoframes types and it will only be enabled if given type
> > is set in crtc_state->infoframes.enable.
> > 
> > While at it also fixing the style of dig_port->set_infoframes() calls.
> > 
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/g4x_hdmi.c       | 22 ++++++-------------
> >  drivers/gpu/drm/i915/display/intel_ddi.c      | 17 +++++---------
> >  drivers/gpu/drm/i915/display/intel_display.c  |  6 ++---
> >  .../drm/i915/display/intel_display_types.h    |  3 ---
> >  drivers/gpu/drm/i915/display/intel_dp_mst.c   |  4 ++--
> >  drivers/gpu/drm/i915/display/intel_hdmi.c     | 13 +++++------
> >  6 files changed, 22 insertions(+), 43 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > index be352e9f0afc..f35db96e6239 100644
> > --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > @@ -105,9 +105,6 @@ static void intel_hdmi_get_config(struct
> > intel_encoder *encoder,
> >         pipe_config->infoframes.enable |=
> >                 intel_hdmi_infoframes_enabled(encoder, pipe_config);
> >  
> > -       if (pipe_config->infoframes.enable)
> > -               pipe_config->has_infoframe = true;
> > -
> "pipe_config->infoframes.enable" is set with information about the
> infoframes currently active in the hardware through "pipe_config-
> > infoframes.enable |= intel_hdmi_infoframes_enabled(encoder,
> pipe_config);".
> 
> Therefore, when calling set_infoframes() semantically, the
> has_infoframe information set by "if (pipe_config->infoframes.enable)
> pipe_config->has_infoframe = true;" is more clear.

That don't work because the functions that will check if a infoframe is needed and set pipe_config->infoframes.enable depends on pipe_config-
>has_infoframe/crtc_state->has_hdmi_sink.
That is probably because DVI ports don't support infoframes but in i915 are handle very similar to HDMI.

> 
> >         if (tmp & HDMI_AUDIO_ENABLE)
> >                 pipe_config->has_audio = true;
> >  
> > @@ -343,9 +340,7 @@ static void intel_disable_hdmi(struct
> > intel_atomic_state *state,
> >                 intel_set_pch_fifo_underrun_reporting(dev_priv, PIPE_A,
> > true);
> >         }
> >  
> > -       dig_port->set_infoframes(encoder,
> > -                                      false,
> > -                                      old_crtc_state, old_conn_state);
> > +       dig_port->set_infoframes(encoder, false, old_crtc_state,
> > old_conn_state);
> >  
> >         intel_dp_dual_mode_set_tmds_output(intel_hdmi, false);
> >  }
> > @@ -390,9 +385,8 @@ static void intel_hdmi_pre_enable(struct
> > intel_atomic_state *state,
> >  
> >         intel_hdmi_prepare(encoder, pipe_config);
> >  
> > -       dig_port->set_infoframes(encoder,
> > -                                      pipe_config->has_infoframe,
> > -                                      pipe_config, conn_state);
> > +       dig_port->set_infoframes(encoder, pipe_config->has_hdmi_sink,
> > +                                pipe_config, conn_state);
> >  }
> >  
> >  static void vlv_hdmi_pre_enable(struct intel_atomic_state *state,
> > @@ -410,9 +404,8 @@ static void vlv_hdmi_pre_enable(struct
> > intel_atomic_state *state,
> >                                  0x2b245f5f, 0x00002000,
> >                                  0x5578b83a, 0x2b247878);
> >  
> > -       dig_port->set_infoframes(encoder,
> > -                             pipe_config->has_infoframe,
> > -                             pipe_config, conn_state);
> > +       dig_port->set_infoframes(encoder, pipe_config->has_hdmi_sink,
> > +                                pipe_config, conn_state);
> >  
> >         g4x_enable_hdmi(state, encoder, pipe_config, conn_state);
> >  
> > @@ -487,9 +480,8 @@ static void chv_hdmi_pre_enable(struct
> > intel_atomic_state *state,
> >         /* Use 800mV-0dB */
> >         chv_set_phy_signal_level(encoder, pipe_config, 128, 102,
> > false);
> >  
> > -       dig_port->set_infoframes(encoder,
> > -                             pipe_config->has_infoframe,
> > -                             pipe_config, conn_state);
> > +       dig_port->set_infoframes(encoder, pipe_config->has_hdmi_sink,
> > +                                pipe_config, conn_state);
> >  
> >         g4x_enable_hdmi(state, encoder, pipe_config, conn_state);
> >  
> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> > b/drivers/gpu/drm/i915/display/intel_ddi.c
> > index b7a2fce684c9..5bc5528f3091 100644
> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > @@ -2722,9 +2722,8 @@ static void intel_ddi_pre_enable_hdmi(struct
> > intel_atomic_state *state,
> >  
> >         intel_ddi_enable_pipe_clock(encoder, crtc_state);
> >  
> > -       dig_port->set_infoframes(encoder,
> > -                                crtc_state->has_infoframe,
> > -                                crtc_state, conn_state);
> > +       dig_port->set_infoframes(encoder, crtc_state->has_hdmi_sink,
> > crtc_state,
> > +                                conn_state);
> >  }
> >  
> >  static void intel_ddi_pre_enable(struct intel_atomic_state *state,
> > @@ -2765,9 +2764,8 @@ static void intel_ddi_pre_enable(struct
> > intel_atomic_state *state,
> >                 /* FIXME precompute everything properly */
> >                 /* FIXME how do we turn infoframes off again? */
> >                 if (dig_port->lspcon.active && dig_port-
> > > dp.has_hdmi_sink)
> > -                       dig_port->set_infoframes(encoder,
> > -                                                crtc_state-
> > > has_infoframe,
> > -                                                crtc_state,
> > conn_state);
> > +                       dig_port->set_infoframes(encoder, true,
> > crtc_state,
> > +                                                conn_state);
> >         }
> >  }
> >  
> > @@ -2813,8 +2811,8 @@ static void intel_ddi_post_disable_dp(struct
> > intel_atomic_state *state,
> >         enum phy phy = intel_port_to_phy(dev_priv, encoder->port);
> >  
> >         if (!is_mst)
> > -               intel_dp_set_infoframes(encoder, false,
> > -                                       old_crtc_state,
> > old_conn_state);
> > +               intel_dp_set_infoframes(encoder, false, old_crtc_state,
> > +                                       old_conn_state);
> >  
> >         /*
> >          * Power down sink before disabling the port, otherwise we end
> > @@ -3569,9 +3567,6 @@ static void intel_ddi_read_func_ctl(struct
> > intel_encoder *encoder,
> >                 pipe_config->infoframes.enable |=
> >                         intel_hdmi_infoframes_enabled(encoder,
> > pipe_config);
> >  
> > -               if (pipe_config->infoframes.enable)
> > -                       pipe_config->has_infoframe = true;
> > -
> >                 if (temp & TRANS_DDI_HDMI_SCRAMBLING)
> >                         pipe_config->hdmi_scrambling = true;
> >                 if (temp & TRANS_DDI_HIGH_TMDS_CHAR_RATE)
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index ebac1bd5cfe5..5d68b253bdfe 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -7594,9 +7594,8 @@ static void intel_dump_pipe_config(const struct
> > intel_crtc_state *pipe_config,
> >         }
> >  
> >         drm_dbg_kms(&dev_priv->drm,
> > -                   "audio: %i, infoframes: %i, infoframes enabled:
> > 0x%x\n",
> > -                   pipe_config->has_audio, pipe_config->has_infoframe,
> > -                   pipe_config->infoframes.enable);
> > +                   "audio: %i, infoframes enabled: 0x%x\n",
> > +                   pipe_config->has_audio, pipe_config-
> > > infoframes.enable);
> >  
> >         if (pipe_config->infoframes.enable &
> >            
> > intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL))
> > @@ -8508,7 +8507,6 @@ intel_pipe_config_compare(const struct
> > intel_crtc_state *current_config,
> >  
> >         PIPE_CONF_CHECK_BOOL(hdmi_scrambling);
> >         PIPE_CONF_CHECK_BOOL(hdmi_high_tmds_clock_ratio);
> > -       PIPE_CONF_CHECK_BOOL(has_infoframe);
> >         /* FIXME do the readout properly and get rid of this quirk */
> >         if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_BIGJOINER_SLAVE))
> >                 PIPE_CONF_CHECK_BOOL(fec_enable);
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> > b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index 9c0adfc60c6f..669c5d8a2131 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -952,9 +952,6 @@ struct intel_crtc_state {
> >          * between pch encoders and cpu encoders. */
> >         bool has_pch_encoder;
> >  
> > -       /* Are we sending infoframes on the attached port */
> > -       bool has_infoframe;
> > -
> >         /* CPU Transcoder for the pipe. Currently this can only differ
> > from the
> >          * pipe on Haswell and later (where we have a special eDP
> > transcoder)
> >          * and Broxton (where we have special DSI transcoders). */
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > index 332d2f9fda5c..1eb54f8ed51a 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > @@ -435,8 +435,8 @@ static void intel_mst_post_disable_dp(struct
> > intel_atomic_state *state,
> >          * the transcoder clock select is set to none.
> >          */
> >         if (last_mst_stream)
> > -               intel_dp_set_infoframes(&dig_port->base, false,
> > -                                       old_crtc_state, NULL);
> > +               intel_dp_set_infoframes(&dig_port->base, false,
> > old_crtc_state,
> > +                                       old_conn_state);
> >         /*
> >          * From TGL spec: "If multi-stream slave transcoder: Configure
> >          * Transcoder Clock Select to direct no clock to the
> > transcoder"
> > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
> > b/drivers/gpu/drm/i915/display/intel_hdmi.c
> > index 4a1b2d863b0c..4b970587067d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> > @@ -712,7 +712,7 @@ intel_hdmi_compute_avi_infoframe(struct
> > intel_encoder *encoder,
> >         struct drm_connector *connector = conn_state->connector;
> >         int ret;
> >  
> > -       if (!crtc_state->has_infoframe)
> > +       if (!crtc_state->has_hdmi_sink)
> >                 return true;
> >  
> >         crtc_state->infoframes.enable |=
> > @@ -766,7 +766,7 @@ intel_hdmi_compute_spd_infoframe(struct
> > intel_encoder *encoder,
> >         struct hdmi_spd_infoframe *frame = &crtc_state-
> > > infoframes.spd.spd;
> >         int ret;
> >  
> > -       if (!crtc_state->has_infoframe)
> > +       if (!crtc_state->has_hdmi_sink)
> >                 return true;
> >  
> >         crtc_state->infoframes.enable |=
> > @@ -796,7 +796,7 @@ intel_hdmi_compute_hdmi_infoframe(struct
> > intel_encoder *encoder,
> >                 &conn_state->connector->display_info;
> >         int ret;
> >  
> > -       if (!crtc_state->has_infoframe || !info->has_hdmi_infoframe)
> > +       if (!crtc_state->has_hdmi_sink || !info->has_hdmi_infoframe)
> >                 return true;
> >  
> >         crtc_state->infoframes.enable |=
> > @@ -827,7 +827,7 @@ intel_hdmi_compute_drm_infoframe(struct
> > intel_encoder *encoder,
> >         if (DISPLAY_VER(dev_priv) < 10)
> >                 return true;
> >  
> > -       if (!crtc_state->has_infoframe)
> > +       if (!crtc_state->has_hdmi_sink)
> >                 return true;
> >  
> >         if (!conn_state->hdr_output_metadata)
> > @@ -1018,7 +1018,7 @@ static void
> > intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
> >  {
> >         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> >  
> > -       if (IS_G4X(dev_priv) || !crtc_state->has_infoframe)
> > +       if (IS_G4X(dev_priv) || !crtc_state->has_hdmi_sink)
> >                 return;
> >  
> >         crtc_state->infoframes.enable |=
> > @@ -2172,9 +2172,6 @@ int intel_hdmi_compute_config(struct
> > intel_encoder *encoder,
> >         pipe_config->has_hdmi_sink = intel_has_hdmi_sink(intel_hdmi,
> >                                                          conn_state);
> >  
> > -       if (pipe_config->has_hdmi_sink)
> > -               pipe_config->has_infoframe = true;
> > -
> >         if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK)
> >                 pipe_config->pixel_multiplier = 2;
> >  
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

[Sripada, Radhakrishna]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of José
> Roberto de Souza
> Sent: Friday, May 14, 2021 4:23 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn
> off infoframes
> 
> intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will take care to
> disable all enabled infoframes.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 5bc5528f3091..d3bc5a1a936a 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct
> intel_atomic_state *state,
>  					conn_state);
> 
>  		/* FIXME precompute everything properly */
> -		/* FIXME how do we turn infoframes off again? */
>  		if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink)
>  			dig_port->set_infoframes(encoder, true, crtc_state,
>  						 conn_state);
> --
> 2.31.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/display: Fix fastsets involving PSR

[Gwan-gyeong Mun]

Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>

On 5/15/21 2:22 AM, José Roberto de Souza wrote:
> Commit 78b772e1a01f ("drm/i915/display: Fill PSR state during hardware
> configuration read out") is not allowing fastsets to happen when PSR
> states changes but PSR is a feature that can be enabled and disabled
> during fastsets.
> 
> So here moving the PSR pipe conf checks to a block that is only
> executed when checking if HW state matches with requested state, not
> during the phase where it checks if fastset is possible or not.
> 
> There still a state mismatch not allowing fastsets between states
> turning off or on PSR because of crtc_state->infoframes.enable
> BIT(DP_SDP_VSC) but at least for now it will allow a fastset between
> PSR1 <-> PSR2, that is a case heavilly used by CI due to pipe CRC not
> work with PSR2, but the remaning issue will be fixed in a future patch.
> 
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: 78b772e1a01f ("drm/i915/display: Fill PSR state during hardware configuration read out")
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_display.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 0c2b194006f8..51f499271cc8 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -8548,6 +8548,11 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>   		bp_gamma = intel_color_get_gamma_bit_precision(pipe_config);
>   		if (bp_gamma)
>   			PIPE_CONF_CHECK_COLOR_LUT(gamma_mode, hw.gamma_lut, bp_gamma);
> +
> +		PIPE_CONF_CHECK_BOOL(has_psr);
> +		PIPE_CONF_CHECK_BOOL(has_psr2);
> +		PIPE_CONF_CHECK_BOOL(enable_psr2_sel_fetch);
> +		PIPE_CONF_CHECK_I(dc3co_exitline);
>   	}
>   
>   	PIPE_CONF_CHECK_BOOL(double_wide);
> @@ -8631,11 +8636,6 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>   	PIPE_CONF_CHECK_I(vrr.flipline);
>   	PIPE_CONF_CHECK_I(vrr.pipeline_full);
>   
> -	PIPE_CONF_CHECK_BOOL(has_psr);
> -	PIPE_CONF_CHECK_BOOL(has_psr2);
> -	PIPE_CONF_CHECK_BOOL(enable_psr2_sel_fetch);
> -	PIPE_CONF_CHECK_I(dc3co_exitline);
> -
>   #undef PIPE_CONF_CHECK_X
>   #undef PIPE_CONF_CHECK_I
>   #undef PIPE_CONF_CHECK_BOOL
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/display: Allow fastsets when DP_SDP_VSC infoframe do not match with PSR enabled

[Gwan-gyeong Mun]

Looks good to me.
Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>

On 5/15/21 2:22 AM, José Roberto de Souza wrote:
> When PSR is enabled it handles DP_SDP_VSC, changing revision and all
> the other fields as necessary.
> It can also enabled and disable this SDP as needed without a full
> modeset.
> 
> So here masking DP_SDP_VSC bit when previous and future state PSR
> enabled, it will still be checked when comparing the asked state
> to what was programmed to hardware.
> 
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: 78b772e1a01f ("drm/i915/display: Fill PSR state during hardware configuration read out"
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_display.c | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 51f499271cc8..ebac1bd5cfe5 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -8260,6 +8260,16 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>   	} \
>   } while (0)
>   
> +#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
> +	if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
> +		pipe_config_mismatch(fastset, crtc, __stringify(name), \
> +				     "(expected 0x%08x, found 0x%08x)", \
> +				     current_config->name & (mask), \
> +				     pipe_config->name & (mask)); \
> +		ret = false; \
> +	} \
> +} while (0)
> +
>   #define PIPE_CONF_CHECK_I(name) do { \
>   	if (current_config->name != pipe_config->name) { \
>   		pipe_config_mismatch(fastset, crtc, __stringify(name), \
> @@ -8606,7 +8616,12 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>   		PIPE_CONF_CHECK_I(min_voltage_level);
>   	}
>   
> -	PIPE_CONF_CHECK_X(infoframes.enable);
> +	if (fastset && (current_config->has_psr || pipe_config->has_psr))
> +		PIPE_CONF_CHECK_X_WITH_MASK(infoframes.enable,
> +					    ~intel_hdmi_infoframe_enable(DP_SDP_VSC));
> +	else
> +		PIPE_CONF_CHECK_X(infoframes.enable);
> +
>   	PIPE_CONF_CHECK_X(infoframes.gcp);
>   	PIPE_CONF_CHECK_INFOFRAME(avi);
>   	PIPE_CONF_CHECK_INFOFRAME(spd);
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Nuke has_infoframe

[Gwan-gyeong Mun]

On 5/21/21 10:58 PM, Souza, Jose wrote:
> On Fri, 2021-05-21 at 16:27 +0100, Mun, Gwan-gyeong wrote:
>> On Fri, 2021-05-14 at 16:22 -0700, José Roberto de Souza wrote:
>>> This was only reduntant information has_hdmi_sink can do the same job.
>>> set_infoframes() hooks will call intel_write_infoframe() for the
>>> supported infoframes types and it will only be enabled if given type
>>> is set in crtc_state->infoframes.enable.
>>>
>>> While at it also fixing the style of dig_port->set_infoframes() calls.
>>>
>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/display/g4x_hdmi.c       | 22 ++++++-------------
>>>   drivers/gpu/drm/i915/display/intel_ddi.c      | 17 +++++---------
>>>   drivers/gpu/drm/i915/display/intel_display.c  |  6 ++---
>>>   .../drm/i915/display/intel_display_types.h    |  3 ---
>>>   drivers/gpu/drm/i915/display/intel_dp_mst.c   |  4 ++--
>>>   drivers/gpu/drm/i915/display/intel_hdmi.c     | 13 +++++------
>>>   6 files changed, 22 insertions(+), 43 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c
>>> b/drivers/gpu/drm/i915/display/g4x_hdmi.c
>>> index be352e9f0afc..f35db96e6239 100644
>>> --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
>>> +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
>>> @@ -105,9 +105,6 @@ static void intel_hdmi_get_config(struct
>>> intel_encoder *encoder,
>>>          pipe_config->infoframes.enable |=
>>>                  intel_hdmi_infoframes_enabled(encoder, pipe_config);
>>>   
>>> -       if (pipe_config->infoframes.enable)
>>> -               pipe_config->has_infoframe = true;
>>> -
>> "pipe_config->infoframes.enable" is set with information about the
>> infoframes currently active in the hardware through "pipe_config-
>>> infoframes.enable |= intel_hdmi_infoframes_enabled(encoder,
>> pipe_config);".
>>
>> Therefore, when calling set_infoframes() semantically, the
>> has_infoframe information set by "if (pipe_config->infoframes.enable)
>> pipe_config->has_infoframe = true;" is more clear.
> 
> That don't work because the functions that will check if a infoframe is needed and set pipe_config->infoframes.enable depends on pipe_config-
>> has_infoframe/crtc_state->has_hdmi_sink.
> That is probably because DVI ports don't support infoframes but in i915 are handle very similar to HDMI.
> 
>>
DP and HDMI can have infoframes that fit each specification in the 
specification.
And (although not used in this sense here) when dp has hdmi sink, it can 
be thought of using dp to hdmi protocol converter. I think it might be a 
little unclear, but what do you think?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)

[Souza, Jose]

[-- Attachment #1.1: Type: text/plain, Size: 28408 bytes --]

On Sat, 2021-05-15 at 13:15 +0000, Patchwork wrote:
Patch Details
Series: series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR (rev2)
URL:    https://patchwork.freedesktop.org/series/90184/
State:  failure
Details:        https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/index.html
CI Bug Log - changes from CI_DRM_10085_full -> Patchwork_20131_full
Summary

FAILURE

Serious unknown changes coming with Patchwork_20131_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20131_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_20131_full:

IGT changes
Possible regressions

  *   igt@api_intel_bb@intel-bb-blit-none:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk7/igt@api_intel_bb@intel-bb-blit-none.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk9/igt@api_intel_bb@intel-bb-blit-none.html>
  *   igt@kms_plane_cursor@pipe-a-viewport-size-128:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@kms_plane_cursor@pipe-a-viewport-size-128.html> +1 similar issue

Both are not related, the changes are related to display and snb don't support PSR.

Pushed the 3 patches reviewed, will follow up the other one latter.

Thanks for the reviews GG.

Warnings

  *   igt@gem_mmap_gtt@fault-concurrent-x:

     *   shard-glk: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk3/igt@gem_mmap_gtt@fault-concurrent-x.html> ([i915#3468]) -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@gem_mmap_gtt@fault-concurrent-x.html>
  *   igt@kms_plane_cursor@pipe-b-viewport-size-64:

     *   shard-tglb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb5/igt@kms_plane_cursor@pipe-b-viewport-size-64.html> ([i915#3457]) -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb7/igt@kms_plane_cursor@pipe-b-viewport-size-64.html>

Known issues

Here are the changes found in Patchwork_20131_full that come from known issues:

IGT changes
Issues hit

  *   igt@api_intel_bb@blit-noreloc-purge-cache:

     *   shard-apl: NOTRUN -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@api_intel_bb@blit-noreloc-purge-cache.html> ([i915#3457]) +1 similar issue

     *   shard-skl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@api_intel_bb@blit-noreloc-purge-cache.html> ([i915#3457])

  *   igt@api_intel_bb@blit-noreloc-purge-cache-random:

     *   shard-kbl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@api_intel_bb@blit-noreloc-purge-cache-random.html> ([i915#3457]) +1 similar issue
  *   igt@gem_create@create-clear:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-skl4/igt@gem_create@create-clear.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl1/igt@gem_create@create-clear.html> ([i915#3160])
  *   igt@gem_create@create-massive:

     *   shard-kbl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl7/igt@gem_create@create-massive.html> ([i915#3002])
  *   igt@gem_ctx_persistence@legacy-engines-queued:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@gem_ctx_persistence@legacy-engines-queued.html> ([fdo#109271] / [i915#1099]) +4 similar issues
  *   igt@gem_eio@in-flight-contexts-10ms:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb1/igt@gem_eio@in-flight-contexts-10ms.html> -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb7/igt@gem_eio@in-flight-contexts-10ms.html> ([i915#3063] / [i915#3457])
  *   igt@gem_exec_fair@basic-none-share@rcs0:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html> ([i915#2842] / [i915#3457])
  *   igt@gem_exec_fair@basic-pace-solo@rcs0:

     *   shard-glk: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html> ([i915#3457]) +3 similar issues
  *   igt@gem_exec_fair@basic-pace@vcs0:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb7/igt@gem_exec_fair@basic-pace@vcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs0.html> ([i915#2842] / [i915#3457]) +1 similar issue
  *   igt@gem_exec_fair@basic-pace@vcs1:

     *   shard-iclb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html> ([i915#2842] / [i915#3457])

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs1.html> ([i915#2842] / [i915#3457])

  *   igt@gem_exec_fence@syncobj-export:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk7/igt@gem_exec_fence@syncobj-export.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk4/igt@gem_exec_fence@syncobj-export.html> ([i915#3457]) +23 similar issues
  *   igt@gem_exec_params@no-vebox:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@gem_exec_params@no-vebox.html> ([fdo#109283])
  *   igt@gem_mmap_gtt@big-copy:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk4/igt@gem_mmap_gtt@big-copy.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@gem_mmap_gtt@big-copy.html> ([i915#307])
  *   igt@gem_mmap_gtt@cpuset-basic-small-copy:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb3/igt@gem_mmap_gtt@cpuset-basic-small-copy.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb8/igt@gem_mmap_gtt@cpuset-basic-small-copy.html> ([i915#3468])
  *   igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:

     *   shard-snb: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb5/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html> ([i915#3468])
  *   igt@gem_mmap_gtt@cpuset-big-copy-odd:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy-odd.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy-odd.html> ([i915#307])
  *   igt@gem_pwrite@basic-exhaustion:

     *   shard-snb: NOTRUN -> WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@gem_pwrite@basic-exhaustion.html> ([i915#2658])
  *   igt@gem_render_copy@mixed-tiled-to-yf-tiled-ccs:

     *   shard-glk: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@gem_render_copy@mixed-tiled-to-yf-tiled-ccs.html> ([i915#3468])
  *   igt@gem_render_copy@yf-tiled-ccs-to-linear:

     *   shard-apl: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@gem_render_copy@yf-tiled-ccs-to-linear.html> ([i915#3468]) +2 similar issues
  *   igt@gem_render_copy@yf-tiled-ccs-to-x-tiled:

     *   shard-skl: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl1/igt@gem_render_copy@yf-tiled-ccs-to-x-tiled.html> ([i915#3468]) +1 similar issue
  *   igt@gem_render_copy@yf-tiled-ccs-to-y-tiled:

     *   shard-tglb: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@gem_render_copy@yf-tiled-ccs-to-y-tiled.html> ([i915#3468])
  *   igt@gem_spin_batch@engines@vcs0:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@gem_spin_batch@engines@vcs0.html> ([i915#2898] / [i915#3457]) +3 similar issues
  *   igt@gem_userptr_blits@set-cache-level:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@gem_userptr_blits@set-cache-level.html> ([i915#3324])
  *   igt@gem_userptr_blits@vma-merge:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@gem_userptr_blits@vma-merge.html> ([i915#2724] / [i915#3457])
  *   igt@i915_hangman@engine-error@vcs1:

     *   shard-iclb: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb4/igt@i915_hangman@engine-error@vcs1.html> ([i915#3457])
  *   igt@i915_hangman@error-state-capture@vcs1:

     *   shard-tglb: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@i915_hangman@error-state-capture@vcs1.html> ([i915#3457]) +4 similar issues
  *   igt@i915_pm_rpm@cursor:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk8/igt@i915_pm_rpm@cursor.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@i915_pm_rpm@cursor.html> ([i915#3457]) +1 similar issue
  *   igt@i915_pm_rpm@gem-mmap-type@uc:

     *   shard-apl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@i915_pm_rpm@gem-mmap-type@uc.html> ([i915#3475])
  *   igt@i915_pm_rpm@gem-mmap-type@wc:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb3/igt@i915_pm_rpm@gem-mmap-type@wc.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb2/igt@i915_pm_rpm@gem-mmap-type@wc.html> ([i915#2411] / [i915#3457])
  *   igt@i915_pm_rpm@modeset-lpsp-stress:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@i915_pm_rpm@modeset-lpsp-stress.html> ([fdo#109271]) +116 similar issues
  *   igt@i915_pm_rps@min-max-config-idle:

     *   shard-glk: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@i915_pm_rps@min-max-config-idle.html> ([i915#3457])
  *   igt@i915_pm_sseu@full-enable:

     *   shard-apl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@i915_pm_sseu@full-enable.html> ([i915#3457]) +1 similar issue
  *   igt@i915_selftest@live@hangcheck:

     *   shard-snb: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@i915_selftest@live@hangcheck.html> ([i915#2782])
  *   igt@i915_selftest@live@mman:

     *   shard-snb: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@i915_selftest@live@mman.html> ([i915#3457]) +1 similar issue
  *   igt@kms_atomic@plane-immutable-zpos:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk4/igt@kms_atomic@plane-immutable-zpos.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@kms_atomic@plane-immutable-zpos.html> ([i915#2657] / [i915#3457])
  *   igt@kms_big_fb@yf-tiled-64bpp-rotate-90:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_big_fb@yf-tiled-64bpp-rotate-90.html> ([fdo#111615])
  *   igt@kms_big_joiner@basic:

     *   shard-glk: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_big_joiner@basic.html> ([fdo#109271] / [i915#2705])
  *   igt@kms_color@pipe-a-ctm-0-75:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@kms_color@pipe-a-ctm-0-75.html> ([i915#1982]) +1 similar issue
  *   igt@kms_color_chamelium@pipe-a-ctm-0-25:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-0-25.html> ([fdo#109271] / [fdo#111827]) +26 similar issues
  *   igt@kms_color_chamelium@pipe-b-ctm-max:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_color_chamelium@pipe-b-ctm-max.html> ([fdo#109271] / [fdo#111827]) +2 similar issues
  *   igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html> ([fdo#109284] / [fdo#111827]) +2 similar issues
  *   igt@kms_color_chamelium@pipe-c-ctm-0-25:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_color_chamelium@pipe-c-ctm-0-25.html> ([fdo#109271] / [fdo#111827]) +12 similar issues
  *   igt@kms_color_chamelium@pipe-c-ctm-0-5:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl8/igt@kms_color_chamelium@pipe-c-ctm-0-5.html> ([fdo#109271] / [fdo#111827]) +3 similar issues
  *   igt@kms_color_chamelium@pipe-d-ctm-0-25:

     *   shard-glk: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_color_chamelium@pipe-d-ctm-0-25.html> ([fdo#109271] / [fdo#111827]) +4 similar issues
  *   igt@kms_content_protection@lic:

     *   shard-apl: NOTRUN -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_content_protection@lic.html> ([i915#1319]) +1 similar issue
  *   igt@kms_cursor_crc@pipe-a-cursor-32x32-random:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-32x32-random.html> ([i915#3319] / [i915#3457])
  *   igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding.html> ([i915#3444] / [i915#3457]) +3 similar issues
  *   igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html> ([i915#3457]) +1 similar issue
  *   igt@kms_cursor_crc@pipe-a-cursor-dpms:

     *   shard-glk: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_cursor_crc@pipe-a-cursor-dpms.html> ([i915#3444] / [i915#3457]) +1 similar issue
  *   igt@kms_cursor_crc@pipe-a-cursor-suspend:

     *   shard-skl: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@kms_cursor_crc@pipe-a-cursor-suspend.html> ([i915#2828] / [i915#300])
  *   igt@kms_cursor_crc@pipe-b-cursor-256x256-random:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html> ([i915#3457]) +11 similar issues
  *   igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding:

     *   shard-skl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding.html> ([i915#3444] / [i915#3457]) +3 similar issues
  *   igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen:

     *   shard-tglb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen.html> ([i915#2124] / [i915#3457]) +3 similar issues
  *   igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement.html> ([fdo#109271] / [i915#3457]) +3 similar issues
  *   igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen.html> ([i915#3444] / [i915#3457]) +2 similar issues
  *   igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen:

     *   shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html> ([i915#3444] / [i915#3457]) +1 similar issue
  *   igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen:

     *   shard-kbl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen.html> ([i915#3444] / [i915#3457]) +4 similar issues
  *   igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen:

     *   shard-glk: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen.html> ([fdo#109271] / [i915#3457]) +5 similar issues
  *   igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding.html> ([fdo#109279] / [i915#3359] / [i915#3457])
  *   igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk6/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk6/igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen.html> ([i915#3444] / [i915#3457]) +3 similar issues
  *   igt@kms_cursor_crc@pipe-d-cursor-256x85-rapid-movement:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@kms_cursor_crc@pipe-d-cursor-256x85-rapid-movement.html> ([fdo#109271] / [i915#3457]) +19 similar issues
  *   igt@kms_cursor_crc@pipe-d-cursor-32x10-rapid-movement:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@kms_cursor_crc@pipe-d-cursor-32x10-rapid-movement.html> ([fdo#109271] / [i915#3457]) +49 similar issues
  *   igt@kms_cursor_crc@pipe-d-cursor-64x21-offscreen:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-64x21-offscreen.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-64x21-offscreen.html> ([i915#2124] / [i915#3457]) +4 similar issues
  *   igt@kms_cursor_crc@pipe-d-cursor-max-size-sliding:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_cursor_crc@pipe-d-cursor-max-size-sliding.html> ([fdo#109271] / [i915#3457]) +6 similar issues
  *   igt@kms_cursor_edge_walk@pipe-b-64x64-bottom-edge:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk8/igt@kms_cursor_edge_walk@pipe-b-64x64-bottom-edge.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@kms_cursor_edge_walk@pipe-b-64x64-bottom-edge.html> ([i915#70]) +1 similar issue
  *   igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html> ([fdo#111825]) +12 similar issues
  *   igt@kms_flip@flip-vs-suspend@b-dp1:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-kbl3/igt@kms_flip@flip-vs-suspend@b-dp1.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl4/igt@kms_flip@flip-vs-suspend@b-dp1.html> ([i915#180]) +2 similar issues
  *   igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html> ([fdo#109271] / [i915#2642])
  *   igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl1/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html> ([fdo#109271]) +29 similar issues
  *   igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html> ([fdo#109271]) +48 similar issues
  *   igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:

     *   shard-glk: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html> ([fdo#109271]) +21 similar issues
  *   igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html> ([fdo#109271]) +391 similar issues
  *   igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html> ([fdo#109271] / [i915#533])
  *   igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html> ([fdo#108145] / [i915#265])

     *   shard-kbl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html> ([fdo#108145] / [i915#265] / [i915#3457])

  *   igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html> ([i915#265])
  *   igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:

     *   shard-skl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html> ([fdo#108145] / [i915#265])
  *   igt@kms_plane_cursor@pipe-a-primary-size-64:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-snb2/igt@kms_plane_cursor@pipe-a-primary-size-64.html> ([i915#3461]) +1 similar issue
  *   igt@kms_plane_cursor@pipe-b-overlay-size-64:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb2/igt@kms_plane_cursor@pipe-b-overlay-size-64.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb7/igt@kms_plane_cursor@pipe-b-overlay-size-64.html> ([i915#2657] / [i915#3457])
  *   igt@kms_plane_cursor@pipe-b-primary-size-64:

     *   shard-skl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl8/igt@kms_plane_cursor@pipe-b-primary-size-64.html> ([i915#2657] / [i915#3457]) +1 similar issue
  *   igt@kms_plane_lowres@pipe-b-tiling-none:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-glk8/igt@kms_plane_lowres@pipe-b-tiling-none.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk8/igt@kms_plane_lowres@pipe-b-tiling-none.html> ([i915#3457] / [i915#899])
  *   igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html> ([fdo#109271] / [i915#658]) +4 similar issues
  *   igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:

     *   shard-glk: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html> ([fdo#109271] / [i915#658])
  *   igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html> ([fdo#109271] / [i915#658]) +2 similar issues
  *   igt@kms_psr2_sf@plane-move-sf-dmg-area-0:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-skl1/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html> ([fdo#109271] / [i915#658]) +2 similar issues
  *   igt@kms_psr@psr2_cursor_render:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-iclb2/igt@kms_psr@psr2_cursor_render.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-iclb7/igt@kms_psr@psr2_cursor_render.html> ([fdo#109441])
  *   igt@kms_writeback@writeback-fb-id:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@kms_writeback@writeback-fb-id.html> ([fdo#109271] / [i915#2437])
  *   igt@nouveau_crc@pipe-b-ctx-flip-detection:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@nouveau_crc@pipe-b-ctx-flip-detection.html> ([i915#2530])
  *   igt@perf_pmu@busy-idle@bcs0:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@perf_pmu@busy-idle@bcs0.html> ([i915#3457]) +3 similar issues
  *   igt@perf_pmu@busy-idle@vecs0:

     *   shard-apl: NOTRUN -> WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@perf_pmu@busy-idle@vecs0.html> ([i915#3457]) +2 similar issues
  *   igt@prime_nv_test@i915_import_cpu_mmap:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@prime_nv_test@i915_import_cpu_mmap.html> ([fdo#109291])
  *   igt@prime_vgem@fence-flip-hang:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-tglb5/igt@prime_vgem@fence-flip-hang.html> ([fdo#109295])
  *   igt@sysfs_clients@recycle-many:

     *   shard-glk: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-glk5/igt@sysfs_clients@recycle-many.html> ([fdo#109271] / [i915#2994])
  *   igt@sysfs_clients@split-50:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl2/igt@sysfs_clients@split-50.html> ([fdo#109271] / [i915#2994]) +1 similar issue

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl6/igt@sysfs_clients@split-50.html> ([fdo#109271] / [i915#2994])

  *   igt@sysfs_heartbeat_interval@mixed@vcs1:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10085/shard-kbl7/igt@sysfs_heartbeat_interval@mixed@vcs1.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-kbl4/igt@sysfs_heartbeat_interval@mixed@vcs1.html> ([i915#1731] / [i915#3457])
  *   igt@sysfs_heartbeat_interval@mixed@vecs0:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20131/shard-apl7/igt@sysfs_heartbeat_interval@mixed@vecs0.html> ([i915#1731] / [i915#3457]) +3 similar issues
  *   igt@sysfs_preempt_timeout@timeout@vecs0:

     *   shard-apl: PASS<https://intel-gfx-ci.01> -> [FAIL][132] ([i915#1755] / [i915#3457]) +1 similar issue


[-- Attachment #1.2: Type: text/html, Size: 34228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Nuke has_infoframe

[Souza, Jose]

On Mon, 2021-06-07 at 15:49 +0300, Gwan-gyeong Mun wrote:
> 
> On 5/21/21 10:58 PM, Souza, Jose wrote:
> > On Fri, 2021-05-21 at 16:27 +0100, Mun, Gwan-gyeong wrote:
> > > On Fri, 2021-05-14 at 16:22 -0700, José Roberto de Souza wrote:
> > > > This was only reduntant information has_hdmi_sink can do the same job.
> > > > set_infoframes() hooks will call intel_write_infoframe() for the
> > > > supported infoframes types and it will only be enabled if given type
> > > > is set in crtc_state->infoframes.enable.
> > > > 
> > > > While at it also fixing the style of dig_port->set_infoframes() calls.
> > > > 
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > ---
> > > >   drivers/gpu/drm/i915/display/g4x_hdmi.c       | 22 ++++++-------------
> > > >   drivers/gpu/drm/i915/display/intel_ddi.c      | 17 +++++---------
> > > >   drivers/gpu/drm/i915/display/intel_display.c  |  6 ++---
> > > >   .../drm/i915/display/intel_display_types.h    |  3 ---
> > > >   drivers/gpu/drm/i915/display/intel_dp_mst.c   |  4 ++--
> > > >   drivers/gpu/drm/i915/display/intel_hdmi.c     | 13 +++++------
> > > >   6 files changed, 22 insertions(+), 43 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > > > b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > > > index be352e9f0afc..f35db96e6239 100644
> > > > --- a/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > > > +++ b/drivers/gpu/drm/i915/display/g4x_hdmi.c
> > > > @@ -105,9 +105,6 @@ static void intel_hdmi_get_config(struct
> > > > intel_encoder *encoder,
> > > >          pipe_config->infoframes.enable |=
> > > >                  intel_hdmi_infoframes_enabled(encoder, pipe_config);
> > > >   
> > > > -       if (pipe_config->infoframes.enable)
> > > > -               pipe_config->has_infoframe = true;
> > > > -
> > > "pipe_config->infoframes.enable" is set with information about the
> > > infoframes currently active in the hardware through "pipe_config-
> > > > infoframes.enable |= intel_hdmi_infoframes_enabled(encoder,
> > > pipe_config);".
> > > 
> > > Therefore, when calling set_infoframes() semantically, the
> > > has_infoframe information set by "if (pipe_config->infoframes.enable)
> > > pipe_config->has_infoframe = true;" is more clear.
> > 
> > That don't work because the functions that will check if a infoframe is needed and set pipe_config->infoframes.enable depends on pipe_config-
> > > has_infoframe/crtc_state->has_hdmi_sink.
> > That is probably because DVI ports don't support infoframes but in i915 are handle very similar to HDMI.
> > 
> > > 
> DP and HDMI can have infoframes that fit each specification in the 
> specification.
> And (although not used in this sense here) when dp has hdmi sink, it can 
> be thought of using dp to hdmi protocol converter. I think it might be a 
> little unclear, but what do you think?

Not sure if I understood what you mean but on intel_hdmi_compute_config(), has_infoframe is set right now after check if there is a HDMI sink(handling
DP and HDMI, intel_has_hdmi_sink()).

FYI I have applied all the other patches.


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

[Ville Syrjälä]

On Fri, May 14, 2021 at 04:22:47PM -0700, José Roberto de Souza wrote:
> intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will
> take care to disable all enabled infoframes.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 5bc5528f3091..d3bc5a1a936a 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
>  					conn_state);
>  
>  		/* FIXME precompute everything properly */
> -		/* FIXME how do we turn infoframes off again? */

The FIXME was there for LSPCON and shouldn't have been removed.
No one has yet figured out how to do this.

>  		if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink)
>  			dig_port->set_infoframes(encoder, true, crtc_state,
>  						 conn_state);
> -- 
> 2.31.1

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

[Souza, Jose]

On Tue, 2021-06-08 at 10:26 +0300, Ville Syrjälä wrote:
> On Fri, May 14, 2021 at 04:22:47PM -0700, José Roberto de Souza wrote:
> > intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will
> > take care to disable all enabled infoframes.
> > 
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_ddi.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > index 5bc5528f3091..d3bc5a1a936a 100644
> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > @@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
> >  					conn_state);
> >  
> >  		/* FIXME precompute everything properly */
> > -		/* FIXME how do we turn infoframes off again? */
> 
> The FIXME was there for LSPCON and shouldn't have been removed.
> No one has yet figured out how to do this.

intel_ddi_post_disable_dp()->intel_dp_set_infoframes() will be executed for LSPCON, or am I missing something?

> 
> >  		if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink)
> >  			dig_port->set_infoframes(encoder, true, crtc_state,
> >  						 conn_state);
> > -- 
> > 2.31.1
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

[Ville Syrjälä]

On Wed, Jun 09, 2021 at 07:25:36PM +0000, Souza, Jose wrote:
> On Tue, 2021-06-08 at 10:26 +0300, Ville Syrjälä wrote:
> > On Fri, May 14, 2021 at 04:22:47PM -0700, José Roberto de Souza wrote:
> > > intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will
> > > take care to disable all enabled infoframes.
> > > 
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_ddi.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > index 5bc5528f3091..d3bc5a1a936a 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > @@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
> > >  					conn_state);
> > >  
> > >  		/* FIXME precompute everything properly */
> > > -		/* FIXME how do we turn infoframes off again? */
> > 
> > The FIXME was there for LSPCON and shouldn't have been removed.
> > No one has yet figured out how to do this.
> 
> intel_ddi_post_disable_dp()->intel_dp_set_infoframes() will be executed for LSPCON, or am I missing something?

LSPCON generates its own infoframes, so turning off the video DIP does
diddly squat.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

[Souza, Jose]

On Thu, 2021-06-10 at 15:18 +0300, Ville Syrjälä wrote:
> On Wed, Jun 09, 2021 at 07:25:36PM +0000, Souza, Jose wrote:
> > On Tue, 2021-06-08 at 10:26 +0300, Ville Syrjälä wrote:
> > > On Fri, May 14, 2021 at 04:22:47PM -0700, José Roberto de Souza wrote:
> > > > intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will
> > > > take care to disable all enabled infoframes.
> > > > 
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > ---
> > > >  drivers/gpu/drm/i915/display/intel_ddi.c | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > index 5bc5528f3091..d3bc5a1a936a 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > @@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
> > > >  					conn_state);
> > > >  
> > > >  		/* FIXME precompute everything properly */
> > > > -		/* FIXME how do we turn infoframes off again? */
> > > 
> > > The FIXME was there for LSPCON and shouldn't have been removed.
> > > No one has yet figured out how to do this.
> > 
> > intel_ddi_post_disable_dp()->intel_dp_set_infoframes() will be executed for LSPCON, or am I missing something?
> 
> LSPCON generates its own infoframes, so turning off the video DIP does
> diddly squat.
> 

It would not be the lspcon job to do so when DP -> lspcon video is off?
Anyways will be sending the revert in a few minutes, please review that if we really need this fixme back.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

[Ville Syrjälä]

On Thu, Jun 10, 2021 at 05:44:12PM +0000, Souza, Jose wrote:
> On Thu, 2021-06-10 at 15:18 +0300, Ville Syrjälä wrote:
> > On Wed, Jun 09, 2021 at 07:25:36PM +0000, Souza, Jose wrote:
> > > On Tue, 2021-06-08 at 10:26 +0300, Ville Syrjälä wrote:
> > > > On Fri, May 14, 2021 at 04:22:47PM -0700, José Roberto de Souza wrote:
> > > > > intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will
> > > > > take care to disable all enabled infoframes.
> > > > > 
> > > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > > > ---
> > > > >  drivers/gpu/drm/i915/display/intel_ddi.c | 1 -
> > > > >  1 file changed, 1 deletion(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > > index 5bc5528f3091..d3bc5a1a936a 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > > @@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
> > > > >  					conn_state);
> > > > >  
> > > > >  		/* FIXME precompute everything properly */
> > > > > -		/* FIXME how do we turn infoframes off again? */
> > > > 
> > > > The FIXME was there for LSPCON and shouldn't have been removed.
> > > > No one has yet figured out how to do this.
> > > 
> > > intel_ddi_post_disable_dp()->intel_dp_set_infoframes() will be executed for LSPCON, or am I missing something?
> > 
> > LSPCON generates its own infoframes, so turning off the video DIP does
> > diddly squat.
> > 
> 
> It would not be the lspcon job to do so when DP -> lspcon video is off?

LSPCON is a blackbox and no one knows what it actually does. Which is
pretty much the point of the FIXME.

> Anyways will be sending the revert in a few minutes, please review that if we really need this fixme back.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx