Re: [PULL 00/20] Misc patches for 2020-05-17

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210517112001.2564006-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210517112001.2564006-1-pbonzini@redhat.com
Subject: [PULL 00/20] Misc patches for 2020-05-17

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210517112001.2564006-1-pbonzini@redhat.com -> patchew/20210517112001.2564006-1-pbonzini@redhat.com
Switched to a new branch 'test'
77eb22a KVM: Dirty ring support
520cdc9 KVM: Disable manual dirty log when dirty ring enabled
d672dde KVM: Add dirty-ring-size property
f325098 KVM: Cache kvm slot dirty bitmap size
568e8ff KVM: Simplify dirty log sync in kvm_set_phys_mem
7d5d872 KVM: Provide helper to sync dirty bitmap from slot to ramblock
7b2937f KVM: Provide helper to get kvm dirty log
8160151 KVM: Create the KVMSlot dirty bitmap on flag changes
a013508 KVM: Use a big lock to replace per-kml slots_lock
3549fdf memory: Introduce log_sync_global() to memory listener
415d0d0 KVM: do not allow setting properties at runtime
d44087e qtest: add a QOM object for qtest
b21d58b object: add more commands to preconfig mode
80d034a2 meson: bump submodule to 0.57.2
91a9f7f i386/cpu: Expose AVX_VNNI instruction to guest
4ed41f8 backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD
525090e hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on'
5451f01 configure: simplify assignment to GIT_SUBMODULES
fd5bbbe configure: check for submodules if --with-git-submodules=ignore
4a71809 configure: Only clone softfloat-3 repositories if TCG is enabled

=== OUTPUT BEGIN ===
1/20 Checking commit 4a7180969269 (configure: Only clone softfloat-3 repositories if TCG is enabled)
ERROR: Doubly-encoded UTF-8
#7: 
    Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

total: 1 errors, 0 warnings, 19 lines checked

Patch 1/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/20 Checking commit fd5bbbe5111e (configure: check for submodules if --with-git-submodules=ignore)
3/20 Checking commit 5451f0196365 (configure: simplify assignment to GIT_SUBMODULES)
4/20 Checking commit 525090e9e978 (hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on')
ERROR: Doubly-encoded UTF-8
#16: 
    Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

total: 1 errors, 0 warnings, 30 lines checked

Patch 4/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/20 Checking commit 4ed41f88b595 (backends/tpm: Replace qemu_mutex_lock calls with QEMU_LOCK_GUARD)
6/20 Checking commit 91a9f7fa5700 (i386/cpu: Expose AVX_VNNI instruction to guest)
7/20 Checking commit 80d034a230fb (meson: bump submodule to 0.57.2)
8/20 Checking commit b21d58bf2249 (object: add more commands to preconfig mode)
9/20 Checking commit d44087e84505 (qtest: add a QOM object for qtest)
10/20 Checking commit 415d0d0f4894 (KVM: do not allow setting properties at runtime)
ERROR: line over 90 characters
#33: FILE: accel/kvm/kvm-all.c:3115:
+        error_setg(errp, "Cannot set properties after the accelerator has been initialized");

ERROR: line over 90 characters
#45: FILE: accel/kvm/kvm-all.c:3134:
+        error_setg(errp, "Cannot set properties after the accelerator has been initialized");

total: 2 errors, 0 warnings, 37 lines checked

Patch 10/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/20 Checking commit 3549fdff41f9 (memory: Introduce log_sync_global() to memory listener)
12/20 Checking commit a01350856d61 (KVM: Use a big lock to replace per-kml slots_lock)
13/20 Checking commit 8160151d18d7 (KVM: Create the KVMSlot dirty bitmap on flag changes)
14/20 Checking commit 7b2937fa36c2 (KVM: Provide helper to get kvm dirty log)
15/20 Checking commit 7d5d87209ba9 (KVM: Provide helper to sync dirty bitmap from slot to ramblock)
16/20 Checking commit 568e8ffbabee (KVM: Simplify dirty log sync in kvm_set_phys_mem)
17/20 Checking commit f32509862618 (KVM: Cache kvm slot dirty bitmap size)
18/20 Checking commit d672dde943f7 (KVM: Add dirty-ring-size property)
ERROR: line over 90 characters
#59: FILE: accel/kvm/kvm-all.c:3206:
+        error_setg(errp, "Cannot set properties after the accelerator has been initialized");

total: 1 errors, 0 warnings, 94 lines checked

Patch 18/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/20 Checking commit 520cdc91f820 (KVM: Disable manual dirty log when dirty ring enabled)
20/20 Checking commit 77eb22ac14f1 (KVM: Dirty ring support)
WARNING: line over 80 characters
#451: FILE: accel/kvm/kvm-all.c:2466:
+                             "Suggested mininum value is 1024.", strerror(-ret));

total: 0 errors, 1 warnings, 498 lines checked

Patch 20/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210517112001.2564006-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com