All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jay Fang <f.fangjian@huawei.com>
To: <gregkh@linuxfoundation.org>
Cc: <linux-serial@vger.kernel.org>, <linuxarm@huawei.com>,
	<huangdaode@huawei.com>, <tangzihao1@hisilicon.com>
Subject: [PATCH 06/11] tty: serial: atmel: Fix some coding style issues
Date: Tue, 18 May 2021 09:57:13 +0800	[thread overview]
Message-ID: <1621303038-12062-7-git-send-email-f.fangjian@huawei.com> (raw)
In-Reply-To: <1621303038-12062-1-git-send-email-f.fangjian@huawei.com>

From: Zihao Tang <tangzihao1@hisilicon.com>

Fix some coding style warnings reported by checkpatch.pl.

Fix 4 "Block comments use a trailing */ on a separate line" warnings.
Fix 1 "Block comments use * on subsequent lines" warning.
Fix 1 "Block comments use * on subsequent lines" warning.

Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
---
 drivers/tty/serial/atmel_serial.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 058886d..5d4675f 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -60,7 +60,8 @@ static void atmel_stop_rx(struct uart_port *port);
 
 /* Use device name ttyAT, major 204 and minor 154-169.  This is necessary if we
  * should coexist with the 8250 driver, such as if we have an external 16C550
- * UART. */
+ * UART.
+ */
 #define SERIAL_ATMEL_MAJOR	204
 #define MINOR_START		154
 #define ATMEL_DEVICENAME	"ttyAT"
@@ -68,7 +69,8 @@ static void atmel_stop_rx(struct uart_port *port);
 #else
 
 /* Use device name ttyS, major 4, minor 64-68.  This is the usual serial port
- * name, but it is legally reserved for the 8250 driver. */
+ * name, but it is legally reserved for the 8250 driver.
+ */
 #define SERIAL_ATMEL_MAJOR	TTY_MAJOR
 #define MINOR_START		64
 #define ATMEL_DEVICENAME	"ttyS"
@@ -582,7 +584,8 @@ static void atmel_start_tx(struct uart_port *port)
 	if (atmel_use_pdc_tx(port) && (atmel_uart_readl(port, ATMEL_PDC_PTSR)
 				       & ATMEL_PDC_TXTEN))
 		/* The transmitter is already running.  Yes, we
-		   really need this.*/
+		 * really need this.
+		 */
 		return;
 
 	if (atmel_use_pdc_tx(port) || atmel_use_dma_tx(port))
@@ -2399,6 +2402,7 @@ static void atmel_config_port(struct uart_port *port, int flags)
 static int atmel_verify_port(struct uart_port *port, struct serial_struct *ser)
 {
 	int ret = 0;
+
 	if (ser->type != PORT_UNKNOWN && ser->type != PORT_ATMEL)
 		ret = -EINVAL;
 	if (port->irq != ser->irq)
@@ -2837,7 +2841,8 @@ static int atmel_serial_probe(struct platform_device *pdev)
 	ret = of_alias_get_id(np, "serial");
 	if (ret < 0)
 		/* port id not found in platform data nor device-tree aliases:
-		 * auto-enumerate it */
+		 * auto-enumerate it
+		 */
 		ret = find_first_zero_bit(atmel_ports_in_use, ATMEL_MAX_UART);
 
 	if (ret >= ATMEL_MAX_UART) {
-- 
2.7.4


  parent reply	other threads:[~2021-05-18  1:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  1:57 [PATCH 00/11] tty: serial: Fix some coding style issues Jay Fang
2021-05-18  1:57 ` [PATCH 01/11] tty: serial: 21285: Fix some coding sytle issues Jay Fang
2021-05-18  1:57 ` [PATCH 02/11] tty: serial: amba-pl010: Fix 2 coding style issues Jay Fang
2021-05-18  1:57 ` [PATCH 03/11] tty: serial: amba-pl011: Replace the unsuitable spaces with tabs Jay Fang
2021-05-18  1:57 ` [PATCH 04/11] tty: serial: amba-pl011: Remove initialization of static variable Jay Fang
2021-05-18  1:57 ` [PATCH 05/11] tty: serial: apbuart: Fix some coding sytle issues Jay Fang
2021-05-18  1:57 ` Jay Fang [this message]
2021-05-18  1:57 ` [PATCH 07/11] tty: serial: bcm63xx_uart: Fix some coding style issues Jay Fang
2021-05-18  1:57 ` [PATCH 08/11] tty: serial: clps711x: Fix some coding style issuses Jay Fang
2021-05-18  1:57 ` [PATCH 09/11] tty: serial: digicolor: Use 'unsigned int' instead of 'unsigned' Jay Fang
2021-05-18  1:57 ` [PATCH 10/11] tty: serial: dz: " Jay Fang
2021-05-18  1:57 ` [PATCH 11/11] tty: serial: earlycon-arm-semihost : Fix some coding style issuses Jay Fang
2021-05-18  5:39 ` [PATCH 00/11] tty: serial: Fix some coding style issues Greg KH
2021-05-21  8:56 ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1621303038-12062-7-git-send-email-f.fangjian@huawei.com \
    --to=f.fangjian@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=huangdaode@huawei.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=tangzihao1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.