All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] net: lan78xx: advertise tx software timestamping support
@ 2021-05-18  9:54 Markus Bloechl
  2021-05-18 20:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Markus Bloechl @ 2021-05-18  9:54 UTC (permalink / raw)
  To: Woojung Huh, Jakub Kicinski, David S. Miller
  Cc: UNGLinuxDriver, netdev, linux-usb, linux-kernel, markus

lan78xx already calls skb_tx_timestamp() in its lan78xx_start_xmit().
Override .get_ts_info to also advertise this capability
(SOF_TIMESTAMPING_TX_SOFTWARE) via ethtool.

Signed-off-by: Markus Blöchl <markus.bloechl@ipetronik.com>
---

Notes:
	The main motivation for this patch was that e.g. linuxptp refuses
	to start if the driver lacks support for the required timestamping
	features.

	I also recognized that many usb ethernet drivers which use the usbnet
	infrastructure do not override .get_ts_info accordingly, despite calling
	skb_tx_timestamp() indirectly in their .ndo_start_xmit handler
	via usbnet_start_xmit().
	For most of them the .get_ts_info override from usbnet is lost when
	they override .ethtool_ops again.
	Should they all receive a similar patch?

 drivers/net/usb/lan78xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 6acc5e904518..02bce40a67e5 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -1645,6 +1645,7 @@ static const struct ethtool_ops lan78xx_ethtool_ops = {
 	.get_strings	= lan78xx_get_strings,
 	.get_wol	= lan78xx_get_wol,
 	.set_wol	= lan78xx_set_wol,
+	.get_ts_info	= ethtool_op_get_ts_info,
 	.get_eee	= lan78xx_get_eee,
 	.set_eee	= lan78xx_set_eee,
 	.get_pauseparam	= lan78xx_get_pause,

base-commit: a6f8ee58a8e35f7e4380a5efce312e2a5bc27497


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: lan78xx: advertise tx software timestamping support
  2021-05-18  9:54 [PATCH net] net: lan78xx: advertise tx software timestamping support Markus Bloechl
@ 2021-05-18 20:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-18 20:40 UTC (permalink / raw)
  To: Markus Bloechl
  Cc: woojung.huh, kuba, davem, UNGLinuxDriver, netdev, linux-usb,
	linux-kernel, markus

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 18 May 2021 11:54:11 +0200 you wrote:
> lan78xx already calls skb_tx_timestamp() in its lan78xx_start_xmit().
> Override .get_ts_info to also advertise this capability
> (SOF_TIMESTAMPING_TX_SOFTWARE) via ethtool.
> 
> Signed-off-by: Markus Blöchl <markus.bloechl@ipetronik.com>
> ---
> 
> [...]

Here is the summary with links:
  - [net] net: lan78xx: advertise tx software timestamping support
    https://git.kernel.org/netdev/net/c/33e6b1674f33

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-18 20:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18  9:54 [PATCH net] net: lan78xx: advertise tx software timestamping support Markus Bloechl
2021-05-18 20:40 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.