[PATCH net-next] cipso: correct comments of cipso_v4_cache_invalidate()

[PATCH net-next] cipso: correct comments of cipso_v4_cache_invalidate()

[Zheng Yejian]

Since cipso_v4_cache_invalidate() has no return value, so drop
related descriptions in its comments.

Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine")
Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
---
 net/ipv4/cipso_ipv4.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
index bfaf327e9d12..d6e3a92841e3 100644
--- a/net/ipv4/cipso_ipv4.c
+++ b/net/ipv4/cipso_ipv4.c
@@ -187,8 +187,7 @@ static int __init cipso_v4_cache_init(void)
  * cipso_v4_cache_invalidate - Invalidates the current CIPSO cache
  *
  * Description:
- * Invalidates and frees any entries in the CIPSO cache.  Returns zero on
- * success and negative values on failure.
+ * Invalidates and frees any entries in the CIPSO cache.
  *
  */
 void cipso_v4_cache_invalidate(void)
-- 
2.17.1

Re: [PATCH net-next] cipso: correct comments of cipso_v4_cache_invalidate()

[Paul Moore]

On Tue, May 18, 2021 at 5:05 AM Zheng Yejian <zhengyejian1@huawei.com> wrote:
>
> Since cipso_v4_cache_invalidate() has no return value, so drop
> related descriptions in its comments.
>
> Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine")
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
> ---
>  net/ipv4/cipso_ipv4.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks for catching this.

Acked-by: Paul Moore <paul@paul-moore.com>

> diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
> index bfaf327e9d12..d6e3a92841e3 100644
> --- a/net/ipv4/cipso_ipv4.c
> +++ b/net/ipv4/cipso_ipv4.c
> @@ -187,8 +187,7 @@ static int __init cipso_v4_cache_init(void)
>   * cipso_v4_cache_invalidate - Invalidates the current CIPSO cache
>   *
>   * Description:
> - * Invalidates and frees any entries in the CIPSO cache.  Returns zero on
> - * success and negative values on failure.
> + * Invalidates and frees any entries in the CIPSO cache.
>   *
>   */
>  void cipso_v4_cache_invalidate(void)
> --
> 2.17.1

-- 
paul moore
www.paul-moore.com

Re: [PATCH net-next] cipso: correct comments of cipso_v4_cache_invalidate()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 18 May 2021 17:11:41 +0800 you wrote:
> Since cipso_v4_cache_invalidate() has no return value, so drop
> related descriptions in its comments.
> 
> Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine")
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
> ---
>  net/ipv4/cipso_ipv4.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Here is the summary with links:
  - [net-next] cipso: correct comments of cipso_v4_cache_invalidate()
    https://git.kernel.org/netdev/net-next/c/4ac9e23cf2cc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html