All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: iii@linux.ibm.com
Cc: iii@linux.ibm.com, david@redhat.com, cohuck@redhat.com,
	richard.henderson@linaro.org, laurent@vivier.eu,
	qemu-devel@nongnu.org, borntraeger@de.ibm.com,
	qemu-s390x@nongnu.org, krebbel@linux.ibm.com
Subject: Re: [PATCH v2 0/2] target/s390x: Fix SIGILL psw.addr reporting
Date: Fri, 21 May 2021 04:30:47 -0700 (PDT)	[thread overview]
Message-ID: <162159664568.20339.14323427012740523410@0addf061776e> (raw)
In-Reply-To: <20210521111908.2843735-1-iii@linux.ibm.com>

Patchew URL: https://patchew.org/QEMU/20210521111908.2843735-1-iii@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210521111908.2843735-1-iii@linux.ibm.com
Subject: [PATCH v2 0/2] target/s390x: Fix SIGILL psw.addr reporting

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   0b5acf8..da9076f  master     -> master
 * [new tag]         patchew/20210521111908.2843735-1-iii@linux.ibm.com -> patchew/20210521111908.2843735-1-iii@linux.ibm.com
Switched to a new branch 'test'
195f303 tests/tcg/s390x: Test SIGILL handling
37f7389 target/s390x: Fix SIGILL psw.addr reporting

=== OUTPUT BEGIN ===
1/2 Checking commit 37f73891cb22 (target/s390x: Fix SIGILL psw.addr reporting)
2/2 Checking commit 195f303f366e (tests/tcg/s390x: Test SIGILL handling)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

ERROR: externs should be avoided in .c files
#43: FILE: tests/tcg/s390x/sigill.c:13:
+void expected_si_addr(void);

ERROR: externs should be avoided in .c files
#44: FILE: tests/tcg/s390x/sigill.c:14:
+void expected_psw_addr(void);

total: 2 errors, 1 warnings, 56 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210521111908.2843735-1-iii@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2021-05-21 11:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 11:19 [PATCH v2 0/2] target/s390x: Fix SIGILL psw.addr reporting Ilya Leoshkevich
2021-05-21 11:19 ` [PATCH v2 1/2] " Ilya Leoshkevich
2021-05-21 11:19 ` [PATCH v2 2/2] tests/tcg/s390x: Test SIGILL handling Ilya Leoshkevich
2021-05-21 11:22   ` David Hildenbrand
2021-05-21 11:30 ` no-reply [this message]
2021-06-01 12:38 ` [PATCH v2 0/2] target/s390x: Fix SIGILL psw.addr reporting Ilya Leoshkevich
2021-06-01 15:52   ` Ilya Leoshkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162159664568.20339.14323427012740523410@0addf061776e \
    --to=no-reply@patchew.org \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=iii@linux.ibm.com \
    --cc=krebbel@linux.ibm.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.