From: Zou Wei <zou_wei@huawei.com> To: <agk@redhat.com>, <snitzer@redhat.com>, <dm-devel@redhat.com> Cc: <linux-kernel@vger.kernel.org>, Zou Wei <zou_wei@huawei.com> Subject: [PATCH -next] dm btree: make symbol 'shadow_child' static Date: Fri, 21 May 2021 20:48:56 +0800 [thread overview] Message-ID: <1621601336-11279-1-git-send-email-zou_wei@huawei.com> (raw) The sparse tool complains as follows: drivers/md/persistent-data/dm-btree.c:696:5: warning: symbol 'shadow_child' was not declared. Should it be static? This symbol is not used outside of dm-btree.c, so marks it static. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/md/persistent-data/dm-btree.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c index b8d21b6..a29bcb8 100644 --- a/drivers/md/persistent-data/dm-btree.c +++ b/drivers/md/persistent-data/dm-btree.c @@ -693,8 +693,10 @@ static int split_one_into_two(struct shadow_spine *s, unsigned parent_index, * child of the given parent node. Making sure to update the parent to point * to the new shadow. */ -int shadow_child(struct dm_btree_info *info, struct dm_btree_value_type *vt, - struct btree_node *parent, unsigned index, struct dm_block **result) +static int shadow_child(struct dm_btree_info *info, + struct dm_btree_value_type *vt, + struct btree_node *parent, + unsigned index, struct dm_block **result) { int r, inc; dm_block_t root; -- 2.6.2
WARNING: multiple messages have this Message-ID (diff)
From: Zou Wei <zou_wei@huawei.com> To: <agk@redhat.com>, <snitzer@redhat.com>, <dm-devel@redhat.com> Cc: Zou Wei <zou_wei@huawei.com>, linux-kernel@vger.kernel.org Subject: [dm-devel] [PATCH -next] dm btree: make symbol 'shadow_child' static Date: Fri, 21 May 2021 20:48:56 +0800 [thread overview] Message-ID: <1621601336-11279-1-git-send-email-zou_wei@huawei.com> (raw) The sparse tool complains as follows: drivers/md/persistent-data/dm-btree.c:696:5: warning: symbol 'shadow_child' was not declared. Should it be static? This symbol is not used outside of dm-btree.c, so marks it static. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/md/persistent-data/dm-btree.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c index b8d21b6..a29bcb8 100644 --- a/drivers/md/persistent-data/dm-btree.c +++ b/drivers/md/persistent-data/dm-btree.c @@ -693,8 +693,10 @@ static int split_one_into_two(struct shadow_spine *s, unsigned parent_index, * child of the given parent node. Making sure to update the parent to point * to the new shadow. */ -int shadow_child(struct dm_btree_info *info, struct dm_btree_value_type *vt, - struct btree_node *parent, unsigned index, struct dm_block **result) +static int shadow_child(struct dm_btree_info *info, + struct dm_btree_value_type *vt, + struct btree_node *parent, + unsigned index, struct dm_block **result) { int r, inc; dm_block_t root; -- 2.6.2 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next reply other threads:[~2021-05-21 12:30 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-21 12:48 Zou Wei [this message] 2021-05-21 12:48 ` [dm-devel] [PATCH -next] dm btree: make symbol 'shadow_child' static Zou Wei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1621601336-11279-1-git-send-email-zou_wei@huawei.com \ --to=zou_wei@huawei.com \ --cc=agk@redhat.com \ --cc=dm-devel@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.