All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] dm btree: make symbol 'shadow_child' static
@ 2021-05-21 12:48 ` Zou Wei
  0 siblings, 0 replies; 2+ messages in thread
From: Zou Wei @ 2021-05-21 12:48 UTC (permalink / raw)
  To: agk, snitzer, dm-devel; +Cc: linux-kernel, Zou Wei

The sparse tool complains as follows:

drivers/md/persistent-data/dm-btree.c:696:5: warning:
 symbol 'shadow_child' was not declared. Should it be static?

This symbol is not used outside of dm-btree.c, so marks it static.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/md/persistent-data/dm-btree.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c
index b8d21b6..a29bcb8 100644
--- a/drivers/md/persistent-data/dm-btree.c
+++ b/drivers/md/persistent-data/dm-btree.c
@@ -693,8 +693,10 @@ static int split_one_into_two(struct shadow_spine *s, unsigned parent_index,
  * child of the given parent node.  Making sure to update the parent to point
  * to the new shadow.
  */
-int shadow_child(struct dm_btree_info *info, struct dm_btree_value_type *vt,
-		 struct btree_node *parent, unsigned index, struct dm_block **result)
+static int shadow_child(struct dm_btree_info *info,
+			struct dm_btree_value_type *vt,
+			struct btree_node *parent,
+			unsigned index, struct dm_block **result)
 {
 	int r, inc;
 	dm_block_t root;
-- 
2.6.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dm-devel] [PATCH -next] dm btree: make symbol 'shadow_child' static
@ 2021-05-21 12:48 ` Zou Wei
  0 siblings, 0 replies; 2+ messages in thread
From: Zou Wei @ 2021-05-21 12:48 UTC (permalink / raw)
  To: agk, snitzer, dm-devel; +Cc: Zou Wei, linux-kernel

The sparse tool complains as follows:

drivers/md/persistent-data/dm-btree.c:696:5: warning:
 symbol 'shadow_child' was not declared. Should it be static?

This symbol is not used outside of dm-btree.c, so marks it static.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/md/persistent-data/dm-btree.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c
index b8d21b6..a29bcb8 100644
--- a/drivers/md/persistent-data/dm-btree.c
+++ b/drivers/md/persistent-data/dm-btree.c
@@ -693,8 +693,10 @@ static int split_one_into_two(struct shadow_spine *s, unsigned parent_index,
  * child of the given parent node.  Making sure to update the parent to point
  * to the new shadow.
  */
-int shadow_child(struct dm_btree_info *info, struct dm_btree_value_type *vt,
-		 struct btree_node *parent, unsigned index, struct dm_block **result)
+static int shadow_child(struct dm_btree_info *info,
+			struct dm_btree_value_type *vt,
+			struct btree_node *parent,
+			unsigned index, struct dm_block **result)
 {
 	int r, inc;
 	dm_block_t root;
-- 
2.6.2

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-24  6:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 12:48 [PATCH -next] dm btree: make symbol 'shadow_child' static Zou Wei
2021-05-21 12:48 ` [dm-devel] " Zou Wei

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.