All of
 help / color / mirror / Atom feed
From: <>
Subject: patch "video: hgafb: correctly handle card detect failure during probe" added to char-misc-linus
Date: Fri, 21 May 2021 15:04:28 +0200	[thread overview]
Message-ID: <> (raw)

This is a note to let you know that I've just added the patch titled

    video: hgafb: correctly handle card detect failure during probe

to my char-misc git tree which can be found at
in the char-misc-linus branch.

The patch will show up in the next release of the linux-next tree
(usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the
next -rc kernel release.

If you have any questions about this process, please let me know.

From 02625c965239b71869326dd0461615f27307ecb3 Mon Sep 17 00:00:00 2001
From: Anirudh Rayabharam <>
Date: Mon, 17 May 2021 00:57:14 +0530
Subject: video: hgafb: correctly handle card detect failure during probe

The return value of hga_card_detect() is not properly handled causing
the probe to succeed even though hga_card_detect() failed. Since probe
succeeds, hgafb_open() can be called which will end up operating on an
unmapped hga_vram. This results in an out-of-bounds access as reported
by kernel test robot [1].

To fix this, correctly detect failure of hga_card_detect() by checking
for a non-zero error code.


Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
Cc: stable <>
Reported-by: kernel test robot <>
Reviewed-by: Igor Matheus Andrade Torrente <>
Signed-off-by: Anirudh Rayabharam <>
Signed-off-by: Dan Carpenter <>
Signed-off-by: Greg Kroah-Hartman <>
 drivers/video/fbdev/hgafb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
index cc8e62ae93f6..bd3d07aa4f0e 100644
--- a/drivers/video/fbdev/hgafb.c
+++ b/drivers/video/fbdev/hgafb.c
@@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
 	int ret;
 	ret = hga_card_detect();
-	if (!ret)
+	if (ret)
 		return ret;
 	printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",

                 reply	other threads:[~2021-05-21 13:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: patch "video: hgafb: correctly handle card detect failure during probe" added to char-misc-linus' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.