* [PATCH] scsi: aic7xxx: restore several defines for aix7xxx firmware build
@ 2021-05-17 13:24 trix
2021-05-22 4:40 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2021-05-17 13:24 UTC (permalink / raw)
To: hare, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
With CONFIG_AIC7XXX_BUILD_FIRMWARE, there is this
representative error
aicasm: Stopped at file ./drivers/scsi/aic7xxx/aic7xxx.seq,
line 271 - Undefined symbol MSG_SIMPLE_Q_TAG referenced
MSG_SIMPLE_Q_TAG used to be defined in
drivers/scsi/aic7xxx/scsi_message.h as
#define MSG_SIMPLE_Q_TAG 0x20 /* O/O */
The new definition in include/scsi/scsi.h is
#define SIMPLE_QUEUE_TAG 0x20
But aicasm can not handle the all the preprocessor directives
in scsi.h, so add MSG_SIMPLE_Q_TAB and similar back to
scsi_message.h
Fixes: d8cd784ff7b3 ("scsi: aic7xxx: aic79xx: Drop internal SCSI message definition"
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/scsi/aic7xxx/scsi_message.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/scsi/aic7xxx/scsi_message.h b/drivers/scsi/aic7xxx/scsi_message.h
index a7515c3039edb..53343a6d8ae19 100644
--- a/drivers/scsi/aic7xxx/scsi_message.h
+++ b/drivers/scsi/aic7xxx/scsi_message.h
@@ -3,6 +3,17 @@
* $FreeBSD: src/sys/cam/scsi/scsi_message.h,v 1.2 2000/05/01 20:21:29 peter Exp $
*/
+/* Messages (1 byte) */ /* I/T (M)andatory or (O)ptional */
+#define MSG_SAVEDATAPOINTER 0x02 /* O/O */
+#define MSG_RESTOREPOINTERS 0x03 /* O/O */
+#define MSG_DISCONNECT 0x04 /* O/O */
+#define MSG_MESSAGE_REJECT 0x07 /* M/M */
+#define MSG_NOOP 0x08 /* M/M */
+
+/* Messages (2 byte) */
+#define MSG_SIMPLE_Q_TAG 0x20 /* O/O */
+#define MSG_IGN_WIDE_RESIDUE 0x23 /* O/O */
+
/* Identify message */ /* M/M */
#define MSG_IDENTIFYFLAG 0x80
#define MSG_IDENTIFY_DISCFLAG 0x40
--
2.26.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: aic7xxx: restore several defines for aix7xxx firmware build
2021-05-17 13:24 [PATCH] scsi: aic7xxx: restore several defines for aix7xxx firmware build trix
@ 2021-05-22 4:40 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-05-22 4:40 UTC (permalink / raw)
To: hare, jejb, trix; +Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Mon, 17 May 2021 06:24:51 -0700, trix@redhat.com wrote:
> With CONFIG_AIC7XXX_BUILD_FIRMWARE, there is this
> representative error
>
> aicasm: Stopped at file ./drivers/scsi/aic7xxx/aic7xxx.seq,
> line 271 - Undefined symbol MSG_SIMPLE_Q_TAG referenced
>
> MSG_SIMPLE_Q_TAG used to be defined in
> drivers/scsi/aic7xxx/scsi_message.h as
> #define MSG_SIMPLE_Q_TAG 0x20 /* O/O */
>
> [...]
Applied to 5.13/scsi-fixes, thanks!
[1/1] scsi: aic7xxx: restore several defines for aix7xxx firmware build
https://git.kernel.org/mkp/scsi/c/7e7606330b16
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-22 4:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 13:24 [PATCH] scsi: aic7xxx: restore several defines for aix7xxx firmware build trix
2021-05-22 4:40 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.