From: Alexey Izbyshev <1887306@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Bug 1887306] Re: qemu-user deadlocks when forked in a multithreaded process
Date: Sun, 23 May 2021 09:39:06 -0000 [thread overview]
Message-ID: <162176274711.31619.12119080761983602615.malone@soybean.canonical.com> (raw)
In-Reply-To: 159458406053.7310.1285869489559583574.malonedeb@wampee.canonical.com
Still reproduces with QEMU 6.0.0.
** Changed in: qemu
Status: Incomplete => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1887306
Title:
qemu-user deadlocks when forked in a multithreaded process
Status in QEMU:
New
Bug description:
The following program (also attached) deadlocks when run under QEMU
user on Linux.
#include <pthread.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <unistd.h>
#define NUM_THREADS 100
#define NUM_FORKS 10
pthread_barrier_t barrier;
void *t(void *arg) {
for (int i = 0; i < NUM_FORKS; i++) {
pid_t pid = fork();
if (pid < 0)
abort();
if (!pid)
_exit(0);
if (waitpid(pid, NULL, 0) < 0)
abort();
}
//pthread_barrier_wait(&barrier);
return NULL;
}
int main(void) {
pthread_barrier_init(&barrier, NULL, NUM_THREADS);
pthread_t ts[NUM_THREADS];
for (size_t i = 0; i < NUM_THREADS; i++) {
if (pthread_create(&ts[i], NULL, t, NULL))
abort();
}
for (size_t i = 0; i < NUM_THREADS; i++) {
pthread_join(ts[i], NULL);
}
printf("Done: %d\n", getpid());
return 0;
}
To reproduce:
$ gcc test.c -pthread
$ while qemu-x86_64 ./a.out; do :; done
(Be careful, Ctrl-C/SIGINT doesn't kill the deadlocked child).
Larger values of NUM_THREADS/NUM_FORKS lead to more often deadlocks.
With the values above it often deadlocks on the first try on my
machine. When it deadlocks, there is a child qemu process with two
threads which is waited upon by one of the worker threads of the
parent.
I tried to avoid the deadlock by serializing fork() with a mutex, but
it didn't help. However, ensuring that no thread exits until all forks
are done (by adding a barrier to t()) does seem to help, at least, the
program above could run for a half an hour until I terminated it.
Tested on QEMU 5.0.0, 4.2.0 and 2.11.1, with x86_64 and AArch64 linux-
user targets.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1887306/+subscriptions
next prev parent reply other threads:[~2021-05-23 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 20:01 [Bug 1887306] [NEW] qemu-user deadlocks when forked in a multithreaded process Alexey Izbyshev
2021-05-07 4:41 ` [Bug 1887306] " Thomas Huth
2021-05-23 9:39 ` Alexey Izbyshev [this message]
2021-05-26 14:36 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162176274711.31619.12119080761983602615.malone@soybean.canonical.com \
--to=1887306@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.