From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB2B6C47084 for ; Mon, 24 May 2021 02:39:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA4D461151 for ; Mon, 24 May 2021 02:39:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232226AbhEXCk5 (ORCPT ); Sun, 23 May 2021 22:40:57 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:55835 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S231867AbhEXCkz (ORCPT ); Sun, 23 May 2021 22:40:55 -0400 X-UUID: 737b6e8ce1a34f3aa17a5d8a8ca6d708-20210524 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VHbcpkFfbs5kF0/zn1F4IWFknNucu5ih4bu3s4aofUc=; b=RJNUy4y0MAik8FXA1WU86JxWfuDnqNzOSAM9DnfavLIY6/a/2ytwQPo1BAyxz8A0IrdCLgFJQKMlizqQY5kA0M71b9N/6ZBEkMmxivaVJxAQhMnKguZWK8y4AYSkLiBATFQn0fKVreV2S1LZhuhmkr4Ls3KpxBPc5LAKdkn39yY=; X-UUID: 737b6e8ce1a34f3aa17a5d8a8ca6d708-20210524 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 179658104; Mon, 24 May 2021 10:39:23 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 24 May 2021 10:39:19 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 May 2021 10:39:18 +0800 Message-ID: <1621823958.25430.4.camel@mhfsdcap03> Subject: Re: [PATCH v4,6/6] media: mtk-vcodec: Support MT8192 H264 4K encoding From: Irui Wang To: Tzung-Bi Shih CC: Alexandre Courbot , Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Maoguang Meng , "Longfei Wang" , Yong Wu , "Yunfei Dong" , Fritz Koenig , Tzung-Bi Shih , , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , , "moderated list:ARM/Mediatek SoC support" , Date: Mon, 24 May 2021 10:39:18 +0800 In-Reply-To: References: <20210521070139.20644-1-irui.wang@mediatek.com> <20210521070139.20644-7-irui.wang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 49EE3BB53A0A8C67CE60DFA93A027160F4556136395BD1B7E64842F9AF2E067B2000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gRnJpLCAyMDIxLTA1LTIxIGF0IDE2OjA2ICswODAwLCBUenVuZy1CaSBTaGloIHdyb3RlOg0K PiBPbiBGcmksIE1heSAyMSwgMjAyMSBhdCAzOjAyIFBNIElydWkgV2FuZyA8aXJ1aS53YW5nQG1l ZGlhdGVrLmNvbT4gd3JvdGU6DQo+ID4gICAgICAgICBmc2l6ZS0+dHlwZSA9IFY0TDJfRlJNU0la RV9UWVBFX1NURVBXSVNFOw0KPiA+IC0gICAgICAgZnNpemUtPnN0ZXB3aXNlID0gbXRrX3ZlbmNf ZnJhbWVzaXplczsNCj4gPiArICAgICAgIGZzaXplLT5zdGVwd2lzZSA9DQo+ID4gKyAgICAgICAg ICAgICAgIChjdHgtPmRldi0+ZW5jX2NhcGFiaWxpdHkgJiBNVEtfVkVOQ180S19DQVBBQklMSVRZ X0VOQUJMRSkgPw0KPiA+ICsgICAgICAgICAgICAgICBtdGtfdmVuY180a19mcmFtZXNpemVzIDog bXRrX3ZlbmNfaGRfZnJhbWVzaXplczsNCj4gDQo+IFVzZSBhIG5vcm1hbCBpZiAuLiBlbHNlIC4u IGlzIG1vcmUgcmVhZGFibGUuDQppZiAoY3R4LT5kZXYtPmVuY19jYXBhYmlsaXR5ICYgTVRLX1ZF TkNfNEtfQ0FQQUJJTElUWV9FTkFCTEUpDQoJZnNpemUtPnN0ZXB3aXNlID0gbXRrX3ZlbmNfNGtf ZnJhbWVzaXplczsNCmVsc2UNCglmc2l6ZS0+c3RlcHdpc2UgPSBtdGtfdmVuY19oZF9mcmFtZXNp emVzOw0KDQo+IA0KPiA+IEBAIC0xMjEwLDYgKzEyMzEsOSBAQCBpbnQgbXRrX3Zjb2RlY19lbmNf Y3RybHNfc2V0dXAoc3RydWN0IG10a192Y29kZWNfY3R4ICpjdHgpDQo+ID4gIHsNCj4gPiAgICAg ICAgIGNvbnN0IHN0cnVjdCB2NGwyX2N0cmxfb3BzICpvcHMgPSAmbXRrX3Zjb2RlY19lbmNfY3Ry bF9vcHM7DQo+ID4gICAgICAgICBzdHJ1Y3QgdjRsMl9jdHJsX2hhbmRsZXIgKmhhbmRsZXIgPSAm Y3R4LT5jdHJsX2hkbDsNCj4gPiArICAgICAgIGNvbnN0IHU4IGgyNjRfbWF4X2xldmVsID0NCj4g PiArICAgICAgICAgICAgICAgKGN0eC0+ZGV2LT5lbmNfY2FwYWJpbGl0eSAmIE1US19WRU5DXzRL X0NBUEFCSUxJVFlfRU5BQkxFKSA/DQo+ID4gKyAgICAgICAgICAgICAgIFY0TDJfTVBFR19WSURF T19IMjY0X0xFVkVMXzVfMSA6IFY0TDJfTVBFR19WSURFT19IMjY0X0xFVkVMXzRfMjsNCj4gQWdh aW4sIEkgd291bGQgbGlrZSBpdCB0byBiZSBhIG5vcm1hbCBpZiAuLiBlbHNlIC4uDQp1OCBoMjY0 X21heF9sZXZlbDsNCmlmIChjdHgtPmRldi0+ZW5jX2NhcGFiaWxpdHkgJiBNVEtfVkVOQ180S19D QVBBQklMSVRZX0VOQUJMRSkNCgloMjY0X21heF9sZXZlbCA9IFY0TDJfTVBFR19WSURFT19IMjY0 X0xFVkVMXzVfMTsNCmVsc2UNCgloMjY0X21heF9sZXZlbCA9IFY0TDJfTVBFR19WSURFT19IMjY0 X0xFVkVMXzRfMjsNCg0KUGF0Y2ggVjUgd2lsbCBiZSBzZW50IHdpdGggdGhlc2UgaWYgdGhlcmUg aXMgbm8gbW9yZSBjb21tZW50cy4NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EDA8C04FF3 for ; Mon, 24 May 2021 17:36:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E40EF606A5 for ; Mon, 24 May 2021 17:36:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E40EF606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y2xyDtGV6XOldSlDogQT+M3fq4Jblqji5LdxZ70pdWY=; b=g+X+aaFhPOJ32M Tu/wIFceNPldNxXMXDbcLWYeaUfPR0YGSmUlTI9tpf8X1ZI5pESB/tU4PxybUWdvwmN+qn4DOpncd 6+K3vWQ0gI/haPDTUbC5Q4VoNcYaCLlKilO5hMAd0T3+LMk8/KKxIPRt4EVkLoRFRL/+fsrVcf5xc K7h+fHolAZiW1JdyCpxOfMQNsKZDcHvJKJZPISKfdtL65qA5OVEUxX+vnlziqhwSC8FrZx36Jb1uW gFfkAMdwbO4Zixp5HjYVVYU9qkRlPBZN+h1uvAeehMrhjbljBihwn0QRzLOw5q3flp6oyyCpPbTWT 7jSRTrutTTRt2xc5wJpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llEVB-001Ip0-F0; Mon, 24 May 2021 17:36:29 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ll0VC-000ed9-33; Mon, 24 May 2021 02:39:40 +0000 X-UUID: c1ebe0f253794f428d50e5d423a3ddaf-20210523 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VHbcpkFfbs5kF0/zn1F4IWFknNucu5ih4bu3s4aofUc=; b=Y3SU1WgOBcxi0zUU4e9qyUuylv/JHD0xv451KI2ND7/YYKc+/CKQRGHETWmUwvYfX0lAIed+qX+DieGMbnQq6W6ckGUkMPPoYUyJaGRPIEN3lSNFmLe0TANL6t90sJzOhRmeGsO+qV+IwAFJD6cVNDOPMmT42KtXZC2FFlnti0o=; X-UUID: c1ebe0f253794f428d50e5d423a3ddaf-20210523 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1133508461; Sun, 23 May 2021 19:39:25 -0700 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 23 May 2021 19:39:24 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 24 May 2021 10:39:19 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 May 2021 10:39:18 +0800 Message-ID: <1621823958.25430.4.camel@mhfsdcap03> Subject: Re: [PATCH v4,6/6] media: mtk-vcodec: Support MT8192 H264 4K encoding From: Irui Wang To: Tzung-Bi Shih CC: Alexandre Courbot , Hans Verkuil , Tiffany Lin , "Andrew-CT Chen" , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Maoguang Meng , "Longfei Wang" , Yong Wu , "Yunfei Dong" , Fritz Koenig , Tzung-Bi Shih , , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , , "moderated list:ARM/Mediatek SoC support" , Date: Mon, 24 May 2021 10:39:18 +0800 In-Reply-To: References: <20210521070139.20644-1-irui.wang@mediatek.com> <20210521070139.20644-7-irui.wang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 49EE3BB53A0A8C67CE60DFA93A027160F4556136395BD1B7E64842F9AF2E067B2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210523_193938_205459_26C07A39 X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2021-05-21 at 16:06 +0800, Tzung-Bi Shih wrote: > On Fri, May 21, 2021 at 3:02 PM Irui Wang wrote: > > fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE; > > - fsize->stepwise = mtk_venc_framesizes; > > + fsize->stepwise = > > + (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) ? > > + mtk_venc_4k_framesizes : mtk_venc_hd_framesizes; > > Use a normal if .. else .. is more readable. if (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) fsize->stepwise = mtk_venc_4k_framesizes; else fsize->stepwise = mtk_venc_hd_framesizes; > > > @@ -1210,6 +1231,9 @@ int mtk_vcodec_enc_ctrls_setup(struct mtk_vcodec_ctx *ctx) > > { > > const struct v4l2_ctrl_ops *ops = &mtk_vcodec_enc_ctrl_ops; > > struct v4l2_ctrl_handler *handler = &ctx->ctrl_hdl; > > + const u8 h264_max_level = > > + (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) ? > > + V4L2_MPEG_VIDEO_H264_LEVEL_5_1 : V4L2_MPEG_VIDEO_H264_LEVEL_4_2; > Again, I would like it to be a normal if .. else .. u8 h264_max_level; if (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) h264_max_level = V4L2_MPEG_VIDEO_H264_LEVEL_5_1; else h264_max_level = V4L2_MPEG_VIDEO_H264_LEVEL_4_2; Patch V5 will be sent with these if there is no more comments. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17AF9C04FF3 for ; Mon, 24 May 2021 17:39:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7DE0613EA for ; Mon, 24 May 2021 17:39:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7DE0613EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uhAYJmCPm4LWIYul9afirpt7R5db9fj4FpDndvTWuzs=; b=WYtIsXxexQB2Ey D3dJxQjTyC+O2fdmh33bkJr8qGvvdbaCOuH0EgurvRJQnBXosmuooDI4ocYX8+xzq5mAPAY9Zc4Vb WDU6L4vbj99vAe1QWyoqXiFW30O1FS/YlFQ8CG3sn3+f44ayC78viErovncEMFvZE1lF3+COO85pC mNvT7VzMunPVIh5qawrwdjlzVrhOcsZEFqN38MokgaNtlRQkpCxSWoiTX9oMpwuKx0zyzbMicFdPb 58B1LtJ3mJqsNigONgQF/eAUblAgVnNps+RGWMnq+jRAiFem+EJQ2VqJZ8TWzOMSvwKcdxThtgMUG WWHirjJ2mpQ1BFzIgHBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llEVK-001IpJ-QU; Mon, 24 May 2021 17:36:39 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ll0VC-000ed9-33; Mon, 24 May 2021 02:39:40 +0000 X-UUID: c1ebe0f253794f428d50e5d423a3ddaf-20210523 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=VHbcpkFfbs5kF0/zn1F4IWFknNucu5ih4bu3s4aofUc=; b=Y3SU1WgOBcxi0zUU4e9qyUuylv/JHD0xv451KI2ND7/YYKc+/CKQRGHETWmUwvYfX0lAIed+qX+DieGMbnQq6W6ckGUkMPPoYUyJaGRPIEN3lSNFmLe0TANL6t90sJzOhRmeGsO+qV+IwAFJD6cVNDOPMmT42KtXZC2FFlnti0o=; X-UUID: c1ebe0f253794f428d50e5d423a3ddaf-20210523 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1133508461; Sun, 23 May 2021 19:39:25 -0700 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 23 May 2021 19:39:24 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 24 May 2021 10:39:19 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 24 May 2021 10:39:18 +0800 Message-ID: <1621823958.25430.4.camel@mhfsdcap03> Subject: Re: [PATCH v4,6/6] media: mtk-vcodec: Support MT8192 H264 4K encoding From: Irui Wang To: Tzung-Bi Shih CC: Alexandre Courbot , Hans Verkuil , Tiffany Lin , "Andrew-CT Chen" , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Maoguang Meng , "Longfei Wang" , Yong Wu , "Yunfei Dong" , Fritz Koenig , Tzung-Bi Shih , , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , , "moderated list:ARM/Mediatek SoC support" , Date: Mon, 24 May 2021 10:39:18 +0800 In-Reply-To: References: <20210521070139.20644-1-irui.wang@mediatek.com> <20210521070139.20644-7-irui.wang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 49EE3BB53A0A8C67CE60DFA93A027160F4556136395BD1B7E64842F9AF2E067B2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210523_193938_205459_26C07A39 X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-05-21 at 16:06 +0800, Tzung-Bi Shih wrote: > On Fri, May 21, 2021 at 3:02 PM Irui Wang wrote: > > fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE; > > - fsize->stepwise = mtk_venc_framesizes; > > + fsize->stepwise = > > + (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) ? > > + mtk_venc_4k_framesizes : mtk_venc_hd_framesizes; > > Use a normal if .. else .. is more readable. if (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) fsize->stepwise = mtk_venc_4k_framesizes; else fsize->stepwise = mtk_venc_hd_framesizes; > > > @@ -1210,6 +1231,9 @@ int mtk_vcodec_enc_ctrls_setup(struct mtk_vcodec_ctx *ctx) > > { > > const struct v4l2_ctrl_ops *ops = &mtk_vcodec_enc_ctrl_ops; > > struct v4l2_ctrl_handler *handler = &ctx->ctrl_hdl; > > + const u8 h264_max_level = > > + (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) ? > > + V4L2_MPEG_VIDEO_H264_LEVEL_5_1 : V4L2_MPEG_VIDEO_H264_LEVEL_4_2; > Again, I would like it to be a normal if .. else .. u8 h264_max_level; if (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) h264_max_level = V4L2_MPEG_VIDEO_H264_LEVEL_5_1; else h264_max_level = V4L2_MPEG_VIDEO_H264_LEVEL_4_2; Patch V5 will be sent with these if there is no more comments. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel