All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] phy: ti: Fix an error code in wiz_probe()
@ 2021-05-25 10:50 ` Yang Li
  0 siblings, 0 replies; 4+ messages in thread
From: Yang Li @ 2021-05-25 10:50 UTC (permalink / raw)
  To: kishon; +Cc: vkoul, linux-phy, linux-kernel, Yang Li

When the code execute this if statement, the value of ret is 0. 
However, we can see from the dev_err() log that the value of 
ret should be -EINVAL.

Clean up smatch warning:

drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code
'ret'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage
typec-gpio-dir")'
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/phy/ti/phy-j721e-wiz.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index 9eb6d37..126f5b8 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev)
 
 		if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN ||
 		    wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) {
+			ret = -EINVAL;
 			dev_err(dev, "Invalid typec-dir-debounce property\n");
 			goto err_addr_to_resource;
 		}
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] phy: ti: Fix an error code in wiz_probe()
@ 2021-05-25 10:50 ` Yang Li
  0 siblings, 0 replies; 4+ messages in thread
From: Yang Li @ 2021-05-25 10:50 UTC (permalink / raw)
  To: kishon; +Cc: vkoul, linux-phy, linux-kernel, Yang Li

When the code execute this if statement, the value of ret is 0. 
However, we can see from the dev_err() log that the value of 
ret should be -EINVAL.

Clean up smatch warning:

drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code
'ret'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage
typec-gpio-dir")'
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/phy/ti/phy-j721e-wiz.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index 9eb6d37..126f5b8 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev)
 
 		if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN ||
 		    wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) {
+			ret = -EINVAL;
 			dev_err(dev, "Invalid typec-dir-debounce property\n");
 			goto err_addr_to_resource;
 		}
-- 
1.8.3.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] phy: ti: Fix an error code in wiz_probe()
  2021-05-25 10:50 ` Yang Li
@ 2021-05-31  8:39   ` Vinod Koul
  -1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-05-31  8:39 UTC (permalink / raw)
  To: Yang Li; +Cc: kishon, linux-phy, linux-kernel

On 25-05-21, 18:50, Yang Li wrote:
> When the code execute this if statement, the value of ret is 0. 
> However, we can see from the dev_err() log that the value of 
> ret should be -EINVAL.
> 
> Clean up smatch warning:
> 
> drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code
> 'ret'

Single line is fine for this

> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage
> typec-gpio-dir")'

Please dont split to two lines for fixes tag

> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

I have fixed while applying so Applied, thanks

> ---
>  drivers/phy/ti/phy-j721e-wiz.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
> index 9eb6d37..126f5b8 100644
> --- a/drivers/phy/ti/phy-j721e-wiz.c
> +++ b/drivers/phy/ti/phy-j721e-wiz.c
> @@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev)
>  
>  		if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN ||
>  		    wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) {
> +			ret = -EINVAL;
>  			dev_err(dev, "Invalid typec-dir-debounce property\n");
>  			goto err_addr_to_resource;
>  		}
> -- 
> 1.8.3.1

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] phy: ti: Fix an error code in wiz_probe()
@ 2021-05-31  8:39   ` Vinod Koul
  0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-05-31  8:39 UTC (permalink / raw)
  To: Yang Li; +Cc: kishon, linux-phy, linux-kernel

On 25-05-21, 18:50, Yang Li wrote:
> When the code execute this if statement, the value of ret is 0. 
> However, we can see from the dev_err() log that the value of 
> ret should be -EINVAL.
> 
> Clean up smatch warning:
> 
> drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code
> 'ret'

Single line is fine for this

> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage
> typec-gpio-dir")'

Please dont split to two lines for fixes tag

> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

I have fixed while applying so Applied, thanks

> ---
>  drivers/phy/ti/phy-j721e-wiz.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
> index 9eb6d37..126f5b8 100644
> --- a/drivers/phy/ti/phy-j721e-wiz.c
> +++ b/drivers/phy/ti/phy-j721e-wiz.c
> @@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev)
>  
>  		if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN ||
>  		    wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) {
> +			ret = -EINVAL;
>  			dev_err(dev, "Invalid typec-dir-debounce property\n");
>  			goto err_addr_to_resource;
>  		}
> -- 
> 1.8.3.1

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-31  8:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 10:50 [PATCH] phy: ti: Fix an error code in wiz_probe() Yang Li
2021-05-25 10:50 ` Yang Li
2021-05-31  8:39 ` Vinod Koul
2021-05-31  8:39   ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.