* [PATCH] x86/syscalls: clear 'offset' and 'prefix' in case they are set in env
@ 2021-05-25 11:54 Masahiro Yamada
2021-05-25 15:00 ` [tip: x86/entry] x86/syscalls: Clear " tip-bot2 for Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2021-05-25 11:54 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86
Cc: Naresh Kamboju, linux-kernel, Masahiro Yamada, Andy Lutomirski,
Geert Uytterhoeven, H. Peter Anvin
If the environment variable 'prefix' is set on the build host,
it is wrongly used as syscall macro prefixes.
$ export prefix=/usr
$ make -s defconfig all
In file included from ./arch/x86/include/asm/unistd.h:20,
from <stdin>:2:
./arch/x86/include/generated/uapi/asm/unistd_64.h:4:9: warning: missing whitespace after the macro name
4 | #define __NR_/usrread 0
| ^~~~~
arch/x86/entry/syscalls/Makefile should clear 'offset' and 'prefix'.
Link: https://lore.kernel.org/lkml/CA+G9fYvFXTHPKwasdVidF7qEHdqwRht8Xg6qm6CCLL0HGaU1ew@mail.gmail.com/
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Fixes: 3cba325b358f ("x86/syscalls: Switch to generic syscallhdr.sh")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/x86/entry/syscalls/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/entry/syscalls/Makefile b/arch/x86/entry/syscalls/Makefile
index 8eb014bca8c9..5b3efed0e4e8 100644
--- a/arch/x86/entry/syscalls/Makefile
+++ b/arch/x86/entry/syscalls/Makefile
@@ -11,6 +11,8 @@ syscall64 := $(src)/syscall_64.tbl
syshdr := $(srctree)/scripts/syscallhdr.sh
systbl := $(srctree)/scripts/syscalltbl.sh
+offset :=
+prefix :=
quiet_cmd_syshdr = SYSHDR $@
cmd_syshdr = $(CONFIG_SHELL) $(syshdr) --abis $(abis) --emit-nr \
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: x86/entry] x86/syscalls: Clear 'offset' and 'prefix' in case they are set in env
2021-05-25 11:54 [PATCH] x86/syscalls: clear 'offset' and 'prefix' in case they are set in env Masahiro Yamada
@ 2021-05-25 15:00 ` tip-bot2 for Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Masahiro Yamada @ 2021-05-25 15:00 UTC (permalink / raw)
To: linux-tip-commits
Cc: Naresh Kamboju, Masahiro Yamada, Thomas Gleixner, x86, linux-kernel
The following commit has been merged into the x86/entry branch of tip:
Commit-ID: 1eb8a49836949a77c4f7d738786719e7fde0c333
Gitweb: https://git.kernel.org/tip/1eb8a49836949a77c4f7d738786719e7fde0c333
Author: Masahiro Yamada <masahiroy@kernel.org>
AuthorDate: Tue, 25 May 2021 20:54:20 +09:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 25 May 2021 16:59:23 +02:00
x86/syscalls: Clear 'offset' and 'prefix' in case they are set in env
If the environment variable 'prefix' is set on the build host, it is
wrongly used as syscall macro prefixes.
$ export prefix=/usr
$ make -s defconfig all
In file included from ./arch/x86/include/asm/unistd.h:20,
from <stdin>:2:
./arch/x86/include/generated/uapi/asm/unistd_64.h:4:9: warning: missing whitespace after the macro name
4 | #define __NR_/usrread 0
| ^~~~~
arch/x86/entry/syscalls/Makefile should clear 'offset' and 'prefix'.
Fixes: 3cba325b358f ("x86/syscalls: Switch to generic syscallhdr.sh")
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210525115420.679416-1-masahiroy@kernel.org
---
arch/x86/entry/syscalls/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/entry/syscalls/Makefile b/arch/x86/entry/syscalls/Makefile
index 8eb014b..5b3efed 100644
--- a/arch/x86/entry/syscalls/Makefile
+++ b/arch/x86/entry/syscalls/Makefile
@@ -11,6 +11,8 @@ syscall64 := $(src)/syscall_64.tbl
syshdr := $(srctree)/scripts/syscallhdr.sh
systbl := $(srctree)/scripts/syscalltbl.sh
+offset :=
+prefix :=
quiet_cmd_syshdr = SYSHDR $@
cmd_syshdr = $(CONFIG_SHELL) $(syshdr) --abis $(abis) --emit-nr \
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-25 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 11:54 [PATCH] x86/syscalls: clear 'offset' and 'prefix' in case they are set in env Masahiro Yamada
2021-05-25 15:00 ` [tip: x86/entry] x86/syscalls: Clear " tip-bot2 for Masahiro Yamada
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.