All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev()
@ 2021-05-11  6:42 ` Zou Wei
  0 siblings, 0 replies; 4+ messages in thread
From: Zou Wei @ 2021-05-11  6:42 UTC (permalink / raw)
  To: will, mark.rutland; +Cc: linux-arm-kernel, linux-kernel, Zou Wei

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/perf/thunderx2_pmu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/perf/thunderx2_pmu.c b/drivers/perf/thunderx2_pmu.c
index 06a6d56..9e8f55a 100644
--- a/drivers/perf/thunderx2_pmu.c
+++ b/drivers/perf/thunderx2_pmu.c
@@ -818,7 +818,6 @@ static struct tx2_uncore_pmu *tx2_uncore_pmu_init_dev(struct device *dev,
 
 	base = devm_ioremap_resource(dev, &res);
 	if (IS_ERR(base)) {
-		dev_err(dev, "PMU type %d: Fail to map resource\n", type);
 		return NULL;
 	}
 
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH -next] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev()
@ 2021-05-11  6:42 ` Zou Wei
  0 siblings, 0 replies; 4+ messages in thread
From: Zou Wei @ 2021-05-11  6:42 UTC (permalink / raw)
  To: will, mark.rutland; +Cc: linux-arm-kernel, linux-kernel, Zou Wei

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/perf/thunderx2_pmu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/perf/thunderx2_pmu.c b/drivers/perf/thunderx2_pmu.c
index 06a6d56..9e8f55a 100644
--- a/drivers/perf/thunderx2_pmu.c
+++ b/drivers/perf/thunderx2_pmu.c
@@ -818,7 +818,6 @@ static struct tx2_uncore_pmu *tx2_uncore_pmu_init_dev(struct device *dev,
 
 	base = devm_ioremap_resource(dev, &res);
 	if (IS_ERR(base)) {
-		dev_err(dev, "PMU type %d: Fail to map resource\n", type);
 		return NULL;
 	}
 
-- 
2.6.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev()
  2021-05-11  6:42 ` Zou Wei
@ 2021-05-25 18:58   ` Will Deacon
  -1 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2021-05-25 18:58 UTC (permalink / raw)
  To: Zou Wei, mark.rutland
  Cc: catalin.marinas, kernel-team, Will Deacon, linux-kernel,
	linux-arm-kernel

On Tue, 11 May 2021 14:42:44 +0800, Zou Wei wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied to will (for-next/perf), thanks!

[1/1] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev()
      https://git.kernel.org/will/c/bf2367aaed73

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev()
@ 2021-05-25 18:58   ` Will Deacon
  0 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2021-05-25 18:58 UTC (permalink / raw)
  To: Zou Wei, mark.rutland
  Cc: catalin.marinas, kernel-team, Will Deacon, linux-kernel,
	linux-arm-kernel

On Tue, 11 May 2021 14:42:44 +0800, Zou Wei wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied to will (for-next/perf), thanks!

[1/1] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev()
      https://git.kernel.org/will/c/bf2367aaed73

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-25 19:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11  6:42 [PATCH -next] drivers/perf: Remove redundant dev_err call in tx2_uncore_pmu_init_dev() Zou Wei
2021-05-11  6:42 ` Zou Wei
2021-05-25 18:58 ` Will Deacon
2021-05-25 18:58   ` Will Deacon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.