From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Matthew Brost" <matthew.brost@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Non-interface changing GuC CTBs updates (rev2)
Date: Wed, 26 May 2021 06:42:04 -0000 [thread overview]
Message-ID: <162201132483.13404.1421856447925207863@emeril.freedesktop.org> (raw)
In-Reply-To: <20210526064237.77853-1-matthew.brost@intel.com>
== Series Details ==
Series: Non-interface changing GuC CTBs updates (rev2)
URL : https://patchwork.freedesktop.org/series/90552/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
6b6bffd59ced drm/i915/guc: skip disabling CTBs before sanitizing the GuC
3f9bbaddbf9d drm/i915/guc: use probe_error log for CT enablement failure
866285dad8d0 drm/i915/guc: enable only the user interrupt when using GuC submission
eafc57f85f6f drm/i915/guc: Remove sample_forcewake h2g action
cb62a7f50e3b drm/i915/guc: Keep strict GuC ABI definitions
-:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 476 lines checked
28e9b20a7873 drm/i915/guc: Drop guc->interrupts.enabled
190975af8c9f drm/i915/guc: Stop using fence/status from CTB descriptor
15a068ac5b1e drm/i915: Promote ptrdiff() to i915_utils.h
e3a6d58106c2 drm/i915/guc: Only rely on own CTB size
aaa8781a008e drm/i915/guc: Don't repeat CTB layout calculations
b065023c038e drm/i915/guc: Replace CTB array with explicit members
9f1ec21626ae drm/i915/guc: Update sizes of CTB buffers
7a0e05be601b drm/i915/guc: Relax CTB response timeout
11573d2c3987 drm/i915/guc: Start protecting access to CTB descriptors
-:87: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#87: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h:36:
+ spinlock_t lock;
total: 0 errors, 0 warnings, 1 checks, 61 lines checked
f32e4faa422e drm/i915/guc: Ensure H2G buffer updates visible before tail update
-:23: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#23: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:331:
+static void write_barrier(struct intel_guc_ct *ct) {
-:31: WARNING:MEMORY_BARRIER: memory barrier without comment
#31: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:339:
+ wmb();
total: 1 errors, 1 warnings, 0 checks, 30 lines checked
6feab437948e drm/i915/guc: Stop using mutex while sending CTB messages
a44bbeef3e75 drm/i915/guc: Don't receive all G2H messages in irq handler
41650b9fd9e5 drm/i915/guc: Always copy CT message to new allocation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-05-26 6:42 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 6:42 [PATCH 00/18] Non-interface changing GuC CTBs updates Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` Patchwork [this message]
2021-05-27 17:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Non-interface changing GuC CTBs updates (rev2) John Harrison
2021-05-27 17:09 ` Matthew Brost
2021-05-26 6:42 ` [PATCH 01/18] drm/i915/guc: skip disabling CTBs before sanitizing the GuC Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 02/18] drm/i915/guc: use probe_error log for CT enablement failure Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 03/18] drm/i915/guc: enable only the user interrupt when using GuC submission Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 04/18] drm/i915/guc: Remove sample_forcewake h2g action Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 05/18] drm/i915/guc: Keep strict GuC ABI definitions Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 06/18] drm/i915/guc: Drop guc->interrupts.enabled Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-27 17:17 ` John Harrison
2021-05-27 17:17 ` John Harrison
2021-05-27 17:13 ` Matthew Brost
2021-05-27 17:13 ` Matthew Brost
2021-05-26 6:42 ` [PATCH 07/18] drm/i915/guc: Stop using fence/status from CTB descriptor Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 08/18] drm/i915: Promote ptrdiff() to i915_utils.h Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 09/18] drm/i915/guc: Only rely on own CTB size Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 10/18] drm/i915/guc: Don't repeat CTB layout calculations Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 11/18] drm/i915/guc: Replace CTB array with explicit members Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 12/18] drm/i915/guc: Update sizes of CTB buffers Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 13/18] drm/i915/guc: Relax CTB response timeout Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 12:25 ` Michal Wajdeczko
2021-05-26 12:25 ` [Intel-gfx] " Michal Wajdeczko
2021-05-26 17:38 ` Matthew Brost
2021-05-26 17:38 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 14/18] drm/i915/guc: Start protecting access to CTB descriptors Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 15/18] drm/i915/guc: Ensure H2G buffer updates visible before tail update Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 12:36 ` Michal Wajdeczko
2021-05-26 12:36 ` [Intel-gfx] " Michal Wajdeczko
2021-05-26 17:58 ` Matthew Brost
2021-05-26 17:58 ` [Intel-gfx] " Matthew Brost
2021-05-28 1:13 ` John Harrison
2021-05-28 1:13 ` John Harrison
2021-05-28 6:52 ` Michal Wajdeczko
2021-05-28 6:52 ` Michal Wajdeczko
2021-05-26 6:42 ` [PATCH 16/18] drm/i915/guc: Stop using mutex while sending CTB messages Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 17/18] drm/i915/guc: Don't receive all G2H messages in irq handler Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:42 ` [PATCH 18/18] drm/i915/guc: Always copy CT message to new allocation Matthew Brost
2021-05-26 6:42 ` [Intel-gfx] " Matthew Brost
2021-05-26 6:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Non-interface changing GuC CTBs updates (rev2) Patchwork
2021-05-27 17:13 ` John Harrison
2021-05-27 17:08 ` Matthew Brost
2021-05-26 7:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-05-26 9:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162201132483.13404.1421856447925207863@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.