[PATCH v2] staging: rtl8723bs: remove the repeated declaration

[PATCH v2] staging: rtl8723bs: remove the repeated declaration

[Shaokun Zhang]

Function 'rtw_indicate_wx_disassoc_event' and 'Hal_SetBandwidth' are
declared twice in their header file, so remove the repeated declaration.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
 drivers/staging/rtl8723bs/include/drv_types.h | 1 -
 drivers/staging/rtl8723bs/include/rtw_mp.h    | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
index 83d43e5726dd..49b404e5cfaf 100644
--- a/drivers/staging/rtl8723bs/include/drv_types.h
+++ b/drivers/staging/rtl8723bs/include/drv_types.h
@@ -503,7 +503,6 @@ static inline u8 *myid(struct eeprom_priv *peepriv)
 
 void rtw_indicate_wx_disassoc_event(struct adapter *padapter);
 void rtw_indicate_wx_assoc_event(struct adapter *padapter);
-void rtw_indicate_wx_disassoc_event(struct adapter *padapter);
 void indicate_wx_scan_complete_event(struct adapter *padapter);
 int rtw_change_ifname(struct adapter *padapter, const char *ifname);
 
diff --git a/drivers/staging/rtl8723bs/include/rtw_mp.h b/drivers/staging/rtl8723bs/include/rtw_mp.h
index 2788ad80b114..ea3abee325ef 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mp.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mp.h
@@ -348,7 +348,6 @@ void Hal_SetCarrierSuppressionTx(struct adapter *padapter, u8 bStart);
 void Hal_SetSingleToneTx(struct adapter *padapter, u8 bStart);
 void Hal_SetSingleCarrierTx(struct adapter *padapter, u8 bStart);
 void Hal_SetContinuousTx(struct adapter *padapter, u8 bStart);
-void Hal_SetBandwidth(struct adapter *padapter);
 
 void Hal_SetDataRate(struct adapter *padapter);
 void Hal_SetChannel(struct adapter *padapter);
-- 
2.7.4

Re: [PATCH v2] staging: rtl8723bs: remove the repeated declaration

[Greg Kroah-Hartman]

On Wed, May 26, 2021 at 04:43:59PM +0800, Shaokun Zhang wrote:
> Function 'rtw_indicate_wx_disassoc_event' and 'Hal_SetBandwidth' are
> declared twice in their header file, so remove the repeated declaration.
> 
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>  drivers/staging/rtl8723bs/include/drv_types.h | 1 -
>  drivers/staging/rtl8723bs/include/rtw_mp.h    | 1 -
>  2 files changed, 2 deletions(-)

What changed from v1?  Always list that below the --- line please.

v3?

Re: [PATCH v2] staging: rtl8723bs: remove the repeated declaration

[Shaokun Zhang]

Hi Greg,

On 2021/5/26 17:26, Greg Kroah-Hartman wrote:
> On Wed, May 26, 2021 at 04:43:59PM +0800, Shaokun Zhang wrote:
>> Function 'rtw_indicate_wx_disassoc_event' and 'Hal_SetBandwidth' are
>> declared twice in their header file, so remove the repeated declaration.
>>
>> Cc: Dan Carpenter <dan.carpenter@oracle.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>> ---
>>  drivers/staging/rtl8723bs/include/drv_types.h | 1 -
>>  drivers/staging/rtl8723bs/include/rtw_mp.h    | 1 -
>>  2 files changed, 2 deletions(-)
> 
> What changed from v1?  Always list that below the --- line please.
> 

Sorry, I lost this.

> v3?

Ok,

Thanks,
Shaokun

> .
>