From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEAF5C47089 for ; Fri, 28 May 2021 02:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB05F60C3F for ; Fri, 28 May 2021 02:07:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236014AbhE1CJJ (ORCPT ); Thu, 27 May 2021 22:09:09 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:52537 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S234834AbhE1CJC (ORCPT ); Thu, 27 May 2021 22:09:02 -0400 X-UUID: 1e1e6fe96a7841ecac571174419ff9d4-20210528 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jjcO25Xagr83g07sXePMtvR2r8MtrL12TZBb3C93zGY=; b=B3tcxpA1v2hlE4+qT6NFz2DLJ00VP+u3C4/Kh/X7kuDspF40ivxkUy9Ty+5aJZpHRptQcA10mOfdcgg6rFvyPEgZW0RFbPGYhstWhDEw42cDwECNIyrrF+yjwGEFTUw9vlxO1w1duMgEVcnNwe8UTGupoHxPVEBarq3GK8xVzyA=; X-UUID: 1e1e6fe96a7841ecac571174419ff9d4-20210528 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 996442827; Fri, 28 May 2021 10:07:26 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 28 May 2021 10:07:19 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 28 May 2021 10:07:19 +0800 Message-ID: <1622167640.5918.4.camel@mhfsdcap03> Subject: Re: [PATCH 2/3] usb: common: add helper to get role-switch-default-mode From: Chunfeng Yun To: Greg Kroah-Hartman CC: Felipe Balbi , Matthias Brugger , Thinh Nguyen , , , , Date: Fri, 28 May 2021 10:07:20 +0800 In-Reply-To: References: <1621933165-9661-1-git-send-email-chunfeng.yun@mediatek.com> <1621933165-9661-2-git-send-email-chunfeng.yun@mediatek.com> <1622108619.5918.3.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 46C5A099E0518FE1F381C0C8780DF59102CDFEFB71DFB8CB090EC1557BF546D42000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVGh1LCAyMDIxLTA1LTI3IGF0IDEyOjAxICswMjAwLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3Jv dGU6DQo+IE9uIFRodSwgTWF5IDI3LCAyMDIxIGF0IDA1OjQzOjM5UE0gKzA4MDAsIENodW5mZW5n IFl1biB3cm90ZToNCj4gPiBPbiBUaHUsIDIwMjEtMDUtMjcgYXQgMDk6MjggKzAyMDAsIEdyZWcg S3JvYWgtSGFydG1hbiB3cm90ZToNCj4gPiA+IE9uIFR1ZSwgTWF5IDI1LCAyMDIxIGF0IDA0OjU5 OjI0UE0gKzA4MDAsIENodW5mZW5nIFl1biB3cm90ZToNCj4gPiA+ID4gQWRkIGhlbHBlciB0byBn ZXQgInJvbGUtc3dpdGNoLWRlZmF1bHQtbW9kZSIsIGFuZCBjb252ZXJ0IGl0DQo+ID4gPiA+IHRv IHRoZSBjb3JyZXNwb25kaW5nIGVudW0gdXNiX2RyX21vZGUNCj4gPiA+ID4gDQo+ID4gPiA+IFNp Z25lZC1vZmYtYnk6IENodW5mZW5nIFl1biA8Y2h1bmZlbmcueXVuQG1lZGlhdGVrLmNvbT4NCj4g PiA+ID4gLS0tDQo+ID4gPiA+ICBkcml2ZXJzL3VzYi9jb21tb24vY29tbW9uLmMgfCAyMCArKysr KysrKysrKysrKysrKysrKw0KPiA+ID4gPiAgaW5jbHVkZS9saW51eC91c2Ivb3RnLmggICAgIHwg IDEgKw0KPiA+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspDQo+ID4gPiA+ IA0KPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvY29tbW9uL2NvbW1vbi5jIGIvZHJp dmVycy91c2IvY29tbW9uL2NvbW1vbi5jDQo+ID4gPiA+IGluZGV4IGZmZjMxODU5NzMzNy4uNzhh NjI1YTRlNTI2IDEwMDY0NA0KPiA+ID4gPiAtLS0gYS9kcml2ZXJzL3VzYi9jb21tb24vY29tbW9u LmMNCj4gPiA+ID4gKysrIGIvZHJpdmVycy91c2IvY29tbW9uL2NvbW1vbi5jDQo+ID4gPiA+IEBA IC0yMDcsNiArMjA3LDI2IEBAIGVudW0gdXNiX2RyX21vZGUgdXNiX2dldF9kcl9tb2RlKHN0cnVj dCBkZXZpY2UgKmRldikNCj4gPiA+ID4gIH0NCj4gPiA+ID4gIEVYUE9SVF9TWU1CT0xfR1BMKHVz Yl9nZXRfZHJfbW9kZSk7DQo+ID4gPiA+ICANCj4gPiA+ID4gKy8qKg0KPiA+ID4gPiArICogdXNi X2dldF9yb2xlX3N3aXRjaF9kZWZhdWx0X21vZGUgLSBHZXQgZGVmYXVsdCBtb2RlIGZvciBnaXZl biBkZXZpY2UNCj4gPiA+ID4gKyAqIEBkZXY6IFBvaW50ZXIgdG8gdGhlIGdpdmVuIGRldmljZQ0K PiA+ID4gPiArICoNCj4gPiA+ID4gKyAqIFRoZSBmdW5jdGlvbiBnZXRzIHN0cmluZyBmcm9tIHBy b3BlcnR5ICdyb2xlLXN3aXRjaC1kZWZhdWx0LW1vZGUnLA0KPiA+ID4gPiArICogYW5kIHJldHVy bnMgdGhlIGNvcnJlc3BvbmRpbmcgZW51bSB1c2JfZHJfbW9kZS4NCj4gPiA+ID4gKyAqLw0KPiA+ ID4gPiArZW51bSB1c2JfZHJfbW9kZSB1c2JfZ2V0X3JvbGVfc3dpdGNoX2RlZmF1bHRfbW9kZShz dHJ1Y3QgZGV2aWNlICpkZXYpDQo+ID4gPiA+ICt7DQo+ID4gPiA+ICsJY29uc3QgY2hhciAqc3Ry Ow0KPiA+ID4gPiArCWludCByZXQ7DQo+ID4gPiA+ICsNCj4gPiA+ID4gKwlyZXQgPSBkZXZpY2Vf cHJvcGVydHlfcmVhZF9zdHJpbmcoZGV2LCAicm9sZS1zd2l0Y2gtZGVmYXVsdC1tb2RlIiwgJnN0 cik7DQo+ID4gPiA+ICsJaWYgKHJldCA8IDApDQo+ID4gPiA+ICsJCXJldHVybiBVU0JfRFJfTU9E RV9VTktOT1dOOw0KPiA+ID4gPiArDQo+ID4gPiA+ICsJcmV0dXJuIHVzYl9nZXRfZHJfbW9kZV9m cm9tX3N0cmluZyhzdHIpOw0KPiA+ID4gPiArfQ0KPiA+ID4gPiArRVhQT1JUX1NZTUJPTF9HUEwo dXNiX2dldF9yb2xlX3N3aXRjaF9kZWZhdWx0X21vZGUpOw0KPiA+ID4gPiArDQo+ID4gPiA+ICAv KioNCj4gPiA+ID4gICAqIHVzYl9kZWNvZGVfaW50ZXJ2YWwgLSBEZWNvZGUgYkludGVydmFsIGlu dG8gdGhlIHRpbWUgZXhwcmVzc2VkIGluIDF1cyB1bml0DQo+ID4gPiA+ICAgKiBAZXBkOiBUaGUg ZGVzY3JpcHRvciBvZiB0aGUgZW5kcG9pbnQNCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv bGludXgvdXNiL290Zy5oIGIvaW5jbHVkZS9saW51eC91c2Ivb3RnLmgNCj4gPiA+ID4gaW5kZXgg YTg2ZWU2YWFkNTFiLi5iZGUzMTNjOTdmYjYgMTAwNjQ0DQo+ID4gPiA+IC0tLSBhL2luY2x1ZGUv bGludXgvdXNiL290Zy5oDQo+ID4gPiA+ICsrKyBiL2luY2x1ZGUvbGludXgvdXNiL290Zy5oDQo+ ID4gPiA+IEBAIC0xMjEsNSArMTIxLDYgQEAgZW51bSB1c2JfZHJfbW9kZSB7DQo+ID4gPiA+ICB9 Ow0KPiA+ID4gPiAgDQo+ID4gPiA+ICBleHRlcm4gZW51bSB1c2JfZHJfbW9kZSB1c2JfZ2V0X2Ry X21vZGUoc3RydWN0IGRldmljZSAqZGV2KTsNCj4gPiA+ID4gK2V4dGVybiBlbnVtIHVzYl9kcl9t b2RlIHVzYl9nZXRfcm9sZV9zd2l0Y2hfZGVmYXVsdF9tb2RlKHN0cnVjdCBkZXZpY2UgKmRldik7 DQo+ID4gPiANCj4gPiA+IFdoYXQgb3RoZXIgY29kZSBvdXRzaWRlIG9mIHRoZSBkd2MzIGRyaXZl ciB3aWxsIGV2ZXIgbmVlZCB0byBjYWxsIHRoaXM/DQo+ID4gSSBwcmVwYXJlIGEgc2VyaWVzIG9m IHBhdGhlcyBmb3IgbXR1MywgYW5kIHdpbGwgc3VwcG9ydA0KPiA+ICJyb2xlLXN3aXRjaC1kZWZh dWx0LW1vZGUiIHByb3BlcnR5DQo+IA0KPiBPaywgaG93IGFib3V0IHdlIHdhaXQgdW50aWwgYXQg bGVhc3QgMiBkcml2ZXJzIG5lZWQgaXQgYmVmb3JlIGFjY2VwdGluZw0KPiB0aGlzIGNoYW5nZS4N Ck1ha2VzIHNlbnNlLCB0aGFuayB5b3UNCj4gDQo+IHRoYW5rcywNCj4gDQo+IGdyZWcgay1oDQoN Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC5AC4707F for ; Fri, 28 May 2021 02:07:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F37260C3F for ; Fri, 28 May 2021 02:07:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F37260C3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N8kkwwE3VZHokbVVswYWGzUOGnKTR6MQ4GQgOP5M1+I=; b=qlVKMFQV+bQ5/Z ESuX5TKEL/5r75H2iSr263vypZoS8qqXIRhwSHviml8/nhnepPRq7HzEvWn9XbD+M/0T2eECk3+Lh O8IVJOokG48tYnqcnxofORqhxxhgXN5SdU8E894XqojgZ8lDgD4n893UvAYRjRGXD2FM3qviO7lNs Zba61H4oW266kYTNVlFT2hOqpdqglW/vCpAl02X1lVdFMn/ZZcTppiXm2M7hGG13Kev1PVBQjPAmC +QaWZn7fCju4wu5ELPzIV1WzeUI2LV3CimFMeKwINweTVHq81oq7LrIPR/6JphDTYaLM64D7LAYj7 zloAYZVp+LypL1KyKBBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmRuP-00BBkL-4H; Fri, 28 May 2021 02:07:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmRuM-00BBj7-6U; Fri, 28 May 2021 02:07:31 +0000 X-UUID: 87b3f5f90ef1432ebc439da732fb532f-20210527 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jjcO25Xagr83g07sXePMtvR2r8MtrL12TZBb3C93zGY=; b=B3tcxpA1v2hlE4+qT6NFz2DLJ00VP+u3C4/Kh/X7kuDspF40ivxkUy9Ty+5aJZpHRptQcA10mOfdcgg6rFvyPEgZW0RFbPGYhstWhDEw42cDwECNIyrrF+yjwGEFTUw9vlxO1w1duMgEVcnNwe8UTGupoHxPVEBarq3GK8xVzyA=; X-UUID: 87b3f5f90ef1432ebc439da732fb532f-20210527 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1520336392; Thu, 27 May 2021 19:07:28 -0700 Received: from MTKMBS33N1.mediatek.inc (172.27.4.75) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 27 May 2021 19:07:26 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 28 May 2021 10:07:19 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 28 May 2021 10:07:19 +0800 Message-ID: <1622167640.5918.4.camel@mhfsdcap03> Subject: Re: [PATCH 2/3] usb: common: add helper to get role-switch-default-mode From: Chunfeng Yun To: Greg Kroah-Hartman CC: Felipe Balbi , Matthias Brugger , Thinh Nguyen , , , , Date: Fri, 28 May 2021 10:07:20 +0800 In-Reply-To: References: <1621933165-9661-1-git-send-email-chunfeng.yun@mediatek.com> <1621933165-9661-2-git-send-email-chunfeng.yun@mediatek.com> <1622108619.5918.3.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 46C5A099E0518FE1F381C0C8780DF59102CDFEFB71DFB8CB090EC1557BF546D42000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_190730_272960_C2A9C209 X-CRM114-Status: GOOD ( 25.04 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2021-05-27 at 12:01 +0200, Greg Kroah-Hartman wrote: > On Thu, May 27, 2021 at 05:43:39PM +0800, Chunfeng Yun wrote: > > On Thu, 2021-05-27 at 09:28 +0200, Greg Kroah-Hartman wrote: > > > On Tue, May 25, 2021 at 04:59:24PM +0800, Chunfeng Yun wrote: > > > > Add helper to get "role-switch-default-mode", and convert it > > > > to the corresponding enum usb_dr_mode > > > > > > > > Signed-off-by: Chunfeng Yun > > > > --- > > > > drivers/usb/common/common.c | 20 ++++++++++++++++++++ > > > > include/linux/usb/otg.h | 1 + > > > > 2 files changed, 21 insertions(+) > > > > > > > > diff --git a/drivers/usb/common/common.c b/drivers/usb/common/common.c > > > > index fff318597337..78a625a4e526 100644 > > > > --- a/drivers/usb/common/common.c > > > > +++ b/drivers/usb/common/common.c > > > > @@ -207,6 +207,26 @@ enum usb_dr_mode usb_get_dr_mode(struct device *dev) > > > > } > > > > EXPORT_SYMBOL_GPL(usb_get_dr_mode); > > > > > > > > +/** > > > > + * usb_get_role_switch_default_mode - Get default mode for given device > > > > + * @dev: Pointer to the given device > > > > + * > > > > + * The function gets string from property 'role-switch-default-mode', > > > > + * and returns the corresponding enum usb_dr_mode. > > > > + */ > > > > +enum usb_dr_mode usb_get_role_switch_default_mode(struct device *dev) > > > > +{ > > > > + const char *str; > > > > + int ret; > > > > + > > > > + ret = device_property_read_string(dev, "role-switch-default-mode", &str); > > > > + if (ret < 0) > > > > + return USB_DR_MODE_UNKNOWN; > > > > + > > > > + return usb_get_dr_mode_from_string(str); > > > > +} > > > > +EXPORT_SYMBOL_GPL(usb_get_role_switch_default_mode); > > > > + > > > > /** > > > > * usb_decode_interval - Decode bInterval into the time expressed in 1us unit > > > > * @epd: The descriptor of the endpoint > > > > diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h > > > > index a86ee6aad51b..bde313c97fb6 100644 > > > > --- a/include/linux/usb/otg.h > > > > +++ b/include/linux/usb/otg.h > > > > @@ -121,5 +121,6 @@ enum usb_dr_mode { > > > > }; > > > > > > > > extern enum usb_dr_mode usb_get_dr_mode(struct device *dev); > > > > +extern enum usb_dr_mode usb_get_role_switch_default_mode(struct device *dev); > > > > > > What other code outside of the dwc3 driver will ever need to call this? > > I prepare a series of pathes for mtu3, and will support > > "role-switch-default-mode" property > > Ok, how about we wait until at least 2 drivers need it before accepting > this change. Makes sense, thank you > > thanks, > > greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CC2C47089 for ; Fri, 28 May 2021 02:09:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4746460C3F for ; Fri, 28 May 2021 02:09:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4746460C3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ev7pJW1j7GRTdN8OtMvn8WYl/Cf878c9hPG8Lkjzguc=; b=EMaEABXgmBVIv4 a6whx0eusSqUO2ru5WdNqFB6GeXhBcBmrXB37FE6Hf7QD7JwWK1M8s0V7sbsBlwtllGkLQSlADcoo 3pLqCHIQEC/l6+veN00yNzgMKT9FvmbNF98SC7ei36R39Kbo1p8XNrJ7JWrmrVrPPXhq3OORQhgoU GKqwqU4ip5Zi0eCsj9YUyM026c8s13FAax9ia5/q5JA7B2ujcKB/c1TduCAlLich5P/D7OmJ6nyeG hs417P0YCjNbRzCsokNYL8mlFsQ41kYYucg3SjxXshv7Efp6aPWabAxi9BLUa7ebQ/jt3KthlDz34 DKTZEEH6uXLECLcfk8hQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmRuR-00BBke-82; Fri, 28 May 2021 02:07:35 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmRuM-00BBj7-6U; Fri, 28 May 2021 02:07:31 +0000 X-UUID: 87b3f5f90ef1432ebc439da732fb532f-20210527 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jjcO25Xagr83g07sXePMtvR2r8MtrL12TZBb3C93zGY=; b=B3tcxpA1v2hlE4+qT6NFz2DLJ00VP+u3C4/Kh/X7kuDspF40ivxkUy9Ty+5aJZpHRptQcA10mOfdcgg6rFvyPEgZW0RFbPGYhstWhDEw42cDwECNIyrrF+yjwGEFTUw9vlxO1w1duMgEVcnNwe8UTGupoHxPVEBarq3GK8xVzyA=; X-UUID: 87b3f5f90ef1432ebc439da732fb532f-20210527 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1520336392; Thu, 27 May 2021 19:07:28 -0700 Received: from MTKMBS33N1.mediatek.inc (172.27.4.75) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 27 May 2021 19:07:26 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 28 May 2021 10:07:19 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 28 May 2021 10:07:19 +0800 Message-ID: <1622167640.5918.4.camel@mhfsdcap03> Subject: Re: [PATCH 2/3] usb: common: add helper to get role-switch-default-mode From: Chunfeng Yun To: Greg Kroah-Hartman CC: Felipe Balbi , Matthias Brugger , Thinh Nguyen , , , , Date: Fri, 28 May 2021 10:07:20 +0800 In-Reply-To: References: <1621933165-9661-1-git-send-email-chunfeng.yun@mediatek.com> <1621933165-9661-2-git-send-email-chunfeng.yun@mediatek.com> <1622108619.5918.3.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 46C5A099E0518FE1F381C0C8780DF59102CDFEFB71DFB8CB090EC1557BF546D42000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_190730_272960_C2A9C209 X-CRM114-Status: GOOD ( 25.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2021-05-27 at 12:01 +0200, Greg Kroah-Hartman wrote: > On Thu, May 27, 2021 at 05:43:39PM +0800, Chunfeng Yun wrote: > > On Thu, 2021-05-27 at 09:28 +0200, Greg Kroah-Hartman wrote: > > > On Tue, May 25, 2021 at 04:59:24PM +0800, Chunfeng Yun wrote: > > > > Add helper to get "role-switch-default-mode", and convert it > > > > to the corresponding enum usb_dr_mode > > > > > > > > Signed-off-by: Chunfeng Yun > > > > --- > > > > drivers/usb/common/common.c | 20 ++++++++++++++++++++ > > > > include/linux/usb/otg.h | 1 + > > > > 2 files changed, 21 insertions(+) > > > > > > > > diff --git a/drivers/usb/common/common.c b/drivers/usb/common/common.c > > > > index fff318597337..78a625a4e526 100644 > > > > --- a/drivers/usb/common/common.c > > > > +++ b/drivers/usb/common/common.c > > > > @@ -207,6 +207,26 @@ enum usb_dr_mode usb_get_dr_mode(struct device *dev) > > > > } > > > > EXPORT_SYMBOL_GPL(usb_get_dr_mode); > > > > > > > > +/** > > > > + * usb_get_role_switch_default_mode - Get default mode for given device > > > > + * @dev: Pointer to the given device > > > > + * > > > > + * The function gets string from property 'role-switch-default-mode', > > > > + * and returns the corresponding enum usb_dr_mode. > > > > + */ > > > > +enum usb_dr_mode usb_get_role_switch_default_mode(struct device *dev) > > > > +{ > > > > + const char *str; > > > > + int ret; > > > > + > > > > + ret = device_property_read_string(dev, "role-switch-default-mode", &str); > > > > + if (ret < 0) > > > > + return USB_DR_MODE_UNKNOWN; > > > > + > > > > + return usb_get_dr_mode_from_string(str); > > > > +} > > > > +EXPORT_SYMBOL_GPL(usb_get_role_switch_default_mode); > > > > + > > > > /** > > > > * usb_decode_interval - Decode bInterval into the time expressed in 1us unit > > > > * @epd: The descriptor of the endpoint > > > > diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h > > > > index a86ee6aad51b..bde313c97fb6 100644 > > > > --- a/include/linux/usb/otg.h > > > > +++ b/include/linux/usb/otg.h > > > > @@ -121,5 +121,6 @@ enum usb_dr_mode { > > > > }; > > > > > > > > extern enum usb_dr_mode usb_get_dr_mode(struct device *dev); > > > > +extern enum usb_dr_mode usb_get_role_switch_default_mode(struct device *dev); > > > > > > What other code outside of the dwc3 driver will ever need to call this? > > I prepare a series of pathes for mtu3, and will support > > "role-switch-default-mode" property > > Ok, how about we wait until at least 2 drivers need it before accepting > this change. Makes sense, thank you > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel