From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <xie.he.0141@gmail.com>,
<ms@dev.tdt.de>, <willemb@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <tanhuazhong@huawei.com>,
<huangguangbin2@huawei.com>
Subject: [PATCH net-next 7/7] net: hdlc: add braces {} to all arms of the statement
Date: Tue, 1 Jun 2021 21:23:22 +0800 [thread overview]
Message-ID: <1622553802-19903-8-git-send-email-huangguangbin2@huawei.com> (raw)
In-Reply-To: <1622553802-19903-1-git-send-email-huangguangbin2@huawei.com>
From: Peng Li <lipeng321@huawei.com>
Braces {} should be used on all arms of this statement.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/wan/hdlc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c
index f48d70e..dd6312b 100644
--- a/drivers/net/wan/hdlc.c
+++ b/drivers/net/wan/hdlc.c
@@ -163,8 +163,9 @@ int hdlc_open(struct net_device *dev)
if (hdlc->carrier) {
netdev_info(dev, "Carrier detected\n");
hdlc_proto_start(dev);
- } else
+ } else {
netdev_info(dev, "No carrier\n");
+ }
hdlc->open = 1;
--
2.8.1
next prev parent reply other threads:[~2021-06-01 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 13:23 [PATCH net-next 0/7] net: hdlc: clean up some code style issues Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 1/7] net: hdlc: remove redundant blank lines Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 2/7] net: hdlc: add blank line after declarations Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 3/7] net: hdlc: fix an code style issue about "foo* bar" Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 4/7] net: hdlc: fix an code style issue about EXPORT_SYMBOL(foo) Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 5/7] net: hdlc: replace comparison to NULL with "!param" Guangbin Huang
2021-06-01 13:23 ` [PATCH net-next 6/7] net: hdlc: move out assignment in if condition Guangbin Huang
2021-06-01 13:23 ` Guangbin Huang [this message]
2021-06-02 0:10 ` [PATCH net-next 0/7] net: hdlc: clean up some code style issues patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622553802-19903-8-git-send-email-huangguangbin2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=tanhuazhong@huawei.com \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.