* [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
@ 2021-05-27 9:04 ` Zhen Lei
0 siblings, 0 replies; 10+ messages in thread
From: Zhen Lei @ 2021-05-27 9:04 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, intel-gfx, dri-devel, linux-kernel
Cc: Zhen Lei
If intel_hdcp_validate_v_prime() has been successful within the allowed
number of tries, we can directly call drm_dbg_kms() and "goto out" without
jumping out of the loop and repeatedly judging whether the operation is
successful. This can help us reduce an unnecessary if judgment. And it's
a little clearer to read.
No functional change.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 24 ++++++++++-------------
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index d8570e14fe60..c32a854eda66 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -663,13 +663,13 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
ret = shim->read_ksv_fifo(dig_port, num_downstream, ksv_fifo);
if (ret)
- goto err;
+ goto out;
if (drm_hdcp_check_ksvs_revoked(&dev_priv->drm, ksv_fifo,
num_downstream) > 0) {
drm_err(&dev_priv->drm, "Revoked Ksv(s) in ksv_fifo\n");
ret = -EPERM;
- goto err;
+ goto out;
}
/*
@@ -680,20 +680,16 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
ret = intel_hdcp_validate_v_prime(connector, shim,
ksv_fifo, num_downstream,
bstatus);
- if (!ret)
- break;
- }
-
- if (i == tries) {
- drm_dbg_kms(&dev_priv->drm,
- "V Prime validation failed.(%d)\n", ret);
- goto err;
+ if (!ret) {
+ drm_dbg_kms(&dev_priv->drm,
+ "HDCP is enabled (%d downstream devices)\n",
+ num_downstream);
+ goto out;
+ }
}
- drm_dbg_kms(&dev_priv->drm, "HDCP is enabled (%d downstream devices)\n",
- num_downstream);
- ret = 0;
-err:
+ drm_dbg_kms(&dev_priv->drm, "V Prime validation failed.(%d)\n", ret);
+out:
kfree(ksv_fifo);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
@ 2021-05-27 9:04 ` Zhen Lei
0 siblings, 0 replies; 10+ messages in thread
From: Zhen Lei @ 2021-05-27 9:04 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, intel-gfx, dri-devel, linux-kernel
Cc: Zhen Lei
If intel_hdcp_validate_v_prime() has been successful within the allowed
number of tries, we can directly call drm_dbg_kms() and "goto out" without
jumping out of the loop and repeatedly judging whether the operation is
successful. This can help us reduce an unnecessary if judgment. And it's
a little clearer to read.
No functional change.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 24 ++++++++++-------------
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index d8570e14fe60..c32a854eda66 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -663,13 +663,13 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
ret = shim->read_ksv_fifo(dig_port, num_downstream, ksv_fifo);
if (ret)
- goto err;
+ goto out;
if (drm_hdcp_check_ksvs_revoked(&dev_priv->drm, ksv_fifo,
num_downstream) > 0) {
drm_err(&dev_priv->drm, "Revoked Ksv(s) in ksv_fifo\n");
ret = -EPERM;
- goto err;
+ goto out;
}
/*
@@ -680,20 +680,16 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
ret = intel_hdcp_validate_v_prime(connector, shim,
ksv_fifo, num_downstream,
bstatus);
- if (!ret)
- break;
- }
-
- if (i == tries) {
- drm_dbg_kms(&dev_priv->drm,
- "V Prime validation failed.(%d)\n", ret);
- goto err;
+ if (!ret) {
+ drm_dbg_kms(&dev_priv->drm,
+ "HDCP is enabled (%d downstream devices)\n",
+ num_downstream);
+ goto out;
+ }
}
- drm_dbg_kms(&dev_priv->drm, "HDCP is enabled (%d downstream devices)\n",
- num_downstream);
- ret = 0;
-err:
+ drm_dbg_kms(&dev_priv->drm, "V Prime validation failed.(%d)\n", ret);
+out:
kfree(ksv_fifo);
return ret;
}
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
2021-05-27 9:04 ` [Intel-gfx] " Zhen Lei
@ 2021-05-27 10:04 ` Jani Nikula
-1 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-05-27 10:04 UTC (permalink / raw)
To: Zhen Lei, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, intel-gfx, dri-devel, linux-kernel
Cc: Zhen Lei
On Thu, 27 May 2021, Zhen Lei <thunder.leizhen@huawei.com> wrote:
> If intel_hdcp_validate_v_prime() has been successful within the allowed
> number of tries, we can directly call drm_dbg_kms() and "goto out" without
> jumping out of the loop and repeatedly judging whether the operation is
> successful. This can help us reduce an unnecessary if judgment. And it's
> a little clearer to read.
Generally I think the "happy day scenario" should be at the topmost
indentation level and not buried in the ifs with a goto exit.
BR,
Jani.
>
> No functional change.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c | 24 ++++++++++-------------
> 1 file changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index d8570e14fe60..c32a854eda66 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -663,13 +663,13 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>
> ret = shim->read_ksv_fifo(dig_port, num_downstream, ksv_fifo);
> if (ret)
> - goto err;
> + goto out;
>
> if (drm_hdcp_check_ksvs_revoked(&dev_priv->drm, ksv_fifo,
> num_downstream) > 0) {
> drm_err(&dev_priv->drm, "Revoked Ksv(s) in ksv_fifo\n");
> ret = -EPERM;
> - goto err;
> + goto out;
> }
>
> /*
> @@ -680,20 +680,16 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
> ret = intel_hdcp_validate_v_prime(connector, shim,
> ksv_fifo, num_downstream,
> bstatus);
> - if (!ret)
> - break;
> - }
> -
> - if (i == tries) {
> - drm_dbg_kms(&dev_priv->drm,
> - "V Prime validation failed.(%d)\n", ret);
> - goto err;
> + if (!ret) {
> + drm_dbg_kms(&dev_priv->drm,
> + "HDCP is enabled (%d downstream devices)\n",
> + num_downstream);
> + goto out;
> + }
> }
>
> - drm_dbg_kms(&dev_priv->drm, "HDCP is enabled (%d downstream devices)\n",
> - num_downstream);
> - ret = 0;
> -err:
> + drm_dbg_kms(&dev_priv->drm, "V Prime validation failed.(%d)\n", ret);
> +out:
> kfree(ksv_fifo);
> return ret;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
@ 2021-05-27 10:04 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-05-27 10:04 UTC (permalink / raw)
To: Zhen Lei, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, intel-gfx, dri-devel, linux-kernel
Cc: Zhen Lei
On Thu, 27 May 2021, Zhen Lei <thunder.leizhen@huawei.com> wrote:
> If intel_hdcp_validate_v_prime() has been successful within the allowed
> number of tries, we can directly call drm_dbg_kms() and "goto out" without
> jumping out of the loop and repeatedly judging whether the operation is
> successful. This can help us reduce an unnecessary if judgment. And it's
> a little clearer to read.
Generally I think the "happy day scenario" should be at the topmost
indentation level and not buried in the ifs with a goto exit.
BR,
Jani.
>
> No functional change.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c | 24 ++++++++++-------------
> 1 file changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index d8570e14fe60..c32a854eda66 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -663,13 +663,13 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>
> ret = shim->read_ksv_fifo(dig_port, num_downstream, ksv_fifo);
> if (ret)
> - goto err;
> + goto out;
>
> if (drm_hdcp_check_ksvs_revoked(&dev_priv->drm, ksv_fifo,
> num_downstream) > 0) {
> drm_err(&dev_priv->drm, "Revoked Ksv(s) in ksv_fifo\n");
> ret = -EPERM;
> - goto err;
> + goto out;
> }
>
> /*
> @@ -680,20 +680,16 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
> ret = intel_hdcp_validate_v_prime(connector, shim,
> ksv_fifo, num_downstream,
> bstatus);
> - if (!ret)
> - break;
> - }
> -
> - if (i == tries) {
> - drm_dbg_kms(&dev_priv->drm,
> - "V Prime validation failed.(%d)\n", ret);
> - goto err;
> + if (!ret) {
> + drm_dbg_kms(&dev_priv->drm,
> + "HDCP is enabled (%d downstream devices)\n",
> + num_downstream);
> + goto out;
> + }
> }
>
> - drm_dbg_kms(&dev_priv->drm, "HDCP is enabled (%d downstream devices)\n",
> - num_downstream);
> - ret = 0;
> -err:
> + drm_dbg_kms(&dev_priv->drm, "V Prime validation failed.(%d)\n", ret);
> +out:
> kfree(ksv_fifo);
> return ret;
> }
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
2021-05-27 10:04 ` [Intel-gfx] " Jani Nikula
@ 2021-05-28 9:36 ` Leizhen (ThunderTown)
-1 siblings, 0 replies; 10+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-28 9:36 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, intel-gfx, dri-devel, linux-kernel
On 2021/5/27 18:04, Jani Nikula wrote:
> On Thu, 27 May 2021, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>> If intel_hdcp_validate_v_prime() has been successful within the allowed
>> number of tries, we can directly call drm_dbg_kms() and "goto out" without
>> jumping out of the loop and repeatedly judging whether the operation is
>> successful. This can help us reduce an unnecessary if judgment. And it's
>> a little clearer to read.
>
> Generally I think the "happy day scenario" should be at the topmost
> indentation level and not buried in the ifs with a goto exit.
for (xxx) {
if (a == b)
return found;
}
At least this way of writing is common.
>
> BR,
> Jani.
>
>>
>> No functional change.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_hdcp.c | 24 ++++++++++-------------
>> 1 file changed, 10 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> index d8570e14fe60..c32a854eda66 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> @@ -663,13 +663,13 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>>
>> ret = shim->read_ksv_fifo(dig_port, num_downstream, ksv_fifo);
>> if (ret)
>> - goto err;
>> + goto out;
>>
>> if (drm_hdcp_check_ksvs_revoked(&dev_priv->drm, ksv_fifo,
>> num_downstream) > 0) {
>> drm_err(&dev_priv->drm, "Revoked Ksv(s) in ksv_fifo\n");
>> ret = -EPERM;
>> - goto err;
>> + goto out;
>> }
>>
>> /*
>> @@ -680,20 +680,16 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>> ret = intel_hdcp_validate_v_prime(connector, shim,
>> ksv_fifo, num_downstream,
>> bstatus);
>> - if (!ret)
>> - break;
>> - }
>> -
>> - if (i == tries) {
>> - drm_dbg_kms(&dev_priv->drm,
>> - "V Prime validation failed.(%d)\n", ret);
>> - goto err;
>> + if (!ret) {
>> + drm_dbg_kms(&dev_priv->drm,
>> + "HDCP is enabled (%d downstream devices)\n",
>> + num_downstream);
>> + goto out;
>> + }
>> }
>>
>> - drm_dbg_kms(&dev_priv->drm, "HDCP is enabled (%d downstream devices)\n",
>> - num_downstream);
>> - ret = 0;
>> -err:
>> + drm_dbg_kms(&dev_priv->drm, "V Prime validation failed.(%d)\n", ret);
>> +out:
>> kfree(ksv_fifo);
>> return ret;
>> }
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
@ 2021-05-28 9:36 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 10+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-28 9:36 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, intel-gfx, dri-devel, linux-kernel
On 2021/5/27 18:04, Jani Nikula wrote:
> On Thu, 27 May 2021, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>> If intel_hdcp_validate_v_prime() has been successful within the allowed
>> number of tries, we can directly call drm_dbg_kms() and "goto out" without
>> jumping out of the loop and repeatedly judging whether the operation is
>> successful. This can help us reduce an unnecessary if judgment. And it's
>> a little clearer to read.
>
> Generally I think the "happy day scenario" should be at the topmost
> indentation level and not buried in the ifs with a goto exit.
for (xxx) {
if (a == b)
return found;
}
At least this way of writing is common.
>
> BR,
> Jani.
>
>>
>> No functional change.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_hdcp.c | 24 ++++++++++-------------
>> 1 file changed, 10 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> index d8570e14fe60..c32a854eda66 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> @@ -663,13 +663,13 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>>
>> ret = shim->read_ksv_fifo(dig_port, num_downstream, ksv_fifo);
>> if (ret)
>> - goto err;
>> + goto out;
>>
>> if (drm_hdcp_check_ksvs_revoked(&dev_priv->drm, ksv_fifo,
>> num_downstream) > 0) {
>> drm_err(&dev_priv->drm, "Revoked Ksv(s) in ksv_fifo\n");
>> ret = -EPERM;
>> - goto err;
>> + goto out;
>> }
>>
>> /*
>> @@ -680,20 +680,16 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>> ret = intel_hdcp_validate_v_prime(connector, shim,
>> ksv_fifo, num_downstream,
>> bstatus);
>> - if (!ret)
>> - break;
>> - }
>> -
>> - if (i == tries) {
>> - drm_dbg_kms(&dev_priv->drm,
>> - "V Prime validation failed.(%d)\n", ret);
>> - goto err;
>> + if (!ret) {
>> + drm_dbg_kms(&dev_priv->drm,
>> + "HDCP is enabled (%d downstream devices)\n",
>> + num_downstream);
>> + goto out;
>> + }
>> }
>>
>> - drm_dbg_kms(&dev_priv->drm, "HDCP is enabled (%d downstream devices)\n",
>> - num_downstream);
>> - ret = 0;
>> -err:
>> + drm_dbg_kms(&dev_priv->drm, "V Prime validation failed.(%d)\n", ret);
>> +out:
>> kfree(ksv_fifo);
>> return ret;
>> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
2021-05-28 9:36 ` [Intel-gfx] " Leizhen (ThunderTown)
@ 2021-05-31 10:36 ` Jani Nikula
-1 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-05-31 10:36 UTC (permalink / raw)
To: Leizhen (ThunderTown),
Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter,
intel-gfx, dri-devel, linux-kernel
On Fri, 28 May 2021, "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> wrote:
> On 2021/5/27 18:04, Jani Nikula wrote:
>> On Thu, 27 May 2021, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>>> If intel_hdcp_validate_v_prime() has been successful within the allowed
>>> number of tries, we can directly call drm_dbg_kms() and "goto out" without
>>> jumping out of the loop and repeatedly judging whether the operation is
>>> successful. This can help us reduce an unnecessary if judgment. And it's
>>> a little clearer to read.
>>
>> Generally I think the "happy day scenario" should be at the topmost
>> indentation level and not buried in the ifs with a goto exit.
>
> for (xxx) {
> if (a == b)
> return found;
> }
>
> At least this way of writing is common.
Yes, if the loop is abstracted to a separate function.
BR,
Jani.
>
>
>>
>> BR,
>> Jani.
>>
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_hdcp.c | 24 ++++++++++-------------
>>> 1 file changed, 10 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
>>> index d8570e14fe60..c32a854eda66 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
>>> @@ -663,13 +663,13 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>>>
>>> ret = shim->read_ksv_fifo(dig_port, num_downstream, ksv_fifo);
>>> if (ret)
>>> - goto err;
>>> + goto out;
>>>
>>> if (drm_hdcp_check_ksvs_revoked(&dev_priv->drm, ksv_fifo,
>>> num_downstream) > 0) {
>>> drm_err(&dev_priv->drm, "Revoked Ksv(s) in ksv_fifo\n");
>>> ret = -EPERM;
>>> - goto err;
>>> + goto out;
>>> }
>>>
>>> /*
>>> @@ -680,20 +680,16 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>>> ret = intel_hdcp_validate_v_prime(connector, shim,
>>> ksv_fifo, num_downstream,
>>> bstatus);
>>> - if (!ret)
>>> - break;
>>> - }
>>> -
>>> - if (i == tries) {
>>> - drm_dbg_kms(&dev_priv->drm,
>>> - "V Prime validation failed.(%d)\n", ret);
>>> - goto err;
>>> + if (!ret) {
>>> + drm_dbg_kms(&dev_priv->drm,
>>> + "HDCP is enabled (%d downstream devices)\n",
>>> + num_downstream);
>>> + goto out;
>>> + }
>>> }
>>>
>>> - drm_dbg_kms(&dev_priv->drm, "HDCP is enabled (%d downstream devices)\n",
>>> - num_downstream);
>>> - ret = 0;
>>> -err:
>>> + drm_dbg_kms(&dev_priv->drm, "V Prime validation failed.(%d)\n", ret);
>>> +out:
>>> kfree(ksv_fifo);
>>> return ret;
>>> }
>>
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
@ 2021-05-31 10:36 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2021-05-31 10:36 UTC (permalink / raw)
To: Leizhen (ThunderTown),
Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter,
intel-gfx, dri-devel, linux-kernel
On Fri, 28 May 2021, "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> wrote:
> On 2021/5/27 18:04, Jani Nikula wrote:
>> On Thu, 27 May 2021, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>>> If intel_hdcp_validate_v_prime() has been successful within the allowed
>>> number of tries, we can directly call drm_dbg_kms() and "goto out" without
>>> jumping out of the loop and repeatedly judging whether the operation is
>>> successful. This can help us reduce an unnecessary if judgment. And it's
>>> a little clearer to read.
>>
>> Generally I think the "happy day scenario" should be at the topmost
>> indentation level and not buried in the ifs with a goto exit.
>
> for (xxx) {
> if (a == b)
> return found;
> }
>
> At least this way of writing is common.
Yes, if the loop is abstracted to a separate function.
BR,
Jani.
>
>
>>
>> BR,
>> Jani.
>>
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_hdcp.c | 24 ++++++++++-------------
>>> 1 file changed, 10 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
>>> index d8570e14fe60..c32a854eda66 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
>>> @@ -663,13 +663,13 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>>>
>>> ret = shim->read_ksv_fifo(dig_port, num_downstream, ksv_fifo);
>>> if (ret)
>>> - goto err;
>>> + goto out;
>>>
>>> if (drm_hdcp_check_ksvs_revoked(&dev_priv->drm, ksv_fifo,
>>> num_downstream) > 0) {
>>> drm_err(&dev_priv->drm, "Revoked Ksv(s) in ksv_fifo\n");
>>> ret = -EPERM;
>>> - goto err;
>>> + goto out;
>>> }
>>>
>>> /*
>>> @@ -680,20 +680,16 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector)
>>> ret = intel_hdcp_validate_v_prime(connector, shim,
>>> ksv_fifo, num_downstream,
>>> bstatus);
>>> - if (!ret)
>>> - break;
>>> - }
>>> -
>>> - if (i == tries) {
>>> - drm_dbg_kms(&dev_priv->drm,
>>> - "V Prime validation failed.(%d)\n", ret);
>>> - goto err;
>>> + if (!ret) {
>>> + drm_dbg_kms(&dev_priv->drm,
>>> + "HDCP is enabled (%d downstream devices)\n",
>>> + num_downstream);
>>> + goto out;
>>> + }
>>> }
>>>
>>> - drm_dbg_kms(&dev_priv->drm, "HDCP is enabled (%d downstream devices)\n",
>>> - num_downstream);
>>> - ret = 0;
>>> -err:
>>> + drm_dbg_kms(&dev_priv->drm, "V Prime validation failed.(%d)\n", ret);
>>> +out:
>>> kfree(ksv_fifo);
>>> return ret;
>>> }
>>
>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
2021-05-27 9:04 ` [Intel-gfx] " Zhen Lei
(?)
(?)
@ 2021-06-01 20:55 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-06-01 20:55 UTC (permalink / raw)
To: Zhen Lei; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5700 bytes --]
== Series Details ==
Series: series starting with [1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
URL : https://patchwork.freedesktop.org/series/90834/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10156 -> Patchwork_20257
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/index.html
Known issues
------------
Here are the changes found in Patchwork_20257 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][2] -> [FAIL][3] ([i915#49])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][4] ([i915#2782]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][6] ([i915#2782] / [i915#2940] / [i915#3462]) -> [DMESG-FAIL][7] ([i915#3462])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
- fi-cml-s: [DMESG-FAIL][8] ([i915#3462]) -> [INCOMPLETE][9] ([i915#3462])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-cml-s/igt@i915_selftest@live@execlists.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-cml-s/igt@i915_selftest@live@execlists.html
* igt@runner@aborted:
- fi-glk-dsi: [FAIL][10] ([i915#2426] / [i915#3363] / [k.org#202321]) -> [FAIL][11] ([i915#3363] / [k.org#202321])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-glk-dsi/igt@runner@aborted.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-glk-dsi/igt@runner@aborted.html
- fi-kbl-r: [FAIL][12] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][13] ([i915#1436] / [i915#3363])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-kbl-r/igt@runner@aborted.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-kbl-r/igt@runner@aborted.html
- fi-kbl-soraka: [FAIL][14] ([i915#1436] / [i915#3363]) -> [FAIL][15] ([i915#1436] / [i915#2426] / [i915#3363])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-kbl-soraka/igt@runner@aborted.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-kbl-soraka/igt@runner@aborted.html
- fi-kbl-7500u: [FAIL][16] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][17] ([i915#1436] / [i915#3363])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-kbl-7500u/igt@runner@aborted.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-kbl-7500u/igt@runner@aborted.html
- fi-cml-u2: [FAIL][18] ([i915#3363] / [i915#3462]) -> [FAIL][19] ([i915#2082] / [i915#2426] / [i915#3363] / [i915#3462])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-cml-u2/igt@runner@aborted.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-cml-u2/igt@runner@aborted.html
- fi-skl-6700k2: [FAIL][20] ([i915#1436] / [i915#3363]) -> [FAIL][21] ([i915#1436] / [i915#2426] / [i915#3363])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/fi-skl-6700k2/igt@runner@aborted.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/fi-skl-6700k2/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (47 -> 41)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10156 -> Patchwork_20257
CI-20190529: 20190529
CI_DRM_10156: 551125c07e42a44a1b4bf8ad735619f2e315a0e2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6098: 1fbc1e7d602f96a7f4e2b95057eef994656b8e74 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_20257: 4a2e6928a899f9cf7d9d59592b3eb63be9222ec0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4a2e6928a899 drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/index.html
[-- Attachment #1.2: Type: text/html, Size: 8446 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
2021-05-27 9:04 ` [Intel-gfx] " Zhen Lei
` (2 preceding siblings ...)
(?)
@ 2021-06-02 6:38 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-06-02 6:38 UTC (permalink / raw)
To: Zhen Lei; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30310 bytes --]
== Series Details ==
Series: series starting with [1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()
URL : https://patchwork.freedesktop.org/series/90834/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10156_full -> Patchwork_20257_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_20257_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20257_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20257_full:
### IGT changes ###
#### Warnings ####
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: [SKIP][1] ([fdo#110892]) -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb1/igt@i915_pm_rpm@modeset-non-lpsp.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb7/igt@i915_pm_rpm@modeset-non-lpsp.html
Known issues
------------
Here are the changes found in Patchwork_20257_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-snb7/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][4] -> [TIMEOUT][5] ([i915#2369] / [i915#3063])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-tglb3/igt@gem_eio@unwedge-stress.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-tglb5/igt@gem_eio@unwedge-stress.html
- shard-snb: NOTRUN -> [FAIL][6] ([i915#3354])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-snb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk1/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][9] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: NOTRUN -> [FAIL][10] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_suspend@basic-s3:
- shard-apl: NOTRUN -> [DMESG-WARN][12] ([i915#180])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl6/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#118] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-glk2/igt@gem_exec_whisper@basic-queues-all.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk6/igt@gem_exec_whisper@basic-queues-all.html
* igt@gem_huc_copy@huc-copy:
- shard-skl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#2190])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl9/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@big-copy:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#307]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-glk8/igt@gem_mmap_gtt@big-copy.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk1/igt@gem_mmap_gtt@big-copy.html
* igt@gem_mmap_gtt@big-copy-xy:
- shard-skl: [PASS][18] -> [FAIL][19] ([i915#307]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl6/igt@gem_mmap_gtt@big-copy-xy.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl2/igt@gem_mmap_gtt@big-copy-xy.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-snb: NOTRUN -> [INCOMPLETE][20] ([i915#2055] / [i915#3468]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-snb2/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
- shard-kbl: [PASS][21] -> [INCOMPLETE][22] ([i915#3468])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-kbl2/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl2/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
* igt@gem_mmap_gtt@fault-concurrent:
- shard-skl: NOTRUN -> [INCOMPLETE][23] ([i915#3468])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl4/igt@gem_mmap_gtt@fault-concurrent.html
* igt@gem_mmap_gtt@fault-concurrent-y:
- shard-skl: NOTRUN -> [INCOMPLETE][24] ([i915#3468] / [i915#3523])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl3/igt@gem_mmap_gtt@fault-concurrent-y.html
- shard-apl: NOTRUN -> [INCOMPLETE][25] ([i915#3468])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl1/igt@gem_mmap_gtt@fault-concurrent-y.html
* igt@gem_mmap_offset@clear:
- shard-skl: [PASS][26] -> [FAIL][27] ([i915#3160])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl7/igt@gem_mmap_offset@clear.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl7/igt@gem_mmap_offset@clear.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][28] ([i915#2658])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl4/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
- shard-glk: NOTRUN -> [SKIP][29] ([fdo#109271]) +53 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk5/igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][30] ([i915#3002])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl6/igt@gem_userptr_blits@input-checking.html
- shard-snb: NOTRUN -> [DMESG-WARN][31] ([i915#3002])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-snb5/igt@gem_userptr_blits@input-checking.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#1937])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_selftest@live@execlists:
- shard-skl: NOTRUN -> [INCOMPLETE][33] ([i915#2782] / [i915#3462])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl9/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][34] ([i915#1886] / [i915#2291])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl9/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: NOTRUN -> [INCOMPLETE][35] ([i915#2782])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-snb7/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][36] -> [DMESG-WARN][37] ([i915#180])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@forcewake:
- shard-skl: [PASS][38] -> [INCOMPLETE][39] ([i915#636])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl9/igt@i915_suspend@forcewake.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl10/igt@i915_suspend@forcewake.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][40] -> [FAIL][41] ([i915#2521])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl5/igt@kms_async_flips@alternate-sync-async-flip.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl9/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111615])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-tglb3/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html
* igt@kms_big_joiner@basic:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#2705])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl2/igt@kms_big_joiner@basic.html
* igt@kms_ccs@pipe-c-bad-pixel-format:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111304])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl9/igt@kms_ccs@pipe-c-bad-pixel-format.html
* igt@kms_chamelium@vga-frame-dump:
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +12 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl5/igt@kms_chamelium@vga-frame-dump.html
* igt@kms_color@pipe-c-ctm-blue-to-red:
- shard-skl: NOTRUN -> [DMESG-WARN][46] ([i915#1982])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl9/igt@kms_color@pipe-c-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-snb: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +18 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +5 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl2/igt@kms_color_chamelium@pipe-b-ctm-0-25.html
* igt@kms_color_chamelium@pipe-c-ctm-max:
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +10 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl2/igt@kms_color_chamelium@pipe-c-ctm-max.html
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +8 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk8/igt@kms_color_chamelium@pipe-d-degamma.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][51] ([i915#2105])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl2/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][52] -> [DMESG-WARN][53] ([i915#180]) +7 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][54] ([fdo#109271]) +310 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-snb2/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][55] -> [FAIL][56] ([i915#2346] / [i915#533])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][57] -> [INCOMPLETE][58] ([i915#155] / [i915#180] / [i915#636])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: NOTRUN -> [FAIL][59] ([i915#2122])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl5/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2642])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
- shard-glk: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#2642])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271]) +87 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl3/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271]) +109 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271]) +58 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-plflip-blt:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#111825]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-tglb3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-plflip-blt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][66] -> [FAIL][67] ([i915#1188])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#533])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl4/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-glk: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#533])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][70] ([fdo#108145] / [i915#265])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-skl: NOTRUN -> [FAIL][71] ([fdo#108145] / [i915#265]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-glk: NOTRUN -> [FAIL][72] ([i915#265])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk8/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][73] ([fdo#108145] / [i915#265])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-skl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#2733])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl4/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#658]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-tglb: NOTRUN -> [SKIP][77] ([i915#2920])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-tglb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-glk: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#658]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk5/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-skl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#658]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][80] -> [SKIP][81] ([fdo#109642] / [fdo#111068] / [i915#658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb6/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][82] -> [SKIP][83] ([fdo#109441]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#533]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl6/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-check-output:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2437])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl4/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2437])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl6/igt@kms_writeback@writeback-fb-id.html
* igt@perf@polling-small-buf:
- shard-skl: [PASS][87] -> [FAIL][88] ([i915#1722])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl5/igt@perf@polling-small-buf.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl7/igt@perf@polling-small-buf.html
* igt@sysfs_clients@fair-0:
- shard-skl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#2994])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl9/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@fair-3:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#2994])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl6/igt@sysfs_clients@fair-3.html
* igt@sysfs_clients@sema-50:
- shard-kbl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl2/igt@sysfs_clients@sema-50.html
#### Possible fixes ####
* igt@gem_ctx_ringsize@active@bcs0:
- shard-skl: [INCOMPLETE][92] ([i915#3316]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl5/igt@gem_ctx_ringsize@active@bcs0.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl5/igt@gem_ctx_ringsize@active@bcs0.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-tglb: [TIMEOUT][94] ([i915#3063]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-tglb3/igt@gem_eio@in-flight-contexts-10ms.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-tglb6/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][96] ([i915#2846]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-glk8/igt@gem_exec_fair@basic-deadline.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk4/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [FAIL][98] ([i915#2842]) -> [PASS][99] +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-tglb8/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][100] ([i915#2842]) -> [PASS][101] +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy:
- shard-skl: [INCOMPLETE][102] ([i915#198] / [i915#3468]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl8/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl5/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][104] ([i915#307]) -> [PASS][105] +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb2/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@gem_mmap_gtt@cpuset-medium-copy-xy:
- shard-tglb: [INCOMPLETE][106] ([i915#3468] / [i915#750]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-tglb7/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-tglb3/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
* igt@gem_mmap_gtt@medium-copy-xy:
- shard-glk: [INCOMPLETE][108] ([i915#2055] / [i915#2502] / [i915#3468]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-glk2/igt@gem_mmap_gtt@medium-copy-xy.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk8/igt@gem_mmap_gtt@medium-copy-xy.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][110] ([i915#180]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-kbl4/igt@gem_workarounds@suspend-resume-fd.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
* igt@kms_color@pipe-c-ctm-0-25:
- shard-skl: [DMESG-WARN][112] ([i915#1982]) -> [PASS][113] +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl1/igt@kms_color@pipe-c-ctm-0-25.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl7/igt@kms_color@pipe-c-ctm-0-25.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][114] ([i915#2346]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][116] ([i915#2122]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-glk1/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk4/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][118] ([i915#79]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][120] ([i915#180]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-apl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: [INCOMPLETE][122] ([i915#198]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane@pixel-format@pipe-a-planes:
- shard-glk: [DMESG-FAIL][124] ([i915#118] / [i915#95]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-glk8/igt@kms_plane@pixel-format@pipe-a-planes.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-glk1/igt@kms_plane@pixel-format@pipe-a-planes.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][126] ([fdo#109441]) -> [PASS][127] +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb6/igt@kms_psr@psr2_dpms.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb2/igt@kms_psr@psr2_dpms.html
#### Warnings ####
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][128] ([i915#2842]) -> [FAIL][129] ([i915#2852])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb6/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb2/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][130] ([i915#2842]) -> [FAIL][131] ([i915#2849])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-skl: [INCOMPLETE][132] ([i915#198] / [i915#3468]) -> [INCOMPLETE][133] ([i915#198])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-skl3/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-skl3/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][134] ([i915#1804] / [i915#2684]) -> [WARN][135] ([i915#2684])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][136] ([i915#2684]) -> [WARN][137] ([i915#1804] / [i915#2684])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_selftest@live@execlists:
- shard-tglb: [INCOMPLETE][138] ([i915#3462]) -> [DMESG-FAIL][139] ([i915#3462])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-tglb1/igt@i915_selftest@live@execlists.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-tglb8/igt@i915_selftest@live@execlists.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][140] ([i915#658]) -> [SKIP][141] ([i915#2920]) +3 similar issues
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10156/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [S
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20257/index.html
[-- Attachment #1.2: Type: text/html, Size: 33602 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-06-02 6:38 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 9:04 [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream() Zhen Lei
2021-05-27 9:04 ` [Intel-gfx] " Zhen Lei
2021-05-27 10:04 ` Jani Nikula
2021-05-27 10:04 ` [Intel-gfx] " Jani Nikula
2021-05-28 9:36 ` Leizhen (ThunderTown)
2021-05-28 9:36 ` [Intel-gfx] " Leizhen (ThunderTown)
2021-05-31 10:36 ` Jani Nikula
2021-05-31 10:36 ` [Intel-gfx] " Jani Nikula
2021-06-01 20:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
2021-06-02 6:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.