All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yejune Deng <yejune.deng@gmail.com>
To: tglx@linutronix.de, peterz@infradead.org, frederic@kernel.org,
	mingo@kernel.org, keescook@chromium.org, dave@stgolabs.net
Cc: linux-kernel@vger.kernel.org, Yejune Deng <yejunedeng@gmail.com>
Subject: [PATCH] softirq: Remove the unnecessary CONFIG_TRACE_IRQFLAGS
Date: Wed,  2 Jun 2021 15:34:42 +0800	[thread overview]
Message-ID: <1622619282-12077-1-git-send-email-yejunedeng@gmail.com> (raw)

The local_irq_enable() and local_irq_disable() had two definitions that
include CONFIG_TRACE_IRQFLAGS or not.

Signed-off-by: Yejune Deng <yejunedeng@gmail.com>
---
 kernel/softirq.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index 4992853..a81d804 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -362,9 +362,7 @@ void __local_bh_enable_ip(unsigned long ip, unsigned int cnt)
 {
 	WARN_ON_ONCE(in_irq());
 	lockdep_assert_irqs_enabled();
-#ifdef CONFIG_TRACE_IRQFLAGS
 	local_irq_disable();
-#endif
 	/*
 	 * Are softirqs going to be turned on now:
 	 */
@@ -385,9 +383,7 @@ void __local_bh_enable_ip(unsigned long ip, unsigned int cnt)
 	}
 
 	preempt_count_dec();
-#ifdef CONFIG_TRACE_IRQFLAGS
 	local_irq_enable();
-#endif
 	preempt_check_resched();
 }
 EXPORT_SYMBOL(__local_bh_enable_ip);
-- 
2.7.4


             reply	other threads:[~2021-06-02  7:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02  7:34 Yejune Deng [this message]
2021-06-02 17:53 ` [PATCH] softirq: Remove the unnecessary CONFIG_TRACE_IRQFLAGS Kees Cook
2021-08-10 13:59   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1622619282-12077-1-git-send-email-yejunedeng@gmail.com \
    --to=yejune.deng@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=frederic@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=yejunedeng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.