* [PATCH] rtnetlink: Fix missing error code in rtnl_bridge_notify()
@ 2021-06-02 10:15 Jiapeng Chong
2021-06-03 21:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-06-02 10:15 UTC (permalink / raw)
To: davem
Cc: kuba, ast, daniel, hawk, john.fastabend, andrii, kafai,
songliubraving, yhs, kpsingh, netdev, linux-kernel, bpf,
Jiapeng Chong
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'err'.
Eliminate the follow smatch warning:
net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
'err'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
net/core/rtnetlink.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 714d5fa..3e84279 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -4842,8 +4842,10 @@ static int rtnl_bridge_notify(struct net_device *dev)
if (err < 0)
goto errout;
- if (!skb->len)
+ if (!skb->len) {
+ err = -EINVAL;
goto errout;
+ }
rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
return 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtnetlink: Fix missing error code in rtnl_bridge_notify()
2021-06-02 10:15 [PATCH] rtnetlink: Fix missing error code in rtnl_bridge_notify() Jiapeng Chong
@ 2021-06-03 21:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-03 21:00 UTC (permalink / raw)
To: Jiapeng Chong
Cc: davem, kuba, ast, daniel, hawk, john.fastabend, andrii, kafai,
songliubraving, yhs, kpsingh, netdev, linux-kernel, bpf
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 2 Jun 2021 18:15:04 +0800 you wrote:
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'err'.
>
> Eliminate the follow smatch warning:
>
> net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
> 'err'.
>
> [...]
Here is the summary with links:
- rtnetlink: Fix missing error code in rtnl_bridge_notify()
https://git.kernel.org/netdev/net/c/a8db57c1d285
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-03 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 10:15 [PATCH] rtnetlink: Fix missing error code in rtnl_bridge_notify() Jiapeng Chong
2021-06-03 21:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.