All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: xgene: Annotate __iomem pointer
@ 2021-05-17 17:18 ` Bjorn Helgaas
  0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2021-05-17 17:18 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: Toan Le, Rob Herring, linux-pci, linux-arm-kernel, Bjorn Helgaas,
	kernel test robot

From: Bjorn Helgaas <bhelgaas@google.com>

"bar_addr" is passed as the argument to writel(), which expects a
"void __iomem *".  Annotate "bar_addr" correctly.  Resolves an sparse
"incorrect type in argument 2 (different address spaces)" warning.

Link: https://lore.kernel.org/r/202105171809.Tay9fImZ-lkp@intel.com
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/controller/pci-xgene.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-xgene.c b/drivers/pci/controller/pci-xgene.c
index 7f503dd4ff81..1a412f5377fb 100644
--- a/drivers/pci/controller/pci-xgene.c
+++ b/drivers/pci/controller/pci-xgene.c
@@ -485,7 +485,7 @@ static void xgene_pcie_setup_ib_reg(struct xgene_pcie_port *port,
 {
 	void __iomem *cfg_base = port->cfg_base;
 	struct device *dev = port->dev;
-	void *bar_addr;
+	void __iomem *bar_addr;
 	u32 pim_reg;
 	u64 cpu_addr = entry->res->start;
 	u64 pci_addr = cpu_addr - entry->offset;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] PCI: xgene: Annotate __iomem pointer
@ 2021-05-17 17:18 ` Bjorn Helgaas
  0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2021-05-17 17:18 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: Toan Le, Rob Herring, linux-pci, linux-arm-kernel, Bjorn Helgaas,
	kernel test robot

From: Bjorn Helgaas <bhelgaas@google.com>

"bar_addr" is passed as the argument to writel(), which expects a
"void __iomem *".  Annotate "bar_addr" correctly.  Resolves an sparse
"incorrect type in argument 2 (different address spaces)" warning.

Link: https://lore.kernel.org/r/202105171809.Tay9fImZ-lkp@intel.com
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/controller/pci-xgene.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-xgene.c b/drivers/pci/controller/pci-xgene.c
index 7f503dd4ff81..1a412f5377fb 100644
--- a/drivers/pci/controller/pci-xgene.c
+++ b/drivers/pci/controller/pci-xgene.c
@@ -485,7 +485,7 @@ static void xgene_pcie_setup_ib_reg(struct xgene_pcie_port *port,
 {
 	void __iomem *cfg_base = port->cfg_base;
 	struct device *dev = port->dev;
-	void *bar_addr;
+	void __iomem *bar_addr;
 	u32 pim_reg;
 	u64 cpu_addr = entry->res->start;
 	u64 pci_addr = cpu_addr - entry->offset;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: xgene: Annotate __iomem pointer
  2021-05-17 17:18 ` Bjorn Helgaas
@ 2021-06-03 14:35   ` Lorenzo Pieralisi
  -1 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2021-06-03 14:35 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Lorenzo Pieralisi, Toan Le, Rob Herring, linux-pci,
	kernel test robot, Bjorn Helgaas, linux-arm-kernel

On Mon, 17 May 2021 12:18:39 -0500, Bjorn Helgaas wrote:
> "bar_addr" is passed as the argument to writel(), which expects a
> "void __iomem *".  Annotate "bar_addr" correctly.  Resolves an sparse
> "incorrect type in argument 2 (different address spaces)" warning.

Applied to pci/xgene, thanks!

[1/1] PCI: xgene: Annotate __iomem pointer
      https://git.kernel.org/lpieralisi/pci/c/eabbc3ccbe

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] PCI: xgene: Annotate __iomem pointer
@ 2021-06-03 14:35   ` Lorenzo Pieralisi
  0 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2021-06-03 14:35 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Lorenzo Pieralisi, Toan Le, Rob Herring, linux-pci,
	kernel test robot, Bjorn Helgaas, linux-arm-kernel

On Mon, 17 May 2021 12:18:39 -0500, Bjorn Helgaas wrote:
> "bar_addr" is passed as the argument to writel(), which expects a
> "void __iomem *".  Annotate "bar_addr" correctly.  Resolves an sparse
> "incorrect type in argument 2 (different address spaces)" warning.

Applied to pci/xgene, thanks!

[1/1] PCI: xgene: Annotate __iomem pointer
      https://git.kernel.org/lpieralisi/pci/c/eabbc3ccbe

Thanks,
Lorenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-03 14:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 17:18 [PATCH] PCI: xgene: Annotate __iomem pointer Bjorn Helgaas
2021-05-17 17:18 ` Bjorn Helgaas
2021-06-03 14:35 ` Lorenzo Pieralisi
2021-06-03 14:35   ` Lorenzo Pieralisi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.