All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues
@ 2021-06-04  7:32 Guangbin Huang
  2021-06-04  7:32 ` [PATCH net-next 1/6] net: hdlc_x25: remove redundant blank lines Guangbin Huang
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-04  7:32 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

This patchset clean up some code style issues.

Peng Li (6):
  net: hdlc_x25: remove redundant blank lines
  net: hdlc_x25: remove unnecessary out of memory message
  net: hdlc_x25: move out assignment in if condition
  net: hdlc_x25: add some required spaces
  net: hdlc_x25: fix the code issue about "if..else.."
  net: hdlc_x25: fix the alignment issue

 drivers/net/wan/hdlc_x25.c | 77 +++++++++++++++++-----------------------------
 1 file changed, 29 insertions(+), 48 deletions(-)

-- 
2.8.1


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH net-next 1/6] net: hdlc_x25: remove redundant blank lines
  2021-06-04  7:32 [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues Guangbin Huang
@ 2021-06-04  7:32 ` Guangbin Huang
  2021-06-04  7:32 ` [PATCH net-next 2/6] net: hdlc_x25: remove unnecessary out of memory message Guangbin Huang
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-04  7:32 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

This patch removes some redundant blank lines.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_x25.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
index ba8c36c..86b88f2 100644
--- a/drivers/net/wan/hdlc_x25.c
+++ b/drivers/net/wan/hdlc_x25.c
@@ -70,22 +70,16 @@ static void x25_connect_disconnect(struct net_device *dev, int reason, int code)
 	tasklet_schedule(&x25st->rx_tasklet);
 }
 
-
-
 static void x25_connected(struct net_device *dev, int reason)
 {
 	x25_connect_disconnect(dev, reason, X25_IFACE_CONNECT);
 }
 
-
-
 static void x25_disconnected(struct net_device *dev, int reason)
 {
 	x25_connect_disconnect(dev, reason, X25_IFACE_DISCONNECT);
 }
 
-
-
 static int x25_data_indication(struct net_device *dev, struct sk_buff *skb)
 {
 	struct x25_state *x25st = state(dev_to_hdlc(dev));
@@ -108,8 +102,6 @@ static int x25_data_indication(struct net_device *dev, struct sk_buff *skb)
 	return NET_RX_SUCCESS;
 }
 
-
-
 static void x25_data_transmit(struct net_device *dev, struct sk_buff *skb)
 {
 	hdlc_device *hdlc = dev_to_hdlc(dev);
@@ -123,8 +115,6 @@ static void x25_data_transmit(struct net_device *dev, struct sk_buff *skb)
 	hdlc->xmit(skb, dev); /* Ignore return value :-( */
 }
 
-
-
 static netdev_tx_t x25_xmit(struct sk_buff *skb, struct net_device *dev)
 {
 	hdlc_device *hdlc = dev_to_hdlc(dev);
@@ -185,8 +175,6 @@ static netdev_tx_t x25_xmit(struct sk_buff *skb, struct net_device *dev)
 	return NETDEV_TX_OK;
 }
 
-
-
 static int x25_open(struct net_device *dev)
 {
 	static const struct lapb_register_struct cb = {
@@ -232,8 +220,6 @@ static int x25_open(struct net_device *dev)
 	return 0;
 }
 
-
-
 static void x25_close(struct net_device *dev)
 {
 	hdlc_device *hdlc = dev_to_hdlc(dev);
@@ -247,8 +233,6 @@ static void x25_close(struct net_device *dev)
 	tasklet_kill(&x25st->rx_tasklet);
 }
 
-
-
 static int x25_rx(struct sk_buff *skb)
 {
 	struct net_device *dev = skb->dev;
@@ -279,7 +263,6 @@ static int x25_rx(struct sk_buff *skb)
 	return NET_RX_DROP;
 }
 
-
 static struct hdlc_proto proto = {
 	.open		= x25_open,
 	.close		= x25_close,
@@ -289,7 +272,6 @@ static struct hdlc_proto proto = {
 	.module		= THIS_MODULE,
 };
 
-
 static int x25_ioctl(struct net_device *dev, struct ifreq *ifr)
 {
 	x25_hdlc_proto __user *x25_s = ifr->ifr_settings.ifs_ifsu.x25;
@@ -380,21 +362,17 @@ static int x25_ioctl(struct net_device *dev, struct ifreq *ifr)
 	return -EINVAL;
 }
 
-
 static int __init mod_init(void)
 {
 	register_hdlc_protocol(&proto);
 	return 0;
 }
 
-
-
 static void __exit mod_exit(void)
 {
 	unregister_hdlc_protocol(&proto);
 }
 
-
 module_init(mod_init);
 module_exit(mod_exit);
 
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH net-next 2/6] net: hdlc_x25: remove unnecessary out of memory message
  2021-06-04  7:32 [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues Guangbin Huang
  2021-06-04  7:32 ` [PATCH net-next 1/6] net: hdlc_x25: remove redundant blank lines Guangbin Huang
@ 2021-06-04  7:32 ` Guangbin Huang
  2021-06-04  7:32 ` [PATCH net-next 3/6] net: hdlc_x25: move out assignment in if condition Guangbin Huang
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-04  7:32 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

This patch removes unnecessary out of memory message,
to fix the following checkpatch.pl warning:
"WARNING: Possible unnecessary 'out of memory' message"

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_x25.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
index 86b88f2..525eb42 100644
--- a/drivers/net/wan/hdlc_x25.c
+++ b/drivers/net/wan/hdlc_x25.c
@@ -56,10 +56,8 @@ static void x25_connect_disconnect(struct net_device *dev, int reason, int code)
 	unsigned char *ptr;
 
 	skb = __dev_alloc_skb(1, GFP_ATOMIC | __GFP_NOMEMALLOC);
-	if (!skb) {
-		netdev_err(dev, "out of memory\n");
+	if (!skb)
 		return;
-	}
 
 	ptr = skb_put(skb, 1);
 	*ptr = code;
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH net-next 3/6] net: hdlc_x25: move out assignment in if condition
  2021-06-04  7:32 [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues Guangbin Huang
  2021-06-04  7:32 ` [PATCH net-next 1/6] net: hdlc_x25: remove redundant blank lines Guangbin Huang
  2021-06-04  7:32 ` [PATCH net-next 2/6] net: hdlc_x25: remove unnecessary out of memory message Guangbin Huang
@ 2021-06-04  7:32 ` Guangbin Huang
  2021-06-04  7:32 ` [PATCH net-next 4/6] net: hdlc_x25: add some required spaces Guangbin Huang
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-04  7:32 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

Should not use assignment in if condition.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_x25.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
index 525eb42..24fdb6c 100644
--- a/drivers/net/wan/hdlc_x25.c
+++ b/drivers/net/wan/hdlc_x25.c
@@ -137,13 +137,15 @@ static netdev_tx_t x25_xmit(struct sk_buff *skb, struct net_device *dev)
 	switch (skb->data[0]) {
 	case X25_IFACE_DATA:	/* Data to be transmitted */
 		skb_pull(skb, 1);
-		if ((result = lapb_data_request(dev, skb)) != LAPB_OK)
+		result = lapb_data_request(dev, skb);
+		if (result != LAPB_OK)
 			dev_kfree_skb(skb);
 		spin_unlock_bh(&x25st->up_lock);
 		return NETDEV_TX_OK;
 
 	case X25_IFACE_CONNECT:
-		if ((result = lapb_connect_request(dev))!= LAPB_OK) {
+		result = lapb_connect_request(dev);
+		if (result != LAPB_OK) {
 			if (result == LAPB_CONNECTED)
 				/* Send connect confirm. msg to level 3 */
 				x25_connected(dev, 0);
@@ -154,7 +156,8 @@ static netdev_tx_t x25_xmit(struct sk_buff *skb, struct net_device *dev)
 		break;
 
 	case X25_IFACE_DISCONNECT:
-		if ((result = lapb_disconnect_request(dev)) != LAPB_OK) {
+		result = lapb_disconnect_request(dev);
+		if (result != LAPB_OK) {
 			if (result == LAPB_NOTCONNECTED)
 				/* Send disconnect confirm. msg to level 3 */
 				x25_disconnected(dev, 0);
@@ -237,7 +240,8 @@ static int x25_rx(struct sk_buff *skb)
 	hdlc_device *hdlc = dev_to_hdlc(dev);
 	struct x25_state *x25st = state(hdlc);
 
-	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) {
+	skb = skb_share_check(skb, GFP_ATOMIC);
+	if (!skb) {
 		dev->stats.rx_dropped++;
 		return NET_RX_DROP;
 	}
@@ -333,8 +337,9 @@ static int x25_ioctl(struct net_device *dev, struct ifreq *ifr)
 		if (result)
 			return result;
 
-		if ((result = attach_hdlc_protocol(dev, &proto,
-						   sizeof(struct x25_state))))
+		result = attach_hdlc_protocol(dev, &proto,
+					      sizeof(struct x25_state));
+		if (result)
 			return result;
 
 		memcpy(&state(hdlc)->settings, &new_settings, size);
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH net-next 4/6] net: hdlc_x25: add some required spaces
  2021-06-04  7:32 [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues Guangbin Huang
                   ` (2 preceding siblings ...)
  2021-06-04  7:32 ` [PATCH net-next 3/6] net: hdlc_x25: move out assignment in if condition Guangbin Huang
@ 2021-06-04  7:32 ` Guangbin Huang
  2021-06-04  7:32 ` [PATCH net-next 5/6] net: hdlc_x25: fix the code issue about "if..else.." Guangbin Huang
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-04  7:32 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

Add spaces required around that '='.
Add space required after that ','.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_x25.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
index 24fdb6c..4e771f7 100644
--- a/drivers/net/wan/hdlc_x25.c
+++ b/drivers/net/wan/hdlc_x25.c
@@ -333,7 +333,8 @@ static int x25_ioctl(struct net_device *dev, struct ifreq *ifr)
 				return -EINVAL;
 		}
 
-		result=hdlc->attach(dev, ENCODING_NRZ,PARITY_CRC16_PR1_CCITT);
+		result = hdlc->attach(dev, ENCODING_NRZ,
+				      PARITY_CRC16_PR1_CCITT);
 		if (result)
 			return result;
 
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH net-next 5/6] net: hdlc_x25: fix the code issue about "if..else.."
  2021-06-04  7:32 [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues Guangbin Huang
                   ` (3 preceding siblings ...)
  2021-06-04  7:32 ` [PATCH net-next 4/6] net: hdlc_x25: add some required spaces Guangbin Huang
@ 2021-06-04  7:32 ` Guangbin Huang
  2021-06-04  7:32 ` [PATCH net-next 6/6] net: hdlc_x25: fix the alignment issue Guangbin Huang
  2021-06-04 21:40 ` [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues patchwork-bot+netdevbpf
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-04  7:32 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

According to the chackpatch.pl, else should follow close brace '}'.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_x25.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
index 4e771f7..bd4fad3 100644
--- a/drivers/net/wan/hdlc_x25.c
+++ b/drivers/net/wan/hdlc_x25.c
@@ -310,8 +310,7 @@ static int x25_ioctl(struct net_device *dev, struct ifreq *ifr)
 			new_settings.t1 = 3;
 			new_settings.t2 = 1;
 			new_settings.n2 = 10;
-		}
-		else {
+		} else {
 			if (copy_from_user(&new_settings, x25_s, size))
 				return -EFAULT;
 
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH net-next 6/6] net: hdlc_x25: fix the alignment issue
  2021-06-04  7:32 [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues Guangbin Huang
                   ` (4 preceding siblings ...)
  2021-06-04  7:32 ` [PATCH net-next 5/6] net: hdlc_x25: fix the code issue about "if..else.." Guangbin Huang
@ 2021-06-04  7:32 ` Guangbin Huang
  2021-06-04 21:40 ` [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues patchwork-bot+netdevbpf
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-04  7:32 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

Alignment should match open parenthesis.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_x25.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/net/wan/hdlc_x25.c b/drivers/net/wan/hdlc_x25.c
index bd4fad3..d2bf72b 100644
--- a/drivers/net/wan/hdlc_x25.c
+++ b/drivers/net/wan/hdlc_x25.c
@@ -315,20 +315,20 @@ static int x25_ioctl(struct net_device *dev, struct ifreq *ifr)
 				return -EFAULT;
 
 			if ((new_settings.dce != 0 &&
-			new_settings.dce != 1) ||
-			(new_settings.modulo != 8 &&
-			new_settings.modulo != 128) ||
-			new_settings.window < 1 ||
-			(new_settings.modulo == 8 &&
-			new_settings.window > 7) ||
-			(new_settings.modulo == 128 &&
-			new_settings.window > 127) ||
-			new_settings.t1 < 1 ||
-			new_settings.t1 > 255 ||
-			new_settings.t2 < 1 ||
-			new_settings.t2 > 255 ||
-			new_settings.n2 < 1 ||
-			new_settings.n2 > 255)
+			     new_settings.dce != 1) ||
+			    (new_settings.modulo != 8 &&
+			     new_settings.modulo != 128) ||
+			    new_settings.window < 1 ||
+			    (new_settings.modulo == 8 &&
+			     new_settings.window > 7) ||
+			    (new_settings.modulo == 128 &&
+			     new_settings.window > 127) ||
+			    new_settings.t1 < 1 ||
+			    new_settings.t1 > 255 ||
+			    new_settings.t2 < 1 ||
+			    new_settings.t2 > 255 ||
+			    new_settings.n2 < 1 ||
+			    new_settings.n2 > 255)
 				return -EINVAL;
 		}
 
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues
  2021-06-04  7:32 [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues Guangbin Huang
                   ` (5 preceding siblings ...)
  2021-06-04  7:32 ` [PATCH net-next 6/6] net: hdlc_x25: fix the alignment issue Guangbin Huang
@ 2021-06-04 21:40 ` patchwork-bot+netdevbpf
  6 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-04 21:40 UTC (permalink / raw)
  To: Guangbin Huang
  Cc: davem, kuba, xie.he.0141, ms, willemb, netdev, linux-kernel, lipeng321

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Fri, 4 Jun 2021 15:32:06 +0800 you wrote:
> From: Peng Li <lipeng321@huawei.com>
> 
> This patchset clean up some code style issues.
> 
> Peng Li (6):
>   net: hdlc_x25: remove redundant blank lines
>   net: hdlc_x25: remove unnecessary out of memory message
>   net: hdlc_x25: move out assignment in if condition
>   net: hdlc_x25: add some required spaces
>   net: hdlc_x25: fix the code issue about "if..else.."
>   net: hdlc_x25: fix the alignment issue
> 
> [...]

Here is the summary with links:
  - [net-next,1/6] net: hdlc_x25: remove redundant blank lines
    https://git.kernel.org/netdev/net-next/c/1c906e369815
  - [net-next,2/6] net: hdlc_x25: remove unnecessary out of memory message
    https://git.kernel.org/netdev/net-next/c/579ebffe7973
  - [net-next,3/6] net: hdlc_x25: move out assignment in if condition
    https://git.kernel.org/netdev/net-next/c/ec1f37741244
  - [net-next,4/6] net: hdlc_x25: add some required spaces
    https://git.kernel.org/netdev/net-next/c/5de446075c8e
  - [net-next,5/6] net: hdlc_x25: fix the code issue about "if..else.."
    https://git.kernel.org/netdev/net-next/c/792b070fca8f
  - [net-next,6/6] net: hdlc_x25: fix the alignment issue
    https://git.kernel.org/netdev/net-next/c/316fe3cc7de3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-06-04 21:40 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04  7:32 [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues Guangbin Huang
2021-06-04  7:32 ` [PATCH net-next 1/6] net: hdlc_x25: remove redundant blank lines Guangbin Huang
2021-06-04  7:32 ` [PATCH net-next 2/6] net: hdlc_x25: remove unnecessary out of memory message Guangbin Huang
2021-06-04  7:32 ` [PATCH net-next 3/6] net: hdlc_x25: move out assignment in if condition Guangbin Huang
2021-06-04  7:32 ` [PATCH net-next 4/6] net: hdlc_x25: add some required spaces Guangbin Huang
2021-06-04  7:32 ` [PATCH net-next 5/6] net: hdlc_x25: fix the code issue about "if..else.." Guangbin Huang
2021-06-04  7:32 ` [PATCH net-next 6/6] net: hdlc_x25: fix the alignment issue Guangbin Huang
2021-06-04 21:40 ` [PATCH net-next 0/6] net: hdlc_x25: clean up some code style issues patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.