From: patchwork-bot+netdevbpf@kernel.org
To: wangyunjian <wangyunjian@huawei.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
maximmi@nvidia.com, tariqt@nvidia.com, xiyou.wangcong@gmail.com,
jhs@mojatatu.com, dingxiaoxiong@huawei.com
Subject: Re: [PATCH net] sch_htb: fix refcount leak in htb_parent_to_leaf_offload
Date: Fri, 04 Jun 2021 21:50:04 +0000 [thread overview]
Message-ID: <162284340414.5449.12585313149011194303.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <1622804598-11164-1-git-send-email-wangyunjian@huawei.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 4 Jun 2021 19:03:18 +0800 you wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> The commit ae81feb7338c ("sch_htb: fix null pointer dereference
> on a null new_q") fixes a NULL pointer dereference bug, but it
> is not correct.
>
> Because htb_graft_helper properly handles the case when new_q
> is NULL, and after the previous patch by skipping this call
> which creates an inconsistency : dev_queue->qdisc will still
> point to the old qdisc, but cl->parent->leaf.q will point to
> the new one (which will be noop_qdisc, because new_q was NULL).
> The code is based on an assumption that these two pointers are
> the same, so it can lead to refcount leaks.
>
> [...]
Here is the summary with links:
- [net] sch_htb: fix refcount leak in htb_parent_to_leaf_offload
https://git.kernel.org/netdev/net/c/944d671d5faa
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-06-04 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 11:03 [PATCH net] sch_htb: fix refcount leak in htb_parent_to_leaf_offload wangyunjian
2021-06-04 21:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162284340414.5449.12585313149011194303.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=dingxiaoxiong@huawei.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@nvidia.com \
--cc=wangyunjian@huawei.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.