From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com. [115.124.30.43]) by gmr-mx.google.com with ESMTPS id j15si809996pll.3.2021.06.06.22.56.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jun 2021 22:56:32 -0700 (PDT) From: Yang Li Subject: [PATCH v2] NTB: Fix an error code in ntb_msit_probe() Date: Mon, 7 Jun 2021 13:56:20 +0800 Message-Id: <1623045380-125394-1-git-send-email-yang.lee@linux.alibaba.com> To: jdmason@kudzu.us Cc: dave.jiang@intel.com, allenbh@gmail.com, logang@deltatee.com, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, Yang Li List-ID: When the value of nm->isr_ctx is false, the value of ret is 0. So, we set ret to -ENOMEM to indicate this error. Clean up smatch warning: drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Yang Li --- Change in v2: --revise typo drivers/ntb/test/ntb_msi_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c index 7095ecd..4e18e08 100644 --- a/drivers/ntb/test/ntb_msi_test.c +++ b/drivers/ntb/test/ntb_msi_test.c @@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb) if (ret) goto remove_dbgfs; - if (!nm->isr_ctx) + if (!nm->isr_ctx) { + ret = -ENOMEM; goto remove_dbgfs; + } ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO); -- 1.8.3.1