* [PATCH -next,resend] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe()
@ 2021-06-08 8:48 ` ChenXiaoSong
0 siblings, 0 replies; 4+ messages in thread
From: ChenXiaoSong @ 2021-06-08 8:48 UTC (permalink / raw)
To: agross, bjorn.andersson, will, mark.rutland
Cc: linux-arm-msm, linux-arm-kernel, linux-kernel, yukuai3, yi.zhang,
chenxiaosong2
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
---
drivers/perf/qcom_l3_pmu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c
index 081273543c6b..c76f6f21d2a8 100644
--- a/drivers/perf/qcom_l3_pmu.c
+++ b/drivers/perf/qcom_l3_pmu.c
@@ -767,10 +767,8 @@ static int qcom_l3_cache_pmu_probe(struct platform_device *pdev)
memrc = platform_get_resource(pdev, IORESOURCE_MEM, 0);
l3pmu->regs = devm_ioremap_resource(&pdev->dev, memrc);
- if (IS_ERR(l3pmu->regs)) {
- dev_err(&pdev->dev, "Can't map PMU @%pa\n", &memrc->start);
+ if (IS_ERR(l3pmu->regs))
return PTR_ERR(l3pmu->regs);
- }
qcom_l3_cache__init(l3pmu);
--
2.25.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next, resend] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe()
@ 2021-06-08 8:48 ` ChenXiaoSong
0 siblings, 0 replies; 4+ messages in thread
From: ChenXiaoSong @ 2021-06-08 8:48 UTC (permalink / raw)
To: agross, bjorn.andersson, will, mark.rutland
Cc: linux-arm-msm, linux-arm-kernel, linux-kernel, yukuai3, yi.zhang,
chenxiaosong2
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
---
drivers/perf/qcom_l3_pmu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c
index 081273543c6b..c76f6f21d2a8 100644
--- a/drivers/perf/qcom_l3_pmu.c
+++ b/drivers/perf/qcom_l3_pmu.c
@@ -767,10 +767,8 @@ static int qcom_l3_cache_pmu_probe(struct platform_device *pdev)
memrc = platform_get_resource(pdev, IORESOURCE_MEM, 0);
l3pmu->regs = devm_ioremap_resource(&pdev->dev, memrc);
- if (IS_ERR(l3pmu->regs)) {
- dev_err(&pdev->dev, "Can't map PMU @%pa\n", &memrc->start);
+ if (IS_ERR(l3pmu->regs))
return PTR_ERR(l3pmu->regs);
- }
qcom_l3_cache__init(l3pmu);
--
2.25.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next,resend] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe()
2021-06-08 8:48 ` [PATCH -next, resend] " ChenXiaoSong
@ 2021-06-08 13:21 ` Will Deacon
-1 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2021-06-08 13:21 UTC (permalink / raw)
To: agross, bjorn.andersson, mark.rutland, ChenXiaoSong
Cc: catalin.marinas, kernel-team, Will Deacon, linux-kernel,
linux-arm-msm, yi.zhang, linux-arm-kernel, yukuai3
On Tue, 8 Jun 2021 16:48:16 +0800, ChenXiaoSong wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Applied to will (for-next/perf), thanks!
[1/1] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe()
https://git.kernel.org/will/c/5ca54404e68d
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next, resend] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe()
@ 2021-06-08 13:21 ` Will Deacon
0 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2021-06-08 13:21 UTC (permalink / raw)
To: agross, bjorn.andersson, mark.rutland, ChenXiaoSong
Cc: catalin.marinas, kernel-team, Will Deacon, linux-kernel,
linux-arm-msm, yi.zhang, linux-arm-kernel, yukuai3
On Tue, 8 Jun 2021 16:48:16 +0800, ChenXiaoSong wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Applied to will (for-next/perf), thanks!
[1/1] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe()
https://git.kernel.org/will/c/5ca54404e68d
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-08 13:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 8:48 [PATCH -next,resend] perf: qcom: Remove redundant dev_err call in qcom_l3_cache_pmu_probe() ChenXiaoSong
2021-06-08 8:48 ` [PATCH -next, resend] " ChenXiaoSong
2021-06-08 13:21 ` [PATCH -next,resend] " Will Deacon
2021-06-08 13:21 ` [PATCH -next, resend] " Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.