From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9FCC47082 for ; Tue, 8 Jun 2021 14:12:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1525D61078 for ; Tue, 8 Jun 2021 14:12:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233192AbhFHOOL (ORCPT ); Tue, 8 Jun 2021 10:14:11 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:15428 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S233116AbhFHOOK (ORCPT ); Tue, 8 Jun 2021 10:14:10 -0400 X-UUID: f0859c30d7544e64ae8c995afce1b066-20210608 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=mBat+eB3UkQSKYEG6CFPmRw5xt3ns69b4y1m/7XycKY=; b=ptobHaLejpV/EeLUjTP7cUPZlG/mkadKVfFy0402PdrFT//4WDXRQzFxHwJb/aupjkTiFornA2GE2YGr+Y28Eyemy6H0cH0YCHnyaHXN6bln6UuHJrbKeJ9EHFl8hwjKpZEOg74Np/IaRj+/ew7yBOkOasQLeOVEuXJIH6WaG4E=; X-UUID: f0859c30d7544e64ae8c995afce1b066-20210608 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 34508918; Tue, 08 Jun 2021 22:10:40 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 22:10:30 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Jun 2021 22:10:29 +0800 Message-ID: <1623161430.7079.15.camel@mhfsdcap03> Subject: Re: [PATCH v1 1/4] mtk-mdp: add driver to probe mdp components From: houlong wei To: Enric Balletbo i Serra CC: Eizan Miyamoto , "linux-kernel@vger.kernel.org" , "chunkuang.hu@kernel.org" , Yong Wu =?UTF-8?Q?=28=E5=90=B4=E5=8B=87=29?= , "Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?=" , Matthias Brugger , Mauro Carvalho Chehab , "Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?=" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" Date: Tue, 8 Jun 2021 22:10:30 +0800 In-Reply-To: References: <20210423055842.2490679-1-eizan@chromium.org> <20210423155824.v1.1.Ie6d1e6e39cf9b5d6b2108ae1096af34c3d55880b@changeid> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3E98DB750DA19B3141B7532FA5318727E6713158E0387F4DA7E5011D6584DEA32000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgRWl6YW4sDQoNClRoYW5rcyBmb3IgeW91ciBwYXRjaC4gSSBoYXZlIGlubGluZSBjb21tZW50 cyBiZWxvdy4NCg0KSG91bG9uZw0KDQoNCk9uIEZyaSwgMjAyMS0wNS0xNCBhdCAxNjoxOSArMDgw MCwgRW5yaWMgQmFsbGV0Ym8gaSBTZXJyYSB3cm90ZToNCj4gSGkgRWl6YW4sDQo+IA0KPiBUaGFu ayBreW91IGZvciB5b3VyIHBhdGNoLg0KPiANCj4gT24gMjMvNC8yMSA3OjU4LCBFaXphbiBNaXlh bW90byB3cm90ZToNCj4gPiBCcm9hZGx5LCB0aGlzIHBhdGNoICgxKSBhZGRzIGEgZHJpdmVyIGZv ciB2YXJpb3VzIE1USyBNRFAgY29tcG9uZW50cyB0bw0KPiA+IGdvIGFsb25nc2lkZSB0aGUgbWFp biBNVEsgTURQIGRyaXZlciwgYW5kICgyKSBob29rcyB0aGVtIGFsbCB0b2dldGhlcg0KPiA+IHVz aW5nIHRoZSBjb21wb25lbnQgZnJhbWV3b3JrLg0KPiA+IA0KPiA+ICgxKSBVcCB1bnRpbCBub3cs IHRoZSBNVEsgTURQIGRyaXZlciBjb250cm9scyA4IGRldmljZXMgaW4gdGhlIGRldmljZQ0KPiA+ IHRyZWUgb24gaXRzIG93bi4gV2hlbiBydW5uaW5nIHRlc3RzIGZvciB0aGUgaGFyZHdhcmUgdmlk ZW8gZGVjb2Rlciwgd2UNCj4gPiBmb3VuZCB0aGF0IHRoZSBpb21tdXMgYW5kIExBUkJzIHdlcmUg bm90IGJlaW5nIHByb3Blcmx5IGNvbmZpZ3VyZWQuIFRvDQo+ID4gY29uZmlndXJlIHRoZW0sIGEg ZHJpdmVyIGZvciBlYWNoIGJlIGFkZGVkIHRvIG10a19tZHBfY29tcCBzbyB0aGF0DQo+ID4gbXRr X2lvbW11X2FkZF9kZXZpY2UoKSBjYW4gKGV2ZW50dWFsbHkpIGJlIGNhbGxlZCBmcm9tIGRtYV9j b25maWd1cmUoKQ0KPiA+IGluc2lkZSByZWFsbHlfcHJvYmUoKS4NCj4gPiANCj4gPiAoMikgVGhl IGludGVncmF0aW9uIGludG8gdGhlIGNvbXBvbmVudCBmcmFtZXdvcmsgYWxsb3dzIHVzIHRvIGRl ZmVyIHRoZQ0KPiA+IHJlZ2lzdHJhdGlvbiB3aXRoIHRoZSB2NGwyIHN1YnN5c3RlbSB1bnRpbCBh bGwgdGhlIE1EUC1yZWxhdGVkIGRldmljZXMNCj4gPiBoYXZlIGJlZW4gcHJvYmVkLCBzbyB0aGF0 IHRoZSByZWxldmFudCBkZXZpY2Ugbm9kZSBkb2VzIG5vdCBiZWNvbWUNCj4gPiBhdmFpbGFibGUg dW50aWwgaW5pdGlhbGl6YXRpb24gb2YgYWxsIHRoZSBjb21wb25lbnRzIGlzIGNvbXBsZXRlLg0K PiA+IA0KPiA+IFNvbWUgbm90ZXMgYWJvdXQgaG93IHRoZSBjb21wb25lbnQgZnJhbWV3b3JrIGhh cyBiZWVuIGludGVncmF0ZWQ6DQo+ID4gDQo+ID4gLSBUaGUgZHJpdmVyIGZvciB0aGUgcmRtYTAg Y29tcG9uZW50IHNlcnZlcyBkb3VibGUgZHV0eSBhcyB0aGUgIm1hc3RlciINCj4gPiAgIChhZ2dy ZWdhdGUpIGRyaXZlciBhcyB3ZWxsIGFzIGEgY29tcG9uZW50IGRyaXZlci4gVGhpcyBpcyBhIG5v bi1pZGVhbA0KPiA+ICAgY29tcHJvbWlzZSB1bnRpbCBhIGJldHRlciBzb2x1dGlvbiBpcyBkZXZl bG9wZWQuIFRoaXMgZGV2aWNlIGlzDQo+ID4gICBkaWZmZXJlbnRpYXRlZCBmcm9tIHRoZSByZXN0 IGJ5IGNoZWNraW5nIGZvciBhICJtZWRpYXRlayx2cHUiIHByb3BlcnR5DQo+ID4gICBpbiB0aGUg ZGV2aWNlIG5vZGUuDQo+ID4gDQo+ID4gLSBUaGUgbGlzdCBvZiBtZHAgY29tcG9uZW50cyByZW1h aW5zIGhhcmQtY29kZWQgYXMgbXRrX21kcF9jb21wX2R0X2lkc1tdDQo+ID4gICBpbiBtdGtfbWRw X2NvcmUuYywgYW5kIGFzIG10a19tZHBfY29tcF9kcml2ZXJfZHRfbWF0Y2hbXSBpbg0KPiA+ICAg bXRrX21kcF9jb21wLmMuIFRoaXMgdW5mb3J0dW5hdGUgZHVwbGljYXRpb24gb2YgaW5mb3JtYXRp b24gaXMNCj4gPiAgIGFkZHJlc3NlZCBpbiBhIGZvbGxvd2luZyBwYXRjaCBpbiB0aGlzIHNlcmll cy4NCj4gPiANCj4gPiAtIFRoZSBjb21wb25lbnQgZHJpdmVyIGNhbGxzIGNvbXBvbmVudF9hZGQo KSBmb3IgZWFjaCBkZXZpY2UgdGhhdCBpcw0KPiA+ICAgcHJvYmVkLg0KPiA+IA0KPiA+IC0gSW4g bXRrX21kcF9wcm9iZSAodGhlICJtYXN0ZXIiIGRldmljZSksIHdlIHNjYW4gdGhlIGRldmljZSB0 cmVlIGZvcg0KPiA+ICAgYW55IG1hdGNoaW5nIG5vZGVzIGFnYWluc3QgbXRrX21kcF9jb21wX2R0 X2lkcywgYW5kIGFkZCBjb21wb25lbnQNCj4gPiAgIG1hdGNoZXMgZm9yIHRoZW0uIFRoZSBtYXRj aCBjcml0ZXJpYSBpcyBhIG1hdGNoaW5nIGRldmljZSBub2RlDQo+ID4gICBwb2ludGVyLg0KPiA+ IA0KPiA+IC0gV2hlbiB0aGUgc2V0IG9mIGNvbXBvbmVudHMgZGV2aWNlcyB0aGF0IGhhdmUgYmVl biBwcm9iZWQgY29ycmVzcG9uZHMNCj4gPiAgIHdpdGggdGhlIGxpc3QgdGhhdCBpcyBnZW5lcmF0 ZWQgYnkgdGhlICJtYXN0ZXIiLCB0aGUgY2FsbGJhY2sgdG8NCj4gPiAgIG10a19tZHBfbWFzdGVy X2JpbmQoKSBpcyBtYWRlLCB3aGljaCB0aGVuIGNhbGxzIHRoZSBjb21wb25lbnQgYmluZA0KPiA+ ICAgZnVuY3Rpb25zLg0KPiA+IA0KPiA+IC0gSW5zaWRlIG10a19tZHBfbWFzdGVyX2JpbmQoKSwg b25jZSBhbGwgdGhlIGNvbXBvbmVudCBiaW5kIGZ1bmN0aW9ucw0KPiA+ICAgaGF2ZSBiZWVuIGNh bGxlZCwgd2UgY2FuIHRoZW4gcmVnaXN0ZXIgb3VyIGRldmljZSB0byB0aGUgdjRsMg0KPiA+ICAg c3Vic3lzdGVtLg0KPiA+IA0KPiA+IC0gVGhlIGNhbGwgdG8gcG1fcnVudGltZV9lbmFibGUoKSBp biB0aGUgbWFzdGVyIGRldmljZSBpcyBjYWxsZWQgYWZ0ZXINCj4gPiAgIGFsbCB0aGUgY29tcG9u ZW50cyBoYXZlIGJlZW4gcmVnaXN0ZXJlZCBieSB0aGVpciBiaW5kKCkgZnVuY3Rpb25zDQo+ID4g ICBjYWxsZWQgYnkgbXRrX210cF9tYXN0ZXJfYmluZCgpLiBBcyBhIHJlc3VsdCwgdGhlIGxpc3Qg b2YgY29tcG9uZW50cw0KPiA+ICAgd2lsbCBub3QgY2hhbmdlIHdoaWxlIHBvd2VyIG1hbmFnZW1l bnQgY2FsbGJhY2tzIG10a19tZHBfc3VzcGVuZCgpLw0KPiA+ICAgcmVzdW1lKCkgYXJlIGFjY2Vz c2luZyB0aGUgbGlzdCBvZiBjb21wb25lbnRzLg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IEVp emFuIE1peWFtb3RvIDxlaXphbkBjaHJvbWl1bS5vcmc+DQo+ID4gLS0tDQo+ID4gDQo+ID4gIGRy aXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLW1kcC9tdGtfbWRwX2NvbXAuYyB8IDEzOSArKysrKysr KysrKystLQ0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay1tZHAvbXRrX21kcF9jb21w LmggfCAgMjYgKy0tDQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLW1kcC9tdGtfbWRw X2NvcmUuYyB8IDE3NSArKysrKysrKysrKysrLS0tLS0NCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0 Zm9ybS9tdGstbWRwL210a19tZHBfY29yZS5oIHwgICAxICsNCj4gPiAgNCBmaWxlcyBjaGFuZ2Vk LCAyNTUgaW5zZXJ0aW9ucygrKSwgODYgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLW1kcC9tdGtfbWRwX2NvbXAuYyBiL2RyaXZl cnMvbWVkaWEvcGxhdGZvcm0vbXRrLW1kcC9tdGtfbWRwX2NvbXAuYw0KPiA+IGluZGV4IDFlMzgz M2YxYzlhZS4uM2ZiYmNmMDU0NDBhIDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxh dGZvcm0vbXRrLW1kcC9tdGtfbWRwX2NvbXAuYw0KPiA+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxh dGZvcm0vbXRrLW1kcC9tdGtfbWRwX2NvbXAuYw0KPiA+IEBAIC01LDEzICs1LDUxIEBADQo+ID4g ICAqLw0KPiA+ICANCj4gPiAgI2luY2x1ZGUgPGxpbnV4L2Nsay5oPg0KPiA+ICsjaW5jbHVkZSA8 bGludXgvY29tcG9uZW50Lmg+DQo+ID4gICNpbmNsdWRlIDxsaW51eC9kZXZpY2UuaD4NCj4gPiAt I2luY2x1ZGUgPGxpbnV4L29mLmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4NCj4g PiAgI2luY2x1ZGUgPGxpbnV4L29mX2FkZHJlc3MuaD4NCj4gPiArI2luY2x1ZGUgPGxpbnV4L29m X2RldmljZS5oPg0KPiA+ICsjaW5jbHVkZSA8bGludXgvb2YuaD4NCj4gPiArI2luY2x1ZGUgPGxp bnV4L29mX2lycS5oPg0KPiA+ICAjaW5jbHVkZSA8bGludXgvb2ZfcGxhdGZvcm0uaD4NCj4gPiAg DQo+ID4gICNpbmNsdWRlICJtdGtfbWRwX2NvbXAuaCINCj4gPiArI2luY2x1ZGUgIm10a19tZHBf Y29yZS5oIg0KPiA+ICsNCj4gPiArLyoqDQo+ID4gKyAqIGVudW0gbXRrX21kcF9jb21wX3R5cGUg LSB0aGUgTURQIGNvbXBvbmVudA0KPiA+ICsgKiBATVRLX01EUF9SRE1BOgkJUmVhZCBETUENCj4g PiArICogQE1US19NRFBfUlNaOgkJUmVzemVyDQoNClJlc3plciBpcyB0aGUgdHlwbyBmb3IgUmVz aXplci4gQ2FuIHlvdSBoZWxwIHRvIGZpeCBpdCwgYWx0aG91Z2ggaXQNCmFscmVhZHkgZXhpc3Rz IGluIHRoZSBvcmlnaW5hbCB2ZXJzaW9uID8NCg0KPiA+ICsgKiBATVRLX01EUF9XRE1BOgkJV3Jp dGUgRE1BDQo+ID4gKyAqIEBNVEtfTURQX1dST1Q6CQlXcml0ZSBETUEgd2l0aCByb3RhdGlvbg0K PiA+ICsgKiBATVRLX01EUF9DT01QX1RZUEVfTUFYOglQbGFjZWhvbGRlciBmb3IgbnVtIGVsZW1z IGluIHRoaXMgZW51bQ0KPiA+ICsgKi8NCj4gPiArZW51bSBtdGtfbWRwX2NvbXBfdHlwZSB7DQo+ ID4gKwlNVEtfTURQX1JETUEsDQo+ID4gKwlNVEtfTURQX1JTWiwNCj4gPiArCU1US19NRFBfV0RN QSwNCj4gPiArCU1US19NRFBfV1JPVCwNCj4gPiArCU1US19NRFBfQ09NUF9UWVBFX01BWCwNCj4g PiArfTsNCj4gPiAgDQo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIG10a19t ZHBfY29tcF9kcml2ZXJfZHRfbWF0Y2hbXSA9IHsNCj4gPiArCXsNCj4gPiArCQkuY29tcGF0aWJs ZSA9ICJtZWRpYXRlayxtdDgxNzMtbWRwLXJkbWEiLA0KPiA+ICsJCS5kYXRhID0gKHZvaWQgKilN VEtfTURQX1JETUENCj4gPiArCX0sIHsNCj4gPiArCQkuY29tcGF0aWJsZSA9ICJtZWRpYXRlayxt dDgxNzMtbWRwLXJzeiIsDQo+ID4gKwkJLmRhdGEgPSAodm9pZCAqKU1US19NRFBfUlNaDQo+ID4g Kwl9LCB7DQo+ID4gKwkJLmNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQ4MTczLW1kcC13ZG1hIiwN Cj4gPiArCQkuZGF0YSA9ICh2b2lkICopTVRLX01EUF9XRE1BDQo+ID4gKwl9LCB7DQo+ID4gKwkJ LmNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQ4MTczLW1kcC13cm90IiwNCj4gPiArCQkuZGF0YSA9 ICh2b2lkICopTVRLX01EUF9XUk9UDQo+ID4gKwl9LA0KPiA+ICsJeyB9DQo+ID4gK307DQo+ID4g K01PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIG10a19tZHBfY29tcF9kcml2ZXJfZHRfbWF0Y2gpOw0K PiA+ICANCj4gPiAgdm9pZCBtdGtfbWRwX2NvbXBfY2xvY2tfb24oc3RydWN0IGRldmljZSAqZGV2 LCBzdHJ1Y3QgbXRrX21kcF9jb21wICpjb21wKQ0KPiA+ICB7DQo+ID4gQEAgLTIzLDggKzYxLDgg QEAgdm9pZCBtdGtfbWRwX2NvbXBfY2xvY2tfb24oc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3Qg bXRrX21kcF9jb21wICpjb21wKQ0KPiA+ICAJCWVyciA9IGNsa19wcmVwYXJlX2VuYWJsZShjb21w LT5jbGtbaV0pOw0KPiA+ICAJCWlmIChlcnIpDQo+ID4gIAkJCWRldl9lcnIoZGV2LA0KPiA+IC0J CQkiZmFpbGVkIHRvIGVuYWJsZSBjbG9jaywgZXJyICVkLiB0eXBlOiVkIGk6JWRcbiIsDQo+ID4g LQkJCQllcnIsIGNvbXAtPnR5cGUsIGkpOw0KPiA+ICsJCQkJImZhaWxlZCB0byBlbmFibGUgY2xv Y2ssIGVyciAlZC4gaTolZFxuIiwNCj4gPiArCQkJCWVyciwgaSk7DQo+IA0KPiBJIHRoaW5rIHlv dWNhbiB0YWtlIGFkdmFudGFnZSBvZiB0aGUgbmV3IGxpbmUgbGVuZ2h0IGxpbWl0IGFuZCBwdXQg YWxsIGluIG9uZQ0KPiBsaW5lIGhlcmUuDQo+IA0KPiANCj4gPiAgCX0NCj4gPiAgfQ0KPiA+ICAN Cj4gPiBAQCAtMzksMTUgKzc3LDQwIEBAIHZvaWQgbXRrX21kcF9jb21wX2Nsb2NrX29mZihzdHJ1 Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBtdGtfbWRwX2NvbXAgKmNvbXApDQo+ID4gIAl9DQo+ID4g IH0NCj4gPiAgDQo+ID4gLWludCBtdGtfbWRwX2NvbXBfaW5pdChzdHJ1Y3QgZGV2aWNlICpkZXYs IHN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZSwNCj4gPiAtCQkgICAgICBzdHJ1Y3QgbXRrX21kcF9j b21wICpjb21wLA0KPiA+IC0JCSAgICAgIGVudW0gbXRrX21kcF9jb21wX3R5cGUgY29tcF90eXBl KQ0KPiA+ICtzdGF0aWMgaW50IG10a19tZHBfY29tcF9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwg c3RydWN0IGRldmljZSAqbWFzdGVyLA0KPiA+ICsJCQl2b2lkICpkYXRhKQ0KPiA+ICt7DQo+ID4g KwlzdHJ1Y3QgbXRrX21kcF9jb21wICpjb21wID0gZGV2X2dldF9kcnZkYXRhKGRldik7DQo+ID4g KwlzdHJ1Y3QgbXRrX21kcF9kZXYgKm1kcCA9IGRhdGE7DQo+ID4gKw0KPiA+ICsJbXRrX21kcF9y ZWdpc3Rlcl9jb21wb25lbnQobWRwLCBjb21wKTsNCj4gPiArDQo+ID4gKwlyZXR1cm4gMDsNCj4g PiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIHZvaWQgbXRrX21kcF9jb21wX3VuYmluZChzdHJ1Y3Qg ZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3RlciwNCj4gPiArCQkJICAgdm9pZCAqZGF0 YSkNCj4gPiArew0KPiA+ICsJc3RydWN0IG10a19tZHBfZGV2ICptZHAgPSBkYXRhOw0KPiA+ICsJ c3RydWN0IG10a19tZHBfY29tcCAqY29tcCA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOw0KPiA+ICsN Cj4gPiArCW10a19tZHBfdW5yZWdpc3Rlcl9jb21wb25lbnQobWRwLCBjb21wKTsNCj4gPiArfQ0K PiA+ICsNCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBjb21wb25lbnRfb3BzIG10a19tZHBfY29t cG9uZW50X29wcyA9IHsNCj4gPiArCS5iaW5kICAgPSBtdGtfbWRwX2NvbXBfYmluZCwNCj4gPiAr CS51bmJpbmQgPSBtdGtfbWRwX2NvbXBfdW5iaW5kLA0KPiA+ICt9Ow0KPiA+ICsNCj4gPiAraW50 IG10a19tZHBfY29tcF9pbml0KHN0cnVjdCBtdGtfbWRwX2NvbXAgKmNvbXAsIHN0cnVjdCBkZXZp Y2UgKmRldikNCj4gPiAgew0KPiA+ICAJaW50IHJldDsNCj4gPiAgCWludCBpOw0KPiA+ICsJc3Ry dWN0IGRldmljZV9ub2RlICpub2RlID0gZGV2LT5vZl9ub2RlOw0KPiA+ICsJZW51bSBtdGtfbWRw X2NvbXBfdHlwZSBjb21wX3R5cGUgPQ0KPiA+ICsJCSAoZW51bSBtdGtfbWRwX2NvbXBfdHlwZSlv Zl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoZGV2KTsNCj4gPiAgDQo+ID4gLQljb21wLT5kZXZfbm9k ZSA9IG9mX25vZGVfZ2V0KG5vZGUpOw0KPiA+IC0JY29tcC0+dHlwZSA9IGNvbXBfdHlwZTsNCj4g PiArCUlOSVRfTElTVF9IRUFEKCZjb21wLT5ub2RlKTsNCj4gPiAgDQo+ID4gIAlmb3IgKGkgPSAw OyBpIDwgQVJSQVlfU0laRShjb21wLT5jbGspOyBpKyspIHsNCj4gPiAgCQljb21wLT5jbGtbaV0g PSBvZl9jbGtfZ2V0KG5vZGUsIGkpOw0KPiA+IEBAIC01NSwyMyArMTE4LDcxIEBAIGludCBtdGtf bWRwX2NvbXBfaW5pdChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9k ZSwNCj4gPiAgCQkJaWYgKFBUUl9FUlIoY29tcC0+Y2xrW2ldKSAhPSAtRVBST0JFX0RFRkVSKQ0K PiA+ICAJCQkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IGNsb2NrXG4iKTsNCj4gPiAgCQkJ cmV0ID0gUFRSX0VSUihjb21wLT5jbGtbaV0pOw0KPiA+IC0JCQlnb3RvIHB1dF9kZXY7DQo+ID4g KwkJCWdvdG8gZXJyOw0KPiA+ICAJCX0NCj4gPiAgDQo+ID4gIAkJLyogT25seSBSRE1BIG5lZWRz IHR3byBjbG9ja3MgKi8NCj4gPiAtCQlpZiAoY29tcC0+dHlwZSAhPSBNVEtfTURQX1JETUEpDQo+ ID4gKwkJaWYgKGNvbXBfdHlwZSAhPSBNVEtfTURQX1JETUEpDQo+ID4gIAkJCWJyZWFrOw0KPiA+ ICAJfQ0KPiA+ICANCj4gPiAgCXJldHVybiAwOw0KPiA+ICANCj4gPiAtcHV0X2RldjoNCj4gPiAt CW9mX25vZGVfcHV0KGNvbXAtPmRldl9ub2RlKTsNCj4gPiArZXJyOg0KPiA+ICsJZGV2X2Vycihk ZXYsICJlcnIgJWRcbiIsIHJldCk7DQo+IA0KPiBUaGlzIGVycm9yIGlzIHRvbyBnZW5lcmljLiBZ b3UgY2FuIHJlbW92ZS4gQW55d2F5IHlvdSdyZSBwcmludGluZyB0aGUgc2FtZSBlcnJvcg0KPiBj b2RlIGlmIG10a19tZHBfY29tcF9pbml0IGZhaWxzIGluIHByb2JlIGZ1bmN0aW9uLCB0aGVyZSBt YWtlcyBtb3JlIHNlbnNlLg0KPiANCj4gPiAgDQo+ID4gIAlyZXR1cm4gcmV0Ow0KPiA+ICB9DQo+ ID4gIA0KPiA+IC12b2lkIG10a19tZHBfY29tcF9kZWluaXQoc3RydWN0IGRldmljZSAqZGV2LCBz dHJ1Y3QgbXRrX21kcF9jb21wICpjb21wKQ0KPiA+ICtzdGF0aWMgaW50IG10a19tZHBfY29tcF9w cm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0KPiA+ICt7DQo+ID4gKwlzdHJ1Y3Qg ZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Ow0KPiA+ICsJc3RydWN0IGRldmljZV9ub2RlICp2cHVf bm9kZTsNCj4gPiArCWludCBzdGF0dXM7DQo+ID4gKwlzdHJ1Y3QgbXRrX21kcF9jb21wICpjb21w Ow0KPiA+ICsNCj4gPiArCXZwdV9ub2RlID0gb2ZfcGFyc2VfcGhhbmRsZShkZXYtPm9mX25vZGUs ICJtZWRpYXRlayx2cHUiLCAwKTsNCj4gPiArCWlmICh2cHVfbm9kZSkgew0KPiA+ICsJCW9mX25v ZGVfcHV0KHZwdV9ub2RlKTsNCj4gPiArCQkvKg0KPiA+ICsJCSAqIFRoZSBkZXZpY2UgdHJlZSBu b2RlIHdpdGggYSBtZWRpYXRlayx2cHUgcHJvcGVydHkgaXMgZGVlbWVkDQo+ID4gKwkJICogdGhl IE1EUCAibWFzdGVyIiBkZXZpY2UsIHdlIGRvbid0IHdhbnQgdG8gYWRkIGEgY29tcG9uZW50DQo+ ID4gKwkJICogZm9yIGl0IGluIHRoaXMgZnVuY3Rpb24gYmVjYXVzZSB0aGUgaW5pdGlhbGl6YXRp b24gZm9yIHRoZQ0KPiA+ICsJCSAqIG1hc3RlciBpcyBkb25lIGVsc2V3aGVyZS4NCj4gPiArCQkg Ki8NCj4gPiArCQlkZXZfaW5mbyhkZXYsICJ2cHUgbm9kZSBmb3VuZCwgbm90IHByb2JpbmdcbiIp Ow0KPiANCj4gVGhpcyBpcyB0aGUgdGhpbmcgdGhhdCBJJ20gbm90IGNvbXBsZXRlbHkgc3VyZSBp cyBkb2luZyB0aGUgcmlnaHQgdGhpbmcuIEhhdmluZw0KPiBhIERUIHByb3ByaWV0eSB0byBpbmRp Y2F0ZSB0byBza2lwIHRoZSBwcm9iaW5nIGlzIHJlYWxseSB3ZWlyZCB0byBtZS4gQWxzbyB0aGUN Cj4gbmFtZSBpcyBxdWl0ZSBjb25mdXNpbmcuIFdoZW4gSSByZWFkIHRoaXMgbmFtZSBJJ2QgZXhw ZWN0IG1lZGlhdGVrLHZwdSBiZWluZyBhDQo+IHBoYW5kbGUgdG8gdGhlIFZQVSBkZXZpY2Ugbm9k ZS4gSWYgdGhlcmUgaXMgYSBtYXN0ZXIgYW5kIGNoaWxkcyBiZWxvdyBmcm9tDQo+IGhhcmR3YXJl IFBPViwgdGhlIERUIGdyYXBoIHNob3VsZCByZWZsZWN0IHRoYXQsIGlmIHRoaXMgaXMgb25seSBh IHdheSB0bw0KPiBpbnN0YW50aWF0ZSBwcm9wZXJseSB0aGUgZGV2aWNlcyB0aGVuIEkgdGhpbmsg d2UgY2FuIGZpbmQgb3RoZXIgc29sdXRpb25zLiBJZg0KPiB5b3Uga25vdyB0aGF0IFJETUEgaXMg YWx3YXlzIHRoZSBtYXN0ZXIgbWF5YmUgd2UgY2FuIGp1c3QgZmluZCB0aGlzIG5vZGUuDQo+IA0K PiBPdGhlciB0aG91Z2h0cz8NCj4gDQoNCk9uZSB3YXkgdG8ganVkZ2UgaXQgaXMgdG8gY29tcGFy ZSB0aGUgb2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKGRldikgd2l0aA0KTVRLX01EUF9SRE1BLg0K DQo+IA0KPiA+ICsJCXJldHVybiAtRU5PREVWOw0KPiA+ICsJfQ0KPiA+ICsNCj4gPiArCWNvbXAg PSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKmNvbXApLCBHRlBfS0VSTkVMKTsNCj4gPiArCWlm ICghY29tcCkNCj4gPiArCQlyZXR1cm4gLUVOT01FTTsNCj4gPiArDQo+ID4gKwlzdGF0dXMgPSBt dGtfbWRwX2NvbXBfaW5pdChjb21wLCBkZXYpOw0KPiA+ICsJaWYgKHN0YXR1cykgew0KPiA+ICsJ CWRldl9lcnIoZGV2LCAiRmFpbGVkIHRvIGluaXRpYWxpemUgY29tcG9uZW50OiAlZFxuIiwgc3Rh dHVzKTsNCj4gPiArCQlyZXR1cm4gc3RhdHVzOw0KPiA+ICsJfQ0KPiA+ICsNCj4gPiArCWRldl9z ZXRfZHJ2ZGF0YShkZXYsIGNvbXApOw0KPiA+ICsNCj4gPiArCXJldHVybiBjb21wb25lbnRfYWRk KGRldiwgJm10a19tZHBfY29tcG9uZW50X29wcyk7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRp YyBpbnQgbXRrX21kcF9jb21wX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0K PiA+ICB7DQo+ID4gLQlvZl9ub2RlX3B1dChjb21wLT5kZXZfbm9kZSk7DQo+ID4gKwlzdHJ1Y3Qg ZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Ow0KPiA+ICsNCj4gPiArCWNvbXBvbmVudF9kZWwoZGV2 LCAmbXRrX21kcF9jb21wb25lbnRfb3BzKTsNCj4gPiArCXJldHVybiAwOw0KPiA+ICB9DQo+ID4g Kw0KPiA+ICtzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIG10a19tZHBfY29tcG9uZW50X2RyaXZlciA9 IHsNCj4gPiArCS5wcm9iZSAgICAgICAgICA9IG10a19tZHBfY29tcF9wcm9iZSwNCj4gPiArCS5y ZW1vdmUgICAgICAgICA9IG10a19tZHBfY29tcF9yZW1vdmUsDQo+ID4gKwkuZHJpdmVyICAgICAg ICAgPSB7DQo+ID4gKwkJLm5hbWUgICA9ICJtZWRpYXRlay1tZHAtY29tcCIsDQo+ID4gKwkJLm93 bmVyICA9IFRISVNfTU9EVUxFLA0KPiA+ICsJCS5vZl9tYXRjaF90YWJsZSA9IG10a19tZHBfY29t cF9kcml2ZXJfZHRfbWF0Y2gsDQo+ID4gKwl9LA0KPiA+ICt9Ow0KPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay1tZHAvbXRrX21kcF9jb21wLmggYi9kcml2ZXJzL21l ZGlhL3BsYXRmb3JtL210ay1tZHAvbXRrX21kcF9jb21wLmgNCj4gPiBpbmRleCAzNmJjMWI4ZjYy MjIuLjk1NmQyMGMwMWUzNCAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3Jt L210ay1tZHAvbXRrX21kcF9jb21wLmgNCj4gPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3Jt L210ay1tZHAvbXRrX21kcF9jb21wLmgNCj4gPiBAQCAtNyw0MSArNywyMSBAQA0KPiA+ICAjaWZu ZGVmIF9fTVRLX01EUF9DT01QX0hfXw0KPiA+ICAjZGVmaW5lIF9fTVRLX01EUF9DT01QX0hfXw0K PiA+ICANCj4gPiAtLyoqDQo+ID4gLSAqIGVudW0gbXRrX21kcF9jb21wX3R5cGUgLSB0aGUgTURQ IGNvbXBvbmVudA0KPiA+IC0gKiBATVRLX01EUF9SRE1BOglSZWFkIERNQQ0KPiA+IC0gKiBATVRL X01EUF9SU1o6CVJpc3plcg0KPiA+IC0gKiBATVRLX01EUF9XRE1BOglXcml0ZSBETUENCj4gPiAt ICogQE1US19NRFBfV1JPVDoJV3JpdGUgRE1BIHdpdGggcm90YXRpb24NCj4gPiAtICovDQo+ID4g LWVudW0gbXRrX21kcF9jb21wX3R5cGUgew0KPiA+IC0JTVRLX01EUF9SRE1BLA0KPiA+IC0JTVRL X01EUF9SU1osDQo+ID4gLQlNVEtfTURQX1dETUEsDQo+ID4gLQlNVEtfTURQX1dST1QsDQo+ID4g LQlNVEtfTURQX0NPTVBfVFlQRV9NQVgsDQo+ID4gLX07DQo+ID4gLQ0KPiA+ICAvKioNCj4gPiAg ICogc3RydWN0IG10a19tZHBfY29tcCAtIHRoZSBNRFAncyBmdW5jdGlvbiBjb21wb25lbnQgZGF0 YQ0KPiA+ICAgKiBAbm9kZToJbGlzdCBub2RlIHRvIHRyYWNrIHNpYmluZyBNRFAgY29tcG9uZW50 cw0KPiA+IC0gKiBAZGV2X25vZGU6CWNvbXBvbmVudCBkZXZpY2Ugbm9kZQ0KPiA+ICAgKiBAY2xr OgljbG9ja3MgcmVxdWlyZWQgZm9yIGNvbXBvbmVudA0KPiA+IC0gKiBAdHlwZToJY29tcG9uZW50 IHR5cGUNCj4gPiAgICovDQo+ID4gIHN0cnVjdCBtdGtfbWRwX2NvbXAgew0KPiA+ICAJc3RydWN0 IGxpc3RfaGVhZAlub2RlOw0KPiA+IC0Jc3RydWN0IGRldmljZV9ub2RlCSpkZXZfbm9kZTsNCj4g PiAgCXN0cnVjdCBjbGsJCSpjbGtbMl07DQo+ID4gLQllbnVtIG10a19tZHBfY29tcF90eXBlCXR5 cGU7DQo+ID4gIH07DQo+ID4gIA0KPiA+IC1pbnQgbXRrX21kcF9jb21wX2luaXQoc3RydWN0IGRl dmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUsDQo+ID4gLQkJICAgICAgc3RydWN0 IG10a19tZHBfY29tcCAqY29tcCwNCj4gPiAtCQkgICAgICBlbnVtIG10a19tZHBfY29tcF90eXBl IGNvbXBfdHlwZSk7DQo+ID4gLXZvaWQgbXRrX21kcF9jb21wX2RlaW5pdChzdHJ1Y3QgZGV2aWNl ICpkZXYsIHN0cnVjdCBtdGtfbWRwX2NvbXAgKmNvbXApOw0KPiA+ICtpbnQgbXRrX21kcF9jb21w X2luaXQoc3RydWN0IG10a19tZHBfY29tcCAqY29tcCwgc3RydWN0IGRldmljZSAqZGV2KTsNCj4g PiArDQo+ID4gIHZvaWQgbXRrX21kcF9jb21wX2Nsb2NrX29uKHN0cnVjdCBkZXZpY2UgKmRldiwg c3RydWN0IG10a19tZHBfY29tcCAqY29tcCk7DQo+ID4gIHZvaWQgbXRrX21kcF9jb21wX2Nsb2Nr X29mZihzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBtdGtfbWRwX2NvbXAgKmNvbXApOw0KPiA+ ICANCj4gPiArZXh0ZXJuIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgbXRrX21kcF9jb21wb25lbnRf ZHJpdmVyOw0KPiA+ICANCj4gPiAgI2VuZGlmIC8qIF9fTVRLX01EUF9DT01QX0hfXyAqLw0KPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay1tZHAvbXRrX21kcF9jb3Jl LmMgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay1tZHAvbXRrX21kcF9jb3JlLmMNCj4gPiBp bmRleCA3MGE4ZWFiMTY4NjMuLmQ3OWJmN2YwMDMxYSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJz L21lZGlhL3BsYXRmb3JtL210ay1tZHAvbXRrX21kcF9jb3JlLmMNCj4gPiArKysgYi9kcml2ZXJz L21lZGlhL3BsYXRmb3JtL210ay1tZHAvbXRrX21kcF9jb3JlLmMNCj4gPiBAQCAtNiw2ICs2LDcg QEANCj4gPiAgICovDQo+ID4gIA0KPiA+ICAjaW5jbHVkZSA8bGludXgvY2xrLmg+DQo+ID4gKyNp bmNsdWRlIDxsaW51eC9jb21wb25lbnQuaD4NCj4gPiAgI2luY2x1ZGUgPGxpbnV4L2RldmljZS5o Pg0KPiA+ICAjaW5jbHVkZSA8bGludXgvZXJybm8uaD4NCj4gPiAgI2luY2x1ZGUgPGxpbnV4L2lu dGVycnVwdC5oPg0KPiA+IEBAIC0xOCw2ICsxOSw3IEBADQo+ID4gICNpbmNsdWRlIDxsaW51eC9w bV9ydW50aW1lLmg+DQo+ID4gICNpbmNsdWRlIDxsaW51eC93b3JrcXVldWUuaD4NCj4gPiAgDQo+ ID4gKyNpbmNsdWRlICJtdGtfbWRwX2NvbXAuaCINCj4gPiAgI2luY2x1ZGUgIm10a19tZHBfY29y ZS5oIg0KPiA+ICAjaW5jbHVkZSAibXRrX21kcF9tMm0uaCINCj4gPiAgI2luY2x1ZGUgIm10a192 cHUuaCINCj4gPiBAQCAtMzEsMTYgKzMzLDEyIEBAIG1vZHVsZV9wYXJhbShtdGtfbWRwX2RiZ19s ZXZlbCwgaW50LCAwNjQ0KTsNCj4gPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQg bXRrX21kcF9jb21wX2R0X2lkc1tdID0gew0KPiA+ICAJew0KPiA+ICAJCS5jb21wYXRpYmxlID0g Im1lZGlhdGVrLG10ODE3My1tZHAtcmRtYSIsDQo+ID4gLQkJLmRhdGEgPSAodm9pZCAqKU1US19N RFBfUkRNQQ0KPiA+ICAJfSwgew0KPiA+ICAJCS5jb21wYXRpYmxlID0gIm1lZGlhdGVrLG10ODE3 My1tZHAtcnN6IiwNCj4gPiAtCQkuZGF0YSA9ICh2b2lkICopTVRLX01EUF9SU1oNCj4gPiAgCX0s IHsNCj4gPiAgCQkuY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdDgxNzMtbWRwLXdkbWEiLA0KPiA+ IC0JCS5kYXRhID0gKHZvaWQgKilNVEtfTURQX1dETUENCj4gPiAgCX0sIHsNCj4gPiAgCQkuY29t cGF0aWJsZSA9ICJtZWRpYXRlayxtdDgxNzMtbWRwLXdyb3QiLA0KPiA+IC0JCS5kYXRhID0gKHZv aWQgKilNVEtfTURQX1dST1QNCj4gPiAgCX0sDQo+ID4gIAl7IH0sDQo+ID4gIH07DQo+ID4gQEAg LTkwLDYgKzg4LDY0IEBAIHN0YXRpYyB2b2lkIG10a19tZHBfcmVzZXRfaGFuZGxlcih2b2lkICpw cml2KQ0KPiA+ICAJcXVldWVfd29yayhtZHAtPndkdF93cSwgJm1kcC0+d2R0X3dvcmspOw0KPiA+ ICB9DQo+ID4gIA0KPiA+ICtzdGF0aWMgaW50IGNvbXBhcmVfb2Yoc3RydWN0IGRldmljZSAqZGV2 LCB2b2lkICpkYXRhKQ0KPiA+ICt7DQo+ID4gKwlyZXR1cm4gZGV2LT5vZl9ub2RlID09IGRhdGE7 DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyB2b2lkIHJlbGVhc2Vfb2Yoc3RydWN0IGRldmlj ZSAqZGV2LCB2b2lkICpkYXRhKQ0KPiA+ICt7DQo+ID4gKwlvZl9ub2RlX3B1dChkYXRhKTsNCj4g PiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGludCBtdGtfbWRwX21hc3Rlcl9iaW5kKHN0cnVjdCBk ZXZpY2UgKmRldikNCj4gPiArew0KPiA+ICsJaW50IHN0YXR1czsNCj4gPiArCXN0cnVjdCBtdGtf bWRwX2RldiAqbWRwID0gZGV2X2dldF9kcnZkYXRhKGRldik7DQo+ID4gKw0KPiA+ICsJbXRrX21k cF9yZWdpc3Rlcl9jb21wb25lbnQobWRwLCAmbWRwLT5jb21wX3NlbGYpOw0KPiA+ICsNCj4gPiAr CXN0YXR1cyA9IGNvbXBvbmVudF9iaW5kX2FsbChkZXYsIG1kcCk7DQo+ID4gKwlpZiAoc3RhdHVz KSB7DQo+ID4gKwkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gYmluZCBhbGwgY29tcG9uZW50czog JWRcbiIsIHN0YXR1cyk7DQo+ID4gKwkJZ290byBlcnJfY29tcG9uZW50X2JpbmRfYWxsOw0KPiA+ ICsJfQ0KPiA+ICsNCj4gPiArCXN0YXR1cyA9IG10a19tZHBfcmVnaXN0ZXJfbTJtX2RldmljZSht ZHApOw0KPiA+ICsJaWYgKHN0YXR1cykgew0KPiA+ICsJCWRldl9lcnIoZGV2LCAiRmFpbGVkIHRv IHJlZ2lzdGVyIG0ybSBkZXZpY2U6ICVkXG4iLCBzdGF0dXMpOw0KPiA+ICsJCXY0bDJfZXJyKCZt ZHAtPnY0bDJfZGV2LCAiRmFpbGVkIHRvIGluaXQgbWVtMm1lbSBkZXZpY2VcbiIpOw0KPiA+ICsJ CWdvdG8gZXJyX210a19tZHBfcmVnaXN0ZXJfbTJtX2RldmljZTsNCj4gPiArCX0NCj4gPiArDQo+ ID4gKwlwbV9ydW50aW1lX2VuYWJsZShkZXYpOw0KPiA+ICsNCj4gPiArCXJldHVybiAwOw0KPiA+ ICsNCj4gPiArZXJyX210a19tZHBfcmVnaXN0ZXJfbTJtX2RldmljZToNCj4gPiArCWNvbXBvbmVu dF91bmJpbmRfYWxsKGRldiwgbWRwKTsNCj4gPiArDQo+ID4gK2Vycl9jb21wb25lbnRfYmluZF9h bGw6DQo+ID4gKwltdGtfbWRwX3VucmVnaXN0ZXJfY29tcG9uZW50KG1kcCwgJm1kcC0+Y29tcF9z ZWxmKTsNCj4gPiArDQo+ID4gKwlyZXR1cm4gc3RhdHVzOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtz dGF0aWMgdm9pZCBtdGtfbWRwX21hc3Rlcl91bmJpbmQoc3RydWN0IGRldmljZSAqZGV2KQ0KPiA+ ICt7DQo+ID4gKwlzdHJ1Y3QgbXRrX21kcF9kZXYgKm1kcCA9IGRldl9nZXRfZHJ2ZGF0YShkZXYp Ow0KPiA+ICsNCj4gPiArCXBtX3J1bnRpbWVfZGlzYWJsZShkZXYpOw0KPiA+ICsJbXRrX21kcF91 bnJlZ2lzdGVyX20ybV9kZXZpY2UobWRwKTsNCj4gPiArCWNvbXBvbmVudF91bmJpbmRfYWxsKGRl diwgbWRwKTsNCj4gPiArCW10a19tZHBfdW5yZWdpc3Rlcl9jb21wb25lbnQobWRwLCAmbWRwLT5j b21wX3NlbGYpOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGNvbXBv bmVudF9tYXN0ZXJfb3BzIG10a19tZHBfY29tX29wcyA9IHsNCj4gPiArCS5iaW5kCQk9IG10a19t ZHBfbWFzdGVyX2JpbmQsDQo+ID4gKwkudW5iaW5kCQk9IG10a19tZHBfbWFzdGVyX3VuYmluZCwN Cj4gPiArfTsNCj4gPiArDQo+ID4gIHZvaWQgbXRrX21kcF9yZWdpc3Rlcl9jb21wb25lbnQoc3Ry dWN0IG10a19tZHBfZGV2ICptZHAsDQo+ID4gIAkJCQlzdHJ1Y3QgbXRrX21kcF9jb21wICpjb21w KQ0KPiA+ICB7DQo+ID4gQEAgLTEwNyw4ICsxNjMsOCBAQCBzdGF0aWMgaW50IG10a19tZHBfcHJv YmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gPiAgCXN0cnVjdCBtdGtfbWRwX2Rl diAqbWRwOw0KPiA+ICAJc3RydWN0IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsNCj4gPiAgCXN0 cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZSwgKnBhcmVudDsNCj4gPiAtCXN0cnVjdCBtdGtfbWRwX2Nv bXAgKmNvbXAsICpjb21wX3RlbXA7DQo+ID4gLQlpbnQgcmV0ID0gMDsNCj4gPiArCWludCBpLCBy ZXQgPSAwOw0KPiA+ICsJc3RydWN0IGNvbXBvbmVudF9tYXRjaCAqbWF0Y2ggPSBOVUxMOw0KPiA+ ICANCj4gPiAgCW1kcCA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqbWRwKSwgR0ZQX0tFUk5F TCk7DQo+ID4gIAlpZiAoIW1kcCkNCj4gPiBAQCAtMTMzLDM2ICsxODksNDMgQEAgc3RhdGljIGlu dCBtdGtfbWRwX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ID4gIAl9DQo+ ID4gIA0KPiA+ICAJLyogSXRlcmF0ZSBvdmVyIHNpYmxpbmcgTURQIGZ1bmN0aW9uIGJsb2NrcyAq Lw0KPiA+ICsJaSA9IDA7DQo+ID4gIAlmb3JfZWFjaF9jaGlsZF9vZl9ub2RlKHBhcmVudCwgbm9k ZSkgew0KPiA+IC0JCWNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgKm9mX2lkOw0KPiA+IC0JCWVu dW0gbXRrX21kcF9jb21wX3R5cGUgY29tcF90eXBlOw0KPiA+ICsJCXN0cnVjdCBwbGF0Zm9ybV9k ZXZpY2UgKnBkZXY7DQoNCidwZGV2JyBpcyB1c2VkIGFib3ZlLCBzbyB3ZSdkIGJldHRlciB0byB1 c2UgYW5vdGhlciB2YXJpYWJsZSBuYW1lIGhlcmUNCnRvIGF2b2lkIGNvbmZ1c2lvbi4NCg0KPiA+ ICANCj4gPiAtCQlvZl9pZCA9IG9mX21hdGNoX25vZGUobXRrX21kcF9jb21wX2R0X2lkcywgbm9k ZSk7DQo+ID4gLQkJaWYgKCFvZl9pZCkNCj4gPiArCQlpZiAoIW9mX21hdGNoX25vZGUobXRrX21k cF9jb21wX2R0X2lkcywgbm9kZSkpDQo+ID4gIAkJCWNvbnRpbnVlOw0KPiA+ICANCj4gPiAtCQlp ZiAoIW9mX2RldmljZV9pc19hdmFpbGFibGUobm9kZSkpIHsNCj4gPiAtCQkJZGV2X2VycihkZXYs ICJTa2lwcGluZyBkaXNhYmxlZCBjb21wb25lbnQgJXBPRlxuIiwNCj4gPiAtCQkJCW5vZGUpOw0K PiA+ICsJCWlmICghb2ZfZGV2aWNlX2lzX2F2YWlsYWJsZShub2RlKSkNCj4gPiAgCQkJY29udGlu dWU7DQo+ID4gLQkJfQ0KPiA+ICANCj4gPiAtCQljb21wX3R5cGUgPSAoZW51bSBtdGtfbWRwX2Nv bXBfdHlwZSlvZl9pZC0+ZGF0YTsNCj4gPiAtDQo+ID4gLQkJY29tcCA9IGRldm1fa3phbGxvYyhk ZXYsIHNpemVvZigqY29tcCksIEdGUF9LRVJORUwpOw0KPiA+IC0JCWlmICghY29tcCkgew0KPiA+ IC0JCQlyZXQgPSAtRU5PTUVNOw0KPiA+IC0JCQlvZl9ub2RlX3B1dChub2RlKTsNCj4gPiAtCQkJ Z290byBlcnJfY29tcDsNCj4gPiArCQlwZGV2ID0gb2ZfZmluZF9kZXZpY2VfYnlfbm9kZShub2Rl KTsNCj4gPiArCQlpZiAoIXBkZXYpIHsNCj4gPiArCQkJZGV2X3dhcm4oZGV2LCAiVW5hYmxlIHRv IGZpbmQgY29tcCBkZXZpY2UgJXNcbiIsDQo+ID4gKwkJCQkgbm9kZS0+ZnVsbF9uYW1lKTsNCj4g PiArCQkJY29udGludWU7DQo+ID4gIAkJfQ0KPiA+ICANCj4gPiAtCQlyZXQgPSBtdGtfbWRwX2Nv bXBfaW5pdChkZXYsIG5vZGUsIGNvbXAsIGNvbXBfdHlwZSk7DQo+ID4gLQkJaWYgKHJldCkgew0K PiA+IC0JCQlvZl9ub2RlX3B1dChub2RlKTsNCj4gPiAtCQkJZ290byBlcnJfY29tcDsNCj4gPiAr CQkvKg0KPiA+ICsJCSAqIERvIG5vdCBhZGQgYSBtYXRjaCBmb3IgbXkgb3duIChyZG1hMCkgZGV2 aWNlIG5vZGUuDQo+ID4gKwkJICogSSB3aWxsIGJlIG1hbmFnaW5nIGl0IGRpcmVjdGx5IGluc3Rl YWQgdXNpbmcgY29tcF9zZWxmLg0KPiA+ICsJCSAqLw0KPiA+ICsJCWlmICgmcGRldi0+ZGV2ICE9 IGRldikgew0KPiA+ICsJCQlkZXZfZGJnKGRldiwgImFkZGluZyBtYXRjaCAlZCBmb3I6ICVwT0Zc biIsIGkrKywgbm9kZSk7DQo+ID4gKwkJCWNvbXBvbmVudF9tYXRjaF9hZGRfcmVsZWFzZShkZXYs ICZtYXRjaCwgcmVsZWFzZV9vZiwNCj4gPiArCQkJCQkJICAgIGNvbXBhcmVfb2YsDQo+ID4gKwkJ CQkJCSAgICBvZl9ub2RlX2dldChub2RlKSk7DQo+ID4gIAkJfQ0KPiA+ICsJfQ0KPiA+ICANCj4g PiAtCQltdGtfbWRwX3JlZ2lzdGVyX2NvbXBvbmVudChtZHAsIGNvbXApOw0KPiA+ICsJLyoNCj4g PiArCSAqIENyZWF0ZSBhIGNvbXBvbmVudCBmb3IgbXlzZWxmIHNvIHRoYXQgY2xvY2tzIGNhbiBi ZSB0b2dnbGVkIGluDQo+ID4gKwkgKiBjbG9ja19vbigpLg0KPiA+ICsJICovDQo+ID4gKwlyZXQg PSBtdGtfbWRwX2NvbXBfaW5pdCgmbWRwLT5jb21wX3NlbGYsIGRldik7DQo+ID4gKwlpZiAocmV0 KSB7DQo+ID4gKwkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gaW5pdGlhbGl6ZSBjb21wb25lbnRc biIpOw0KPiA+ICsJCWdvdG8gZXJyX2NvbXA7DQo+ID4gIAl9DQo+ID4gIA0KPiA+ICAJbWRwLT5q b2Jfd3EgPSBjcmVhdGVfc2luZ2xldGhyZWFkX3dvcmtxdWV1ZShNVEtfTURQX01PRFVMRV9OQU1F KTsNCj4gPiBAQCAtMTg3LDE4ICsyNTAsMTIgQEAgc3RhdGljIGludCBtdGtfbWRwX3Byb2JlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ID4gIAkJZ290byBlcnJfZGV2X3JlZ2lzdGVy Ow0KPiA+ICAJfQ0KPiA+ICANCj4gPiAtCXJldCA9IG10a19tZHBfcmVnaXN0ZXJfbTJtX2Rldmlj ZShtZHApOw0KPiA+IC0JaWYgKHJldCkgew0KPiA+IC0JCXY0bDJfZXJyKCZtZHAtPnY0bDJfZGV2 LCAiRmFpbGVkIHRvIGluaXQgbWVtMm1lbSBkZXZpY2VcbiIpOw0KPiA+IC0JCWdvdG8gZXJyX20y bV9yZWdpc3RlcjsNCj4gPiAtCX0NCj4gPiAtDQo+ID4gIAltZHAtPnZwdV9kZXYgPSB2cHVfZ2V0 X3BsYXRfZGV2aWNlKHBkZXYpOw0KPiA+ICAJcmV0ID0gdnB1X3dkdF9yZWdfaGFuZGxlcihtZHAt PnZwdV9kZXYsIG10a19tZHBfcmVzZXRfaGFuZGxlciwgbWRwLA0KPiA+ICAJCQkJICBWUFVfUlNU X01EUCk7DQo+ID4gIAlpZiAocmV0KSB7DQo+ID4gIAkJZGV2X2VycigmcGRldi0+ZGV2LCAiRmFp bGVkIHRvIHJlZ2lzdGVyIHJlc2V0IGhhbmRsZXJcbiIpOw0KPiA+IC0JCWdvdG8gZXJyX20ybV9y ZWdpc3RlcjsNCj4gPiArCQlnb3RvIGVycl93ZHRfcmVnOw0KPiA+ICAJfQ0KPiA+ICANCj4gPiAg CXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIG1kcCk7DQo+ID4gQEAgLTIwNiwxNSArMjYzLDI1 IEBAIHN0YXRpYyBpbnQgbXRrX21kcF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KQ0KPiA+ICAJcmV0ID0gdmIyX2RtYV9jb250aWdfc2V0X21heF9zZWdfc2l6ZSgmcGRldi0+ZGV2 LCBETUFfQklUX01BU0soMzIpKTsNCj4gPiAgCWlmIChyZXQpIHsNCj4gPiAgCQlkZXZfZXJyKCZw ZGV2LT5kZXYsICJGYWlsZWQgdG8gc2V0IHZiMiBkbWEgbWFnIHNlZyBzaXplXG4iKTsNCj4gPiAt CQlnb3RvIGVycl9tMm1fcmVnaXN0ZXI7DQo+ID4gKwkJZ290byBlcnJfc2V0X21heF9zZWdfc2l6 ZTsNCj4gPiArCX0NCj4gPiArDQo+ID4gKwlyZXQgPSBjb21wb25lbnRfbWFzdGVyX2FkZF93aXRo X21hdGNoKGRldiwgJm10a19tZHBfY29tX29wcywgbWF0Y2gpOw0KPiA+ICsJaWYgKHJldCkgew0K PiA+ICsJCWRldl9lcnIoZGV2LCAiQ29tcG9uZW50IG1hc3RlciBhZGQgZmFpbGVkXG4iKTsNCj4g PiArCQlnb3RvIGVycl9jb21wb25lbnRfbWFzdGVyX2FkZDsNCj4gPiAgCX0NCj4gPiAgDQo+ID4g LQlwbV9ydW50aW1lX2VuYWJsZShkZXYpOw0KPiA+ICAJZGV2X2RiZyhkZXYsICJtZHAtJWQgcmVn aXN0ZXJlZCBzdWNjZXNzZnVsbHlcbiIsIG1kcC0+aWQpOw0KPiA+ICANCj4gPiAgCXJldHVybiAw Ow0KPiA+ICANCj4gPiAtZXJyX20ybV9yZWdpc3RlcjoNCj4gPiArZXJyX2NvbXBvbmVudF9tYXN0 ZXJfYWRkOg0KPiA+ICsJdmIyX2RtYV9jb250aWdfY2xlYXJfbWF4X3NlZ19zaXplKCZwZGV2LT5k ZXYpOw0KPiA+ICsNCj4gPiArZXJyX3NldF9tYXhfc2VnX3NpemU6DQo+ID4gKw0KPiA+ICtlcnJf d2R0X3JlZzoNCj4gPiAgCXY0bDJfZGV2aWNlX3VucmVnaXN0ZXIoJm1kcC0+djRsMl9kZXYpOw0K PiA+ICANCj4gPiAgZXJyX2Rldl9yZWdpc3RlcjoNCj4gPiBAQCAtMjI2LDExICsyOTMsNiBAQCBz dGF0aWMgaW50IG10a19tZHBfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4g PiAgZXJyX2FsbG9jX2pvYl93cToNCj4gPiAgDQo+ID4gIGVycl9jb21wOg0KPiA+IC0JbGlzdF9m b3JfZWFjaF9lbnRyeV9zYWZlKGNvbXAsIGNvbXBfdGVtcCwgJm1kcC0+Y29tcF9saXN0LCBub2Rl KSB7DQo+ID4gLQkJbXRrX21kcF91bnJlZ2lzdGVyX2NvbXBvbmVudChtZHAsIGNvbXApOw0KPiA+ IC0JCW10a19tZHBfY29tcF9kZWluaXQoZGV2LCBjb21wKTsNCj4gPiAtCX0NCj4gPiAtDQo+ID4g IAlkZXZfZGJnKGRldiwgImVyciAlZFxuIiwgcmV0KTsNCj4gPiAgCXJldHVybiByZXQ7DQo+ID4g IH0NCj4gPiBAQCAtMjM4LDExICszMDAsMTAgQEAgc3RhdGljIGludCBtdGtfbWRwX3Byb2JlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ID4gIHN0YXRpYyBpbnQgbXRrX21kcF9yZW1v dmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gPiAgew0KPiA+ICAJc3RydWN0IG10 a19tZHBfZGV2ICptZHAgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsNCj4gPiAtCXN0cnVj dCBtdGtfbWRwX2NvbXAgKmNvbXAsICpjb21wX3RlbXA7DQo+ID4gIA0KPiA+IC0JcG1fcnVudGlt ZV9kaXNhYmxlKCZwZGV2LT5kZXYpOw0KPiA+ICsJY29tcG9uZW50X21hc3Rlcl9kZWwoJnBkZXYt PmRldiwgJm10a19tZHBfY29tX29wcyk7DQo+ID4gKw0KPiA+ICAJdmIyX2RtYV9jb250aWdfY2xl YXJfbWF4X3NlZ19zaXplKCZwZGV2LT5kZXYpOw0KPiA+IC0JbXRrX21kcF91bnJlZ2lzdGVyX20y bV9kZXZpY2UobWRwKTsNCj4gPiAgCXY0bDJfZGV2aWNlX3VucmVnaXN0ZXIoJm1kcC0+djRsMl9k ZXYpOw0KPiA+ICANCj4gPiAgCWZsdXNoX3dvcmtxdWV1ZShtZHAtPndkdF93cSk7DQo+ID4gQEAg LTI1MSwxMCArMzEyLDggQEAgc3RhdGljIGludCBtdGtfbWRwX3JlbW92ZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQ0KPiA+ICAJZmx1c2hfd29ya3F1ZXVlKG1kcC0+am9iX3dxKTsNCj4g PiAgCWRlc3Ryb3lfd29ya3F1ZXVlKG1kcC0+am9iX3dxKTsNCj4gPiAgDQo+ID4gLQlsaXN0X2Zv cl9lYWNoX2VudHJ5X3NhZmUoY29tcCwgY29tcF90ZW1wLCAmbWRwLT5jb21wX2xpc3QsIG5vZGUp IHsNCj4gPiAtCQltdGtfbWRwX3VucmVnaXN0ZXJfY29tcG9uZW50KG1kcCwgY29tcCk7DQo+ID4g LQkJbXRrX21kcF9jb21wX2RlaW5pdCgmcGRldi0+ZGV2LCBjb21wKTsNCj4gPiAtCX0NCj4gPiAr CWlmICghbGlzdF9lbXB0eSgmbWRwLT5jb21wX2xpc3QpKQ0KPiA+ICsJCWRldl9lcnIoJnBkZXYt PmRldiwgIm5vdCBhbGwgY29tcG9uZW50cyByZW1vdmVkXG4iKTsNCj4gPiAgDQo+ID4gIAlkZXZf ZGJnKCZwZGV2LT5kZXYsICIlcyBkcml2ZXIgdW5sb2FkZWRcbiIsIHBkZXYtPm5hbWUpOw0KPiA+ ICAJcmV0dXJuIDA7DQo+ID4gQEAgLTMwOSw3ICszNjgsMjUgQEAgc3RhdGljIHN0cnVjdCBwbGF0 Zm9ybV9kcml2ZXIgbXRrX21kcF9kcml2ZXIgPSB7DQo+ID4gIAl9DQo+ID4gIH07DQo+ID4gIA0K PiA+IC1tb2R1bGVfcGxhdGZvcm1fZHJpdmVyKG10a19tZHBfZHJpdmVyKTsNCj4gPiArc3RhdGlj IHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgKiBjb25zdCBtdGtfbWRwX2RyaXZlcnNbXSA9IHsNCj4g PiArCSZtdGtfbWRwX2RyaXZlciwNCj4gPiArCSZtdGtfbWRwX2NvbXBvbmVudF9kcml2ZXIsDQo+ ID4gK307DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW50IF9faW5pdCBtdGtfbWRwX2luaXQodm9pZCkN Cj4gPiArew0KPiA+ICsJcmV0dXJuIHBsYXRmb3JtX3JlZ2lzdGVyX2RyaXZlcnMobXRrX21kcF9k cml2ZXJzLA0KPiA+ICsJCQkJCSBBUlJBWV9TSVpFKG10a19tZHBfZHJpdmVycykpOw0KPiA+ICt9 DQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCBfX2V4aXQgbXRrX21kcF9leGl0KHZvaWQpDQo+ID4g K3sNCj4gPiArCXBsYXRmb3JtX3VucmVnaXN0ZXJfZHJpdmVycyhtdGtfbWRwX2RyaXZlcnMsDQo+ ID4gKwkJCQkgICAgQVJSQVlfU0laRShtdGtfbWRwX2RyaXZlcnMpKTsNCj4gPiArfQ0KPiA+ICsN Cj4gPiArbW9kdWxlX2luaXQobXRrX21kcF9pbml0KTsNCj4gPiArbW9kdWxlX2V4aXQobXRrX21k cF9leGl0KTsNCj4gPiAgDQo+ID4gIE1PRFVMRV9BVVRIT1IoIkhvdWxvbmcgV2VpIDxob3Vsb25n LndlaUBtZWRpYXRlay5jb20+Iik7DQo+ID4gIE1PRFVMRV9ERVNDUklQVElPTigiTWVkaWF0ZWsg aW1hZ2UgcHJvY2Vzc29yIGRyaXZlciIpOw0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlh L3BsYXRmb3JtL210ay1tZHAvbXRrX21kcF9jb3JlLmggYi9kcml2ZXJzL21lZGlhL3BsYXRmb3Jt L210ay1tZHAvbXRrX21kcF9jb3JlLmgNCj4gPiBpbmRleCBhN2RhMTRiOTcwNzcuLjIzMGY1MzE0 MDBjYSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay1tZHAvbXRr X21kcF9jb3JlLmgNCj4gPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay1tZHAvbXRr X21kcF9jb3JlLmgNCj4gPiBAQCAtMTU1LDYgKzE1NSw3IEBAIHN0cnVjdCBtdGtfbWRwX2RldiB7 DQo+ID4gIAlzdHJ1Y3QgbXRrX21kcF92YXJpYW50CQkqdmFyaWFudDsNCj4gPiAgCXUxNgkJCQlp ZDsNCj4gPiAgCXN0cnVjdCBsaXN0X2hlYWQJCWNvbXBfbGlzdDsNCj4gPiArCXN0cnVjdCBtdGtf bWRwX2NvbXAJCWNvbXBfc2VsZjsNCj4gPiAgCXN0cnVjdCB2NGwyX20ybV9kZXYJCSptMm1fZGV2 Ow0KPiA+ICAJc3RydWN0IGxpc3RfaGVhZAkJY3R4X2xpc3Q7DQo+ID4gIAlzdHJ1Y3QgdmlkZW9f ZGV2aWNlCQkqdmRldjsNCj4gPiANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF77C48BCD for ; Tue, 8 Jun 2021 14:12:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14B7361078 for ; Tue, 8 Jun 2021 14:12:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14B7361078 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uXoSgHslUecMjDkOI7Jg8LmdZb8tJkNc0p/X8cWLqx8=; b=u6KCl/HGXigI3k bMp9nRenZOCOl+8np3EZ6GmX962EGa+pPXTKKlsUC2bMaV9i2Tdyd0EiRhUA1TYbGAhLI97aqUllZ UITYwJsR8RLpvVmTWO/4lkuA89fEoSeFgvcd6PhZF2T4VtquayLnH2sZUX8zKOZnpWmoTZY3yyFnl eU/7KkajePv1cGtbRr6yShGI/uEhk0DQeZrxB21skL/rHilj9QVaMM/lf9lFKJkbjKf+ToFMKMg7k XPCitlmEudRsycSyQQd+we7nvAHKOOe46zxmIr/ciU2g8Z0dNEt7bUSKKvg+h7YZ9M0d5E5bO9DEx FQAhMQ02KFVrPXyg9e1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqcSW-008nEm-Tc; Tue, 08 Jun 2021 14:12:00 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqcSI-008n1e-I3; Tue, 08 Jun 2021 14:11:49 +0000 X-UUID: 8134b9113c54462b892bf48c7b1c3731-20210608 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=mBat+eB3UkQSKYEG6CFPmRw5xt3ns69b4y1m/7XycKY=; b=FiWR5KUiWbwrITBlrCYOLSwMPwyWh6nCVbewDz8Pksz1DDiENDJLZ7qt+n4xdu9JuHdzCJR2CYJt34S9mBr+lhW5OIKO03Khu5YxW/mf9FIDMQ/I2q75Iywo0LhZEJ+4SFfvdG4ImQTyzM2aNQrfIdHcd8igLKgZLv8mypVjJgI=; X-UUID: 8134b9113c54462b892bf48c7b1c3731-20210608 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 911238864; Tue, 08 Jun 2021 07:11:42 -0700 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 07:10:41 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 22:10:30 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Jun 2021 22:10:29 +0800 Message-ID: <1623161430.7079.15.camel@mhfsdcap03> Subject: Re: [PATCH v1 1/4] mtk-mdp: add driver to probe mdp components From: houlong wei To: Enric Balletbo i Serra CC: Eizan Miyamoto , "linux-kernel@vger.kernel.org" , "chunkuang.hu@kernel.org" , Yong Wu =?UTF-8?Q?=28=E5=90=B4=E5=8B=87=29?= , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Matthias Brugger , Mauro Carvalho Chehab , Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?= , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" Date: Tue, 8 Jun 2021 22:10:30 +0800 In-Reply-To: References: <20210423055842.2490679-1-eizan@chromium.org> <20210423155824.v1.1.Ie6d1e6e39cf9b5d6b2108ae1096af34c3d55880b@changeid> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3E98DB750DA19B3141B7532FA5318727E6713158E0387F4DA7E5011D6584DEA32000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_071146_625245_247E622C X-CRM114-Status: GOOD ( 56.36 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Eizan, Thanks for your patch. I have inline comments below. Houlong On Fri, 2021-05-14 at 16:19 +0800, Enric Balletbo i Serra wrote: > Hi Eizan, > > Thank kyou for your patch. > > On 23/4/21 7:58, Eizan Miyamoto wrote: > > Broadly, this patch (1) adds a driver for various MTK MDP components to > > go alongside the main MTK MDP driver, and (2) hooks them all together > > using the component framework. > > > > (1) Up until now, the MTK MDP driver controls 8 devices in the device > > tree on its own. When running tests for the hardware video decoder, we > > found that the iommus and LARBs were not being properly configured. To > > configure them, a driver for each be added to mtk_mdp_comp so that > > mtk_iommu_add_device() can (eventually) be called from dma_configure() > > inside really_probe(). > > > > (2) The integration into the component framework allows us to defer the > > registration with the v4l2 subsystem until all the MDP-related devices > > have been probed, so that the relevant device node does not become > > available until initialization of all the components is complete. > > > > Some notes about how the component framework has been integrated: > > > > - The driver for the rdma0 component serves double duty as the "master" > > (aggregate) driver as well as a component driver. This is a non-ideal > > compromise until a better solution is developed. This device is > > differentiated from the rest by checking for a "mediatek,vpu" property > > in the device node. > > > > - The list of mdp components remains hard-coded as mtk_mdp_comp_dt_ids[] > > in mtk_mdp_core.c, and as mtk_mdp_comp_driver_dt_match[] in > > mtk_mdp_comp.c. This unfortunate duplication of information is > > addressed in a following patch in this series. > > > > - The component driver calls component_add() for each device that is > > probed. > > > > - In mtk_mdp_probe (the "master" device), we scan the device tree for > > any matching nodes against mtk_mdp_comp_dt_ids, and add component > > matches for them. The match criteria is a matching device node > > pointer. > > > > - When the set of components devices that have been probed corresponds > > with the list that is generated by the "master", the callback to > > mtk_mdp_master_bind() is made, which then calls the component bind > > functions. > > > > - Inside mtk_mdp_master_bind(), once all the component bind functions > > have been called, we can then register our device to the v4l2 > > subsystem. > > > > - The call to pm_runtime_enable() in the master device is called after > > all the components have been registered by their bind() functions > > called by mtk_mtp_master_bind(). As a result, the list of components > > will not change while power management callbacks mtk_mdp_suspend()/ > > resume() are accessing the list of components. > > > > Signed-off-by: Eizan Miyamoto > > --- > > > > drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 139 ++++++++++++-- > > drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 26 +-- > > drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 175 +++++++++++++----- > > drivers/media/platform/mtk-mdp/mtk_mdp_core.h | 1 + > > 4 files changed, 255 insertions(+), 86 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c > > index 1e3833f1c9ae..3fbbcf05440a 100644 > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c > > @@ -5,13 +5,51 @@ > > */ > > > > #include > > +#include > > #include > > -#include > > +#include > > #include > > +#include > > +#include > > +#include > > #include > > > > #include "mtk_mdp_comp.h" > > +#include "mtk_mdp_core.h" > > + > > +/** > > + * enum mtk_mdp_comp_type - the MDP component > > + * @MTK_MDP_RDMA: Read DMA > > + * @MTK_MDP_RSZ: Reszer Reszer is the typo for Resizer. Can you help to fix it, although it already exists in the original version ? > > + * @MTK_MDP_WDMA: Write DMA > > + * @MTK_MDP_WROT: Write DMA with rotation > > + * @MTK_MDP_COMP_TYPE_MAX: Placeholder for num elems in this enum > > + */ > > +enum mtk_mdp_comp_type { > > + MTK_MDP_RDMA, > > + MTK_MDP_RSZ, > > + MTK_MDP_WDMA, > > + MTK_MDP_WROT, > > + MTK_MDP_COMP_TYPE_MAX, > > +}; > > > > +static const struct of_device_id mtk_mdp_comp_driver_dt_match[] = { > > + { > > + .compatible = "mediatek,mt8173-mdp-rdma", > > + .data = (void *)MTK_MDP_RDMA > > + }, { > > + .compatible = "mediatek,mt8173-mdp-rsz", > > + .data = (void *)MTK_MDP_RSZ > > + }, { > > + .compatible = "mediatek,mt8173-mdp-wdma", > > + .data = (void *)MTK_MDP_WDMA > > + }, { > > + .compatible = "mediatek,mt8173-mdp-wrot", > > + .data = (void *)MTK_MDP_WROT > > + }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, mtk_mdp_comp_driver_dt_match); > > > > void mtk_mdp_comp_clock_on(struct device *dev, struct mtk_mdp_comp *comp) > > { > > @@ -23,8 +61,8 @@ void mtk_mdp_comp_clock_on(struct device *dev, struct mtk_mdp_comp *comp) > > err = clk_prepare_enable(comp->clk[i]); > > if (err) > > dev_err(dev, > > - "failed to enable clock, err %d. type:%d i:%d\n", > > - err, comp->type, i); > > + "failed to enable clock, err %d. i:%d\n", > > + err, i); > > I think youcan take advantage of the new line lenght limit and put all in one > line here. > > > > } > > } > > > > @@ -39,15 +77,40 @@ void mtk_mdp_comp_clock_off(struct device *dev, struct mtk_mdp_comp *comp) > > } > > } > > > > -int mtk_mdp_comp_init(struct device *dev, struct device_node *node, > > - struct mtk_mdp_comp *comp, > > - enum mtk_mdp_comp_type comp_type) > > +static int mtk_mdp_comp_bind(struct device *dev, struct device *master, > > + void *data) > > +{ > > + struct mtk_mdp_comp *comp = dev_get_drvdata(dev); > > + struct mtk_mdp_dev *mdp = data; > > + > > + mtk_mdp_register_component(mdp, comp); > > + > > + return 0; > > +} > > + > > +static void mtk_mdp_comp_unbind(struct device *dev, struct device *master, > > + void *data) > > +{ > > + struct mtk_mdp_dev *mdp = data; > > + struct mtk_mdp_comp *comp = dev_get_drvdata(dev); > > + > > + mtk_mdp_unregister_component(mdp, comp); > > +} > > + > > +static const struct component_ops mtk_mdp_component_ops = { > > + .bind = mtk_mdp_comp_bind, > > + .unbind = mtk_mdp_comp_unbind, > > +}; > > + > > +int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev) > > { > > int ret; > > int i; > > + struct device_node *node = dev->of_node; > > + enum mtk_mdp_comp_type comp_type = > > + (enum mtk_mdp_comp_type)of_device_get_match_data(dev); > > > > - comp->dev_node = of_node_get(node); > > - comp->type = comp_type; > > + INIT_LIST_HEAD(&comp->node); > > > > for (i = 0; i < ARRAY_SIZE(comp->clk); i++) { > > comp->clk[i] = of_clk_get(node, i); > > @@ -55,23 +118,71 @@ int mtk_mdp_comp_init(struct device *dev, struct device_node *node, > > if (PTR_ERR(comp->clk[i]) != -EPROBE_DEFER) > > dev_err(dev, "Failed to get clock\n"); > > ret = PTR_ERR(comp->clk[i]); > > - goto put_dev; > > + goto err; > > } > > > > /* Only RDMA needs two clocks */ > > - if (comp->type != MTK_MDP_RDMA) > > + if (comp_type != MTK_MDP_RDMA) > > break; > > } > > > > return 0; > > > > -put_dev: > > - of_node_put(comp->dev_node); > > +err: > > + dev_err(dev, "err %d\n", ret); > > This error is too generic. You can remove. Anyway you're printing the same error > code if mtk_mdp_comp_init fails in probe function, there makes more sense. > > > > > return ret; > > } > > > > -void mtk_mdp_comp_deinit(struct device *dev, struct mtk_mdp_comp *comp) > > +static int mtk_mdp_comp_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *vpu_node; > > + int status; > > + struct mtk_mdp_comp *comp; > > + > > + vpu_node = of_parse_phandle(dev->of_node, "mediatek,vpu", 0); > > + if (vpu_node) { > > + of_node_put(vpu_node); > > + /* > > + * The device tree node with a mediatek,vpu property is deemed > > + * the MDP "master" device, we don't want to add a component > > + * for it in this function because the initialization for the > > + * master is done elsewhere. > > + */ > > + dev_info(dev, "vpu node found, not probing\n"); > > This is the thing that I'm not completely sure is doing the right thing. Having > a DT propriety to indicate to skip the probing is really weird to me. Also the > name is quite confusing. When I read this name I'd expect mediatek,vpu being a > phandle to the VPU device node. If there is a master and childs below from > hardware POV, the DT graph should reflect that, if this is only a way to > instantiate properly the devices then I think we can find other solutions. If > you know that RDMA is always the master maybe we can just find this node. > > Other thoughts? > One way to judge it is to compare the of_device_get_match_data(dev) with MTK_MDP_RDMA. > > > + return -ENODEV; > > + } > > + > > + comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL); > > + if (!comp) > > + return -ENOMEM; > > + > > + status = mtk_mdp_comp_init(comp, dev); > > + if (status) { > > + dev_err(dev, "Failed to initialize component: %d\n", status); > > + return status; > > + } > > + > > + dev_set_drvdata(dev, comp); > > + > > + return component_add(dev, &mtk_mdp_component_ops); > > +} > > + > > +static int mtk_mdp_comp_remove(struct platform_device *pdev) > > { > > - of_node_put(comp->dev_node); > > + struct device *dev = &pdev->dev; > > + > > + component_del(dev, &mtk_mdp_component_ops); > > + return 0; > > } > > + > > +struct platform_driver mtk_mdp_component_driver = { > > + .probe = mtk_mdp_comp_probe, > > + .remove = mtk_mdp_comp_remove, > > + .driver = { > > + .name = "mediatek-mdp-comp", > > + .owner = THIS_MODULE, > > + .of_match_table = mtk_mdp_comp_driver_dt_match, > > + }, > > +}; > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h > > index 36bc1b8f6222..956d20c01e34 100644 > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h > > @@ -7,41 +7,21 @@ > > #ifndef __MTK_MDP_COMP_H__ > > #define __MTK_MDP_COMP_H__ > > > > -/** > > - * enum mtk_mdp_comp_type - the MDP component > > - * @MTK_MDP_RDMA: Read DMA > > - * @MTK_MDP_RSZ: Riszer > > - * @MTK_MDP_WDMA: Write DMA > > - * @MTK_MDP_WROT: Write DMA with rotation > > - */ > > -enum mtk_mdp_comp_type { > > - MTK_MDP_RDMA, > > - MTK_MDP_RSZ, > > - MTK_MDP_WDMA, > > - MTK_MDP_WROT, > > - MTK_MDP_COMP_TYPE_MAX, > > -}; > > - > > /** > > * struct mtk_mdp_comp - the MDP's function component data > > * @node: list node to track sibing MDP components > > - * @dev_node: component device node > > * @clk: clocks required for component > > - * @type: component type > > */ > > struct mtk_mdp_comp { > > struct list_head node; > > - struct device_node *dev_node; > > struct clk *clk[2]; > > - enum mtk_mdp_comp_type type; > > }; > > > > -int mtk_mdp_comp_init(struct device *dev, struct device_node *node, > > - struct mtk_mdp_comp *comp, > > - enum mtk_mdp_comp_type comp_type); > > -void mtk_mdp_comp_deinit(struct device *dev, struct mtk_mdp_comp *comp); > > +int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev); > > + > > void mtk_mdp_comp_clock_on(struct device *dev, struct mtk_mdp_comp *comp); > > void mtk_mdp_comp_clock_off(struct device *dev, struct mtk_mdp_comp *comp); > > > > +extern struct platform_driver mtk_mdp_component_driver; > > > > #endif /* __MTK_MDP_COMP_H__ */ > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > > index 70a8eab16863..d79bf7f0031a 100644 > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > > @@ -6,6 +6,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -18,6 +19,7 @@ > > #include > > #include > > > > +#include "mtk_mdp_comp.h" > > #include "mtk_mdp_core.h" > > #include "mtk_mdp_m2m.h" > > #include "mtk_vpu.h" > > @@ -31,16 +33,12 @@ module_param(mtk_mdp_dbg_level, int, 0644); > > static const struct of_device_id mtk_mdp_comp_dt_ids[] = { > > { > > .compatible = "mediatek,mt8173-mdp-rdma", > > - .data = (void *)MTK_MDP_RDMA > > }, { > > .compatible = "mediatek,mt8173-mdp-rsz", > > - .data = (void *)MTK_MDP_RSZ > > }, { > > .compatible = "mediatek,mt8173-mdp-wdma", > > - .data = (void *)MTK_MDP_WDMA > > }, { > > .compatible = "mediatek,mt8173-mdp-wrot", > > - .data = (void *)MTK_MDP_WROT > > }, > > { }, > > }; > > @@ -90,6 +88,64 @@ static void mtk_mdp_reset_handler(void *priv) > > queue_work(mdp->wdt_wq, &mdp->wdt_work); > > } > > > > +static int compare_of(struct device *dev, void *data) > > +{ > > + return dev->of_node == data; > > +} > > + > > +static void release_of(struct device *dev, void *data) > > +{ > > + of_node_put(data); > > +} > > + > > +static int mtk_mdp_master_bind(struct device *dev) > > +{ > > + int status; > > + struct mtk_mdp_dev *mdp = dev_get_drvdata(dev); > > + > > + mtk_mdp_register_component(mdp, &mdp->comp_self); > > + > > + status = component_bind_all(dev, mdp); > > + if (status) { > > + dev_err(dev, "Failed to bind all components: %d\n", status); > > + goto err_component_bind_all; > > + } > > + > > + status = mtk_mdp_register_m2m_device(mdp); > > + if (status) { > > + dev_err(dev, "Failed to register m2m device: %d\n", status); > > + v4l2_err(&mdp->v4l2_dev, "Failed to init mem2mem device\n"); > > + goto err_mtk_mdp_register_m2m_device; > > + } > > + > > + pm_runtime_enable(dev); > > + > > + return 0; > > + > > +err_mtk_mdp_register_m2m_device: > > + component_unbind_all(dev, mdp); > > + > > +err_component_bind_all: > > + mtk_mdp_unregister_component(mdp, &mdp->comp_self); > > + > > + return status; > > +} > > + > > +static void mtk_mdp_master_unbind(struct device *dev) > > +{ > > + struct mtk_mdp_dev *mdp = dev_get_drvdata(dev); > > + > > + pm_runtime_disable(dev); > > + mtk_mdp_unregister_m2m_device(mdp); > > + component_unbind_all(dev, mdp); > > + mtk_mdp_unregister_component(mdp, &mdp->comp_self); > > +} > > + > > +static const struct component_master_ops mtk_mdp_com_ops = { > > + .bind = mtk_mdp_master_bind, > > + .unbind = mtk_mdp_master_unbind, > > +}; > > + > > void mtk_mdp_register_component(struct mtk_mdp_dev *mdp, > > struct mtk_mdp_comp *comp) > > { > > @@ -107,8 +163,8 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > struct mtk_mdp_dev *mdp; > > struct device *dev = &pdev->dev; > > struct device_node *node, *parent; > > - struct mtk_mdp_comp *comp, *comp_temp; > > - int ret = 0; > > + int i, ret = 0; > > + struct component_match *match = NULL; > > > > mdp = devm_kzalloc(dev, sizeof(*mdp), GFP_KERNEL); > > if (!mdp) > > @@ -133,36 +189,43 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > } > > > > /* Iterate over sibling MDP function blocks */ > > + i = 0; > > for_each_child_of_node(parent, node) { > > - const struct of_device_id *of_id; > > - enum mtk_mdp_comp_type comp_type; > > + struct platform_device *pdev; 'pdev' is used above, so we'd better to use another variable name here to avoid confusion. > > > > - of_id = of_match_node(mtk_mdp_comp_dt_ids, node); > > - if (!of_id) > > + if (!of_match_node(mtk_mdp_comp_dt_ids, node)) > > continue; > > > > - if (!of_device_is_available(node)) { > > - dev_err(dev, "Skipping disabled component %pOF\n", > > - node); > > + if (!of_device_is_available(node)) > > continue; > > - } > > > > - comp_type = (enum mtk_mdp_comp_type)of_id->data; > > - > > - comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL); > > - if (!comp) { > > - ret = -ENOMEM; > > - of_node_put(node); > > - goto err_comp; > > + pdev = of_find_device_by_node(node); > > + if (!pdev) { > > + dev_warn(dev, "Unable to find comp device %s\n", > > + node->full_name); > > + continue; > > } > > > > - ret = mtk_mdp_comp_init(dev, node, comp, comp_type); > > - if (ret) { > > - of_node_put(node); > > - goto err_comp; > > + /* > > + * Do not add a match for my own (rdma0) device node. > > + * I will be managing it directly instead using comp_self. > > + */ > > + if (&pdev->dev != dev) { > > + dev_dbg(dev, "adding match %d for: %pOF\n", i++, node); > > + component_match_add_release(dev, &match, release_of, > > + compare_of, > > + of_node_get(node)); > > } > > + } > > > > - mtk_mdp_register_component(mdp, comp); > > + /* > > + * Create a component for myself so that clocks can be toggled in > > + * clock_on(). > > + */ > > + ret = mtk_mdp_comp_init(&mdp->comp_self, dev); > > + if (ret) { > > + dev_err(dev, "Failed to initialize component\n"); > > + goto err_comp; > > } > > > > mdp->job_wq = create_singlethread_workqueue(MTK_MDP_MODULE_NAME); > > @@ -187,18 +250,12 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > goto err_dev_register; > > } > > > > - ret = mtk_mdp_register_m2m_device(mdp); > > - if (ret) { > > - v4l2_err(&mdp->v4l2_dev, "Failed to init mem2mem device\n"); > > - goto err_m2m_register; > > - } > > - > > mdp->vpu_dev = vpu_get_plat_device(pdev); > > ret = vpu_wdt_reg_handler(mdp->vpu_dev, mtk_mdp_reset_handler, mdp, > > VPU_RST_MDP); > > if (ret) { > > dev_err(&pdev->dev, "Failed to register reset handler\n"); > > - goto err_m2m_register; > > + goto err_wdt_reg; > > } > > > > platform_set_drvdata(pdev, mdp); > > @@ -206,15 +263,25 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > ret = vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); > > if (ret) { > > dev_err(&pdev->dev, "Failed to set vb2 dma mag seg size\n"); > > - goto err_m2m_register; > > + goto err_set_max_seg_size; > > + } > > + > > + ret = component_master_add_with_match(dev, &mtk_mdp_com_ops, match); > > + if (ret) { > > + dev_err(dev, "Component master add failed\n"); > > + goto err_component_master_add; > > } > > > > - pm_runtime_enable(dev); > > dev_dbg(dev, "mdp-%d registered successfully\n", mdp->id); > > > > return 0; > > > > -err_m2m_register: > > +err_component_master_add: > > + vb2_dma_contig_clear_max_seg_size(&pdev->dev); > > + > > +err_set_max_seg_size: > > + > > +err_wdt_reg: > > v4l2_device_unregister(&mdp->v4l2_dev); > > > > err_dev_register: > > @@ -226,11 +293,6 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > err_alloc_job_wq: > > > > err_comp: > > - list_for_each_entry_safe(comp, comp_temp, &mdp->comp_list, node) { > > - mtk_mdp_unregister_component(mdp, comp); > > - mtk_mdp_comp_deinit(dev, comp); > > - } > > - > > dev_dbg(dev, "err %d\n", ret); > > return ret; > > } > > @@ -238,11 +300,10 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > static int mtk_mdp_remove(struct platform_device *pdev) > > { > > struct mtk_mdp_dev *mdp = platform_get_drvdata(pdev); > > - struct mtk_mdp_comp *comp, *comp_temp; > > > > - pm_runtime_disable(&pdev->dev); > > + component_master_del(&pdev->dev, &mtk_mdp_com_ops); > > + > > vb2_dma_contig_clear_max_seg_size(&pdev->dev); > > - mtk_mdp_unregister_m2m_device(mdp); > > v4l2_device_unregister(&mdp->v4l2_dev); > > > > flush_workqueue(mdp->wdt_wq); > > @@ -251,10 +312,8 @@ static int mtk_mdp_remove(struct platform_device *pdev) > > flush_workqueue(mdp->job_wq); > > destroy_workqueue(mdp->job_wq); > > > > - list_for_each_entry_safe(comp, comp_temp, &mdp->comp_list, node) { > > - mtk_mdp_unregister_component(mdp, comp); > > - mtk_mdp_comp_deinit(&pdev->dev, comp); > > - } > > + if (!list_empty(&mdp->comp_list)) > > + dev_err(&pdev->dev, "not all components removed\n"); > > > > dev_dbg(&pdev->dev, "%s driver unloaded\n", pdev->name); > > return 0; > > @@ -309,7 +368,25 @@ static struct platform_driver mtk_mdp_driver = { > > } > > }; > > > > -module_platform_driver(mtk_mdp_driver); > > +static struct platform_driver * const mtk_mdp_drivers[] = { > > + &mtk_mdp_driver, > > + &mtk_mdp_component_driver, > > +}; > > + > > +static int __init mtk_mdp_init(void) > > +{ > > + return platform_register_drivers(mtk_mdp_drivers, > > + ARRAY_SIZE(mtk_mdp_drivers)); > > +} > > + > > +static void __exit mtk_mdp_exit(void) > > +{ > > + platform_unregister_drivers(mtk_mdp_drivers, > > + ARRAY_SIZE(mtk_mdp_drivers)); > > +} > > + > > +module_init(mtk_mdp_init); > > +module_exit(mtk_mdp_exit); > > > > MODULE_AUTHOR("Houlong Wei "); > > MODULE_DESCRIPTION("Mediatek image processor driver"); > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.h b/drivers/media/platform/mtk-mdp/mtk_mdp_core.h > > index a7da14b97077..230f531400ca 100644 > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.h > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.h > > @@ -155,6 +155,7 @@ struct mtk_mdp_dev { > > struct mtk_mdp_variant *variant; > > u16 id; > > struct list_head comp_list; > > + struct mtk_mdp_comp comp_self; > > struct v4l2_m2m_dev *m2m_dev; > > struct list_head ctx_list; > > struct video_device *vdev; > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4431C4743D for ; Tue, 8 Jun 2021 14:14:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B2A560FE9 for ; Tue, 8 Jun 2021 14:14:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B2A560FE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5pct3O+/MIMTMd17gMhvl2uBMnFZj2UvU9bSwSAJv+g=; b=XABRrTFVmvsxQQ 422QRpdCIwspZvLEuPZkQmWn9VkevsltrT5NPbw2XWT35sQxNArg31moQMOQrGQCcFZD9gj2AiVbK dkxR0oOonCvyQ7ApHyW5pEvsG79bFCEnCyP0VstMLpNw9ge4zxPnonHsS/FDx/IHLxxEOHEKM/5EU 5Z056xgNDhOvNJZPXY+pzr7D1i7XYeDV+SqojiPtVOy4nAJUZhxsvNbdgNDVV/geIcPDoOdzcPuUs keQIGsIk82K0znRDgaOa9t0nugApCoA8ExkdUXbbJTp1c5UP0ljg3qzoAMarJ/DqTnYXsvrNTvCVc l12hjJEzl6XOHFpA12BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqcSY-008nIM-RI; Tue, 08 Jun 2021 14:12:03 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqcSI-008n1e-I3; Tue, 08 Jun 2021 14:11:49 +0000 X-UUID: 8134b9113c54462b892bf48c7b1c3731-20210608 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=mBat+eB3UkQSKYEG6CFPmRw5xt3ns69b4y1m/7XycKY=; b=FiWR5KUiWbwrITBlrCYOLSwMPwyWh6nCVbewDz8Pksz1DDiENDJLZ7qt+n4xdu9JuHdzCJR2CYJt34S9mBr+lhW5OIKO03Khu5YxW/mf9FIDMQ/I2q75Iywo0LhZEJ+4SFfvdG4ImQTyzM2aNQrfIdHcd8igLKgZLv8mypVjJgI=; X-UUID: 8134b9113c54462b892bf48c7b1c3731-20210608 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 911238864; Tue, 08 Jun 2021 07:11:42 -0700 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 07:10:41 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Jun 2021 22:10:30 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Jun 2021 22:10:29 +0800 Message-ID: <1623161430.7079.15.camel@mhfsdcap03> Subject: Re: [PATCH v1 1/4] mtk-mdp: add driver to probe mdp components From: houlong wei To: Enric Balletbo i Serra CC: Eizan Miyamoto , "linux-kernel@vger.kernel.org" , "chunkuang.hu@kernel.org" , Yong Wu =?UTF-8?Q?=28=E5=90=B4=E5=8B=87=29?= , Andrew-CT Chen =?UTF-8?Q?=28=E9=99=B3=E6=99=BA=E8=BF=AA=29?= , Matthias Brugger , Mauro Carvalho Chehab , Minghsiu Tsai =?UTF-8?Q?=28=E8=94=A1=E6=98=8E=E4=BF=AE=29?= , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" Date: Tue, 8 Jun 2021 22:10:30 +0800 In-Reply-To: References: <20210423055842.2490679-1-eizan@chromium.org> <20210423155824.v1.1.Ie6d1e6e39cf9b5d6b2108ae1096af34c3d55880b@changeid> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 3E98DB750DA19B3141B7532FA5318727E6713158E0387F4DA7E5011D6584DEA32000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_071146_625245_247E622C X-CRM114-Status: GOOD ( 56.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Eizan, Thanks for your patch. I have inline comments below. Houlong On Fri, 2021-05-14 at 16:19 +0800, Enric Balletbo i Serra wrote: > Hi Eizan, > > Thank kyou for your patch. > > On 23/4/21 7:58, Eizan Miyamoto wrote: > > Broadly, this patch (1) adds a driver for various MTK MDP components to > > go alongside the main MTK MDP driver, and (2) hooks them all together > > using the component framework. > > > > (1) Up until now, the MTK MDP driver controls 8 devices in the device > > tree on its own. When running tests for the hardware video decoder, we > > found that the iommus and LARBs were not being properly configured. To > > configure them, a driver for each be added to mtk_mdp_comp so that > > mtk_iommu_add_device() can (eventually) be called from dma_configure() > > inside really_probe(). > > > > (2) The integration into the component framework allows us to defer the > > registration with the v4l2 subsystem until all the MDP-related devices > > have been probed, so that the relevant device node does not become > > available until initialization of all the components is complete. > > > > Some notes about how the component framework has been integrated: > > > > - The driver for the rdma0 component serves double duty as the "master" > > (aggregate) driver as well as a component driver. This is a non-ideal > > compromise until a better solution is developed. This device is > > differentiated from the rest by checking for a "mediatek,vpu" property > > in the device node. > > > > - The list of mdp components remains hard-coded as mtk_mdp_comp_dt_ids[] > > in mtk_mdp_core.c, and as mtk_mdp_comp_driver_dt_match[] in > > mtk_mdp_comp.c. This unfortunate duplication of information is > > addressed in a following patch in this series. > > > > - The component driver calls component_add() for each device that is > > probed. > > > > - In mtk_mdp_probe (the "master" device), we scan the device tree for > > any matching nodes against mtk_mdp_comp_dt_ids, and add component > > matches for them. The match criteria is a matching device node > > pointer. > > > > - When the set of components devices that have been probed corresponds > > with the list that is generated by the "master", the callback to > > mtk_mdp_master_bind() is made, which then calls the component bind > > functions. > > > > - Inside mtk_mdp_master_bind(), once all the component bind functions > > have been called, we can then register our device to the v4l2 > > subsystem. > > > > - The call to pm_runtime_enable() in the master device is called after > > all the components have been registered by their bind() functions > > called by mtk_mtp_master_bind(). As a result, the list of components > > will not change while power management callbacks mtk_mdp_suspend()/ > > resume() are accessing the list of components. > > > > Signed-off-by: Eizan Miyamoto > > --- > > > > drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 139 ++++++++++++-- > > drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 26 +-- > > drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 175 +++++++++++++----- > > drivers/media/platform/mtk-mdp/mtk_mdp_core.h | 1 + > > 4 files changed, 255 insertions(+), 86 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c > > index 1e3833f1c9ae..3fbbcf05440a 100644 > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c > > @@ -5,13 +5,51 @@ > > */ > > > > #include > > +#include > > #include > > -#include > > +#include > > #include > > +#include > > +#include > > +#include > > #include > > > > #include "mtk_mdp_comp.h" > > +#include "mtk_mdp_core.h" > > + > > +/** > > + * enum mtk_mdp_comp_type - the MDP component > > + * @MTK_MDP_RDMA: Read DMA > > + * @MTK_MDP_RSZ: Reszer Reszer is the typo for Resizer. Can you help to fix it, although it already exists in the original version ? > > + * @MTK_MDP_WDMA: Write DMA > > + * @MTK_MDP_WROT: Write DMA with rotation > > + * @MTK_MDP_COMP_TYPE_MAX: Placeholder for num elems in this enum > > + */ > > +enum mtk_mdp_comp_type { > > + MTK_MDP_RDMA, > > + MTK_MDP_RSZ, > > + MTK_MDP_WDMA, > > + MTK_MDP_WROT, > > + MTK_MDP_COMP_TYPE_MAX, > > +}; > > > > +static const struct of_device_id mtk_mdp_comp_driver_dt_match[] = { > > + { > > + .compatible = "mediatek,mt8173-mdp-rdma", > > + .data = (void *)MTK_MDP_RDMA > > + }, { > > + .compatible = "mediatek,mt8173-mdp-rsz", > > + .data = (void *)MTK_MDP_RSZ > > + }, { > > + .compatible = "mediatek,mt8173-mdp-wdma", > > + .data = (void *)MTK_MDP_WDMA > > + }, { > > + .compatible = "mediatek,mt8173-mdp-wrot", > > + .data = (void *)MTK_MDP_WROT > > + }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, mtk_mdp_comp_driver_dt_match); > > > > void mtk_mdp_comp_clock_on(struct device *dev, struct mtk_mdp_comp *comp) > > { > > @@ -23,8 +61,8 @@ void mtk_mdp_comp_clock_on(struct device *dev, struct mtk_mdp_comp *comp) > > err = clk_prepare_enable(comp->clk[i]); > > if (err) > > dev_err(dev, > > - "failed to enable clock, err %d. type:%d i:%d\n", > > - err, comp->type, i); > > + "failed to enable clock, err %d. i:%d\n", > > + err, i); > > I think youcan take advantage of the new line lenght limit and put all in one > line here. > > > > } > > } > > > > @@ -39,15 +77,40 @@ void mtk_mdp_comp_clock_off(struct device *dev, struct mtk_mdp_comp *comp) > > } > > } > > > > -int mtk_mdp_comp_init(struct device *dev, struct device_node *node, > > - struct mtk_mdp_comp *comp, > > - enum mtk_mdp_comp_type comp_type) > > +static int mtk_mdp_comp_bind(struct device *dev, struct device *master, > > + void *data) > > +{ > > + struct mtk_mdp_comp *comp = dev_get_drvdata(dev); > > + struct mtk_mdp_dev *mdp = data; > > + > > + mtk_mdp_register_component(mdp, comp); > > + > > + return 0; > > +} > > + > > +static void mtk_mdp_comp_unbind(struct device *dev, struct device *master, > > + void *data) > > +{ > > + struct mtk_mdp_dev *mdp = data; > > + struct mtk_mdp_comp *comp = dev_get_drvdata(dev); > > + > > + mtk_mdp_unregister_component(mdp, comp); > > +} > > + > > +static const struct component_ops mtk_mdp_component_ops = { > > + .bind = mtk_mdp_comp_bind, > > + .unbind = mtk_mdp_comp_unbind, > > +}; > > + > > +int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev) > > { > > int ret; > > int i; > > + struct device_node *node = dev->of_node; > > + enum mtk_mdp_comp_type comp_type = > > + (enum mtk_mdp_comp_type)of_device_get_match_data(dev); > > > > - comp->dev_node = of_node_get(node); > > - comp->type = comp_type; > > + INIT_LIST_HEAD(&comp->node); > > > > for (i = 0; i < ARRAY_SIZE(comp->clk); i++) { > > comp->clk[i] = of_clk_get(node, i); > > @@ -55,23 +118,71 @@ int mtk_mdp_comp_init(struct device *dev, struct device_node *node, > > if (PTR_ERR(comp->clk[i]) != -EPROBE_DEFER) > > dev_err(dev, "Failed to get clock\n"); > > ret = PTR_ERR(comp->clk[i]); > > - goto put_dev; > > + goto err; > > } > > > > /* Only RDMA needs two clocks */ > > - if (comp->type != MTK_MDP_RDMA) > > + if (comp_type != MTK_MDP_RDMA) > > break; > > } > > > > return 0; > > > > -put_dev: > > - of_node_put(comp->dev_node); > > +err: > > + dev_err(dev, "err %d\n", ret); > > This error is too generic. You can remove. Anyway you're printing the same error > code if mtk_mdp_comp_init fails in probe function, there makes more sense. > > > > > return ret; > > } > > > > -void mtk_mdp_comp_deinit(struct device *dev, struct mtk_mdp_comp *comp) > > +static int mtk_mdp_comp_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *vpu_node; > > + int status; > > + struct mtk_mdp_comp *comp; > > + > > + vpu_node = of_parse_phandle(dev->of_node, "mediatek,vpu", 0); > > + if (vpu_node) { > > + of_node_put(vpu_node); > > + /* > > + * The device tree node with a mediatek,vpu property is deemed > > + * the MDP "master" device, we don't want to add a component > > + * for it in this function because the initialization for the > > + * master is done elsewhere. > > + */ > > + dev_info(dev, "vpu node found, not probing\n"); > > This is the thing that I'm not completely sure is doing the right thing. Having > a DT propriety to indicate to skip the probing is really weird to me. Also the > name is quite confusing. When I read this name I'd expect mediatek,vpu being a > phandle to the VPU device node. If there is a master and childs below from > hardware POV, the DT graph should reflect that, if this is only a way to > instantiate properly the devices then I think we can find other solutions. If > you know that RDMA is always the master maybe we can just find this node. > > Other thoughts? > One way to judge it is to compare the of_device_get_match_data(dev) with MTK_MDP_RDMA. > > > + return -ENODEV; > > + } > > + > > + comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL); > > + if (!comp) > > + return -ENOMEM; > > + > > + status = mtk_mdp_comp_init(comp, dev); > > + if (status) { > > + dev_err(dev, "Failed to initialize component: %d\n", status); > > + return status; > > + } > > + > > + dev_set_drvdata(dev, comp); > > + > > + return component_add(dev, &mtk_mdp_component_ops); > > +} > > + > > +static int mtk_mdp_comp_remove(struct platform_device *pdev) > > { > > - of_node_put(comp->dev_node); > > + struct device *dev = &pdev->dev; > > + > > + component_del(dev, &mtk_mdp_component_ops); > > + return 0; > > } > > + > > +struct platform_driver mtk_mdp_component_driver = { > > + .probe = mtk_mdp_comp_probe, > > + .remove = mtk_mdp_comp_remove, > > + .driver = { > > + .name = "mediatek-mdp-comp", > > + .owner = THIS_MODULE, > > + .of_match_table = mtk_mdp_comp_driver_dt_match, > > + }, > > +}; > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h > > index 36bc1b8f6222..956d20c01e34 100644 > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h > > @@ -7,41 +7,21 @@ > > #ifndef __MTK_MDP_COMP_H__ > > #define __MTK_MDP_COMP_H__ > > > > -/** > > - * enum mtk_mdp_comp_type - the MDP component > > - * @MTK_MDP_RDMA: Read DMA > > - * @MTK_MDP_RSZ: Riszer > > - * @MTK_MDP_WDMA: Write DMA > > - * @MTK_MDP_WROT: Write DMA with rotation > > - */ > > -enum mtk_mdp_comp_type { > > - MTK_MDP_RDMA, > > - MTK_MDP_RSZ, > > - MTK_MDP_WDMA, > > - MTK_MDP_WROT, > > - MTK_MDP_COMP_TYPE_MAX, > > -}; > > - > > /** > > * struct mtk_mdp_comp - the MDP's function component data > > * @node: list node to track sibing MDP components > > - * @dev_node: component device node > > * @clk: clocks required for component > > - * @type: component type > > */ > > struct mtk_mdp_comp { > > struct list_head node; > > - struct device_node *dev_node; > > struct clk *clk[2]; > > - enum mtk_mdp_comp_type type; > > }; > > > > -int mtk_mdp_comp_init(struct device *dev, struct device_node *node, > > - struct mtk_mdp_comp *comp, > > - enum mtk_mdp_comp_type comp_type); > > -void mtk_mdp_comp_deinit(struct device *dev, struct mtk_mdp_comp *comp); > > +int mtk_mdp_comp_init(struct mtk_mdp_comp *comp, struct device *dev); > > + > > void mtk_mdp_comp_clock_on(struct device *dev, struct mtk_mdp_comp *comp); > > void mtk_mdp_comp_clock_off(struct device *dev, struct mtk_mdp_comp *comp); > > > > +extern struct platform_driver mtk_mdp_component_driver; > > > > #endif /* __MTK_MDP_COMP_H__ */ > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > > index 70a8eab16863..d79bf7f0031a 100644 > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c > > @@ -6,6 +6,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -18,6 +19,7 @@ > > #include > > #include > > > > +#include "mtk_mdp_comp.h" > > #include "mtk_mdp_core.h" > > #include "mtk_mdp_m2m.h" > > #include "mtk_vpu.h" > > @@ -31,16 +33,12 @@ module_param(mtk_mdp_dbg_level, int, 0644); > > static const struct of_device_id mtk_mdp_comp_dt_ids[] = { > > { > > .compatible = "mediatek,mt8173-mdp-rdma", > > - .data = (void *)MTK_MDP_RDMA > > }, { > > .compatible = "mediatek,mt8173-mdp-rsz", > > - .data = (void *)MTK_MDP_RSZ > > }, { > > .compatible = "mediatek,mt8173-mdp-wdma", > > - .data = (void *)MTK_MDP_WDMA > > }, { > > .compatible = "mediatek,mt8173-mdp-wrot", > > - .data = (void *)MTK_MDP_WROT > > }, > > { }, > > }; > > @@ -90,6 +88,64 @@ static void mtk_mdp_reset_handler(void *priv) > > queue_work(mdp->wdt_wq, &mdp->wdt_work); > > } > > > > +static int compare_of(struct device *dev, void *data) > > +{ > > + return dev->of_node == data; > > +} > > + > > +static void release_of(struct device *dev, void *data) > > +{ > > + of_node_put(data); > > +} > > + > > +static int mtk_mdp_master_bind(struct device *dev) > > +{ > > + int status; > > + struct mtk_mdp_dev *mdp = dev_get_drvdata(dev); > > + > > + mtk_mdp_register_component(mdp, &mdp->comp_self); > > + > > + status = component_bind_all(dev, mdp); > > + if (status) { > > + dev_err(dev, "Failed to bind all components: %d\n", status); > > + goto err_component_bind_all; > > + } > > + > > + status = mtk_mdp_register_m2m_device(mdp); > > + if (status) { > > + dev_err(dev, "Failed to register m2m device: %d\n", status); > > + v4l2_err(&mdp->v4l2_dev, "Failed to init mem2mem device\n"); > > + goto err_mtk_mdp_register_m2m_device; > > + } > > + > > + pm_runtime_enable(dev); > > + > > + return 0; > > + > > +err_mtk_mdp_register_m2m_device: > > + component_unbind_all(dev, mdp); > > + > > +err_component_bind_all: > > + mtk_mdp_unregister_component(mdp, &mdp->comp_self); > > + > > + return status; > > +} > > + > > +static void mtk_mdp_master_unbind(struct device *dev) > > +{ > > + struct mtk_mdp_dev *mdp = dev_get_drvdata(dev); > > + > > + pm_runtime_disable(dev); > > + mtk_mdp_unregister_m2m_device(mdp); > > + component_unbind_all(dev, mdp); > > + mtk_mdp_unregister_component(mdp, &mdp->comp_self); > > +} > > + > > +static const struct component_master_ops mtk_mdp_com_ops = { > > + .bind = mtk_mdp_master_bind, > > + .unbind = mtk_mdp_master_unbind, > > +}; > > + > > void mtk_mdp_register_component(struct mtk_mdp_dev *mdp, > > struct mtk_mdp_comp *comp) > > { > > @@ -107,8 +163,8 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > struct mtk_mdp_dev *mdp; > > struct device *dev = &pdev->dev; > > struct device_node *node, *parent; > > - struct mtk_mdp_comp *comp, *comp_temp; > > - int ret = 0; > > + int i, ret = 0; > > + struct component_match *match = NULL; > > > > mdp = devm_kzalloc(dev, sizeof(*mdp), GFP_KERNEL); > > if (!mdp) > > @@ -133,36 +189,43 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > } > > > > /* Iterate over sibling MDP function blocks */ > > + i = 0; > > for_each_child_of_node(parent, node) { > > - const struct of_device_id *of_id; > > - enum mtk_mdp_comp_type comp_type; > > + struct platform_device *pdev; 'pdev' is used above, so we'd better to use another variable name here to avoid confusion. > > > > - of_id = of_match_node(mtk_mdp_comp_dt_ids, node); > > - if (!of_id) > > + if (!of_match_node(mtk_mdp_comp_dt_ids, node)) > > continue; > > > > - if (!of_device_is_available(node)) { > > - dev_err(dev, "Skipping disabled component %pOF\n", > > - node); > > + if (!of_device_is_available(node)) > > continue; > > - } > > > > - comp_type = (enum mtk_mdp_comp_type)of_id->data; > > - > > - comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL); > > - if (!comp) { > > - ret = -ENOMEM; > > - of_node_put(node); > > - goto err_comp; > > + pdev = of_find_device_by_node(node); > > + if (!pdev) { > > + dev_warn(dev, "Unable to find comp device %s\n", > > + node->full_name); > > + continue; > > } > > > > - ret = mtk_mdp_comp_init(dev, node, comp, comp_type); > > - if (ret) { > > - of_node_put(node); > > - goto err_comp; > > + /* > > + * Do not add a match for my own (rdma0) device node. > > + * I will be managing it directly instead using comp_self. > > + */ > > + if (&pdev->dev != dev) { > > + dev_dbg(dev, "adding match %d for: %pOF\n", i++, node); > > + component_match_add_release(dev, &match, release_of, > > + compare_of, > > + of_node_get(node)); > > } > > + } > > > > - mtk_mdp_register_component(mdp, comp); > > + /* > > + * Create a component for myself so that clocks can be toggled in > > + * clock_on(). > > + */ > > + ret = mtk_mdp_comp_init(&mdp->comp_self, dev); > > + if (ret) { > > + dev_err(dev, "Failed to initialize component\n"); > > + goto err_comp; > > } > > > > mdp->job_wq = create_singlethread_workqueue(MTK_MDP_MODULE_NAME); > > @@ -187,18 +250,12 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > goto err_dev_register; > > } > > > > - ret = mtk_mdp_register_m2m_device(mdp); > > - if (ret) { > > - v4l2_err(&mdp->v4l2_dev, "Failed to init mem2mem device\n"); > > - goto err_m2m_register; > > - } > > - > > mdp->vpu_dev = vpu_get_plat_device(pdev); > > ret = vpu_wdt_reg_handler(mdp->vpu_dev, mtk_mdp_reset_handler, mdp, > > VPU_RST_MDP); > > if (ret) { > > dev_err(&pdev->dev, "Failed to register reset handler\n"); > > - goto err_m2m_register; > > + goto err_wdt_reg; > > } > > > > platform_set_drvdata(pdev, mdp); > > @@ -206,15 +263,25 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > ret = vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); > > if (ret) { > > dev_err(&pdev->dev, "Failed to set vb2 dma mag seg size\n"); > > - goto err_m2m_register; > > + goto err_set_max_seg_size; > > + } > > + > > + ret = component_master_add_with_match(dev, &mtk_mdp_com_ops, match); > > + if (ret) { > > + dev_err(dev, "Component master add failed\n"); > > + goto err_component_master_add; > > } > > > > - pm_runtime_enable(dev); > > dev_dbg(dev, "mdp-%d registered successfully\n", mdp->id); > > > > return 0; > > > > -err_m2m_register: > > +err_component_master_add: > > + vb2_dma_contig_clear_max_seg_size(&pdev->dev); > > + > > +err_set_max_seg_size: > > + > > +err_wdt_reg: > > v4l2_device_unregister(&mdp->v4l2_dev); > > > > err_dev_register: > > @@ -226,11 +293,6 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > err_alloc_job_wq: > > > > err_comp: > > - list_for_each_entry_safe(comp, comp_temp, &mdp->comp_list, node) { > > - mtk_mdp_unregister_component(mdp, comp); > > - mtk_mdp_comp_deinit(dev, comp); > > - } > > - > > dev_dbg(dev, "err %d\n", ret); > > return ret; > > } > > @@ -238,11 +300,10 @@ static int mtk_mdp_probe(struct platform_device *pdev) > > static int mtk_mdp_remove(struct platform_device *pdev) > > { > > struct mtk_mdp_dev *mdp = platform_get_drvdata(pdev); > > - struct mtk_mdp_comp *comp, *comp_temp; > > > > - pm_runtime_disable(&pdev->dev); > > + component_master_del(&pdev->dev, &mtk_mdp_com_ops); > > + > > vb2_dma_contig_clear_max_seg_size(&pdev->dev); > > - mtk_mdp_unregister_m2m_device(mdp); > > v4l2_device_unregister(&mdp->v4l2_dev); > > > > flush_workqueue(mdp->wdt_wq); > > @@ -251,10 +312,8 @@ static int mtk_mdp_remove(struct platform_device *pdev) > > flush_workqueue(mdp->job_wq); > > destroy_workqueue(mdp->job_wq); > > > > - list_for_each_entry_safe(comp, comp_temp, &mdp->comp_list, node) { > > - mtk_mdp_unregister_component(mdp, comp); > > - mtk_mdp_comp_deinit(&pdev->dev, comp); > > - } > > + if (!list_empty(&mdp->comp_list)) > > + dev_err(&pdev->dev, "not all components removed\n"); > > > > dev_dbg(&pdev->dev, "%s driver unloaded\n", pdev->name); > > return 0; > > @@ -309,7 +368,25 @@ static struct platform_driver mtk_mdp_driver = { > > } > > }; > > > > -module_platform_driver(mtk_mdp_driver); > > +static struct platform_driver * const mtk_mdp_drivers[] = { > > + &mtk_mdp_driver, > > + &mtk_mdp_component_driver, > > +}; > > + > > +static int __init mtk_mdp_init(void) > > +{ > > + return platform_register_drivers(mtk_mdp_drivers, > > + ARRAY_SIZE(mtk_mdp_drivers)); > > +} > > + > > +static void __exit mtk_mdp_exit(void) > > +{ > > + platform_unregister_drivers(mtk_mdp_drivers, > > + ARRAY_SIZE(mtk_mdp_drivers)); > > +} > > + > > +module_init(mtk_mdp_init); > > +module_exit(mtk_mdp_exit); > > > > MODULE_AUTHOR("Houlong Wei "); > > MODULE_DESCRIPTION("Mediatek image processor driver"); > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.h b/drivers/media/platform/mtk-mdp/mtk_mdp_core.h > > index a7da14b97077..230f531400ca 100644 > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.h > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.h > > @@ -155,6 +155,7 @@ struct mtk_mdp_dev { > > struct mtk_mdp_variant *variant; > > u16 id; > > struct list_head comp_list; > > + struct mtk_mdp_comp comp_self; > > struct v4l2_m2m_dev *m2m_dev; > > struct list_head ctx_list; > > struct video_device *vdev; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel