* [PATCH net-next] net: x25: Use list_for_each_entry() to simplify code in x25_link.c
@ 2021-06-08 8:05 ` Wang Hai
0 siblings, 0 replies; 3+ messages in thread
From: Wang Hai @ 2021-06-08 8:05 UTC (permalink / raw)
To: davem, kuba, ms; +Cc: linux-x25, netdev, linux-kernel
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
net/x25/x25_link.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c
index 57a81100c5da..5460b9146dd8 100644
--- a/net/x25/x25_link.c
+++ b/net/x25/x25_link.c
@@ -332,12 +332,9 @@ void x25_link_device_down(struct net_device *dev)
struct x25_neigh *x25_get_neigh(struct net_device *dev)
{
struct x25_neigh *nb, *use = NULL;
- struct list_head *entry;
read_lock_bh(&x25_neigh_list_lock);
- list_for_each(entry, &x25_neigh_list) {
- nb = list_entry(entry, struct x25_neigh, node);
-
+ list_for_each_entry(nb, &x25_neigh_list, node) {
if (nb->dev == dev) {
use = nb;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH net-next] net: x25: Use list_for_each_entry() to simplify code in x25_link.c
@ 2021-06-08 8:05 ` Wang Hai
0 siblings, 0 replies; 3+ messages in thread
From: Wang Hai @ 2021-06-08 8:05 UTC (permalink / raw)
To: davem, kuba, ms; +Cc: linux-x25, netdev, linux-kernel
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
net/x25/x25_link.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c
index 57a81100c5da..5460b9146dd8 100644
--- a/net/x25/x25_link.c
+++ b/net/x25/x25_link.c
@@ -332,12 +332,9 @@ void x25_link_device_down(struct net_device *dev)
struct x25_neigh *x25_get_neigh(struct net_device *dev)
{
struct x25_neigh *nb, *use = NULL;
- struct list_head *entry;
read_lock_bh(&x25_neigh_list_lock);
- list_for_each(entry, &x25_neigh_list) {
- nb = list_entry(entry, struct x25_neigh, node);
-
+ list_for_each_entry(nb, &x25_neigh_list, node) {
if (nb->dev == dev) {
use = nb;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: x25: Use list_for_each_entry() to simplify code in x25_link.c
2021-06-08 8:05 ` Wang Hai
(?)
@ 2021-06-08 23:40 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-08 23:40 UTC (permalink / raw)
To: Wang Hai; +Cc: davem, kuba, ms, linux-x25, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 8 Jun 2021 08:05:05 +0000 you wrote:
> Convert list_for_each() to list_for_each_entry() where
> applicable. This simplifies the code.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> net/x25/x25_link.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Here is the summary with links:
- [net-next] net: x25: Use list_for_each_entry() to simplify code in x25_link.c
https://git.kernel.org/netdev/net-next/c/3835a6614ae7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-08 23:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 8:05 [PATCH net-next] net: x25: Use list_for_each_entry() to simplify code in x25_link.c Wang Hai
2021-06-08 8:05 ` Wang Hai
2021-06-08 23:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.