* [PATCH v2 1/1] scsi: ufs: Fix a possible use before initialization case
@ 2021-06-09 6:39 ` Can Guo
0 siblings, 0 replies; 3+ messages in thread
From: Can Guo @ 2021-06-09 6:39 UTC (permalink / raw)
To: asutoshd, nguyenb, hongwus, ziqichen, linux-scsi, kernel-team, cang
Cc: Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, Matthias Brugger, Stanley Chu, Bean Huo,
Jaegeuk Kim, open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
In ufshcd_exec_dev_cmd(), if error happens before lrpb is initialized,
then we should bail out instead of letting trace record the error.
Fixes: a45f937110fa6 ("scsi: ufs: Optimize host lock on transfer requests send/compl paths")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Can Guo <cang@codeaurora.org>
---
Change since V1:
- Use codeaurora mail in Signed-off-by tag.
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index fe1b5f4..0d54ab7 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -2972,7 +2972,7 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba *hba,
if (unlikely(test_bit(tag, &hba->outstanding_reqs))) {
err = -EBUSY;
- goto out;
+ goto out_put_tag;
}
init_completion(&wait);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 1/1] scsi: ufs: Fix a possible use before initialization case
@ 2021-06-09 6:39 ` Can Guo
0 siblings, 0 replies; 3+ messages in thread
From: Can Guo @ 2021-06-09 6:39 UTC (permalink / raw)
To: asutoshd, nguyenb, hongwus, ziqichen, linux-scsi, kernel-team, cang
Cc: Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, Matthias Brugger, Stanley Chu, Bean Huo,
Jaegeuk Kim, open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
In ufshcd_exec_dev_cmd(), if error happens before lrpb is initialized,
then we should bail out instead of letting trace record the error.
Fixes: a45f937110fa6 ("scsi: ufs: Optimize host lock on transfer requests send/compl paths")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Can Guo <cang@codeaurora.org>
---
Change since V1:
- Use codeaurora mail in Signed-off-by tag.
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index fe1b5f4..0d54ab7 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -2972,7 +2972,7 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba *hba,
if (unlikely(test_bit(tag, &hba->outstanding_reqs))) {
err = -EBUSY;
- goto out;
+ goto out_put_tag;
}
init_completion(&wait);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 1/1] scsi: ufs: Fix a possible use before initialization case
@ 2021-06-09 6:39 ` Can Guo
0 siblings, 0 replies; 3+ messages in thread
From: Can Guo @ 2021-06-09 6:39 UTC (permalink / raw)
To: asutoshd, nguyenb, hongwus, ziqichen, linux-scsi, kernel-team, cang
Cc: Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, Matthias Brugger, Stanley Chu, Bean Huo,
Jaegeuk Kim, open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
In ufshcd_exec_dev_cmd(), if error happens before lrpb is initialized,
then we should bail out instead of letting trace record the error.
Fixes: a45f937110fa6 ("scsi: ufs: Optimize host lock on transfer requests send/compl paths")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Can Guo <cang@codeaurora.org>
---
Change since V1:
- Use codeaurora mail in Signed-off-by tag.
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index fe1b5f4..0d54ab7 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -2972,7 +2972,7 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba *hba,
if (unlikely(test_bit(tag, &hba->outstanding_reqs))) {
err = -EBUSY;
- goto out;
+ goto out_put_tag;
}
init_completion(&wait);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-09 6:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 6:39 [PATCH v2 1/1] scsi: ufs: Fix a possible use before initialization case Can Guo
2021-06-09 6:39 ` Can Guo
2021-06-09 6:39 ` Can Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.