* [PATCH] memory: tegra: Delete dead debugfs checking code
@ 2021-06-09 9:55 Dan Carpenter
2021-06-10 7:22 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-06-09 9:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Joseph Lo
Cc: Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
Nathan Chancellor, Qinglang Miao, Viresh Kumar, Yang Li,
Chanwoo Choi, Geert Uytterhoeven, linux-kernel, linux-tegra,
kernel-janitors
The debugfs_create_dir() function does not return NULL, it returns error
pointers. But in normal situations like this where the caller is not
dereferencing "emc->debugfs.root" then we are not supposed to check the
return. So instead of fixing these checks, we should delete them.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/memory/tegra/tegra124-emc.c | 4 ----
drivers/memory/tegra/tegra20-emc.c | 4 ----
drivers/memory/tegra/tegra210-emc-core.c | 4 ----
drivers/memory/tegra/tegra30-emc.c | 4 ----
4 files changed, 16 deletions(-)
diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c
index a21ca8e0841a..908f8d5392b2 100644
--- a/drivers/memory/tegra/tegra124-emc.c
+++ b/drivers/memory/tegra/tegra124-emc.c
@@ -1269,10 +1269,6 @@ static void emc_debugfs_init(struct device *dev, struct tegra_emc *emc)
}
emc->debugfs.root = debugfs_create_dir("emc", NULL);
- if (!emc->debugfs.root) {
- dev_err(dev, "failed to create debugfs directory\n");
- return;
- }
debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc,
&tegra_emc_debug_available_rates_fops);
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
index a534197a5fb2..c3462dbc8c22 100644
--- a/drivers/memory/tegra/tegra20-emc.c
+++ b/drivers/memory/tegra/tegra20-emc.c
@@ -776,10 +776,6 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
}
emc->debugfs.root = debugfs_create_dir("emc", NULL);
- if (!emc->debugfs.root) {
- dev_err(emc->dev, "failed to create debugfs directory\n");
- return;
- }
debugfs_create_file("available_rates", 0444, emc->debugfs.root,
emc, &tegra_emc_debug_available_rates_fops);
diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
index 5f224796e32e..06c0f17fa429 100644
--- a/drivers/memory/tegra/tegra210-emc-core.c
+++ b/drivers/memory/tegra/tegra210-emc-core.c
@@ -1759,10 +1759,6 @@ static void tegra210_emc_debugfs_init(struct tegra210_emc *emc)
}
emc->debugfs.root = debugfs_create_dir("emc", NULL);
- if (!emc->debugfs.root) {
- dev_err(dev, "failed to create debugfs directory\n");
- return;
- }
debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc,
&tegra210_emc_debug_available_rates_fops);
diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
index 63e1983f8a0d..7e21a852f2e1 100644
--- a/drivers/memory/tegra/tegra30-emc.c
+++ b/drivers/memory/tegra/tegra30-emc.c
@@ -1354,10 +1354,6 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
}
emc->debugfs.root = debugfs_create_dir("emc", NULL);
- if (!emc->debugfs.root) {
- dev_err(emc->dev, "failed to create debugfs directory\n");
- return;
- }
debugfs_create_file("available_rates", 0444, emc->debugfs.root,
emc, &tegra_emc_debug_available_rates_fops);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memory: tegra: Delete dead debugfs checking code
2021-06-09 9:55 [PATCH] memory: tegra: Delete dead debugfs checking code Dan Carpenter
@ 2021-06-10 7:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-06-10 7:22 UTC (permalink / raw)
To: Dan Carpenter, Joseph Lo
Cc: Krzysztof Kozlowski, Thierry Reding, linux-tegra, Viresh Kumar,
Geert Uytterhoeven, Nathan Chancellor, Jonathan Hunter,
Dmitry Osipenko, Qinglang Miao, Yang Li, linux-kernel,
Chanwoo Choi, kernel-janitors
On Wed, 9 Jun 2021 12:55:25 +0300, Dan Carpenter wrote:
> The debugfs_create_dir() function does not return NULL, it returns error
> pointers. But in normal situations like this where the caller is not
> dereferencing "emc->debugfs.root" then we are not supposed to check the
> return. So instead of fixing these checks, we should delete them.
Applied, thanks!
[1/1] memory: tegra: Delete dead debugfs checking code
commit: c7c65703260c88a3e4d7387b2d03023c3625c6d4
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-10 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 9:55 [PATCH] memory: tegra: Delete dead debugfs checking code Dan Carpenter
2021-06-10 7:22 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.