[PATCH] drm/i915: Add relocation exceptions for two other platforms

[PATCH] drm/i915: Add relocation exceptions for two other platforms

[Zbigniew Kempczyński]

We have established previously we stop using relocations starting
from gen12 platforms with Tigerlake as an exception. We keep this
statement but we want to enable relocations conditionally for
Rocketlake and Alderlake under require_force_probe flag set.

Keeping relocations under require_force_probe flag is interim solution
until IGTs will be rewritten to use softpin.

v2: - remove inline from function definition (Jani)
    - fix indentation

v3: change to GRAPHICS_VER() (Zbigniew)

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Acked-by: Dave Airlie <airlied@redhat.com>
---
 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index a8abc9af5ff4..30c4f0549ea0 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
 	ev->flags &= ~__EXEC_OBJECT_RESERVED;
 }
 
+static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
+{
+	/*
+	 * Relocations are disallowed starting from gen12 with Tigerlake
+	 * as an exception. We allow temporarily use relocations for Rocketlake
+	 * and Alderlake when require_force_probe flag is set.
+	 */
+	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
+		return true;
+
+	if (INTEL_INFO(eb->i915)->require_force_probe &&
+	    (IS_ROCKETLAKE(eb->i915) || IS_ALDERLAKE_S(eb->i915) ||
+	     IS_ALDERLAKE_P(eb->i915)))
+		return true;
+
+	return false;
+}
+
 static int
 eb_validate_vma(struct i915_execbuffer *eb,
 		struct drm_i915_gem_exec_object2 *entry,
 		struct i915_vma *vma)
 {
-	/* Relocations are disallowed for all platforms after TGL-LP.  This
-	 * also covers all platforms with local memory.
-	 */
-	if (entry->relocation_count &&
-	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
+	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
 		return -EINVAL;
 
 	if (unlikely(entry->flags & eb->invalid_flags))
-- 
2.26.0

[Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Zbigniew Kempczyński]

We have established previously we stop using relocations starting
from gen12 platforms with Tigerlake as an exception. We keep this
statement but we want to enable relocations conditionally for
Rocketlake and Alderlake under require_force_probe flag set.

Keeping relocations under require_force_probe flag is interim solution
until IGTs will be rewritten to use softpin.

v2: - remove inline from function definition (Jani)
    - fix indentation

v3: change to GRAPHICS_VER() (Zbigniew)

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Acked-by: Dave Airlie <airlied@redhat.com>
---
 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index a8abc9af5ff4..30c4f0549ea0 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
 	ev->flags &= ~__EXEC_OBJECT_RESERVED;
 }
 
+static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
+{
+	/*
+	 * Relocations are disallowed starting from gen12 with Tigerlake
+	 * as an exception. We allow temporarily use relocations for Rocketlake
+	 * and Alderlake when require_force_probe flag is set.
+	 */
+	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
+		return true;
+
+	if (INTEL_INFO(eb->i915)->require_force_probe &&
+	    (IS_ROCKETLAKE(eb->i915) || IS_ALDERLAKE_S(eb->i915) ||
+	     IS_ALDERLAKE_P(eb->i915)))
+		return true;
+
+	return false;
+}
+
 static int
 eb_validate_vma(struct i915_execbuffer *eb,
 		struct drm_i915_gem_exec_object2 *entry,
 		struct i915_vma *vma)
 {
-	/* Relocations are disallowed for all platforms after TGL-LP.  This
-	 * also covers all platforms with local memory.
-	 */
-	if (entry->relocation_count &&
-	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
+	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
 		return -EINVAL;
 
 	if (unlikely(entry->flags & eb->invalid_flags))
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add relocation exceptions for two other platforms (rev5)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 6556 bytes --]

== Series Details ==

Series: drm/i915: Add relocation exceptions for two other platforms (rev5)
URL   : https://patchwork.freedesktop.org/series/89594/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10204 -> Patchwork_20330
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/index.html

Known issues
------------

  Here are the changes found in Patchwork_20330 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-bdw-5557u:       NOTRUN -> [WARN][1] ([i915#2283])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html

  * igt@i915_selftest@live@execlists:
    - fi-bdw-5557u:       NOTRUN -> [DMESG-FAIL][2] ([i915#3462])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-bdw-5557u/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-icl-u2:          [PASS][3] -> [DMESG-FAIL][4] ([i915#2291] / [i915#541])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/fi-icl-u2/igt@i915_selftest@live@gt_heartbeat.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-icl-u2/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-icl-u2:          [PASS][6] -> [DMESG-WARN][7] ([i915#2203] / [i915#2868])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_psr@cursor_plane_move:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][8] ([fdo#109271]) +9 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html

  * igt@runner@aborted:
    - fi-bdw-5557u:       NOTRUN -> [FAIL][9] ([i915#3462])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-bdw-5557u/igt@runner@aborted.html

  
#### Warnings ####

  * igt@i915_selftest@live@execlists:
    - fi-cml-s:           [INCOMPLETE][10] ([i915#3462]) -> [DMESG-FAIL][11] ([i915#3462])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/fi-cml-s/igt@i915_selftest@live@execlists.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-cml-s/igt@i915_selftest@live@execlists.html

  * igt@runner@aborted:
    - fi-cfl-8700k:       [FAIL][12] ([i915#3363]) -> [FAIL][13] ([i915#2426] / [i915#3363])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/fi-cfl-8700k/igt@runner@aborted.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-cfl-8700k/igt@runner@aborted.html
    - fi-glk-dsi:         [FAIL][14] ([i915#3363] / [k.org#202321]) -> [FAIL][15] ([i915#2426] / [i915#3363] / [k.org#202321])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/fi-glk-dsi/igt@runner@aborted.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-glk-dsi/igt@runner@aborted.html
    - fi-kbl-r:           [FAIL][16] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][17] ([i915#1436] / [i915#3363])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/fi-kbl-r/igt@runner@aborted.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-kbl-r/igt@runner@aborted.html
    - fi-kbl-soraka:      [FAIL][18] ([i915#1436] / [i915#3363]) -> [FAIL][19] ([i915#1436] / [i915#2426] / [i915#3363])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/fi-kbl-soraka/igt@runner@aborted.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-kbl-soraka/igt@runner@aborted.html
    - fi-kbl-7500u:       [FAIL][20] ([i915#1436] / [i915#3363]) -> [FAIL][21] ([i915#1436] / [i915#2426] / [i915#3363])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/fi-kbl-7500u/igt@runner@aborted.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-kbl-7500u/igt@runner@aborted.html
    - fi-skl-guc:         [FAIL][22] ([i915#1436] / [i915#3363]) -> [FAIL][23] ([i915#1436] / [i915#2426] / [i915#3363])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/fi-skl-guc/igt@runner@aborted.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/fi-skl-guc/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
  [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
  [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
  [i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
  [i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
  [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
  [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321


Participating hosts (39 -> 37)
------------------------------

  Additional (1): fi-bdw-5557u 
  Missing    (3): fi-ilk-m540 fi-bdw-samus fi-hsw-4200u 


Build changes
-------------

  * Linux: CI_DRM_10204 -> Patchwork_20330

  CI-20190529: 20190529
  CI_DRM_10204: 49f55716c1c64348b925292c6cbaca589a6480e6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6103: 3aa79e55e73d4a49a5222e5dfde486b800a29fe7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_20330: 8ea98a31aee7205732d42302847a8b71264d76fc @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

8ea98a31aee7 drm/i915: Add relocation exceptions for two other platforms

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/index.html

[-- Attachment #1.2: Type: text/html, Size: 9140 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Rodrigo Vivi]

On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> We have established previously we stop using relocations starting
> from gen12 platforms with Tigerlake as an exception. We keep this
> statement but we want to enable relocations conditionally for
> Rocketlake and Alderlake under require_force_probe flag set.
> 
> Keeping relocations under require_force_probe flag is interim solution
> until IGTs will be rewritten to use softpin.

hmm... to be really honest I'm not so happy that we are introducing
a new criteria to the force_probe.

The criteria was to have a functional driver and not to track uapi.

But on the other hand I do recognize that the current definition
of the flag allows that, because we have established that with
this behavior, the "driver for new Intel graphics devices that
are recognized but not properly supported by this kernel version"
(as stated in the Kconfig for the DRM_I915_FORCE_PROBE).

However...

> 
> v2: - remove inline from function definition (Jani)
>     - fix indentation
> 
> v3: change to GRAPHICS_VER() (Zbigniew)
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Acked-by: Dave Airlie <airlied@redhat.com>
> ---
>  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
>  1 file changed, 19 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index a8abc9af5ff4..30c4f0549ea0 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
>  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
>  }
>  
> +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> +{
> +	/*
> +	 * Relocations are disallowed starting from gen12 with Tigerlake
> +	 * as an exception. We allow temporarily use relocations for Rocketlake
> +	 * and Alderlake when require_force_probe flag is set.
> +	 */
> +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> +		return true;
> +
> +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> +	    (IS_ROCKETLAKE(eb->i915)

This ship has sailed... RKL is not protected by this flag any longer.
Should this be on the TGL side now?

>  || IS_ALDERLAKE_S(eb->i915) ||
> +	     IS_ALDERLAKE_P(eb->i915)))

How to ensure that we will easily catch this when removing the
flag?

I mean, should we have a GEM_BUG or drm_err message when these
platforms in this list has not the required_force_probe?

> +		return true;
> +
> +	return false;
> +}
> +
>  static int
>  eb_validate_vma(struct i915_execbuffer *eb,
>  		struct drm_i915_gem_exec_object2 *entry,
>  		struct i915_vma *vma)
>  {
> -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> -	 * also covers all platforms with local memory.
> -	 */
> -	if (entry->relocation_count &&
> -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
>  		return -EINVAL;
>  
>  	if (unlikely(entry->flags & eb->invalid_flags))
> -- 
> 2.26.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Rodrigo Vivi]

On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> We have established previously we stop using relocations starting
> from gen12 platforms with Tigerlake as an exception. We keep this
> statement but we want to enable relocations conditionally for
> Rocketlake and Alderlake under require_force_probe flag set.
> 
> Keeping relocations under require_force_probe flag is interim solution
> until IGTs will be rewritten to use softpin.

hmm... to be really honest I'm not so happy that we are introducing
a new criteria to the force_probe.

The criteria was to have a functional driver and not to track uapi.

But on the other hand I do recognize that the current definition
of the flag allows that, because we have established that with
this behavior, the "driver for new Intel graphics devices that
are recognized but not properly supported by this kernel version"
(as stated in the Kconfig for the DRM_I915_FORCE_PROBE).

However...

> 
> v2: - remove inline from function definition (Jani)
>     - fix indentation
> 
> v3: change to GRAPHICS_VER() (Zbigniew)
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Acked-by: Dave Airlie <airlied@redhat.com>
> ---
>  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
>  1 file changed, 19 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index a8abc9af5ff4..30c4f0549ea0 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
>  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
>  }
>  
> +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> +{
> +	/*
> +	 * Relocations are disallowed starting from gen12 with Tigerlake
> +	 * as an exception. We allow temporarily use relocations for Rocketlake
> +	 * and Alderlake when require_force_probe flag is set.
> +	 */
> +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> +		return true;
> +
> +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> +	    (IS_ROCKETLAKE(eb->i915)

This ship has sailed... RKL is not protected by this flag any longer.
Should this be on the TGL side now?

>  || IS_ALDERLAKE_S(eb->i915) ||
> +	     IS_ALDERLAKE_P(eb->i915)))

How to ensure that we will easily catch this when removing the
flag?

I mean, should we have a GEM_BUG or drm_err message when these
platforms in this list has not the required_force_probe?

> +		return true;
> +
> +	return false;
> +}
> +
>  static int
>  eb_validate_vma(struct i915_execbuffer *eb,
>  		struct drm_i915_gem_exec_object2 *entry,
>  		struct i915_vma *vma)
>  {
> -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> -	 * also covers all platforms with local memory.
> -	 */
> -	if (entry->relocation_count &&
> -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
>  		return -EINVAL;
>  
>  	if (unlikely(entry->flags & eb->invalid_flags))
> -- 
> 2.26.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Zbigniew Kempczyński]

On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote:
> On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> > We have established previously we stop using relocations starting
> > from gen12 platforms with Tigerlake as an exception. We keep this
> > statement but we want to enable relocations conditionally for
> > Rocketlake and Alderlake under require_force_probe flag set.
> > 
> > Keeping relocations under require_force_probe flag is interim solution
> > until IGTs will be rewritten to use softpin.
> 
> hmm... to be really honest I'm not so happy that we are introducing
> a new criteria to the force_probe.
> 
> The criteria was to have a functional driver and not to track uapi.
> 
> But on the other hand I do recognize that the current definition
> of the flag allows that, because we have established that with
> this behavior, the "driver for new Intel graphics devices that
> are recognized but not properly supported by this kernel version"
> (as stated in the Kconfig for the DRM_I915_FORCE_PROBE).
> 
> However...
> 
> > 
> > v2: - remove inline from function definition (Jani)
> >     - fix indentation
> > 
> > v3: change to GRAPHICS_VER() (Zbigniew)
> > 
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > Cc: Dave Airlie <airlied@redhat.com>
> > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > Acked-by: Dave Airlie <airlied@redhat.com>
> > ---
> >  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
> >  1 file changed, 19 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > index a8abc9af5ff4..30c4f0549ea0 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
> >  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
> >  }
> >  
> > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> > +{
> > +	/*
> > +	 * Relocations are disallowed starting from gen12 with Tigerlake
> > +	 * as an exception. We allow temporarily use relocations for Rocketlake
> > +	 * and Alderlake when require_force_probe flag is set.
> > +	 */
> > +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > +		return true;
> > +
> > +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> > +	    (IS_ROCKETLAKE(eb->i915)
> 
> This ship has sailed... RKL is not protected by this flag any longer.
> Should this be on the TGL side now?

+Lucas

I think no, RKL has relocations disabled so we cannot put it to TGL side.
So if RKL is already released then putting it under require_force_probe 
flag is wrong and only I can do is to remove it from that condition. 
There's no option to unblock RKL on IGT CI until we rewrite all the tests.
We have to rely then on ADL* with require_force_probe flag to check how
ADL will work with relocations. 

> 
> >  || IS_ALDERLAKE_S(eb->i915) ||
> > +	     IS_ALDERLAKE_P(eb->i915)))
> 
> How to ensure that we will easily catch this when removing the
> flag?
> 
> I mean, should we have a GEM_BUG or drm_err message when these
> platforms in this list has not the required_force_probe?

I don't think we need GEM_BUG()/drm_err() - when IGT tests will support
both - reloc + no-reloc - then condition will be limited to:

        if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
                return true;
 
        return false;

so require_force_probe condition will be deleted and we won't need it
anymore (IGTs will be ready).

--
Zbigniew

> 
> > +		return true;
> > +
> > +	return false;
> > +}
> > +
> >  static int
> >  eb_validate_vma(struct i915_execbuffer *eb,
> >  		struct drm_i915_gem_exec_object2 *entry,
> >  		struct i915_vma *vma)
> >  {
> > -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> > -	 * also covers all platforms with local memory.
> > -	 */
> > -	if (entry->relocation_count &&
> > -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> > +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
> >  		return -EINVAL;
> >  
> >  	if (unlikely(entry->flags & eb->invalid_flags))
> > -- 
> > 2.26.0
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Zbigniew Kempczyński]

On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote:
> On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> > We have established previously we stop using relocations starting
> > from gen12 platforms with Tigerlake as an exception. We keep this
> > statement but we want to enable relocations conditionally for
> > Rocketlake and Alderlake under require_force_probe flag set.
> > 
> > Keeping relocations under require_force_probe flag is interim solution
> > until IGTs will be rewritten to use softpin.
> 
> hmm... to be really honest I'm not so happy that we are introducing
> a new criteria to the force_probe.
> 
> The criteria was to have a functional driver and not to track uapi.
> 
> But on the other hand I do recognize that the current definition
> of the flag allows that, because we have established that with
> this behavior, the "driver for new Intel graphics devices that
> are recognized but not properly supported by this kernel version"
> (as stated in the Kconfig for the DRM_I915_FORCE_PROBE).
> 
> However...
> 
> > 
> > v2: - remove inline from function definition (Jani)
> >     - fix indentation
> > 
> > v3: change to GRAPHICS_VER() (Zbigniew)
> > 
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > Cc: Dave Airlie <airlied@redhat.com>
> > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > Acked-by: Dave Airlie <airlied@redhat.com>
> > ---
> >  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
> >  1 file changed, 19 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > index a8abc9af5ff4..30c4f0549ea0 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
> >  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
> >  }
> >  
> > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> > +{
> > +	/*
> > +	 * Relocations are disallowed starting from gen12 with Tigerlake
> > +	 * as an exception. We allow temporarily use relocations for Rocketlake
> > +	 * and Alderlake when require_force_probe flag is set.
> > +	 */
> > +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > +		return true;
> > +
> > +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> > +	    (IS_ROCKETLAKE(eb->i915)
> 
> This ship has sailed... RKL is not protected by this flag any longer.
> Should this be on the TGL side now?

+Lucas

I think no, RKL has relocations disabled so we cannot put it to TGL side.
So if RKL is already released then putting it under require_force_probe 
flag is wrong and only I can do is to remove it from that condition. 
There's no option to unblock RKL on IGT CI until we rewrite all the tests.
We have to rely then on ADL* with require_force_probe flag to check how
ADL will work with relocations. 

> 
> >  || IS_ALDERLAKE_S(eb->i915) ||
> > +	     IS_ALDERLAKE_P(eb->i915)))
> 
> How to ensure that we will easily catch this when removing the
> flag?
> 
> I mean, should we have a GEM_BUG or drm_err message when these
> platforms in this list has not the required_force_probe?

I don't think we need GEM_BUG()/drm_err() - when IGT tests will support
both - reloc + no-reloc - then condition will be limited to:

        if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
                return true;
 
        return false;

so require_force_probe condition will be deleted and we won't need it
anymore (IGTs will be ready).

--
Zbigniew

> 
> > +		return true;
> > +
> > +	return false;
> > +}
> > +
> >  static int
> >  eb_validate_vma(struct i915_execbuffer *eb,
> >  		struct drm_i915_gem_exec_object2 *entry,
> >  		struct i915_vma *vma)
> >  {
> > -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> > -	 * also covers all platforms with local memory.
> > -	 */
> > -	if (entry->relocation_count &&
> > -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> > +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
> >  		return -EINVAL;
> >  
> >  	if (unlikely(entry->flags & eb->invalid_flags))
> > -- 
> > 2.26.0
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Rodrigo Vivi]

On Fri, Jun 11, 2021 at 08:09:00AM +0200, Zbigniew Kempczyński wrote:
> On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote:
> > On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> > > We have established previously we stop using relocations starting
> > > from gen12 platforms with Tigerlake as an exception. We keep this
> > > statement but we want to enable relocations conditionally for
> > > Rocketlake and Alderlake under require_force_probe flag set.
> > > 
> > > Keeping relocations under require_force_probe flag is interim solution
> > > until IGTs will be rewritten to use softpin.
> > 
> > hmm... to be really honest I'm not so happy that we are introducing
> > a new criteria to the force_probe.
> > 
> > The criteria was to have a functional driver and not to track uapi.
> > 
> > But on the other hand I do recognize that the current definition
> > of the flag allows that, because we have established that with
> > this behavior, the "driver for new Intel graphics devices that
> > are recognized but not properly supported by this kernel version"
> > (as stated in the Kconfig for the DRM_I915_FORCE_PROBE).
> > 
> > However...
> > 
> > > 
> > > v2: - remove inline from function definition (Jani)
> > >     - fix indentation
> > > 
> > > v3: change to GRAPHICS_VER() (Zbigniew)
> > > 
> > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > > Cc: Dave Airlie <airlied@redhat.com>
> > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > > Acked-by: Dave Airlie <airlied@redhat.com>
> > > ---
> > >  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
> > >  1 file changed, 19 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > index a8abc9af5ff4..30c4f0549ea0 100644
> > > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
> > >  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
> > >  }
> > >  
> > > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> > > +{
> > > +	/*
> > > +	 * Relocations are disallowed starting from gen12 with Tigerlake
> > > +	 * as an exception. We allow temporarily use relocations for Rocketlake
> > > +	 * and Alderlake when require_force_probe flag is set.
> > > +	 */
> > > +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > > +		return true;
> > > +
> > > +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> > > +	    (IS_ROCKETLAKE(eb->i915)
> > 
> > This ship has sailed... RKL is not protected by this flag any longer.
> > Should this be on the TGL side now?
> 
> +Lucas
> 
> I think no, RKL has relocations disabled so we cannot put it to TGL side.
> So if RKL is already released then putting it under require_force_probe 
> flag is wrong and only I can do is to remove it from that condition. 
> There's no option to unblock RKL on IGT CI until we rewrite all the tests.
> We have to rely then on ADL* with require_force_probe flag to check how
> ADL will work with relocations. 

So... I'm confused now. I'm missing the point of this patch then.
I thought the reason was to protect from any user space to attempt to
use the relocation, unless using the force_probe temporarily only for
these platforms.
But if I'm understanding correctly now it is only to silence CI?!
Is that the case?
Is the CI noise so bad?

> 
> > 
> > >  || IS_ALDERLAKE_S(eb->i915) ||
> > > +	     IS_ALDERLAKE_P(eb->i915)))
> > 
> > How to ensure that we will easily catch this when removing the
> > flag?
> > 
> > I mean, should we have a GEM_BUG or drm_err message when these
> > platforms in this list has not the required_force_probe?
> 
> I don't think we need GEM_BUG()/drm_err() - when IGT tests will support
> both - reloc + no-reloc - then condition will be limited to:
> 
>         if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
>                 return true;
>  
>         return false;
> 
> so require_force_probe condition will be deleted and we won't need it
> anymore (IGTs will be ready).

yes...
but then, when we remove the flag we will forget to come here and remove
this check.

Oh, and I just thought that we might need drm_error when the protection
doesn't exist for the platform, but also a drm_info to the user to tell
this is a temporary accepted behavior, but that will be removed later

The concern is if any other userspace was using the flag and suddently move to a
version without the flag, it would be considered a regression...

> 
> --
> Zbigniew
> 
> > 
> > > +		return true;
> > > +
> > > +	return false;
> > > +}
> > > +
> > >  static int
> > >  eb_validate_vma(struct i915_execbuffer *eb,
> > >  		struct drm_i915_gem_exec_object2 *entry,
> > >  		struct i915_vma *vma)
> > >  {
> > > -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> > > -	 * also covers all platforms with local memory.
> > > -	 */
> > > -	if (entry->relocation_count &&
> > > -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> > > +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
> > >  		return -EINVAL;
> > >  
> > >  	if (unlikely(entry->flags & eb->invalid_flags))
> > > -- 
> > > 2.26.0
> > > 
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Rodrigo Vivi]

On Fri, Jun 11, 2021 at 08:09:00AM +0200, Zbigniew Kempczyński wrote:
> On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote:
> > On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> > > We have established previously we stop using relocations starting
> > > from gen12 platforms with Tigerlake as an exception. We keep this
> > > statement but we want to enable relocations conditionally for
> > > Rocketlake and Alderlake under require_force_probe flag set.
> > > 
> > > Keeping relocations under require_force_probe flag is interim solution
> > > until IGTs will be rewritten to use softpin.
> > 
> > hmm... to be really honest I'm not so happy that we are introducing
> > a new criteria to the force_probe.
> > 
> > The criteria was to have a functional driver and not to track uapi.
> > 
> > But on the other hand I do recognize that the current definition
> > of the flag allows that, because we have established that with
> > this behavior, the "driver for new Intel graphics devices that
> > are recognized but not properly supported by this kernel version"
> > (as stated in the Kconfig for the DRM_I915_FORCE_PROBE).
> > 
> > However...
> > 
> > > 
> > > v2: - remove inline from function definition (Jani)
> > >     - fix indentation
> > > 
> > > v3: change to GRAPHICS_VER() (Zbigniew)
> > > 
> > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > > Cc: Dave Airlie <airlied@redhat.com>
> > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > > Acked-by: Dave Airlie <airlied@redhat.com>
> > > ---
> > >  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
> > >  1 file changed, 19 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > index a8abc9af5ff4..30c4f0549ea0 100644
> > > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
> > >  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
> > >  }
> > >  
> > > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> > > +{
> > > +	/*
> > > +	 * Relocations are disallowed starting from gen12 with Tigerlake
> > > +	 * as an exception. We allow temporarily use relocations for Rocketlake
> > > +	 * and Alderlake when require_force_probe flag is set.
> > > +	 */
> > > +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > > +		return true;
> > > +
> > > +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> > > +	    (IS_ROCKETLAKE(eb->i915)
> > 
> > This ship has sailed... RKL is not protected by this flag any longer.
> > Should this be on the TGL side now?
> 
> +Lucas
> 
> I think no, RKL has relocations disabled so we cannot put it to TGL side.
> So if RKL is already released then putting it under require_force_probe 
> flag is wrong and only I can do is to remove it from that condition. 
> There's no option to unblock RKL on IGT CI until we rewrite all the tests.
> We have to rely then on ADL* with require_force_probe flag to check how
> ADL will work with relocations. 

So... I'm confused now. I'm missing the point of this patch then.
I thought the reason was to protect from any user space to attempt to
use the relocation, unless using the force_probe temporarily only for
these platforms.
But if I'm understanding correctly now it is only to silence CI?!
Is that the case?
Is the CI noise so bad?

> 
> > 
> > >  || IS_ALDERLAKE_S(eb->i915) ||
> > > +	     IS_ALDERLAKE_P(eb->i915)))
> > 
> > How to ensure that we will easily catch this when removing the
> > flag?
> > 
> > I mean, should we have a GEM_BUG or drm_err message when these
> > platforms in this list has not the required_force_probe?
> 
> I don't think we need GEM_BUG()/drm_err() - when IGT tests will support
> both - reloc + no-reloc - then condition will be limited to:
> 
>         if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
>                 return true;
>  
>         return false;
> 
> so require_force_probe condition will be deleted and we won't need it
> anymore (IGTs will be ready).

yes...
but then, when we remove the flag we will forget to come here and remove
this check.

Oh, and I just thought that we might need drm_error when the protection
doesn't exist for the platform, but also a drm_info to the user to tell
this is a temporary accepted behavior, but that will be removed later

The concern is if any other userspace was using the flag and suddently move to a
version without the flag, it would be considered a regression...

> 
> --
> Zbigniew
> 
> > 
> > > +		return true;
> > > +
> > > +	return false;
> > > +}
> > > +
> > >  static int
> > >  eb_validate_vma(struct i915_execbuffer *eb,
> > >  		struct drm_i915_gem_exec_object2 *entry,
> > >  		struct i915_vma *vma)
> > >  {
> > > -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> > > -	 * also covers all platforms with local memory.
> > > -	 */
> > > -	if (entry->relocation_count &&
> > > -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> > > +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
> > >  		return -EINVAL;
> > >  
> > >  	if (unlikely(entry->flags & eb->invalid_flags))
> > > -- 
> > > 2.26.0
> > > 
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Zbigniew Kempczyński]

On Fri, Jun 11, 2021 at 04:54:32AM -0400, Rodrigo Vivi wrote:
> On Fri, Jun 11, 2021 at 08:09:00AM +0200, Zbigniew Kempczyński wrote:
> > On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote:
> > > On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> > > > We have established previously we stop using relocations starting
> > > > from gen12 platforms with Tigerlake as an exception. We keep this
> > > > statement but we want to enable relocations conditionally for
> > > > Rocketlake and Alderlake under require_force_probe flag set.
> > > > 
> > > > Keeping relocations under require_force_probe flag is interim solution
> > > > until IGTs will be rewritten to use softpin.
> > > 
> > > hmm... to be really honest I'm not so happy that we are introducing
> > > a new criteria to the force_probe.
> > > 
> > > The criteria was to have a functional driver and not to track uapi.
> > > 
> > > But on the other hand I do recognize that the current definition
> > > of the flag allows that, because we have established that with
> > > this behavior, the "driver for new Intel graphics devices that
> > > are recognized but not properly supported by this kernel version"
> > > (as stated in the Kconfig for the DRM_I915_FORCE_PROBE).
> > > 
> > > However...
> > > 
> > > > 
> > > > v2: - remove inline from function definition (Jani)
> > > >     - fix indentation
> > > > 
> > > > v3: change to GRAPHICS_VER() (Zbigniew)
> > > > 
> > > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > > > Cc: Dave Airlie <airlied@redhat.com>
> > > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > > > Acked-by: Dave Airlie <airlied@redhat.com>
> > > > ---
> > > >  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
> > > >  1 file changed, 19 insertions(+), 5 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > index a8abc9af5ff4..30c4f0549ea0 100644
> > > > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
> > > >  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
> > > >  }
> > > >  
> > > > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> > > > +{
> > > > +	/*
> > > > +	 * Relocations are disallowed starting from gen12 with Tigerlake
> > > > +	 * as an exception. We allow temporarily use relocations for Rocketlake
> > > > +	 * and Alderlake when require_force_probe flag is set.
> > > > +	 */
> > > > +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > > > +		return true;
> > > > +
> > > > +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> > > > +	    (IS_ROCKETLAKE(eb->i915)
> > > 
> > > This ship has sailed... RKL is not protected by this flag any longer.
> > > Should this be on the TGL side now?
> > 
> > +Lucas
> > 
> > I think no, RKL has relocations disabled so we cannot put it to TGL side.
> > So if RKL is already released then putting it under require_force_probe 
> > flag is wrong and only I can do is to remove it from that condition. 
> > There's no option to unblock RKL on IGT CI until we rewrite all the tests.
> > We have to rely then on ADL* with require_force_probe flag to check how
> > ADL will work with relocations. 
> 
> So... I'm confused now. I'm missing the point of this patch then.
> I thought the reason was to protect from any user space to attempt to
> use the relocation, unless using the force_probe temporarily only for
> these platforms.
> But if I'm understanding correctly now it is only to silence CI?!
> Is that the case?
> Is the CI noise so bad?

The point of the patch is to verify driver on ADL. IGT still uses 
relocations (we're rewriting them now but it takes time) so execbuf
on ADL just exits with failure. We're blind right now about driver
behavior and we want to address this - temporary enable relocations
on ADL (under flag) to see if driver works properly on that platform.

> 
> > 
> > > 
> > > >  || IS_ALDERLAKE_S(eb->i915) ||
> > > > +	     IS_ALDERLAKE_P(eb->i915)))
> > > 
> > > How to ensure that we will easily catch this when removing the
> > > flag?
> > > 
> > > I mean, should we have a GEM_BUG or drm_err message when these
> > > platforms in this list has not the required_force_probe?
> > 
> > I don't think we need GEM_BUG()/drm_err() - when IGT tests will support
> > both - reloc + no-reloc - then condition will be limited to:
> > 
> >         if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> >                 return true;
> >  
> >         return false;
> > 
> > so require_force_probe condition will be deleted and we won't need it
> > anymore (IGTs will be ready).
> 
> yes...
> but then, when we remove the flag we will forget to come here and remove
> this check.

I think we won't forget - this is cherry on top of rewriting IGT -
to switch to no-reloc on ADL, so that condition disappear.

> 
> Oh, and I just thought that we might need drm_error when the protection
> doesn't exist for the platform, but also a drm_info to the user to tell
> this is a temporary accepted behavior, but that will be removed later
> 
> The concern is if any other userspace was using the flag and suddently move to a
> version without the flag, it would be considered a regression...

That means I don't understand the meaning of that flag. I thought it is
to enforce probe of driver on platform which behavior is not already 
well defined and we want to "try" driver on it. 

--
Zbigniew

> 
> > 
> > --
> > Zbigniew
> > 
> > > 
> > > > +		return true;
> > > > +
> > > > +	return false;
> > > > +}
> > > > +
> > > >  static int
> > > >  eb_validate_vma(struct i915_execbuffer *eb,
> > > >  		struct drm_i915_gem_exec_object2 *entry,
> > > >  		struct i915_vma *vma)
> > > >  {
> > > > -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> > > > -	 * also covers all platforms with local memory.
> > > > -	 */
> > > > -	if (entry->relocation_count &&
> > > > -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> > > > +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
> > > >  		return -EINVAL;
> > > >  
> > > >  	if (unlikely(entry->flags & eb->invalid_flags))
> > > > -- 
> > > > 2.26.0
> > > > 
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Zbigniew Kempczyński]

On Fri, Jun 11, 2021 at 04:54:32AM -0400, Rodrigo Vivi wrote:
> On Fri, Jun 11, 2021 at 08:09:00AM +0200, Zbigniew Kempczyński wrote:
> > On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote:
> > > On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> > > > We have established previously we stop using relocations starting
> > > > from gen12 platforms with Tigerlake as an exception. We keep this
> > > > statement but we want to enable relocations conditionally for
> > > > Rocketlake and Alderlake under require_force_probe flag set.
> > > > 
> > > > Keeping relocations under require_force_probe flag is interim solution
> > > > until IGTs will be rewritten to use softpin.
> > > 
> > > hmm... to be really honest I'm not so happy that we are introducing
> > > a new criteria to the force_probe.
> > > 
> > > The criteria was to have a functional driver and not to track uapi.
> > > 
> > > But on the other hand I do recognize that the current definition
> > > of the flag allows that, because we have established that with
> > > this behavior, the "driver for new Intel graphics devices that
> > > are recognized but not properly supported by this kernel version"
> > > (as stated in the Kconfig for the DRM_I915_FORCE_PROBE).
> > > 
> > > However...
> > > 
> > > > 
> > > > v2: - remove inline from function definition (Jani)
> > > >     - fix indentation
> > > > 
> > > > v3: change to GRAPHICS_VER() (Zbigniew)
> > > > 
> > > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > > > Cc: Dave Airlie <airlied@redhat.com>
> > > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > > > Acked-by: Dave Airlie <airlied@redhat.com>
> > > > ---
> > > >  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
> > > >  1 file changed, 19 insertions(+), 5 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > index a8abc9af5ff4..30c4f0549ea0 100644
> > > > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
> > > >  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
> > > >  }
> > > >  
> > > > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> > > > +{
> > > > +	/*
> > > > +	 * Relocations are disallowed starting from gen12 with Tigerlake
> > > > +	 * as an exception. We allow temporarily use relocations for Rocketlake
> > > > +	 * and Alderlake when require_force_probe flag is set.
> > > > +	 */
> > > > +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > > > +		return true;
> > > > +
> > > > +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> > > > +	    (IS_ROCKETLAKE(eb->i915)
> > > 
> > > This ship has sailed... RKL is not protected by this flag any longer.
> > > Should this be on the TGL side now?
> > 
> > +Lucas
> > 
> > I think no, RKL has relocations disabled so we cannot put it to TGL side.
> > So if RKL is already released then putting it under require_force_probe 
> > flag is wrong and only I can do is to remove it from that condition. 
> > There's no option to unblock RKL on IGT CI until we rewrite all the tests.
> > We have to rely then on ADL* with require_force_probe flag to check how
> > ADL will work with relocations. 
> 
> So... I'm confused now. I'm missing the point of this patch then.
> I thought the reason was to protect from any user space to attempt to
> use the relocation, unless using the force_probe temporarily only for
> these platforms.
> But if I'm understanding correctly now it is only to silence CI?!
> Is that the case?
> Is the CI noise so bad?

The point of the patch is to verify driver on ADL. IGT still uses 
relocations (we're rewriting them now but it takes time) so execbuf
on ADL just exits with failure. We're blind right now about driver
behavior and we want to address this - temporary enable relocations
on ADL (under flag) to see if driver works properly on that platform.

> 
> > 
> > > 
> > > >  || IS_ALDERLAKE_S(eb->i915) ||
> > > > +	     IS_ALDERLAKE_P(eb->i915)))
> > > 
> > > How to ensure that we will easily catch this when removing the
> > > flag?
> > > 
> > > I mean, should we have a GEM_BUG or drm_err message when these
> > > platforms in this list has not the required_force_probe?
> > 
> > I don't think we need GEM_BUG()/drm_err() - when IGT tests will support
> > both - reloc + no-reloc - then condition will be limited to:
> > 
> >         if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> >                 return true;
> >  
> >         return false;
> > 
> > so require_force_probe condition will be deleted and we won't need it
> > anymore (IGTs will be ready).
> 
> yes...
> but then, when we remove the flag we will forget to come here and remove
> this check.

I think we won't forget - this is cherry on top of rewriting IGT -
to switch to no-reloc on ADL, so that condition disappear.

> 
> Oh, and I just thought that we might need drm_error when the protection
> doesn't exist for the platform, but also a drm_info to the user to tell
> this is a temporary accepted behavior, but that will be removed later
> 
> The concern is if any other userspace was using the flag and suddently move to a
> version without the flag, it would be considered a regression...

That means I don't understand the meaning of that flag. I thought it is
to enforce probe of driver on platform which behavior is not already 
well defined and we want to "try" driver on it. 

--
Zbigniew

> 
> > 
> > --
> > Zbigniew
> > 
> > > 
> > > > +		return true;
> > > > +
> > > > +	return false;
> > > > +}
> > > > +
> > > >  static int
> > > >  eb_validate_vma(struct i915_execbuffer *eb,
> > > >  		struct drm_i915_gem_exec_object2 *entry,
> > > >  		struct i915_vma *vma)
> > > >  {
> > > > -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> > > > -	 * also covers all platforms with local memory.
> > > > -	 */
> > > > -	if (entry->relocation_count &&
> > > > -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> > > > +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
> > > >  		return -EINVAL;
> > > >  
> > > >  	if (unlikely(entry->flags & eb->invalid_flags))
> > > > -- 
> > > > 2.26.0
> > > > 
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Rodrigo Vivi]

On Mon, Jun 14, 2021 at 10:35:30AM +0200, Zbigniew Kempczyński wrote:
> On Fri, Jun 11, 2021 at 04:54:32AM -0400, Rodrigo Vivi wrote:
> > On Fri, Jun 11, 2021 at 08:09:00AM +0200, Zbigniew Kempczyński wrote:
> > > On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote:
> > > > On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> > > > > We have established previously we stop using relocations starting
> > > > > from gen12 platforms with Tigerlake as an exception. We keep this
> > > > > statement but we want to enable relocations conditionally for
> > > > > Rocketlake and Alderlake under require_force_probe flag set.
> > > > > 
> > > > > Keeping relocations under require_force_probe flag is interim solution
> > > > > until IGTs will be rewritten to use softpin.
> > > > 
> > > > hmm... to be really honest I'm not so happy that we are introducing
> > > > a new criteria to the force_probe.
> > > > 
> > > > The criteria was to have a functional driver and not to track uapi.
> > > > 
> > > > But on the other hand I do recognize that the current definition
> > > > of the flag allows that, because we have established that with
> > > > this behavior, the "driver for new Intel graphics devices that
> > > > are recognized but not properly supported by this kernel version"
> > > > (as stated in the Kconfig for the DRM_I915_FORCE_PROBE).
> > > > 
> > > > However...
> > > > 
> > > > > 
> > > > > v2: - remove inline from function definition (Jani)
> > > > >     - fix indentation
> > > > > 
> > > > > v3: change to GRAPHICS_VER() (Zbigniew)
> > > > > 
> > > > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > > > > Cc: Dave Airlie <airlied@redhat.com>
> > > > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > > > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > > > > Acked-by: Dave Airlie <airlied@redhat.com>
> > > > > ---
> > > > >  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
> > > > >  1 file changed, 19 insertions(+), 5 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > > index a8abc9af5ff4..30c4f0549ea0 100644
> > > > > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
> > > > >  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
> > > > >  }
> > > > >  
> > > > > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> > > > > +{
> > > > > +	/*
> > > > > +	 * Relocations are disallowed starting from gen12 with Tigerlake
> > > > > +	 * as an exception. We allow temporarily use relocations for Rocketlake
> > > > > +	 * and Alderlake when require_force_probe flag is set.
> > > > > +	 */
> > > > > +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > > > > +		return true;
> > > > > +
> > > > > +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> > > > > +	    (IS_ROCKETLAKE(eb->i915)
> > > > 
> > > > This ship has sailed... RKL is not protected by this flag any longer.
> > > > Should this be on the TGL side now?
> > > 
> > > +Lucas
> > > 
> > > I think no, RKL has relocations disabled so we cannot put it to TGL side.
> > > So if RKL is already released then putting it under require_force_probe 
> > > flag is wrong and only I can do is to remove it from that condition. 
> > > There's no option to unblock RKL on IGT CI until we rewrite all the tests.
> > > We have to rely then on ADL* with require_force_probe flag to check how
> > > ADL will work with relocations. 
> > 
> > So... I'm confused now. I'm missing the point of this patch then.
> > I thought the reason was to protect from any user space to attempt to
> > use the relocation, unless using the force_probe temporarily only for
> > these platforms.
> > But if I'm understanding correctly now it is only to silence CI?!
> > Is that the case?
> > Is the CI noise so bad?
> 
> The point of the patch is to verify driver on ADL. IGT still uses 
> relocations (we're rewriting them now but it takes time) so execbuf
> on ADL just exits with failure. We're blind right now about driver
> behavior and we want to address this - temporary enable relocations
> on ADL (under flag) to see if driver works properly on that platform.

Okay, so I believe we need a bigger code refactor here. Whenever
we attempt to use the relocation but we are on ADL we need to have
a big bold message saying this should not be used. That this code
path is deprecated and getting removed...

My fear is that after adding this some UMD, other than IGT,
would start using relocation back again and then the removal
of require_force_probe of ADL would mean regression and we would
need to support that forever again.

Ideally a bold drm_warn, but I understand this might impact CI
so at least a drm_info with capital letters...

> 
> > 
> > > 
> > > > 
> > > > >  || IS_ALDERLAKE_S(eb->i915) ||
> > > > > +	     IS_ALDERLAKE_P(eb->i915)))
> > > > 
> > > > How to ensure that we will easily catch this when removing the
> > > > flag?
> > > > 
> > > > I mean, should we have a GEM_BUG or drm_err message when these
> > > > platforms in this list has not the required_force_probe?
> > > 
> > > I don't think we need GEM_BUG()/drm_err() - when IGT tests will support
> > > both - reloc + no-reloc - then condition will be limited to:
> > > 
> > >         if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > >                 return true;
> > >  
> > >         return false;
> > > 
> > > so require_force_probe condition will be deleted and we won't need it
> > > anymore (IGTs will be ready).
> > 
> > yes...
> > but then, when we remove the flag we will forget to come here and remove
> > this check.
> 
> I think we won't forget - this is cherry on top of rewriting IGT -
> to switch to no-reloc on ADL, so that condition disappear.

believe me, we will forget to remove this function if we don't
start warning that ADL is not protected by the flag anymore...
like we were about to add RKL and live that useless there forever...

> 
> > 
> > Oh, and I just thought that we might need drm_error when the protection
> > doesn't exist for the platform, but also a drm_info to the user to tell
> > this is a temporary accepted behavior, but that will be removed later
> > 
> > The concern is if any other userspace was using the flag and suddently move to a
> > version without the flag, it would be considered a regression...
> 
> That means I don't understand the meaning of that flag. I thought it is
> to enforce probe of driver on platform which behavior is not already 
> well defined and we want to "try" driver on it.

The goal of the flag is to protect end users to get a unstable driver
support. In special, linux installer .iso images where driver cannot be
updated... if user gets a old .iso with driver from the enabling times
and a brand new platform, the installation migh hang or get blank screens.
It was a nightmare in the past.

But the flag was never intended to be used with UAPI decisions, so
this case here is changing this...

> 
> --
> Zbigniew
> 
> > 
> > > 
> > > --
> > > Zbigniew
> > > 
> > > > 
> > > > > +		return true;
> > > > > +
> > > > > +	return false;
> > > > > +}
> > > > > +
> > > > >  static int
> > > > >  eb_validate_vma(struct i915_execbuffer *eb,
> > > > >  		struct drm_i915_gem_exec_object2 *entry,
> > > > >  		struct i915_vma *vma)
> > > > >  {
> > > > > -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> > > > > -	 * also covers all platforms with local memory.
> > > > > -	 */
> > > > > -	if (entry->relocation_count &&
> > > > > -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> > > > > +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
> > > > >  		return -EINVAL;
> > > > >  
> > > > >  	if (unlikely(entry->flags & eb->invalid_flags))
> > > > > -- 
> > > > > 2.26.0
> > > > > 
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > Intel-gfx@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

[Rodrigo Vivi]

On Mon, Jun 14, 2021 at 10:35:30AM +0200, Zbigniew Kempczyński wrote:
> On Fri, Jun 11, 2021 at 04:54:32AM -0400, Rodrigo Vivi wrote:
> > On Fri, Jun 11, 2021 at 08:09:00AM +0200, Zbigniew Kempczyński wrote:
> > > On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote:
> > > > On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote:
> > > > > We have established previously we stop using relocations starting
> > > > > from gen12 platforms with Tigerlake as an exception. We keep this
> > > > > statement but we want to enable relocations conditionally for
> > > > > Rocketlake and Alderlake under require_force_probe flag set.
> > > > > 
> > > > > Keeping relocations under require_force_probe flag is interim solution
> > > > > until IGTs will be rewritten to use softpin.
> > > > 
> > > > hmm... to be really honest I'm not so happy that we are introducing
> > > > a new criteria to the force_probe.
> > > > 
> > > > The criteria was to have a functional driver and not to track uapi.
> > > > 
> > > > But on the other hand I do recognize that the current definition
> > > > of the flag allows that, because we have established that with
> > > > this behavior, the "driver for new Intel graphics devices that
> > > > are recognized but not properly supported by this kernel version"
> > > > (as stated in the Kconfig for the DRM_I915_FORCE_PROBE).
> > > > 
> > > > However...
> > > > 
> > > > > 
> > > > > v2: - remove inline from function definition (Jani)
> > > > >     - fix indentation
> > > > > 
> > > > > v3: change to GRAPHICS_VER() (Zbigniew)
> > > > > 
> > > > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > > > > Cc: Dave Airlie <airlied@redhat.com>
> > > > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > > > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > > > > Acked-by: Dave Airlie <airlied@redhat.com>
> > > > > ---
> > > > >  .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 24 +++++++++++++++----
> > > > >  1 file changed, 19 insertions(+), 5 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > > index a8abc9af5ff4..30c4f0549ea0 100644
> > > > > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> > > > > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev)
> > > > >  	ev->flags &= ~__EXEC_OBJECT_RESERVED;
> > > > >  }
> > > > >  
> > > > > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb)
> > > > > +{
> > > > > +	/*
> > > > > +	 * Relocations are disallowed starting from gen12 with Tigerlake
> > > > > +	 * as an exception. We allow temporarily use relocations for Rocketlake
> > > > > +	 * and Alderlake when require_force_probe flag is set.
> > > > > +	 */
> > > > > +	if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > > > > +		return true;
> > > > > +
> > > > > +	if (INTEL_INFO(eb->i915)->require_force_probe &&
> > > > > +	    (IS_ROCKETLAKE(eb->i915)
> > > > 
> > > > This ship has sailed... RKL is not protected by this flag any longer.
> > > > Should this be on the TGL side now?
> > > 
> > > +Lucas
> > > 
> > > I think no, RKL has relocations disabled so we cannot put it to TGL side.
> > > So if RKL is already released then putting it under require_force_probe 
> > > flag is wrong and only I can do is to remove it from that condition. 
> > > There's no option to unblock RKL on IGT CI until we rewrite all the tests.
> > > We have to rely then on ADL* with require_force_probe flag to check how
> > > ADL will work with relocations. 
> > 
> > So... I'm confused now. I'm missing the point of this patch then.
> > I thought the reason was to protect from any user space to attempt to
> > use the relocation, unless using the force_probe temporarily only for
> > these platforms.
> > But if I'm understanding correctly now it is only to silence CI?!
> > Is that the case?
> > Is the CI noise so bad?
> 
> The point of the patch is to verify driver on ADL. IGT still uses 
> relocations (we're rewriting them now but it takes time) so execbuf
> on ADL just exits with failure. We're blind right now about driver
> behavior and we want to address this - temporary enable relocations
> on ADL (under flag) to see if driver works properly on that platform.

Okay, so I believe we need a bigger code refactor here. Whenever
we attempt to use the relocation but we are on ADL we need to have
a big bold message saying this should not be used. That this code
path is deprecated and getting removed...

My fear is that after adding this some UMD, other than IGT,
would start using relocation back again and then the removal
of require_force_probe of ADL would mean regression and we would
need to support that forever again.

Ideally a bold drm_warn, but I understand this might impact CI
so at least a drm_info with capital letters...

> 
> > 
> > > 
> > > > 
> > > > >  || IS_ALDERLAKE_S(eb->i915) ||
> > > > > +	     IS_ALDERLAKE_P(eb->i915)))
> > > > 
> > > > How to ensure that we will easily catch this when removing the
> > > > flag?
> > > > 
> > > > I mean, should we have a GEM_BUG or drm_err message when these
> > > > platforms in this list has not the required_force_probe?
> > > 
> > > I don't think we need GEM_BUG()/drm_err() - when IGT tests will support
> > > both - reloc + no-reloc - then condition will be limited to:
> > > 
> > >         if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915))
> > >                 return true;
> > >  
> > >         return false;
> > > 
> > > so require_force_probe condition will be deleted and we won't need it
> > > anymore (IGTs will be ready).
> > 
> > yes...
> > but then, when we remove the flag we will forget to come here and remove
> > this check.
> 
> I think we won't forget - this is cherry on top of rewriting IGT -
> to switch to no-reloc on ADL, so that condition disappear.

believe me, we will forget to remove this function if we don't
start warning that ADL is not protected by the flag anymore...
like we were about to add RKL and live that useless there forever...

> 
> > 
> > Oh, and I just thought that we might need drm_error when the protection
> > doesn't exist for the platform, but also a drm_info to the user to tell
> > this is a temporary accepted behavior, but that will be removed later
> > 
> > The concern is if any other userspace was using the flag and suddently move to a
> > version without the flag, it would be considered a regression...
> 
> That means I don't understand the meaning of that flag. I thought it is
> to enforce probe of driver on platform which behavior is not already 
> well defined and we want to "try" driver on it.

The goal of the flag is to protect end users to get a unstable driver
support. In special, linux installer .iso images where driver cannot be
updated... if user gets a old .iso with driver from the enabling times
and a brand new platform, the installation migh hang or get blank screens.
It was a nightmare in the past.

But the flag was never intended to be used with UAPI decisions, so
this case here is changing this...

> 
> --
> Zbigniew
> 
> > 
> > > 
> > > --
> > > Zbigniew
> > > 
> > > > 
> > > > > +		return true;
> > > > > +
> > > > > +	return false;
> > > > > +}
> > > > > +
> > > > >  static int
> > > > >  eb_validate_vma(struct i915_execbuffer *eb,
> > > > >  		struct drm_i915_gem_exec_object2 *entry,
> > > > >  		struct i915_vma *vma)
> > > > >  {
> > > > > -	/* Relocations are disallowed for all platforms after TGL-LP.  This
> > > > > -	 * also covers all platforms with local memory.
> > > > > -	 */
> > > > > -	if (entry->relocation_count &&
> > > > > -	    GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
> > > > > +	if (entry->relocation_count && !platform_has_relocs_enabled(eb))
> > > > >  		return -EINVAL;
> > > > >  
> > > > >  	if (unlikely(entry->flags & eb->invalid_flags))
> > > > > -- 
> > > > > 2.26.0
> > > > > 
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > Intel-gfx@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add relocation exceptions for two other platforms (rev5)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 29275 bytes --]

== Series Details ==

Series: drm/i915: Add relocation exceptions for two other platforms (rev5)
URL   : https://patchwork.freedesktop.org/series/89594/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10204_full -> Patchwork_20330_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_20330_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_20330_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_20330_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-xtiled:
    - shard-skl:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl8/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-xtiled.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-xtiled.html

  
Known issues
------------

  Here are the changes found in Patchwork_20330_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_create@create-clear:
    - shard-glk:          [PASS][3] -> [FAIL][4] ([i915#1888] / [i915#3160])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-glk5/igt@gem_create@create-clear.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-glk1/igt@gem_create@create-clear.html

  * igt@gem_ctx_persistence@clone:
    - shard-snb:          NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +3 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-snb2/igt@gem_ctx_persistence@clone.html

  * igt@gem_eio@unwedge-stress:
    - shard-snb:          NOTRUN -> [FAIL][6] ([i915#3354])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-snb6/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-glk:          [PASS][7] -> [FAIL][8] ([i915#2842])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-glk5/igt@gem_exec_fair@basic-none-share@rcs0.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-glk1/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none@vecs0:
    - shard-apl:          [PASS][9] -> [FAIL][10] ([i915#2842] / [i915#3468])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-apl1/igt@gem_exec_fair@basic-none@vecs0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@gem_exec_fair@basic-none@vecs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-tglb:         [PASS][11] -> [FAIL][12] ([i915#2842])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][13] ([i915#2842]) +1 similar issue
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html
    - shard-kbl:          [PASS][14] -> [FAIL][15] ([i915#2842]) +1 similar issue
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_whisper@basic-fds-all:
    - shard-glk:          [PASS][16] -> [DMESG-WARN][17] ([i915#118] / [i915#95])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-glk6/igt@gem_exec_whisper@basic-fds-all.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-glk9/igt@gem_exec_whisper@basic-fds-all.html

  * igt@gem_huc_copy@huc-copy:
    - shard-kbl:          NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#2190])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl2/igt@gem_huc_copy@huc-copy.html

  * igt@gem_mmap_gtt@big-copy-odd:
    - shard-glk:          [PASS][19] -> [FAIL][20] ([i915#307])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-glk4/igt@gem_mmap_gtt@big-copy-odd.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-glk9/igt@gem_mmap_gtt@big-copy-odd.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-snb:          NOTRUN -> [WARN][21] ([i915#2658])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-snb6/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_userptr_blits@input-checking:
    - shard-apl:          NOTRUN -> [DMESG-WARN][22] ([i915#3002]) +1 similar issue
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl3/igt@gem_userptr_blits@input-checking.html

  * igt@i915_hangman@engine-error@vecs0:
    - shard-kbl:          NOTRUN -> [SKIP][23] ([fdo#109271]) +37 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl6/igt@i915_hangman@engine-error@vecs0.html

  * igt@i915_selftest@live@execlists:
    - shard-apl:          NOTRUN -> [DMESG-FAIL][24] ([i915#3462])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@i915_selftest@live@execlists.html

  * igt@kms_ccs@pipe-a-ccs-on-another-bo:
    - shard-snb:          NOTRUN -> [SKIP][25] ([fdo#109271]) +288 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-snb5/igt@kms_ccs@pipe-a-ccs-on-another-bo.html

  * igt@kms_chamelium@dp-crc-multiple:
    - shard-apl:          NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +9 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl8/igt@kms_chamelium@dp-crc-multiple.html

  * igt@kms_color_chamelium@pipe-a-ctm-0-25:
    - shard-snb:          NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +17 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-c-gamma:
    - shard-kbl:          NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +3 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl2/igt@kms_color_chamelium@pipe-c-gamma.html

  * igt@kms_content_protection@srm:
    - shard-apl:          NOTRUN -> [TIMEOUT][29] ([i915#1319])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl3/igt@kms_content_protection@srm.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][30] -> [DMESG-WARN][31] ([i915#180]) +5 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
    - shard-snb:          [PASS][32] -> [SKIP][33] ([fdo#109271]) +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-snb5/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-snb5/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html

  * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
    - shard-glk:          [PASS][34] -> [FAIL][35] ([i915#2122])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-glk3/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
    - shard-skl:          [PASS][36] -> [FAIL][37] ([i915#79])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html

  * igt@kms_flip@plain-flip-fb-recreate@b-edp1:
    - shard-skl:          [PASS][38] -> [FAIL][39] ([i915#2122]) +1 similar issue
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl10/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl3/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
    - shard-apl:          NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#2642])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-kbl:          NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#2642])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt:
    - shard-skl:          [PASS][42] -> [FAIL][43] ([i915#2546] / [i915#49])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt.html

  * igt@kms_hdr@bpc-switch-dpms:
    - shard-skl:          [PASS][44] -> [FAIL][45] ([i915#1188]) +1 similar issue
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html

  * igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c:
    - shard-apl:          NOTRUN -> [SKIP][46] ([fdo#109271]) +109 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl8/igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
    - shard-apl:          NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#533]) +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-apl:          [PASS][48] -> [DMESG-WARN][49] ([i915#180]) +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-apl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
    - shard-apl:          NOTRUN -> [FAIL][50] ([fdo#108145] / [i915#265]) +1 similar issue
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
    - shard-apl:          NOTRUN -> [FAIL][51] ([i915#265])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl8/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-skl:          [PASS][52] -> [FAIL][53] ([fdo#108145] / [i915#265])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
    - shard-apl:          NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#658]) +3 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][55] -> [SKIP][56] ([fdo#109441]) +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_setmode@basic:
    - shard-snb:          NOTRUN -> [FAIL][57] ([i915#31])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-snb5/igt@kms_setmode@basic.html

  * igt@kms_writeback@writeback-check-output:
    - shard-apl:          NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2437])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@kms_writeback@writeback-check-output.html

  * igt@perf@gen12-mi-rpc:
    - shard-skl:          NOTRUN -> [SKIP][59] ([fdo#109271])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl9/igt@perf@gen12-mi-rpc.html

  * igt@perf@polling-parameterized:
    - shard-skl:          [PASS][60] -> [FAIL][61] ([i915#1542])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl10/igt@perf@polling-parameterized.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl5/igt@perf@polling-parameterized.html

  * igt@sysfs_clients@fair-0:
    - shard-apl:          NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2994]) +1 similar issue
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl8/igt@sysfs_clients@fair-0.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@preservation-s3@bcs0:
    - shard-kbl:          [INCOMPLETE][63] -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@bcs0.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@bcs0.html

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         [TIMEOUT][65] ([i915#2369] / [i915#3063]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-tglb5/igt@gem_eio@unwedge-stress.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-tglb5/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-flow@rcs0:
    - shard-tglb:         [FAIL][67] ([i915#2842]) -> [PASS][68] +1 similar issue
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-iclb:         [FAIL][69] ([i915#2842]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none@rcs0:
    - shard-kbl:          [FAIL][71] ([i915#2842]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl2/igt@gem_exec_fair@basic-none@rcs0.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl4/igt@gem_exec_fair@basic-none@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs0:
    - shard-apl:          [FAIL][73] ([i915#2842]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-apl1/igt@gem_exec_fair@basic-none@vcs0.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@gem_exec_fair@basic-none@vcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-glk:          [FAIL][75] ([i915#2842]) -> [PASS][76] +3 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-glk8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_mmap_gtt@big-copy:
    - shard-skl:          [FAIL][77] ([i915#307]) -> [PASS][78]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl5/igt@gem_mmap_gtt@big-copy.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl3/igt@gem_mmap_gtt@big-copy.html

  * igt@gem_mmap_gtt@cpuset-big-copy-odd:
    - shard-glk:          [FAIL][79] ([i915#307]) -> [PASS][80] +1 similar issue
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-glk6/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-glk9/igt@gem_mmap_gtt@cpuset-big-copy-odd.html

  * igt@gem_mmap_offset@clear:
    - shard-skl:          [FAIL][81] ([i915#3160]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl8/igt@gem_mmap_offset@clear.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl1/igt@gem_mmap_offset@clear.html

  * igt@gem_ppgtt@blt-vs-render-ctxn:
    - shard-glk:          [DMESG-WARN][83] ([i915#118] / [i915#95]) -> [PASS][84] +1 similar issue
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-glk1/igt@gem_ppgtt@blt-vs-render-ctxn.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-glk5/igt@gem_ppgtt@blt-vs-render-ctxn.html

  * igt@i915_selftest@live@hangcheck:
    - shard-snb:          [INCOMPLETE][85] ([i915#2782]) -> [PASS][86]
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-snb2/igt@i915_selftest@live@hangcheck.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-snb2/igt@i915_selftest@live@hangcheck.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-skl:          [FAIL][87] ([i915#2346]) -> [PASS][88]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_flip@absolute-wf_vblank-interruptible@a-edp1:
    - shard-skl:          [DMESG-WARN][89] ([i915#1982]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl2/igt@kms_flip@absolute-wf_vblank-interruptible@a-edp1.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl7/igt@kms_flip@absolute-wf_vblank-interruptible@a-edp1.html

  * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
    - shard-apl:          [DMESG-WARN][91] ([i915#180]) -> [PASS][92] +2 similar issues
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-kbl:          [DMESG-WARN][93] ([i915#180]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-kbl:          [FAIL][95] ([fdo#108145] / [i915#265]) -> [PASS][96]
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][97] ([fdo#109441]) -> [PASS][98] +2 similar issues
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  
#### Warnings ####

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-iclb:         [FAIL][99] ([i915#2842]) -> [FAIL][100] ([i915#2849])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@i915_selftest@live@execlists:
    - shard-iclb:         [INCOMPLETE][101] ([i915#2782] / [i915#3462]) -> [DMESG-FAIL][102] ([i915#3462])
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-iclb1/igt@i915_selftest@live@execlists.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-iclb5/igt@i915_selftest@live@execlists.html

  * igt@kms_psr2_sf@cursor-plane-update-sf:
    - shard-iclb:         [SKIP][103] ([i915#2920]) -> [SKIP][104] ([i915#658]) +2 similar issues
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-iclb8/igt@kms_psr2_sf@cursor-plane-update-sf.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
    - shard-iclb:         [SKIP][105] ([i915#658]) -> [SKIP][106] ([i915#2920]) +2 similar issues
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-iclb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602])
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl4/igt@runner@aborted.html
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl2/igt@runner@aborted.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl7/igt@runner@aborted.html
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl7/igt@runner@aborted.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-kbl7/igt@runner@aborted.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl7/igt@runner@aborted.html
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl7/igt@runner@aborted.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl6/igt@runner@aborted.html
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl7/igt@runner@aborted.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl7/igt@runner@aborted.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl4/igt@runner@aborted.html
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl4/igt@runner@aborted.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-kbl4/igt@runner@aborted.html
    - shard-apl:          ([FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123]) ([i915#180] / [i915#1814] / [i915#3363]) -> ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128]) ([fdo#109271] / [i915#1814] / [i915#3002] / [i915#3363])
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-apl8/igt@runner@aborted.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-apl7/igt@runner@aborted.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-apl8/igt@runner@aborted.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-apl6/igt@runner@aborted.html
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@runner@aborted.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl8/igt@runner@aborted.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@runner@aborted.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl6/igt@runner@aborted.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-apl3/igt@runner@aborted.html
    - shard-skl:          ([FAIL][129], [FAIL][130], [FAIL][131]) ([i915#1436] / [i915#3002] / [i915#3363]) -> ([FAIL][132], [FAIL][133], [FAIL][134]) ([i915#1436] / [i915#2426] / [i915#3002] / [i915#3363])
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl8/igt@runner@aborted.html
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl10/igt@runner@aborted.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10204/shard-skl3/igt@runner@aborted.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl1/igt@runner@aborted.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl3/igt@runner@aborted.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/shard-skl8/igt@runner@aborted.html

  
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
  [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
  [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
  [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
  [i915#2642]: https://gitlab.freedesktop.org/drm/intel/issues/2642
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
  [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
  [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
  [i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
  [i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#3160]: https://gitlab.freedesktop.org/drm/intel/issues/3160
  [i915#3354]: https://gitlab.freedesktop.org/drm/intel/issues/3354
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
  [i915#3468]: https://gitlab.freedesktop.org/drm/intel/issues/3468
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#602]: https://gitlab.freedesktop.org/drm/intel/issues/602
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (11 -> 10)
------------------------------

  Missing    (1): pig-icl-1065g7 


Build changes
-------------

  * Linux: CI_DRM_10204 -> Patchwork_20330

  CI-20190529: 20190529
  CI_DRM_10204: 49f55716c1c64348b925292c6cbaca589a6480e6 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6103: 3aa79e55e73d4a49a5222e5dfde486b800a29fe7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_20330: 8ea98a31aee7205732d42302847a8b71264d76fc @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/index.html

[-- Attachment #1.2: Type: text/html, Size: 36471 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add relocation exceptions for two other platforms (rev5)

[Zbigniew Kempczyński]

On Thu, Jun 10, 2021 at 03:02:20PM +0000, Patchwork wrote:
>    Patch Details
> 
>    Series:  drm/i915: Add relocation exceptions for two other platforms (rev5)  
>    URL:     https://patchwork.freedesktop.org/series/89594/                     
>    State:   failure                                                             
>    Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20330/index.html 
> 
>       CI Bug Log - changes from CI_DRM_10204_full -> Patchwork_20330_full
> 
> Summary
> 
>    FAILURE
> 
>    Serious unknown changes coming with Patchwork_20330_full absolutely need
>    to be
>    verified manually.
> 
>    If you think the reported changes have nothing to do with the changes
>    introduced in Patchwork_20330_full, please notify your bug team to allow
>    them
>    to document this new failure mode, which will reduce false positives in
>    CI.
> 
> Possible new issues
> 
>    Here are the unknown changes that may have been introduced in
>    Patchwork_20330_full:
> 
>   IGT changes
> 
>     Possible regressions
> 
>      * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-xtiled:
>           * shard-skl: PASS -> FAIL

Unrelated, patch doesn't touch SKL.

--
Zbigniew

> 
> Known issues
> 
>    Here are the changes found in Patchwork_20330_full that come from known
>    issues:
> 
>   IGT changes
> 
>     Issues hit
> 
>      * igt@gem_create@create-clear:
> 
>           * shard-glk: PASS -> FAIL (i915#1888 / i915#3160)
>      * igt@gem_ctx_persistence@clone:
> 
>           * shard-snb: NOTRUN -> SKIP (fdo#109271 / i915#1099) +3 similar
>             issues
>      * igt@gem_eio@unwedge-stress:
> 
>           * shard-snb: NOTRUN -> FAIL (i915#3354)
>      * igt@gem_exec_fair@basic-none-share@rcs0:
> 
>           * shard-glk: PASS -> FAIL (i915#2842)
>      * igt@gem_exec_fair@basic-none@vecs0:
> 
>           * shard-apl: PASS -> FAIL (i915#2842 / i915#3468)
>      * igt@gem_exec_fair@basic-pace-share@rcs0:
> 
>           * shard-tglb: PASS -> FAIL (i915#2842)
>      * igt@gem_exec_fair@basic-pace@vcs1:
> 
>           * shard-iclb: NOTRUN -> FAIL (i915#2842) +1 similar issue
> 
>           * shard-kbl: PASS -> FAIL (i915#2842) +1 similar issue
> 
>      * igt@gem_exec_whisper@basic-fds-all:
> 
>           * shard-glk: PASS -> DMESG-WARN (i915#118 / i915#95)
>      * igt@gem_huc_copy@huc-copy:
> 
>           * shard-kbl: NOTRUN -> SKIP (fdo#109271 / i915#2190)
>      * igt@gem_mmap_gtt@big-copy-odd:
> 
>           * shard-glk: PASS -> FAIL (i915#307)
>      * igt@gem_pwrite@basic-exhaustion:
> 
>           * shard-snb: NOTRUN -> WARN (i915#2658)
>      * igt@gem_userptr_blits@input-checking:
> 
>           * shard-apl: NOTRUN -> DMESG-WARN (i915#3002) +1 similar issue
>      * igt@i915_hangman@engine-error@vecs0:
> 
>           * shard-kbl: NOTRUN -> SKIP (fdo#109271) +37 similar issues
>      * igt@i915_selftest@live@execlists:
> 
>           * shard-apl: NOTRUN -> DMESG-FAIL (i915#3462)
>      * igt@kms_ccs@pipe-a-ccs-on-another-bo:
> 
>           * shard-snb: NOTRUN -> SKIP (fdo#109271) +288 similar issues
>      * igt@kms_chamelium@dp-crc-multiple:
> 
>           * shard-apl: NOTRUN -> SKIP (fdo#109271 / fdo#111827) +9 similar
>             issues
>      * igt@kms_color_chamelium@pipe-a-ctm-0-25:
> 
>           * shard-snb: NOTRUN -> SKIP (fdo#109271 / fdo#111827) +17 similar
>             issues
>      * igt@kms_color_chamelium@pipe-c-gamma:
> 
>           * shard-kbl: NOTRUN -> SKIP (fdo#109271 / fdo#111827) +3 similar
>             issues
>      * igt@kms_content_protection@srm:
> 
>           * shard-apl: NOTRUN -> TIMEOUT (i915#1319)
>      * igt@kms_cursor_crc@pipe-a-cursor-suspend:
> 
>           * shard-kbl: PASS -> DMESG-WARN (i915#180) +5 similar issues
>      * igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
> 
>           * shard-snb: PASS -> SKIP (fdo#109271) +1 similar issue
>      * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
> 
>           * shard-glk: PASS -> FAIL (i915#2122)
>      * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
> 
>           * shard-skl: PASS -> FAIL (i915#79)
>      * igt@kms_flip@plain-flip-fb-recreate@b-edp1:
> 
>           * shard-skl: PASS -> FAIL (i915#2122) +1 similar issue
>      * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
> 
>           * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#2642)
>      * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
> 
>           * shard-kbl: NOTRUN -> SKIP (fdo#109271 / i915#2642)
>      * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt:
> 
>           * shard-skl: PASS -> FAIL (i915#2546 / i915#49)
>      * igt@kms_hdr@bpc-switch-dpms:
> 
>           * shard-skl: PASS -> FAIL (i915#1188) +1 similar issue
>      * igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c:
> 
>           * shard-apl: NOTRUN -> SKIP (fdo#109271) +109 similar issues
>      * igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
> 
>           * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#533) +1 similar
>             issue
>      * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
> 
>           * shard-apl: PASS -> DMESG-WARN (i915#180) +1 similar issue
>      * igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
> 
>           * shard-apl: NOTRUN -> FAIL (fdo#108145 / i915#265) +1 similar
>             issue
>      * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
> 
>           * shard-apl: NOTRUN -> FAIL (i915#265)
>      * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
> 
>           * shard-skl: PASS -> FAIL (fdo#108145 / i915#265)
>      * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
> 
>           * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#658) +3 similar
>             issues
>      * igt@kms_psr@psr2_sprite_plane_move:
> 
>           * shard-iclb: PASS -> SKIP (fdo#109441) +1 similar issue
>      * igt@kms_setmode@basic:
> 
>           * shard-snb: NOTRUN -> FAIL (i915#31)
>      * igt@kms_writeback@writeback-check-output:
> 
>           * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#2437)
>      * igt@perf@gen12-mi-rpc:
> 
>           * shard-skl: NOTRUN -> SKIP (fdo#109271)
>      * igt@perf@polling-parameterized:
> 
>           * shard-skl: PASS -> FAIL (i915#1542)
>      * igt@sysfs_clients@fair-0:
> 
>           * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#2994) +1 similar
>             issue
> 
>     Possible fixes
> 
>      * igt@gem_ctx_isolation@preservation-s3@bcs0:
> 
>           * shard-kbl: INCOMPLETE -> PASS
>      * igt@gem_eio@unwedge-stress:
> 
>           * shard-tglb: TIMEOUT (i915#2369 / i915#3063) -> PASS
>      * igt@gem_exec_fair@basic-flow@rcs0:
> 
>           * shard-tglb: FAIL (i915#2842) -> PASS +1 similar issue
>      * igt@gem_exec_fair@basic-none-share@rcs0:
> 
>           * shard-iclb: FAIL (i915#2842) -> PASS
>      * igt@gem_exec_fair@basic-none@rcs0:
> 
>           * shard-kbl: FAIL (i915#2842) -> PASS
>      * igt@gem_exec_fair@basic-none@vcs0:
> 
>           * shard-apl: FAIL (i915#2842) -> PASS
>      * igt@gem_exec_fair@basic-pace-solo@rcs0:
> 
>           * shard-glk: FAIL (i915#2842) -> PASS +3 similar issues
>      * igt@gem_mmap_gtt@big-copy:
> 
>           * shard-skl: FAIL (i915#307) -> PASS
>      * igt@gem_mmap_gtt@cpuset-big-copy-odd:
> 
>           * shard-glk: FAIL (i915#307) -> PASS +1 similar issue
>      * igt@gem_mmap_offset@clear:
> 
>           * shard-skl: FAIL (i915#3160) -> PASS
>      * igt@gem_ppgtt@blt-vs-render-ctxn:
> 
>           * shard-glk: DMESG-WARN (i915#118 / i915#95) -> PASS +1 similar
>             issue
>      * igt@i915_selftest@live@hangcheck:
> 
>           * shard-snb: INCOMPLETE (i915#2782) -> PASS
>      * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
> 
>           * shard-skl: FAIL (i915#2346) -> PASS
>      * igt@kms_flip@absolute-wf_vblank-interruptible@a-edp1:
> 
>           * shard-skl: DMESG-WARN (i915#1982) -> PASS
>      * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
> 
>           * shard-apl: DMESG-WARN (i915#180) -> PASS +2 similar issues
>      * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
> 
>           * shard-kbl: DMESG-WARN (i915#180) -> PASS
>      * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
> 
>           * shard-kbl: FAIL (fdo#108145 / i915#265) -> PASS
>      * igt@kms_psr@psr2_cursor_render:
> 
>           * shard-iclb: SKIP (fdo#109441) -> PASS +2 similar issues
> 
>     Warnings
> 
>      * igt@gem_exec_fair@basic-throttle@rcs0:
> 
>           * shard-iclb: FAIL (i915#2842) -> FAIL (i915#2849)
>      * igt@i915_selftest@live@execlists:
> 
>           * shard-iclb: INCOMPLETE (i915#2782 / i915#3462) -> DMESG-FAIL
>             (i915#3462)
>      * igt@kms_psr2_sf@cursor-plane-update-sf:
> 
>           * shard-iclb: SKIP (i915#2920) -> SKIP (i915#658) +2 similar issues
>      * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
> 
>           * shard-iclb: SKIP (i915#658) -> SKIP (i915#2920) +2 similar issues
>      * igt@runner@aborted:
> 
>           * shard-kbl: (FAIL, FAIL, FAIL, FAIL, FAIL) (i915#1436 / i915#180 /
>             i915#1814 / i915#3002 / i915#3363) -> (FAIL, FAIL, FAIL, FAIL,
>             FAIL, FAIL, FAIL, FAIL) (i915#1436 / i915#180 / i915#1814 /
>             i915#2505 / i915#3002 / i915#3363 / i915#602)
> 
>           * shard-apl: (FAIL, FAIL, FAIL, FAIL) (i915#180 / i915#1814 /
>             i915#3363) -> (FAIL, FAIL, FAIL, FAIL, FAIL) (fdo#109271 /
>             i915#1814 / i915#3002 / i915#3363)
> 
>           * shard-skl: (FAIL, FAIL, FAIL) (i915#1436 / i915#3002 / i915#3363)
>             -> (FAIL, FAIL, FAIL) (i915#1436 / i915#2426 / i915#3002 /
>             i915#3363)
> 
> Participating hosts (11 -> 10)
> 
>    Missing (1): pig-icl-1065g7
> 
> Build changes
> 
>      * Linux: CI_DRM_10204 -> Patchwork_20330
> 
>    CI-20190529: 20190529
>    CI_DRM_10204: 49f55716c1c64348b925292c6cbaca589a6480e6 @
>    git://anongit.freedesktop.org/gfx-ci/linux
>    IGT_6103: 3aa79e55e73d4a49a5222e5dfde486b800a29fe7 @
>    https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>    Patchwork_20330: 8ea98a31aee7205732d42302847a8b71264d76fc @
>    git://anongit.freedesktop.org/gfx-ci/linux
>    piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
>    git://anongit.freedesktop.org/piglit
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx