From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com
Cc: Allison Henderson <allison.henderson@oracle.com>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me,
amir73il@gmail.com, ebiggers@kernel.org
Subject: [PATCH 05/13] fstests: move test group info to test files
Date: Mon, 14 Jun 2021 13:59:26 -0700 [thread overview]
Message-ID: <162370436680.3800603.3592918737641309773.stgit@locust> (raw)
In-Reply-To: <162370433910.3800603.9623820748404628250.stgit@locust>
From: Darrick J. Wong <djwong@kernel.org>
Refactor every test in the entire test suite to use the new boilerplate
functions. This also migrates all the test group information into the
test files. This patch has been autogenerated via the command:
./tools/convert-group btrfs ceph cifs ext4 f2fs generic nfs ocfs2 overlay perf shared udf xfs
NOTE: This patch submission only contains diffs of the first seven btrfs
tests because vger rejects 1.5MB patches. The full conversion is in the
git branch linked from the cover letter.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
---
tests/btrfs/001 | 19 +++----------------
tests/btrfs/002 | 19 +++----------------
tests/btrfs/003 | 15 ++++-----------
tests/btrfs/004 | 15 ++++-----------
tests/btrfs/005 | 21 +++------------------
tests/btrfs/006 | 21 +++------------------
6 files changed, 20 insertions(+), 90 deletions(-)
diff --git a/tests/btrfs/001 b/tests/btrfs/001
index fb051e8a..000aeb34 100755
--- a/tests/btrfs/001
+++ b/tests/btrfs/001
@@ -6,23 +6,10 @@
#
# Test btrfs's subvolume and snapshot support
#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
+. ./common/preamble
+_begin_fstest auto quick subvol snapshot
-here=`pwd`
-tmp=/tmp/$$
-status=1 # failure is the default!
-
-_cleanup()
-{
- rm -f $tmp.*
-}
-
-trap "_cleanup ; exit \$status" 0 1 2 3 15
-
-# get standard environment, filters and checks
-. ./common/rc
+# Import common functions.
. ./common/filter
. ./common/filter.btrfs
diff --git a/tests/btrfs/002 b/tests/btrfs/002
index 66775562..58f0cdcd 100755
--- a/tests/btrfs/002
+++ b/tests/btrfs/002
@@ -6,23 +6,10 @@
#
# Extented btrfs snapshot test cases
#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
+. ./common/preamble
+_begin_fstest auto snapshot
-here=`pwd`
-tmp=/tmp/$$
-status=1 # failure is the default!
-
-_cleanup()
-{
- rm -f $tmp.*
-}
-
-trap "_cleanup ; exit \$status" 0 1 2 3 15
-
-# get standard environment, filters and checks
-. ./common/rc
+# Import common functions.
. ./common/filter
_supported_fs btrfs
diff --git a/tests/btrfs/003 b/tests/btrfs/003
index fbb313fb..d241ec6e 100755
--- a/tests/btrfs/003
+++ b/tests/btrfs/003
@@ -6,16 +6,11 @@
#
# btrfs vol tests
#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
+. ./common/preamble
+_begin_fstest auto replace volume balance
-here=`pwd`
-tmp=/tmp/$$
-status=1 # failure is the default!
dev_removed=0
removed_dev_htl=""
-trap "_cleanup; exit \$status" 0 1 2 3 15
# Check if all scratch dev pools are deletable
deletable_scratch_dev_pool()
@@ -32,6 +27,7 @@ deletable_scratch_dev_pool()
return 0
}
+# Override the default cleanup function.
_cleanup()
{
cd /
@@ -42,8 +38,7 @@ _cleanup()
fi
}
-# get standard environment, filters and checks
-. ./common/rc
+# Import common functions.
. ./common/filter
_supported_fs btrfs
@@ -51,8 +46,6 @@ _require_scratch
_require_scratch_dev_pool 4
_require_command "$WIPEFS_PROG" wipefs
-rm -f $seqres.full
-
# Test cases related to raid in btrfs
_test_raid0()
{
diff --git a/tests/btrfs/004 b/tests/btrfs/004
index 0458d2b6..4e767a2f 100755
--- a/tests/btrfs/004
+++ b/tests/btrfs/004
@@ -9,25 +9,20 @@
# run filefrag to get the extent mapping and follow the backrefs.
# We check to end up back at the original file with the correct offset.
#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
+. ./common/preamble
+_begin_fstest auto rw metadata
-here=`pwd`
-tmp=/tmp/$$
-status=1
noise_pid=0
+# Override the default cleanup function.
_cleanup()
{
rm $tmp.running
wait
rm -f $tmp.*
}
-trap "_cleanup; exit \$status" 0 1 2 3 15
-# get standard environment, filters and checks
-. ./common/rc
+# Import common functions.
. ./common/filter
# real QA test starts here
@@ -38,8 +33,6 @@ _require_btrfs_command inspect-internal logical-resolve
_require_btrfs_command inspect-internal inode-resolve
_require_command "$FILEFRAG_PROG" filefrag
-rm -f $seqres.full
-
FILEFRAG_FILTER='
if (/blocks? of (\d+) bytes/) {
$blocksize = $1;
diff --git a/tests/btrfs/005 b/tests/btrfs/005
index ff20a638..878a8c7c 100755
--- a/tests/btrfs/005
+++ b/tests/btrfs/005
@@ -6,23 +6,11 @@
#
# Btrfs Online defragmentation tests
#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "QA output created by $seq"
-here="`pwd`"
-tmp=/tmp/$$
+. ./common/preamble
+_begin_fstest auto defrag
cnt=119
filesize=48000
-status=1 # failure is the default!
-trap "_cleanup; exit \$status" 0 1 2 3 15
-
-_cleanup()
-{
- cd /
- rm -f $tmp.*
-}
-
_create_file()
{
if [ $1 -ne 2 ]; then
@@ -111,8 +99,7 @@ _rundefrag()
_check_scratch_fs
}
-# get standard environment, filters and checks
-. ./common/rc
+# Import common functions.
. ./common/filter
. ./common/defrag
@@ -120,8 +107,6 @@ _rundefrag()
_supported_fs btrfs
_require_scratch
-rm -f $seqres.full
-
_scratch_mkfs >/dev/null 2>&1
_scratch_mount
_require_defrag
diff --git a/tests/btrfs/006 b/tests/btrfs/006
index 67f1fcd8..fd0f89e2 100755
--- a/tests/btrfs/006
+++ b/tests/btrfs/006
@@ -7,23 +7,10 @@
# run basic btrfs information commands in various ways
# sanity tests: filesystem show, label, sync, and device stats
#
-seq=`basename $0`
-seqres=$RESULT_DIR/$seq
-echo "== QA output created by $seq"
+. ./common/preamble
+_begin_fstest auto quick volume
-here=`pwd`
-tmp=/tmp/$$
-status=1 # failure is the default!
-trap "_cleanup; exit \$status" 0 1 2 3 15
-
-_cleanup()
-{
- cd /
- rm -f $tmp.*
-}
-
-# get standard environment, filters and checks
-. ./common/rc
+# Import common functions.
. ./common/filter.btrfs
# real QA test starts here
@@ -33,8 +20,6 @@ _supported_fs btrfs
_require_scratch
_require_scratch_dev_pool
-rm -f $seqres.full
-
FIRST_POOL_DEV=`echo $SCRATCH_DEV_POOL | awk '{print $1}'`
LAST_POOL_DEV=`echo $SCRATCH_DEV_POOL | awk '{print $NF}'`
TOTAL_DEVS=`echo $SCRATCH_DEV_POOL | wc -w`
next prev parent reply other threads:[~2021-06-14 20:59 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 20:58 [PATCHSET v2 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-14 20:59 ` [PATCH 01/13] fstests: fix group check in new script Darrick J. Wong
2021-06-16 5:40 ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 02/13] misc: move exit status into trap handler Darrick J. Wong
2021-06-16 5:41 ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 03/13] fstests: refactor test boilerplate code Darrick J. Wong
2021-06-16 5:42 ` Christoph Hellwig
2021-06-16 20:47 ` Eric Biggers
2021-06-17 0:02 ` Darrick J. Wong
2021-06-14 20:59 ` [PATCH 04/13] fstests: add tool migrate group membership data to test files Darrick J. Wong
2021-06-16 7:29 ` Christoph Hellwig
2021-06-14 20:59 ` Darrick J. Wong [this message]
2021-06-16 20:53 ` [PATCH 05/13] fstests: move test group info " Eric Biggers
2021-06-14 20:59 ` [PATCH 06/13] fstests: clean up open-coded golden output Darrick J. Wong
2021-06-16 5:45 ` Christoph Hellwig
2021-06-17 0:06 ` Darrick J. Wong
2021-06-14 20:59 ` [PATCH 07/13] fstests: automatically generate group files Darrick J. Wong
2021-06-16 7:32 ` Christoph Hellwig
2021-06-17 0:13 ` Darrick J. Wong
2021-06-17 7:56 ` Christoph Hellwig
2021-06-17 17:15 ` Darrick J. Wong
2021-06-18 13:45 ` Christoph Hellwig
2021-06-18 15:32 ` Amir Goldstein
2021-06-18 15:56 ` Darrick J. Wong
2021-06-21 5:25 ` Christoph Hellwig
2021-06-21 6:38 ` Eryu Guan
2021-06-21 16:14 ` Darrick J. Wong
2021-06-21 5:20 ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 08/13] fstests: convert nextid to use automatic group generation Darrick J. Wong
2021-06-16 20:54 ` Eric Biggers
2021-06-14 20:59 ` [PATCH 09/13] fstests: adapt the new test script to our new group tagging scheme Darrick J. Wong
2021-06-14 20:59 ` [PATCH 10/13] check: use generated group files Darrick J. Wong
2021-06-16 20:55 ` Eric Biggers
2021-06-14 20:59 ` [PATCH 11/13] fstests: remove " Darrick J. Wong
2021-06-16 20:56 ` Eric Biggers
2021-06-14 21:00 ` [PATCH 12/13] fstests: remove test group management code Darrick J. Wong
2021-06-16 20:58 ` Eric Biggers
2021-06-17 0:08 ` Darrick J. Wong
2021-06-14 21:00 ` [PATCH 13/13] misc: update documentation to reflect auto-generated group files Darrick J. Wong
2021-06-16 21:00 ` Eric Biggers
2021-06-17 0:11 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2021-06-08 17:19 [PATCHSET v1 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-08 17:19 ` [PATCH 05/13] fstests: move test group info to " Darrick J. Wong
2021-06-11 21:55 ` Allison Henderson
2021-06-11 23:29 ` Eric Biggers
2021-06-12 0:17 ` Eric Biggers
2021-06-12 0:34 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162370436680.3800603.3592918737641309773.stgit@locust \
--to=djwong@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=amir73il@gmail.com \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.