From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24ABCC48BE5 for ; Tue, 15 Jun 2021 12:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA81B61458 for ; Tue, 15 Jun 2021 12:29:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbhFOMbo (ORCPT ); Tue, 15 Jun 2021 08:31:44 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:29808 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229520AbhFOMbn (ORCPT ); Tue, 15 Jun 2021 08:31:43 -0400 X-UUID: 2caa48c5f2f4426095a7d3a514d19c4a-20210615 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=hy2ulTOYtTz6fWJfoMGqCOL0cJY7Tmx70wHn6d0aIag=; b=KgyZsXtf1OcG8DAwz2BuLG8DJuwufQrmOzmvtPNmpochpW39dfI3+XMaOpzQp8cZJcpnBCu6GgrZBD8ybQ6ReJf7AM2ZvUl88RFRTcNn8E84gCCmaSEq1Ik70zhfOKdvsWF+qPhtRIbJwUjIR2alMlnYBLxxgu7tTS0TyvpcAas=; X-UUID: 2caa48c5f2f4426095a7d3a514d19c4a-20210615 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 69459193; Tue, 15 Jun 2021 20:29:35 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Jun 2021 20:29:26 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Jun 2021 20:29:26 +0800 Message-ID: <1623760166.24285.1.camel@mhfsdcap03> Subject: Re: [PATCH v3 3/6] iommu: Improve iommu_iotlb_gather helpers From: Yong Wu To: Nadav Amit CC: Joerg Roedel , Robin Murphy , , , Jiajun Cao , Will Deacon Date: Tue, 15 Jun 2021 20:29:26 +0800 In-Reply-To: <20210607182541.119756-4-namit@vmware.com> References: <20210607182541.119756-1-namit@vmware.com> <20210607182541.119756-4-namit@vmware.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 619EC6FAECE4DB4BFD5D7B0E99DD46A5676E4A97FF55DE65E1407293A0E41BBB2000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDIxLTA2LTA3IGF0IDExOjI1IC0wNzAwLCBOYWRhdiBBbWl0IHdyb3RlOg0KPiBG cm9tOiBSb2JpbiBNdXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPg0KPiANCj4gVGhlIE1lZGlh dGVrIGRyaXZlciBpcyBub3QgdGhlIG9ubHkgb25lIHdoaWNoIG1pZ2h0IHdhbnQgYSBiYXNpYw0K PiBhZGRyZXNzLWJhc2VkIGdhdGhlcmluZyBiZWhhdmlvdXIsIHNvIGFsdGhvdWdoIGl0J3MgYXJn dWFibHkgc2ltcGxlDQo+IGVub3VnaCB0byBvcGVuLWNvZGUsIGxldCdzIGZhY3RvciBpdCBvdXQg Zm9yIHRoZSBzYWtlIG9mIGNsZWFubGluZXNzLg0KPiBMZXQncyBhbHNvIHRha2UgdGhpcyBvcHBv cnR1bml0eSB0byBkb2N1bWVudCB0aGUgaW50ZW50IG9mIHRoZXNlDQo+IGhlbHBlcnMgZm9yIGNs YXJpdHkuDQo+IA0KPiBDYzogSm9lcmcgUm9lZGVsIDxqb3JvQDhieXRlcy5vcmc+DQo+IENjOiBX aWxsIERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPg0KPiBDYzogSmlhanVuIENhbyA8Y2FvamlhanVu QHZtd2FyZS5jb20+DQo+IENjOiBSb2JpbiBNdXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPg0K PiBDYzogTHUgQmFvbHUgPGJhb2x1Lmx1QGxpbnV4LmludGVsLmNvbT4NCj4gQ2M6IGlvbW11QGxp c3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnDQo+IENjOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwu b3JnDQo+IFNpZ25lZC1vZmYtYnk6IFJvYmluIE11cnBoeSA8cm9iaW4ubXVycGh5QGFybS5jb20+ DQo+IA0KPiAtLS0NCj4gDQo+IENoYW5nZXMgZnJvbSBSb2JpbidzIHZlcnNpb246DQo+ICogQWRk ZWQgaW9tbXVfaW90bGJfZ2F0aGVyX2FkZF9yYW5nZSgpIHN0dWIgIUNPTkZJR19JT01NVV9BUEkN Cj4gKiBVc2UgaW9tbXVfaW90bGJfZ2F0aGVyX2FkZF9yYW5nZSgpIGluIGlvbW11X2lvdGxiX2dh dGhlcl9hZGRfcGFnZSgpDQo+IC0tLQ0KPiAgZHJpdmVycy9pb21tdS9tdGtfaW9tbXUuYyB8ICA1 ICstLS0tDQo+ICBpbmNsdWRlL2xpbnV4L2lvbW11LmggICAgIHwgNDMgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tDQo+ICAyIGZpbGVzIGNoYW5nZWQsIDM5IGluc2VydGlv bnMoKyksIDkgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9t dGtfaW9tbXUuYyBiL2RyaXZlcnMvaW9tbXUvbXRrX2lvbW11LmMNCj4gaW5kZXggZTA2YjhhMGUy YjU2Li4wYWY0YTkxYWM3ZGEgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvaW9tbXUvbXRrX2lvbW11 LmMNCj4gKysrIGIvZHJpdmVycy9pb21tdS9tdGtfaW9tbXUuYw0KPiBAQCAtNTIzLDEwICs1MjMs NyBAQCBzdGF0aWMgc2l6ZV90IG10a19pb21tdV91bm1hcChzdHJ1Y3QgaW9tbXVfZG9tYWluICpk b21haW4sDQo+ICAJc3RydWN0IG10a19pb21tdV9kb21haW4gKmRvbSA9IHRvX210a19kb21haW4o ZG9tYWluKTsNCj4gIAl1bnNpZ25lZCBsb25nIGVuZCA9IGlvdmEgKyBzaXplIC0gMTsNCg0KUGxl YXNlIGFsc28gaGVscCBkZWxldGUgdGhpcyAiZW5kIi4NCg0KPiAgDQo+IC0JaWYgKGdhdGhlci0+ c3RhcnQgPiBpb3ZhKQ0KPiAtCQlnYXRoZXItPnN0YXJ0ID0gaW92YTsNCj4gLQlpZiAoZ2F0aGVy LT5lbmQgPCBlbmQpDQo+IC0JCWdhdGhlci0+ZW5kID0gZW5kOw0KPiArCWlvbW11X2lvdGxiX2dh dGhlcl9hZGRfcmFuZ2UoZ2F0aGVyLCBpb3ZhLCBzaXplKTsNCj4gIAlyZXR1cm4gZG9tLT5pb3At PnVubWFwKGRvbS0+aW9wLCBpb3ZhLCBzaXplLCBnYXRoZXIpOw0KPiAgfQ0KDQpbc25pcF0gDQoN Cg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27518C48BDF for ; Tue, 15 Jun 2021 12:29:57 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B983461462 for ; Tue, 15 Jun 2021 12:29:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B983461462 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 8856483B4B; Tue, 15 Jun 2021 12:29:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uS6rqM1yx3_N; Tue, 15 Jun 2021 12:29:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 6E4F483B58; Tue, 15 Jun 2021 12:29:54 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4162EC000D; Tue, 15 Jun 2021 12:29:54 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 07E73C000B for ; Tue, 15 Jun 2021 12:29:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E8F694046C for ; Tue, 15 Jun 2021 12:29:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=neutral reason="invalid (public key: DNS error: query timed out)" header.d=mediatek.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gbEk9ouxFTJH for ; Tue, 15 Jun 2021 12:29:43 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mailgw02.mediatek.com (unknown [1.203.163.81]) by smtp4.osuosl.org (Postfix) with ESMTP id 0C2644045E for ; Tue, 15 Jun 2021 12:29:42 +0000 (UTC) X-UUID: 2caa48c5f2f4426095a7d3a514d19c4a-20210615 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=hy2ulTOYtTz6fWJfoMGqCOL0cJY7Tmx70wHn6d0aIag=; b=KgyZsXtf1OcG8DAwz2BuLG8DJuwufQrmOzmvtPNmpochpW39dfI3+XMaOpzQp8cZJcpnBCu6GgrZBD8ybQ6ReJf7AM2ZvUl88RFRTcNn8E84gCCmaSEq1Ik70zhfOKdvsWF+qPhtRIbJwUjIR2alMlnYBLxxgu7tTS0TyvpcAas=; X-UUID: 2caa48c5f2f4426095a7d3a514d19c4a-20210615 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 69459193; Tue, 15 Jun 2021 20:29:35 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Jun 2021 20:29:26 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Jun 2021 20:29:26 +0800 Message-ID: <1623760166.24285.1.camel@mhfsdcap03> Subject: Re: [PATCH v3 3/6] iommu: Improve iommu_iotlb_gather helpers From: Yong Wu To: Nadav Amit Date: Tue, 15 Jun 2021 20:29:26 +0800 In-Reply-To: <20210607182541.119756-4-namit@vmware.com> References: <20210607182541.119756-1-namit@vmware.com> <20210607182541.119756-4-namit@vmware.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 619EC6FAECE4DB4BFD5D7B0E99DD46A5676E4A97FF55DE65E1407293A0E41BBB2000:8 X-MTK: N Cc: Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jiajun Cao , Will Deacon X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, 2021-06-07 at 11:25 -0700, Nadav Amit wrote: > From: Robin Murphy > > The Mediatek driver is not the only one which might want a basic > address-based gathering behaviour, so although it's arguably simple > enough to open-code, let's factor it out for the sake of cleanliness. > Let's also take this opportunity to document the intent of these > helpers for clarity. > > Cc: Joerg Roedel > Cc: Will Deacon > Cc: Jiajun Cao > Cc: Robin Murphy > Cc: Lu Baolu > Cc: iommu@lists.linux-foundation.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Robin Murphy > > --- > > Changes from Robin's version: > * Added iommu_iotlb_gather_add_range() stub !CONFIG_IOMMU_API > * Use iommu_iotlb_gather_add_range() in iommu_iotlb_gather_add_page() > --- > drivers/iommu/mtk_iommu.c | 5 +---- > include/linux/iommu.h | 43 ++++++++++++++++++++++++++++++++++----- > 2 files changed, 39 insertions(+), 9 deletions(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index e06b8a0e2b56..0af4a91ac7da 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -523,10 +523,7 @@ static size_t mtk_iommu_unmap(struct iommu_domain *domain, > struct mtk_iommu_domain *dom = to_mtk_domain(domain); > unsigned long end = iova + size - 1; Please also help delete this "end". > > - if (gather->start > iova) > - gather->start = iova; > - if (gather->end < end) > - gather->end = end; > + iommu_iotlb_gather_add_range(gather, iova, size); > return dom->iop->unmap(dom->iop, iova, size, gather); > } [snip] _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu