From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Ramalingam C" <ramalingam.c@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915 TTM sync accelerated migration and clear (rev3)
Date: Tue, 15 Jun 2021 13:36:39 -0000 [thread overview]
Message-ID: <162376419933.8819.4284370819516280088@emeril.freedesktop.org> (raw)
In-Reply-To: <20210615131451.61023-1-thomas.hellstrom@linux.intel.com>
== Series Details ==
Series: i915 TTM sync accelerated migration and clear (rev3)
URL : https://patchwork.freedesktop.org/series/91463/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
84d52ccba4bc drm/i915: Reference objects on the ww object list
dad033f5d41d drm/i915: Break out dma_resv ww locking utilities to separate files
-:141: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#141:
new file mode 100644
-:166: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#166: FILE: drivers/gpu/drm/i915/i915_gem_ww.c:21:
+ while ((obj = list_first_entry_or_null(&ww->obj_list, struct drm_i915_gem_object, obj_link))) {
total: 0 errors, 2 warnings, 0 checks, 183 lines checked
170905ae335a drm/i915: Introduce a ww transaction helper
-:56: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_ww' - possible side-effects?
#56: FILE: drivers/gpu/drm/i915/i915_gem_ww.h:46:
+#define for_i915_gem_ww(_ww, _err, _intr) \
+ for (__i915_gem_ww_init(_ww, _intr); (_ww)->loop; \
+ _err = __i915_gem_ww_fini(_ww, _err))
-:56: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_err' - possible side-effects?
#56: FILE: drivers/gpu/drm/i915/i915_gem_ww.h:46:
+#define for_i915_gem_ww(_ww, _err, _intr) \
+ for (__i915_gem_ww_init(_ww, _intr); (_ww)->loop; \
+ _err = __i915_gem_ww_fini(_ww, _err))
total: 0 errors, 0 warnings, 2 checks, 41 lines checked
1d7d203cc9de drm/i915/gt: Add an insert_entry for gen8_ppgtt
b8de4e1527e9 drm/i915/gt: Add a routine to iterate over the pagetables of a GTT
9c144ca818bb drm/i915/gt: Export the pinned context constructor and destructor
ee3ad654412a drm/i915/gt: Pipelined page migration
-:66: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#66:
new file mode 100644
-:878: WARNING:LINE_SPACING: Missing a blank line after declarations
#878: FILE: drivers/gpu/drm/i915/gt/selftest_migrate.c:176:
+ struct drm_i915_private *i915 = migrate->context->engine->i915;
+ I915_RND_STATE(prng);
-:907: WARNING:LINE_SPACING: Missing a blank line after declarations
#907: FILE: drivers/gpu/drm/i915/gt/selftest_migrate.c:205:
+ struct threaded_migrate *thread;
+ I915_RND_STATE(prng);
-:932: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#932: FILE: drivers/gpu/drm/i915/gt/selftest_migrate.c:230:
+ msleep(10); /* start all threads before we kthread_stop() */
total: 0 errors, 4 warnings, 0 checks, 931 lines checked
35222babd9d2 drm/i915/gt: Pipelined clear
-:355: WARNING:LINE_SPACING: Missing a blank line after declarations
#355: FILE: drivers/gpu/drm/i915/gt/selftest_migrate.c:311:
+ struct drm_i915_private *i915 = migrate->context->engine->i915;
+ I915_RND_STATE(prng);
total: 0 errors, 1 warnings, 0 checks, 380 lines checked
1196a59da677 drm/i915/gt: Setup a default migration context on the GT
54c4a427f357 drm/i915/ttm: accelerated move implementation
656ff10118e4 drm/i915/gem: Zap the client blt code
-:35: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#35:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 146 lines checked
51bd492a35f8 drm/i915/gem: Zap the i915_gem_object_blt code
-:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 65 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-15 13:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 13:14 [Intel-gfx] [PATCH v4 00/12] i915 TTM sync accelerated migration and clear Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 01/12] drm/i915: Reference objects on the ww object list Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 02/12] drm/i915: Break out dma_resv ww locking utilities to separate files Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 03/12] drm/i915: Introduce a ww transaction helper Thomas Hellström
2021-06-16 11:00 ` Maarten Lankhorst
2021-06-16 11:21 ` Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 04/12] drm/i915/gt: Add an insert_entry for gen8_ppgtt Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 05/12] drm/i915/gt: Add a routine to iterate over the pagetables of a GTT Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 06/12] drm/i915/gt: Export the pinned context constructor and destructor Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 07/12] drm/i915/gt: Pipelined page migration Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 08/12] drm/i915/gt: Pipelined clear Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 09/12] drm/i915/gt: Setup a default migration context on the GT Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 10/12] drm/i915/ttm: accelerated move implementation Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 11/12] drm/i915/gem: Zap the client blt code Thomas Hellström
2021-06-15 13:14 ` [Intel-gfx] [PATCH v4 12/12] drm/i915/gem: Zap the i915_gem_object_blt code Thomas Hellström
2021-06-15 13:36 ` Patchwork [this message]
2021-06-15 14:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for i915 TTM sync accelerated migration and clear (rev3) Patchwork
2021-06-15 21:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162376419933.8819.4284370819516280088@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.