Re: [PATCH 0/3] renesas_sci update

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210616091244.33049-1-ysato@users.sourceforge.jp/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210616091244.33049-1-ysato@users.sourceforge.jp
Subject: [PATCH 0/3] renesas_sci update

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210610133538.608390-1-pbonzini@redhat.com -> patchew/20210610133538.608390-1-pbonzini@redhat.com
 - [tag update]      patchew/20210615192848.1065297-1-venture@google.com -> patchew/20210615192848.1065297-1-venture@google.com
 - [tag update]      patchew/20210616064334.53398-1-lukas.juenger@greensocs.com -> patchew/20210616064334.53398-1-lukas.juenger@greensocs.com
 - [tag update]      patchew/20210616073358.750472-1-joel@jms.id.au -> patchew/20210616073358.750472-1-joel@jms.id.au
 * [new tag]         patchew/20210616091244.33049-1-ysato@users.sourceforge.jp -> patchew/20210616091244.33049-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
2aee00f hw/sh4: sh7750 using renesas_sci.
163b17f hw/char: renesas_sci Add SCI and SCIF support.
3a37650 hw/char: renesas_sci: Refactor for merge all SCI variant..

=== OUTPUT BEGIN ===
1/3 Checking commit 3a3765029d7c (hw/char: renesas_sci: Refactor for merge all SCI variant..)
2/3 Checking commit 163b17f2e78e (hw/char: renesas_sci Add SCI and SCIF support.)
ERROR: spaces required around that ':' (ctx:VxW)
#24: FILE: hw/char/renesas_sci.c:6:
+ *        And SH7751 Group, SH7751R Group User's Manual: Hardware
                                                        ^

ERROR: space prohibited after that '*' (ctx:ExW)
#25: FILE: hw/char/renesas_sci.c:7:
+ *            (Rev.4.01 R01UH0457EJ0401)
  ^

total: 2 errors, 0 warnings, 715 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 2aee00ffc830 (hw/sh4: sh7750 using renesas_sci.)
ERROR: space required before the open parenthesis '('
#63: FILE: hw/sh4/sh7750.c:770:
+    switch(feat) {

ERROR: braces {} are necessary for all arms of this statement
#79: FILE: hw/sh4/sh7750.c:786:
+    if (tei_source)
[...]

ERROR: braces {} are necessary for all arms of this statement
#81: FILE: hw/sh4/sh7750.c:788:
+    if (bri_source)
[...]

total: 3 errors, 0 warnings, 79 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210616091244.33049-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com