Re: [PATCH v5 0/6] support dirtyrate at the granualrity of vcpu

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/cover.1623934182.git.huangy81@chinatelecom.cn/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: cover.1623934182.git.huangy81@chinatelecom.cn
Subject: [PATCH v5 0/6] support dirtyrate at the granualrity of vcpu 

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/cover.1623934182.git.huangy81@chinatelecom.cn -> patchew/cover.1623934182.git.huangy81@chinatelecom.cn
Switched to a new branch 'test'
7c3806f migration/dirtyrate: implement dirty-ring dirtyrate calculation
de17d86 migration/dirtyrate: move init step of calculation to main thread
bcdab9c migration/dirtyrate: adjust order of registering thread
7df987c migration/dirtyrate: introduce struct and adjust DirtyRateStat
4cb2069 memory: make global_dirty_tracking a bitmask
1eaf085 memory: rename global_dirty_log to global_dirty_tracking

=== OUTPUT BEGIN ===
1/6 Checking commit 1eaf085f9a24 (memory: rename global_dirty_log to global_dirty_tracking)
2/6 Checking commit 4cb20690ee05 (memory: make global_dirty_tracking a bitmask)
3/6 Checking commit 7df987cc88c8 (migration/dirtyrate: introduce struct and adjust DirtyRateStat)
4/6 Checking commit bcdab9c720b2 (migration/dirtyrate: adjust order of registering thread)
5/6 Checking commit de17d8630d2f (migration/dirtyrate: move init step of calculation to main thread)
6/6 Checking commit 7c3806f92697 (migration/dirtyrate: implement dirty-ring dirtyrate calculation)
ERROR: trailing whitespace
#88: FILE: migration/dirtyrate.c:93:
+ $

WARNING: line over 80 characters
#94: FILE: migration/dirtyrate.c:99:
+            /* set sample_pages with 0 to indicate page sampling isn't enabled */

ERROR: trailing whitespace
#106: FILE: migration/dirtyrate.c:111:
+   $

ERROR: trailing whitespace
#325: FILE: migration/dirtyrate.c:658:
+    qapi_free_DirtyRateVcpuList(info->vcpu_dirty_rate); $

total: 3 errors, 1 warnings, 350 lines checked

Patch 6/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/cover.1623934182.git.huangy81@chinatelecom.cn/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com