All of lore.kernel.org
 help / color / mirror / Atom feed
From: "thermal-bot for Dmitry Osipenko" <tip-bot2@linutronix.de>
To: linux-pm@vger.kernel.org
Cc: Dmitry Osipenko <digetx@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	rui.zhang@intel.com, amitk@kernel.org
Subject: [thermal: thermal/next] thermal/core/thermal_of: Stop zone device before unregistering it
Date: Mon, 21 Jun 2021 09:46:43 -0000	[thread overview]
Message-ID: <162426880307.395.3890058875463840927.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210616190417.32214-3-digetx@gmail.com>

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     add9a126cfb59375c36e779bf739fc765219ed11
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//add9a126cfb59375c36e779bf739fc765219ed11
Author:        Dmitry Osipenko <digetx@gmail.com>
AuthorDate:    Wed, 16 Jun 2021 22:04:13 +03:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Fri, 18 Jun 2021 12:39:50 +02:00

thermal/core/thermal_of: Stop zone device before unregistering it

Zone device is enabled after thermal_zone_of_sensor_register() completion,
but it's not disabled before senor is unregistered, leaving temperature
polling active. This results in accessing a disabled zone device and
produces a warning about this problem. Stop zone device before
unregistering it in order to fix this "use-after-free" problem.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210616190417.32214-3-digetx@gmail.com
---
 drivers/thermal/thermal_of.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
index 5b76f9a..6379f26 100644
--- a/drivers/thermal/thermal_of.c
+++ b/drivers/thermal/thermal_of.c
@@ -559,6 +559,9 @@ void thermal_zone_of_sensor_unregister(struct device *dev,
 	if (!tz)
 		return;
 
+	/* stop temperature polling */
+	thermal_zone_device_disable(tzd);
+
 	mutex_lock(&tzd->lock);
 	tzd->ops->get_temp = NULL;
 	tzd->ops->get_trend = NULL;

  reply	other threads:[~2021-06-21  9:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 19:04 [PATCH v4 0/6] Add driver for NVIDIA Tegra30 SoC Thermal sensor Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 1/6] dt-bindings: thermal: Add binding for Tegra30 thermal sensor Dmitry Osipenko
2021-06-21  9:46   ` [thermal: thermal/next] " thermal-bot for Dmitry Osipenko
2021-07-04 18:02   ` thermal-bot for Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 2/6] thermal: thermal_of: Stop zone device before unregistering it Dmitry Osipenko
2021-06-21  9:46   ` thermal-bot for Dmitry Osipenko [this message]
2021-07-04 18:02   ` [thermal: thermal/next] thermal/core/thermal_of: " thermal-bot for Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 3/6] thermal/drivers/tegra: Add driver for Tegra30 thermal sensor Dmitry Osipenko
2021-06-21  9:46   ` [thermal: thermal/next] " thermal-bot for Dmitry Osipenko
2021-09-09 14:38   ` thermal-bot for Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 4/6] ARM: tegra_defconfig: Enable CONFIG_TEGRA30_TSENSOR Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 5/6] ARM: multi_v7_defconfig: " Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 6/6] ARM: tegra: Add SoC thermal sensor to Tegra30 device-trees Dmitry Osipenko
2021-06-21 17:13 ` [PATCH v4 0/6] Add driver for NVIDIA Tegra30 SoC Thermal sensor Daniel Lezcano
2021-06-21 17:26   ` Dmitry Osipenko
2021-06-21 18:16     ` Daniel Lezcano
2021-06-21 18:25       ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162426880307.395.3890058875463840927.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=digetx@gmail.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --subject='Re: [thermal: thermal/next] thermal/core/thermal_of: Stop zone device before unregistering it' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.