* [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow()
@ 2021-06-19 13:53 Dan Carpenter
2021-06-21 5:15 ` Louis Peens
2021-06-21 19:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-06-19 13:53 UTC (permalink / raw)
To: Simon Horman, Louis Peens
Cc: Jakub Kicinski, David S. Miller, Yinjun Zhang, oss-drivers,
netdev, kernel-janitors
The nfp_fl_ct_add_flow() function can fail so we need to check for
failure.
Fixes: 95255017e0a8 ("nfp: flower-ct: add nft flows to nft list")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/netronome/nfp/flower/conntrack.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
index 9ea77bb3b69c..273d529d43c2 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
@@ -1067,6 +1067,8 @@ nfp_fl_ct_offload_nft_flow(struct nfp_fl_ct_zone_entry *zt, struct flow_cls_offl
nfp_ct_map_params);
if (!ct_map_ent) {
ct_entry = nfp_fl_ct_add_flow(zt, NULL, flow, true, extack);
+ if (IS_ERR(ct_entry))
+ return PTR_ERR(ct_entry);
ct_entry->type = CT_TYPE_NFT;
list_add(&ct_entry->list_node, &zt->nft_flows_list);
zt->nft_flows_count++;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow()
2021-06-19 13:53 [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow() Dan Carpenter
@ 2021-06-21 5:15 ` Louis Peens
2021-06-21 9:22 ` Simon Horman
2021-06-21 19:30 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Louis Peens @ 2021-06-21 5:15 UTC (permalink / raw)
To: Dan Carpenter, Simon Horman
Cc: Jakub Kicinski, David S. Miller, Yinjun Zhang, oss-drivers,
netdev, kernel-janitors
On 2021/06/19 15:53, Dan Carpenter wrote:
> The nfp_fl_ct_add_flow() function can fail so we need to check for
> failure.
>
> Fixes: 95255017e0a8 ("nfp: flower-ct: add nft flows to nft list")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Ah, of course, thank you.
Reviewed-by: Louis Peens <louis.peens@corigine.com>
> ---
> drivers/net/ethernet/netronome/nfp/flower/conntrack.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> index 9ea77bb3b69c..273d529d43c2 100644
> --- a/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/conntrack.c
> @@ -1067,6 +1067,8 @@ nfp_fl_ct_offload_nft_flow(struct nfp_fl_ct_zone_entry *zt, struct flow_cls_offl
> nfp_ct_map_params);
> if (!ct_map_ent) {
> ct_entry = nfp_fl_ct_add_flow(zt, NULL, flow, true, extack);
> + if (IS_ERR(ct_entry))
> + return PTR_ERR(ct_entry);
> ct_entry->type = CT_TYPE_NFT;
> list_add(&ct_entry->list_node, &zt->nft_flows_list);
> zt->nft_flows_count++;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow()
2021-06-21 5:15 ` Louis Peens
@ 2021-06-21 9:22 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2021-06-21 9:22 UTC (permalink / raw)
To: Louis Peens
Cc: Dan Carpenter, Jakub Kicinski, David S. Miller, Yinjun Zhang,
oss-drivers, netdev, kernel-janitors
On Mon, Jun 21, 2021 at 07:15:08AM +0200, Louis Peens wrote:
>
>
> On 2021/06/19 15:53, Dan Carpenter wrote:
> > The nfp_fl_ct_add_flow() function can fail so we need to check for
> > failure.
> >
> > Fixes: 95255017e0a8 ("nfp: flower-ct: add nft flows to nft list")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Ah, of course, thank you.
> Reviewed-by: Louis Peens <louis.peens@corigine.com>
Likewise, thanks.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow()
2021-06-19 13:53 [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow() Dan Carpenter
2021-06-21 5:15 ` Louis Peens
@ 2021-06-21 19:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-21 19:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: simon.horman, louis.peens, kuba, davem, yinjun.zhang,
oss-drivers, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 19 Jun 2021 16:53:26 +0300 you wrote:
> The nfp_fl_ct_add_flow() function can fail so we need to check for
> failure.
>
> Fixes: 95255017e0a8 ("nfp: flower-ct: add nft flows to nft list")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/netronome/nfp/flower/conntrack.c | 2 ++
> 1 file changed, 2 insertions(+)
Here is the summary with links:
- [net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow()
https://git.kernel.org/netdev/net-next/c/43c9a8111680
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-21 19:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 13:53 [PATCH net-next] nfp: flower-ct: check for error in nfp_fl_ct_offload_nft_flow() Dan Carpenter
2021-06-21 5:15 ` Louis Peens
2021-06-21 9:22 ` Simon Horman
2021-06-21 19:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.