From: Stephen Boyd <sboyd@kernel.org>
To: Alexandru Ardelean <aardelean@deviqon.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com,
mturquette@baylibre.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, Alexandru Ardelean <aardelean@deviqon.com>
Subject: Re: [PATCH] clk: tegra: clk-tegra124-dfll-fcpu: don't use devm functions for regulator
Date: Fri, 25 Jun 2021 16:23:46 -0700 [thread overview]
Message-ID: <162466342649.3259633.211016165907683345@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210624084737.42336-1-aardelean@deviqon.com>
Quoting Alexandru Ardelean (2021-06-24 01:47:37)
> The purpose of the device-managed functions is to bind the life-time of an
> object to that of a parent device object.
>
> This is not the case for the 'vdd-cpu' regulator in this driver. A
> reference is obtained via devm_regulator_get() and immediately released
> with devm_regulator_put().
>
> In this case, the usage of devm_ functions is slightly excessive, as the
> un-managed versions of these functions is a little cleaner (and slightly
> more economical in terms of allocation).
>
> This change converts the devm_regulator_{get,put}() to
> regulator_{get,put}() in the get_alignment_from_regulator() function of
> this driver.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2021-06-25 23:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 8:47 [PATCH] clk: tegra: clk-tegra124-dfll-fcpu: don't use devm functions for regulator Alexandru Ardelean
2021-06-24 11:57 ` Thierry Reding
2021-06-25 23:23 ` Stephen Boyd
2021-06-25 23:23 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162466342649.3259633.211016165907683345@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=aardelean@deviqon.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.