From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C56C07E97 for ; Fri, 2 Jul 2021 21:00:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07E50613F7 for ; Fri, 2 Jul 2021 21:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232512AbhGBVD1 (ORCPT ); Fri, 2 Jul 2021 17:03:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:47666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230274AbhGBVD0 (ORCPT ); Fri, 2 Jul 2021 17:03:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3E68C61167; Fri, 2 Jul 2021 21:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625259654; bh=WOZ1VopfRwrnnRB8pJr+CmLYqpYymi8au37V22c6ILU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=cZUPmVEuu0gWRMENpm98DvfRaC+h2GHX4YbmTv9UeHJcNwcYDlx6UJLolKVzBB7iK 00qmT3BIYsgZzZ1T0Cv58FakY+fVxiUzKQFOj679u+AYj6fGVuUOQyAp5DKglSBUIj RR10lJKV/cwQEkRA3T6aIJjUfK/n2tHAr43olZkcKymvLTamFByWz2WxK7+R3FR9ur ChcOy+jhcH37K/twV5a94rG7c0A8I9uazPp3cfivmn3JJMVRIA0p1BpNI9iMi5zIof hageaNPakNSd286Y5JCNvpOUY19PMfrUqFuDselKK6fO+j/nfttz/mO8dO8N7o1/PG cK6IbvZRSlqCQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20210627223959.188139-1-martin.blumenstingl@googlemail.com> <20210627223959.188139-3-martin.blumenstingl@googlemail.com> <20210701202540.GA1085600@roeck-us.net> <162518776607.3570193.14348711594242395887@swboyd.mtv.corp.google.com> Subject: Re: [PATCH v3 2/3] clk: divider: Switch from .round_rate to .determine_rate by default From: Stephen Boyd Cc: Guenter Roeck , mturquette@baylibre.com, linux-clk@vger.kernel.org, Neil Armstrong , jbrunet@baylibre.com, khilman@baylibre.com, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org To: Marek Szyprowski , Martin Blumenstingl Date: Fri, 02 Jul 2021 14:00:53 -0700 Message-ID: <162525965307.3570193.9588997729905273358@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marek Szyprowski (2021-07-02 05:46:11) > Hi >=20 > On 02.07.2021 11:19, Martin Blumenstingl wrote: > > Hi Stephen, > > > > On Fri, Jul 2, 2021 at 3:02 AM Stephen Boyd wrote: > > [...] > >> My guess is that we have drivers copying the clk_ops from the > >> divider_ops structure and so they are copying over round_rate but not > >> determine_rate. > > I just learned something new - thanks for investigating this as well! > > > > $ git grep "clk_divider_ops\.round_rate" drivers/ > > drivers/clk/bcm/clk-bcm2835.c: return clk_divider_ops.round_rate(hw, > > rate, parent_rate); >=20 > I confirm that this issue appears also on Raspberry Pi 3b+ board. I was=20 > about to write a bug report, but you were faster. The funny thing is=20 > that is so nondeterministic, that automated bisecting failed to catch it. >=20 I'd think it was deterministic. The function pointer is NULL after this patch so it should always try to set the PC to 0 and fail to execute. Unless that is somehow executable? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E5BC07E95 for ; Fri, 2 Jul 2021 21:02:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74D5D61167 for ; Fri, 2 Jul 2021 21:02:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74D5D61167 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AW6g2kNZ+hcgRG1UzX5S/3Oe9kNr6RzuNecxwH8FOBc=; b=WSq9Epc8m9pGOl fEV/UrbAeJlMLy3llXoBT96I5m9B4P7fOP87enTQgHVwF2W7KLELEHbO6LgPvxspRNzw2R3szhXsY Na/nQBzFJWoZ6CQamYp+OEuu0EuVlQUs8Q+AfirnYLNPlpFA1CKYbfvuwTf+d5UfiBkFYc7ItW3+M KJePmzF7FxTruJcU5BDOgkDsHDvYbCs1hvgiUL+WxotHc20x4W9dypzLtz+SjiQCMHZNx9CpbX6xX 7rkEqLoolQVO6JlixVZNBB1sEuZYO7cADnixKQLftoTHkGng+MjhGcB9UNpOop4qbjQUxs3JApnnd N9yhV6idIakOjTG0S/XA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzQHS-0043LS-J4; Fri, 02 Jul 2021 21:00:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzQHO-0043K8-LO; Fri, 02 Jul 2021 21:00:55 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3E68C61167; Fri, 2 Jul 2021 21:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625259654; bh=WOZ1VopfRwrnnRB8pJr+CmLYqpYymi8au37V22c6ILU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=cZUPmVEuu0gWRMENpm98DvfRaC+h2GHX4YbmTv9UeHJcNwcYDlx6UJLolKVzBB7iK 00qmT3BIYsgZzZ1T0Cv58FakY+fVxiUzKQFOj679u+AYj6fGVuUOQyAp5DKglSBUIj RR10lJKV/cwQEkRA3T6aIJjUfK/n2tHAr43olZkcKymvLTamFByWz2WxK7+R3FR9ur ChcOy+jhcH37K/twV5a94rG7c0A8I9uazPp3cfivmn3JJMVRIA0p1BpNI9iMi5zIof hageaNPakNSd286Y5JCNvpOUY19PMfrUqFuDselKK6fO+j/nfttz/mO8dO8N7o1/PG cK6IbvZRSlqCQ== MIME-Version: 1.0 In-Reply-To: References: <20210627223959.188139-1-martin.blumenstingl@googlemail.com> <20210627223959.188139-3-martin.blumenstingl@googlemail.com> <20210701202540.GA1085600@roeck-us.net> <162518776607.3570193.14348711594242395887@swboyd.mtv.corp.google.com> Subject: Re: [PATCH v3 2/3] clk: divider: Switch from .round_rate to .determine_rate by default From: Stephen Boyd Cc: Guenter Roeck , mturquette@baylibre.com, linux-clk@vger.kernel.org, Neil Armstrong , jbrunet@baylibre.com, khilman@baylibre.com, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org To: Marek Szyprowski , Martin Blumenstingl Date: Fri, 02 Jul 2021 14:00:53 -0700 Message-ID: <162525965307.3570193.9588997729905273358@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210702_140054_754208_AD9C28B5 X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Marek Szyprowski (2021-07-02 05:46:11) > Hi > > On 02.07.2021 11:19, Martin Blumenstingl wrote: > > Hi Stephen, > > > > On Fri, Jul 2, 2021 at 3:02 AM Stephen Boyd wrote: > > [...] > >> My guess is that we have drivers copying the clk_ops from the > >> divider_ops structure and so they are copying over round_rate but not > >> determine_rate. > > I just learned something new - thanks for investigating this as well! > > > > $ git grep "clk_divider_ops\.round_rate" drivers/ > > drivers/clk/bcm/clk-bcm2835.c: return clk_divider_ops.round_rate(hw, > > rate, parent_rate); > > I confirm that this issue appears also on Raspberry Pi 3b+ board. I was > about to write a bug report, but you were faster. The funny thing is > that is so nondeterministic, that automated bisecting failed to catch it. > I'd think it was deterministic. The function pointer is NULL after this patch so it should always try to set the PC to 0 and fail to execute. Unless that is somehow executable? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84193C07E95 for ; Fri, 2 Jul 2021 21:01:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5674E613F7 for ; Fri, 2 Jul 2021 21:01:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5674E613F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RJKPHFvvIvkgZ95hzxfGSzVqXE71uyvoUdTwzT1CUoY=; b=Gu/571uKDii8+K vSzjXlVDElyL4RdfisKUwRkvFOQ23RRdlh3OIib1Y3sCb6KQ2srs9h/Kleztw3jVfs8T1L2TgsVTS gzW+GOWE12Da9ioL8+kfGOUhedur1M6+dggBkiZ0r2v9zsacyzuETFrr7BB4F+vM/ISUc7pgG1Q7S DP2aGfcHC3vLKNlqcVzdmwvDrNa+uWIe6GUWfpIA4QvvAfGO3drZv8hh/YP1qRUlN1XSIfVxrA10g ooOICAuQs7XWcUX1g8GzpaYo0TVzwlavRBrmu8KYepWYWr0XECkw0UwhJ9rR5EE2fgaLTQ2CKw5VZ Imi1QmUaGDhQa/suSv6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzQHQ-0043LA-Oo; Fri, 02 Jul 2021 21:00:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzQHO-0043K8-LO; Fri, 02 Jul 2021 21:00:55 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3E68C61167; Fri, 2 Jul 2021 21:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625259654; bh=WOZ1VopfRwrnnRB8pJr+CmLYqpYymi8au37V22c6ILU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=cZUPmVEuu0gWRMENpm98DvfRaC+h2GHX4YbmTv9UeHJcNwcYDlx6UJLolKVzBB7iK 00qmT3BIYsgZzZ1T0Cv58FakY+fVxiUzKQFOj679u+AYj6fGVuUOQyAp5DKglSBUIj RR10lJKV/cwQEkRA3T6aIJjUfK/n2tHAr43olZkcKymvLTamFByWz2WxK7+R3FR9ur ChcOy+jhcH37K/twV5a94rG7c0A8I9uazPp3cfivmn3JJMVRIA0p1BpNI9iMi5zIof hageaNPakNSd286Y5JCNvpOUY19PMfrUqFuDselKK6fO+j/nfttz/mO8dO8N7o1/PG cK6IbvZRSlqCQ== MIME-Version: 1.0 In-Reply-To: References: <20210627223959.188139-1-martin.blumenstingl@googlemail.com> <20210627223959.188139-3-martin.blumenstingl@googlemail.com> <20210701202540.GA1085600@roeck-us.net> <162518776607.3570193.14348711594242395887@swboyd.mtv.corp.google.com> Subject: Re: [PATCH v3 2/3] clk: divider: Switch from .round_rate to .determine_rate by default From: Stephen Boyd Cc: Guenter Roeck , mturquette@baylibre.com, linux-clk@vger.kernel.org, Neil Armstrong , jbrunet@baylibre.com, khilman@baylibre.com, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org To: Marek Szyprowski , Martin Blumenstingl Date: Fri, 02 Jul 2021 14:00:53 -0700 Message-ID: <162525965307.3570193.9588997729905273358@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210702_140054_754208_AD9C28B5 X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Quoting Marek Szyprowski (2021-07-02 05:46:11) > Hi > > On 02.07.2021 11:19, Martin Blumenstingl wrote: > > Hi Stephen, > > > > On Fri, Jul 2, 2021 at 3:02 AM Stephen Boyd wrote: > > [...] > >> My guess is that we have drivers copying the clk_ops from the > >> divider_ops structure and so they are copying over round_rate but not > >> determine_rate. > > I just learned something new - thanks for investigating this as well! > > > > $ git grep "clk_divider_ops\.round_rate" drivers/ > > drivers/clk/bcm/clk-bcm2835.c: return clk_divider_ops.round_rate(hw, > > rate, parent_rate); > > I confirm that this issue appears also on Raspberry Pi 3b+ board. I was > about to write a bug report, but you were faster. The funny thing is > that is so nondeterministic, that automated bisecting failed to catch it. > I'd think it was deterministic. The function pointer is NULL after this patch so it should always try to set the PC to 0 and fail to execute. Unless that is somehow executable? _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic