From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] drivers/net: document missing speed capabilities feature Date: Wed, 10 May 2017 15:51:22 +0200 Message-ID: <16254100.QC6ztoDaX8@xps> References: <20170510131053.75843-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shepard Siegel , Ed Czeck , John Miller , John McNamara , Harish Patil , Rasesh Mody , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Jing Chen , Helin Zhang , Jingjing Wu , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Matej Vido , Pascal Mazon Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 05CF81C00 for ; Wed, 10 May 2017 15:51:23 +0200 (CEST) In-Reply-To: <20170510131053.75843-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/05/2017 15:10, Ferruh Yigit: > --- a/doc/guides/nics/features/bnx2x.ini > +++ b/doc/guides/nics/features/bnx2x.ini > @@ -4,6 +4,7 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Features] > +Speed capabilities = Y We should validate this feature only if the driver advertise the right speeds for the device. Most of drivers advertise every possible speeds for the driver without considering device limitations.