From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro Date: Fri, 18 Apr 2014 04:42:01 -0700 (PDT) Message-ID: <16254493.92s6zWrT4n@xps13> References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com> <1397585169-14537-4-git-send-email-nhorman@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Neil Horman Return-path: In-Reply-To: <1397585169-14537-4-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-04-15 14:05, Neil Horman: > Rather than have each driver have to remember to add a constructor to it to > make sure its gets registered properly, wrap that process up in a macro to > make registration a one line affair. This also sets the stage for us to > make registration of vdev pmds and physical pmds a uniform process > > Signed-off-by: Neil Horman > --- /dev/null > +++ b/lib/librte_eal/common/include/rte_pmd.h So you are creating a new header file for PMD API, right? According to rte_ethdev.h, "The Ethernet Device API is composed of two parts:" "- The application-oriented Ethernet API" "- The driver-oriented Ethernet API" So we should implement this macro in rte_ethdev.h. But maybe you prefer to split this file in two files. If so, please send a separated patch for that. Thanks -- Thomas