All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf record: Add a dummy event for a hybrid system
@ 2021-07-08 16:03 kan.liang
  2021-07-09  5:32 ` Namhyung Kim
  0 siblings, 1 reply; 3+ messages in thread
From: kan.liang @ 2021-07-08 16:03 UTC (permalink / raw)
  To: acme, mingo, jolsa, linux-kernel; +Cc: namhyung, yao.jin, Kan Liang

From: Kan Liang <kan.liang@linux.intel.com>

Some symbols may not be resolved if a user only monitor one type of PMU.

 $ sudo perf record -e cpu_atom/branch-instructions/ ./big_small_workload
 $ sudo perf report –stdio
 # Overhead  Command    Shared Object      Symbol
 # ........  .........  .................
 # ......................................
 #
    28.02%  perf-exec  [unknown]          [.] 0x0000000000401cf6
    11.32%  perf-exec  [unknown]          [.] 0x0000000000401d04
    10.90%  perf-exec  [unknown]          [.] 0x0000000000401d11
    10.61%  perf-exec  [unknown]          [.] 0x0000000000401cfc

To parse symbols, the side-band events, e.g., COMM, which are generated
by the kernel are required. To decide whether to generate the side-band
event, the kernel relies on the event_filter_match() to filter the
unrelated events. On a hybrid system, the event_filter_match() further
checks the CPU mask of the current enabled PMU. If an event is collected
on the CPU which doesn't have an enabled PMU, it's treated as an
unrelated event.

The "big_small_workload" is created in a big core, but runs on a small
core. The side-band events are filtered, because the user only monitors
the PMU of the small core. The big core PMU is not enabled.

For a hybrid system, a dummy event is required to generate the complete
side-band events.

Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---
 tools/perf/builtin-record.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 3337b5f..99607b9 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -891,11 +891,12 @@ static int record__open(struct record *rec)
 	int rc = 0;
 
 	/*
-	 * For initial_delay or system wide, we need to add a dummy event so
-	 * that we can track PERF_RECORD_MMAP to cover the delay of waiting or
-	 * event synthesis.
+	 * For initial_delay or system wide or a hybrid system, we need to
+	 * add a dummy event so that we can track PERF_RECORD_MMAP to cover
+	 * the delay of waiting or event synthesis.
 	 */
-	if (opts->initial_delay || target__has_cpu(&opts->target)) {
+	if (opts->initial_delay || target__has_cpu(&opts->target) ||
+	    perf_pmu__has_hybrid()) {
 		pos = evlist__get_tracking_event(evlist);
 		if (!evsel__is_dummy_event(pos)) {
 			/* Set up dummy event. */
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf record: Add a dummy event for a hybrid system
  2021-07-08 16:03 [PATCH] perf record: Add a dummy event for a hybrid system kan.liang
@ 2021-07-09  5:32 ` Namhyung Kim
  2021-07-09 12:51   ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2021-07-09  5:32 UTC (permalink / raw)
  To: Liang, Kan
  Cc: Arnaldo Carvalho de Melo, Ingo Molnar, Jiri Olsa, linux-kernel,
	Yao Jin, Kan Liang

On Thu, Jul 8, 2021 at 9:05 AM <kan.liang@intel.com> wrote:
>
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Some symbols may not be resolved if a user only monitor one type of PMU.
>
>  $ sudo perf record -e cpu_atom/branch-instructions/ ./big_small_workload
>  $ sudo perf report –stdio
>  # Overhead  Command    Shared Object      Symbol
>  # ........  .........  .................
>  # ......................................
>  #
>     28.02%  perf-exec  [unknown]          [.] 0x0000000000401cf6
>     11.32%  perf-exec  [unknown]          [.] 0x0000000000401d04
>     10.90%  perf-exec  [unknown]          [.] 0x0000000000401d11
>     10.61%  perf-exec  [unknown]          [.] 0x0000000000401cfc
>
> To parse symbols, the side-band events, e.g., COMM, which are generated
> by the kernel are required. To decide whether to generate the side-band
> event, the kernel relies on the event_filter_match() to filter the
> unrelated events. On a hybrid system, the event_filter_match() further
> checks the CPU mask of the current enabled PMU. If an event is collected
> on the CPU which doesn't have an enabled PMU, it's treated as an
> unrelated event.
>
> The "big_small_workload" is created in a big core, but runs on a small
> core. The side-band events are filtered, because the user only monitors
> the PMU of the small core. The big core PMU is not enabled.
>
> For a hybrid system, a dummy event is required to generate the complete
> side-band events.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/builtin-record.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 3337b5f..99607b9 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -891,11 +891,12 @@ static int record__open(struct record *rec)
>         int rc = 0;
>
>         /*
> -        * For initial_delay or system wide, we need to add a dummy event so
> -        * that we can track PERF_RECORD_MMAP to cover the delay of waiting or
> -        * event synthesis.
> +        * For initial_delay or system wide or a hybrid system, we need to
> +        * add a dummy event so that we can track PERF_RECORD_MMAP to cover
> +        * the delay of waiting or event synthesis.
>          */
> -       if (opts->initial_delay || target__has_cpu(&opts->target)) {
> +       if (opts->initial_delay || target__has_cpu(&opts->target) ||
> +           perf_pmu__has_hybrid()) {
>                 pos = evlist__get_tracking_event(evlist);
>                 if (!evsel__is_dummy_event(pos)) {
>                         /* Set up dummy event. */
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf record: Add a dummy event for a hybrid system
  2021-07-09  5:32 ` Namhyung Kim
@ 2021-07-09 12:51   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-07-09 12:51 UTC (permalink / raw)
  To: Namhyung Kim
  Cc: Liang, Kan, Ingo Molnar, Jiri Olsa, linux-kernel, Yao Jin, Kan Liang

Em Thu, Jul 08, 2021 at 10:32:13PM -0700, Namhyung Kim escreveu:
> On Thu, Jul 8, 2021 at 9:05 AM <kan.liang@intel.com> wrote:
> >
> > From: Kan Liang <kan.liang@linux.intel.com>
> >
> > Some symbols may not be resolved if a user only monitor one type of PMU.
> >
> >  $ sudo perf record -e cpu_atom/branch-instructions/ ./big_small_workload
> >  $ sudo perf report –stdio
> >  # Overhead  Command    Shared Object      Symbol
> >  # ........  .........  .................
> >  # ......................................
> >  #
> >     28.02%  perf-exec  [unknown]          [.] 0x0000000000401cf6
> >     11.32%  perf-exec  [unknown]          [.] 0x0000000000401d04
> >     10.90%  perf-exec  [unknown]          [.] 0x0000000000401d11
> >     10.61%  perf-exec  [unknown]          [.] 0x0000000000401cfc
> >
> > To parse symbols, the side-band events, e.g., COMM, which are generated
> > by the kernel are required. To decide whether to generate the side-band
> > event, the kernel relies on the event_filter_match() to filter the
> > unrelated events. On a hybrid system, the event_filter_match() further
> > checks the CPU mask of the current enabled PMU. If an event is collected
> > on the CPU which doesn't have an enabled PMU, it's treated as an
> > unrelated event.
> >
> > The "big_small_workload" is created in a big core, but runs on a small
> > core. The side-band events are filtered, because the user only monitors
> > the PMU of the small core. The big core PMU is not enabled.
> >
> > For a hybrid system, a dummy event is required to generate the complete
> > side-band events.
> >
> > Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks, applied.

- Arnaldo


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-09 12:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 16:03 [PATCH] perf record: Add a dummy event for a hybrid system kan.liang
2021-07-09  5:32 ` Namhyung Kim
2021-07-09 12:51   ` Arnaldo Carvalho de Melo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.