From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B24C07E95 for ; Sat, 10 Jul 2021 04:38:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3400613DC for ; Sat, 10 Jul 2021 04:38:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3400613DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m24km-0001rT-OB for qemu-devel@archiver.kernel.org; Sat, 10 Jul 2021 00:38:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m24ZT-0000Oy-Ie for qemu-devel@nongnu.org; Sat, 10 Jul 2021 00:26:31 -0400 Received: from indium.canonical.com ([91.189.90.7]:45876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m24ZR-0000eF-OP for qemu-devel@nongnu.org; Sat, 10 Jul 2021 00:26:31 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.93 #5 (Debian)) id 1m24ZD-0003gS-0L for ; Sat, 10 Jul 2021 04:26:15 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 902FE2E8278 for ; Sat, 10 Jul 2021 04:26:07 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Sat, 10 Jul 2021 04:17:17 -0000 From: Launchpad Bug Tracker <1904490@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Expired; importance=Undecided; assignee=None; X-Launchpad-Bug-Tags: intel-hda X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: jacob11 janitor th-huth X-Launchpad-Bug-Reporter: Jacob (jacob11) X-Launchpad-Bug-Modifier: Launchpad Janitor (janitor) References: <160558234310.29971.12864468607339587807.malonedeb@gac.canonical.com> Message-Id: <162589063810.5654.10694346741488951355.malone@loganberry.canonical.com> Subject: [Bug 1904490] Re: intel-hda: valid registers are unknown X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="1b66c075b8638845e61f40eb9036fabeaa01f591"; Instance="production" X-Launchpad-Hash: b44288c9aa1d4459785a2def05926f579d519632 Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1904490 <1904490@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" [Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete =3D> Expired -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1904490 Title: intel-hda: valid registers are unknown Status in QEMU: Expired Bug description: According to HDA specification, "3.1.2 General Register Behaviors and Access Requirements": "All controller registers must be addressable as byte, Word, and Dword quantities." But e.g. if you try the following to reset and enable the CORB, assuming es:esi contains the base MMIO address of the controller, es or [esi+4bh], byte 80h ; reset CORB corbresetloop: es test [esi+4bh], byte 80h ; is HW done resetting yet? jnz corbreset1ok ; yes, bit is now 1 hlt ; wait a little bit jmp corbresetloop ; and check again corbreset1ok: es and [esi+4bh], byte 7fh ; clear the bit It will hang indefinitely because the bit never gets set, and if you enable debug output of the controller with "-device intel- hda,debug=3D1", you will see infinitely the line "unknown register, addr 0x4b" output. The same code on a real hardware (I tried with ICH7M) works fine, as it should according to the spec. Host/guest/version does not matter (I am writing own drivers) --- as of right now, latest version still has this code: https://github.com/qemu/qemu/blob/master/hw/audio/intel-hda.c which seems to emit "unknown register" message in intel_hda_reg_find(), and this function does not take into account range of addresses that each register occupies. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1904490/+subscriptions