From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25CBC07E9B for ; Mon, 12 Jul 2021 09:04:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BF6F6101D for ; Mon, 12 Jul 2021 09:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384961AbhGLJF2 (ORCPT ); Mon, 12 Jul 2021 05:05:28 -0400 Received: from mailgw01.mediatek.com ([60.244.123.138]:60826 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1355638AbhGLIKK (ORCPT ); Mon, 12 Jul 2021 04:10:10 -0400 X-UUID: 8eab63c0825a494fb72f3489822534c5-20210712 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=pYihUe16LMSA8Z5B8sReIfUro/yCMswXaige3lLlv3k=; b=WH3RlvhMtzj5bi2g9GfaCo+Qjkau9BbZftNtDEhMvaunJb4wP5HVjQ9MGlDoAKJV5/RUX6mA/F0BfkDUssc72SEuowPyFrG8JNGOgS5HzMKvQvkRBzY7hW5xO4h0MQQuMQ6erTW+g4QTQvKOyYE6hf+BdfG/bMOsO/luqbrahTs=; X-UUID: 8eab63c0825a494fb72f3489822534c5-20210712 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 405197711; Mon, 12 Jul 2021 16:07:16 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 16:07:08 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 12 Jul 2021 16:07:07 +0800 Message-ID: <1626077227.7221.20.camel@mhfsdcap03> Subject: Re: [PATCH v1, 06/14] media: mtk-vcodec: Add irq interface for core hardware From: mtk12024 To: Tzung-Bi Shih CC: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , "Tiffany Lin" , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , "Fritz Koenig" , Irui Wang , , , , , , , Date: Mon, 12 Jul 2021 16:07:07 +0800 In-Reply-To: References: <20210707062157.21176-1-yunfei.dong@mediatek.com> <20210707062157.21176-7-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgVHp1bmctQmksDQoNClRoYW5rcyBmb3IgeW91ciBkZXRhaWwgZmVlZGJhY2suDQpJIGFkZCB0 aGUgZGVzY3JpcHRpb24gYWNjb3JkaW5nIHRvIHlvdXIgZWFjaCBjb21tZW50cy4NCg0KT24gRnJp LCAyMDIxLTA3LTA5IGF0IDE1OjU5ICswODAwLCBUenVuZy1CaSBTaGloIHdyb3RlOg0KPiBPbiBX ZWQsIEp1bCA3LCAyMDIxIGF0IDI6MjIgUE0gWXVuZmVpIERvbmcgPHl1bmZlaS5kb25nQG1lZGlh dGVrLmNvbT4gd3JvdGU6DQo+ID4gK3N0YXRpYyBpbnQgbXRrX3Zjb2RlY19nZXRfaHdfY291bnQo c3RydWN0IG10a192Y29kZWNfZGV2ICpkZXYpDQo+ID4gK3sNCj4gPiArICAgICAgIGlmIChkZXYt PnZkZWNfcGRhdGEtPmh3X2FyY2ggPT0gTVRLX1ZERUNfUFVSRV9TSU5HTEVfQ09SRSkNCj4gPiAr ICAgICAgICAgICAgICAgcmV0dXJuIDE7DQo+ID4gKyAgICAgICBlbHNlIGlmIChkZXYtPnZkZWNf cGRhdGEtPmh3X2FyY2ggPT0gTVRLX1ZERUNfTEFUX1NJTkdMRV9DT1JFKQ0KPiA+ICsgICAgICAg ICAgICAgICByZXR1cm4gMjsNCj4gPiArICAgICAgIGVsc2UNCj4gPiArICAgICAgICAgICAgICAg cmV0dXJuIDA7DQo+ID4gK30NCj4gVXNlIGEgc3dpdGNoIC4uIGNhc2UgLi4gd291bGQgYmUgZWFz aWVyIHRvIHJlYWQuDQpZZXMNCj4gV291bGQgaXQgYmUgYmV0dGVyIHRvIHVzZSBzb21lIG1hY3Jv IG9yIGVudW1zIGZvciB0aGUgbWFnaWMgbnVtYmVycz8NClllcywgYWRkIGVudW1zIGZvciBtYWdp YyBudW1iZXJzLiANCmVudW0gbXRrX3ZkZWNfaHdfY291bnQgew0KCU1US19WREVDX05PX0hXID0g MCwNCglNVEtfVkRFQ19PTkVfQ09SRSwNCglNVEtfVkRFQ19PTkVfTEFUX09ORV9DT1JFLA0KCU1U S19WREVDX01BWF9IV19DT1VOVCwNCn07DQo+ID4gQEAgLTExMyw4ICsxMTQsNyBAQCBzdGF0aWMg aW50IG10a192ZGVjX2NvbXBfaW5pdF9pcnEoc3RydWN0IG10a192ZGVjX2NvbXBfZGV2ICpkZXYp DQo+ID4gICAgICAgICB9DQo+ID4NCj4gPiAgICAgICAgIHJldCA9IGRldm1fcmVxdWVzdF9pcnEo JnBkZXYtPmRldiwgZGV2LT5kZWNfaXJxLA0KPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbXRrX3ZkZWNfY29tcF9pcnFfaGFuZGxlciwNCj4gPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDAsIHBkZXYtPm5hbWUsIGRldik7DQo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBtdGtfdmRlY19jb21wX2lycV9oYW5kbGVyLCAwLCBwZGV2LT5uYW1lLCBk ZXYpOw0KPiBUaGUgY2hhbmdlIGlzIGlycmVsZXZhbnQgdG8gdGhpcyBwYXRjaC4NCldpbGwgZml4 Lg0KPiA+IEBAIC0xNTQsOCArMTU0LDEwIEBAIHN0YXRpYyBpbnQgbXRrX3ZkZWNfY29tcF9wcm9i ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0KPiA+ICAgICAgICAgICAgICAgICBkbWFf c2V0X21hc2tfYW5kX2NvaGVyZW50KCZwZGV2LT5kZXYsIERNQV9CSVRfTUFTSygzNCkpOw0KPiA+ DQo+ID4gICAgICAgICByZXQgPSBtdGtfdmRlY19jb21wX2luaXRfaXJxKGRldik7DQo+ID4gLSAg ICAgICBpZiAocmV0KQ0KPiA+ICsgICAgICAgaWYgKHJldCkgew0KPiA+ICsgICAgICAgICAgICAg ICBkZXZfZXJyKCZwZGV2LT5kZXYsICJGYWlsZWQgdG8gcmVnaXN0ZXIgaXJxIGhhbmRsZXIuXG4i KTsNCj4gPiAgICAgICAgICAgICAgICAgZ290byBlcnI7DQo+ID4gKyAgICAgICB9DQo+IFRoZSBj aGFuZ2Ugc2hvdWxkbid0IGJlIGluIHRoaXMgcGF0Y2guICBJbnN0ZWFkLCBhbm90aGVyIHBhdGNo IHRoYXQNCj4gYWRkcyB0aGUgbXRrX3ZkZWNfY29tcF9pbml0X2lycSgpIGludm9jYXRpb24uDQo+ IA0KPiA+ICtpbnQgbXRrX3Zjb2RlY193YWl0X2Zvcl9jb21wX2RvbmVfY3R4KHN0cnVjdCBtdGtf dmNvZGVjX2N0eCAgKmN0eCwNCj4gUmVtb3ZlIHRoZSBleHRyYSBzcGFjZSBiZWZvcmUgIipjdHgi Lg0KV2lsIGZpeC4NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF6BC11F66 for ; Mon, 12 Jul 2021 08:10:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55E2B61249 for ; Mon, 12 Jul 2021 08:10:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55E2B61249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TTFtb5q9F+OufQhabyRSx58pdYWNGjCIrBSdGovIuoE=; b=quDuAkwO4dNXBW FkkUTl1VyCyrHL7YEF7JeoB4jWT+kYfxI9U5QpjSQZK9eSdsphqulouK4z+BXbTdy7n+gHbgD7XD1 LhxjZjmSt4+l0jsoj5IqjSWl8450e4VRAr0D8VnL8us01wLc8J5TFL3vqWagi2u8Nrmep/116nPzr 5PNvfQCxhJb2dVo5rf90t8YJPoRMhA8kr1LSDvRaT/6V2xl9Pbo+zVXRuVyIvCNYa5dlKHOYEOPqQ 5P6AN3Nnq3fDqIy1NYvv173Od0KNDDF0bT+041H3/Vhj25qgq9NyGo2TKNy2HpAq6EqEX7oV4W2x6 opR4iE5wjhAhqHnWLGMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2r10-006WI7-Lw; Mon, 12 Jul 2021 08:10:10 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2r0x-006WGk-Cn; Mon, 12 Jul 2021 08:10:09 +0000 X-UUID: c675db921c414e84a7299430baf90b56-20210712 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=pYihUe16LMSA8Z5B8sReIfUro/yCMswXaige3lLlv3k=; b=WH3RlvhMtzj5bi2g9GfaCo+Qjkau9BbZftNtDEhMvaunJb4wP5HVjQ9MGlDoAKJV5/RUX6mA/F0BfkDUssc72SEuowPyFrG8JNGOgS5HzMKvQvkRBzY7hW5xO4h0MQQuMQ6erTW+g4QTQvKOyYE6hf+BdfG/bMOsO/luqbrahTs=; X-UUID: c675db921c414e84a7299430baf90b56-20210712 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 536291358; Mon, 12 Jul 2021 01:10:03 -0700 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 01:07:16 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 16:07:08 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 12 Jul 2021 16:07:07 +0800 Message-ID: <1626077227.7221.20.camel@mhfsdcap03> Subject: Re: [PATCH v1, 06/14] media: mtk-vcodec: Add irq interface for core hardware From: mtk12024 To: Tzung-Bi Shih CC: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , "Tiffany Lin" , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , "Fritz Koenig" , Irui Wang , , , , , , , Date: Mon, 12 Jul 2021 16:07:07 +0800 In-Reply-To: References: <20210707062157.21176-1-yunfei.dong@mediatek.com> <20210707062157.21176-7-yunfei.dong@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_011007_490445_BAAC2535 X-CRM114-Status: GOOD ( 21.20 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Tzung-Bi, Thanks for your detail feedback. I add the description according to your each comments. On Fri, 2021-07-09 at 15:59 +0800, Tzung-Bi Shih wrote: > On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong wrote: > > +static int mtk_vcodec_get_hw_count(struct mtk_vcodec_dev *dev) > > +{ > > + if (dev->vdec_pdata->hw_arch == MTK_VDEC_PURE_SINGLE_CORE) > > + return 1; > > + else if (dev->vdec_pdata->hw_arch == MTK_VDEC_LAT_SINGLE_CORE) > > + return 2; > > + else > > + return 0; > > +} > Use a switch .. case .. would be easier to read. Yes > Would it be better to use some macro or enums for the magic numbers? Yes, add enums for magic numbers. enum mtk_vdec_hw_count { MTK_VDEC_NO_HW = 0, MTK_VDEC_ONE_CORE, MTK_VDEC_ONE_LAT_ONE_CORE, MTK_VDEC_MAX_HW_COUNT, }; > > @@ -113,8 +114,7 @@ static int mtk_vdec_comp_init_irq(struct mtk_vdec_comp_dev *dev) > > } > > > > ret = devm_request_irq(&pdev->dev, dev->dec_irq, > > - mtk_vdec_comp_irq_handler, > > - 0, pdev->name, dev); > > + mtk_vdec_comp_irq_handler, 0, pdev->name, dev); > The change is irrelevant to this patch. Will fix. > > @@ -154,8 +154,10 @@ static int mtk_vdec_comp_probe(struct platform_device *pdev) > > dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > > > > ret = mtk_vdec_comp_init_irq(dev); > > - if (ret) > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to register irq handler.\n"); > > goto err; > > + } > The change shouldn't be in this patch. Instead, another patch that > adds the mtk_vdec_comp_init_irq() invocation. > > > +int mtk_vcodec_wait_for_comp_done_ctx(struct mtk_vcodec_ctx *ctx, > Remove the extra space before "*ctx". Wil fix. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BAFC07E99 for ; Mon, 12 Jul 2021 08:11:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C9196191A for ; Mon, 12 Jul 2021 08:11:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C9196191A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WsCS3YwL5yjMJCp6W8EkdiLhBbakePlRsd36W/EOvF4=; b=NPyOJJL7tXQ/gj wisvtas9WamgLaUx//RcvvMf1QrZnkyRZ8JGFm1QXJoz8mjj+6vzrK1R6zDujNrax+P9Yc08OBhoR bm+AVx77Y9TjjjzP85yf0u6M50shEoOJpqzFLp+iAOhvdvafjzZcrvnNP9tv+VuXJBHQqAUOB544K crPvzxfhX6At/MMcLfURO0Tu0zFFO/QAbpH8xGWWaoX54GWNNe9urhwbmvlZ9hLLbnX8pfquTNEoG 6HhONHv4jJ4QOrI7QiZfXNmpwdYt/sDBTp6bcw3ubrKHl0j8SgWVT5XUBN1unek1maSnptULvV8cQ lH5g7OyHWgjJVajqzOjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2r12-006WIN-TO; Mon, 12 Jul 2021 08:10:13 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2r0x-006WGk-Cn; Mon, 12 Jul 2021 08:10:09 +0000 X-UUID: c675db921c414e84a7299430baf90b56-20210712 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=pYihUe16LMSA8Z5B8sReIfUro/yCMswXaige3lLlv3k=; b=WH3RlvhMtzj5bi2g9GfaCo+Qjkau9BbZftNtDEhMvaunJb4wP5HVjQ9MGlDoAKJV5/RUX6mA/F0BfkDUssc72SEuowPyFrG8JNGOgS5HzMKvQvkRBzY7hW5xO4h0MQQuMQ6erTW+g4QTQvKOyYE6hf+BdfG/bMOsO/luqbrahTs=; X-UUID: c675db921c414e84a7299430baf90b56-20210712 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 536291358; Mon, 12 Jul 2021 01:10:03 -0700 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 01:07:16 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 16:07:08 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 12 Jul 2021 16:07:07 +0800 Message-ID: <1626077227.7221.20.camel@mhfsdcap03> Subject: Re: [PATCH v1, 06/14] media: mtk-vcodec: Add irq interface for core hardware From: mtk12024 To: Tzung-Bi Shih CC: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , "Tiffany Lin" , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , "Fritz Koenig" , Irui Wang , , , , , , , Date: Mon, 12 Jul 2021 16:07:07 +0800 In-Reply-To: References: <20210707062157.21176-1-yunfei.dong@mediatek.com> <20210707062157.21176-7-yunfei.dong@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_011007_490445_BAAC2535 X-CRM114-Status: GOOD ( 21.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tzung-Bi, Thanks for your detail feedback. I add the description according to your each comments. On Fri, 2021-07-09 at 15:59 +0800, Tzung-Bi Shih wrote: > On Wed, Jul 7, 2021 at 2:22 PM Yunfei Dong wrote: > > +static int mtk_vcodec_get_hw_count(struct mtk_vcodec_dev *dev) > > +{ > > + if (dev->vdec_pdata->hw_arch == MTK_VDEC_PURE_SINGLE_CORE) > > + return 1; > > + else if (dev->vdec_pdata->hw_arch == MTK_VDEC_LAT_SINGLE_CORE) > > + return 2; > > + else > > + return 0; > > +} > Use a switch .. case .. would be easier to read. Yes > Would it be better to use some macro or enums for the magic numbers? Yes, add enums for magic numbers. enum mtk_vdec_hw_count { MTK_VDEC_NO_HW = 0, MTK_VDEC_ONE_CORE, MTK_VDEC_ONE_LAT_ONE_CORE, MTK_VDEC_MAX_HW_COUNT, }; > > @@ -113,8 +114,7 @@ static int mtk_vdec_comp_init_irq(struct mtk_vdec_comp_dev *dev) > > } > > > > ret = devm_request_irq(&pdev->dev, dev->dec_irq, > > - mtk_vdec_comp_irq_handler, > > - 0, pdev->name, dev); > > + mtk_vdec_comp_irq_handler, 0, pdev->name, dev); > The change is irrelevant to this patch. Will fix. > > @@ -154,8 +154,10 @@ static int mtk_vdec_comp_probe(struct platform_device *pdev) > > dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > > > > ret = mtk_vdec_comp_init_irq(dev); > > - if (ret) > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to register irq handler.\n"); > > goto err; > > + } > The change shouldn't be in this patch. Instead, another patch that > adds the mtk_vdec_comp_init_irq() invocation. > > > +int mtk_vcodec_wait_for_comp_done_ctx(struct mtk_vcodec_ctx *ctx, > Remove the extra space before "*ctx". Wil fix. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel