From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F171C07E9A for ; Wed, 14 Jul 2021 16:38:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8170C613C1 for ; Wed, 14 Jul 2021 16:38:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236312AbhGNQlT (ORCPT ); Wed, 14 Jul 2021 12:41:19 -0400 Received: from foss.arm.com ([217.140.110.172]:36864 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhGNQlS (ORCPT ); Wed, 14 Jul 2021 12:41:18 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25239D6E; Wed, 14 Jul 2021 09:38:26 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6B3083F7D8; Wed, 14 Jul 2021 09:38:25 -0700 (PDT) From: Sudeep Holla To: Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Sudeep Holla Subject: Re: [PATCH] firmware: arm_scmi: Avoid padding in sensor message structure Date: Wed, 14 Jul 2021 17:38:21 +0100 Message-Id: <162628065273.2615991.7447656949078196138.b4-ty@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210628170042.34105-1-cristian.marussi@arm.com> References: <20210628170042.34105-1-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Jun 2021 18:00:42 +0100, Cristian Marussi wrote: > Structure scmi_resp_sensor_reading_complete is meant to represent an SCMI > asynchronous reading complete message: representing the readings field with > a 64bit type forces padding and breaks reads in scmi_sensor_reading_get. > > Split it in two adjacent 32bit readings_low/high subfields to avoid padding > or the need to make it packed. Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/1] firmware: arm_scmi: Avoid padding in sensor message structure https://git.kernel.org/sudeep.holla/c/187a002b07 -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C2FC07E9A for ; Wed, 14 Jul 2021 16:40:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA695613B6 for ; Wed, 14 Jul 2021 16:40:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA695613B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FbxN6LU88FYU8TUOGujb20KSIxBFwEZ5N/c3XXHvyYA=; b=i+TkaGGlAHpnUF RCaSB5vOfHuLDVJlPcEheIUKn0S6cQgMuekP+UnZG5GGeP3xG1mw+IZmsgFBpowfah/3W5GJ+2HV0 eVZr+1A4xkRDomg/yXdcSSzab3paBpAG7bEXOGgKB8oDsaTEro2eTsdhc9+ECmEpp/9AdUQklrsou s2mK8aYAlnGetWSaZGj356WyMq2OdirYAP+X1m9NWrsE6pB0CK+fedxItHc7xc0AmHZrqtIxNAV6w pfILlNKggRfzO/1odR4zoLdmBdigNjHXxOyPIGeRqCjnH31uEqs5FPdJXorDzpJFlKIAhAR3CPFwe 78jmbFhqkM65sT+GNSOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3hu6-00E6zb-7Z; Wed, 14 Jul 2021 16:38:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3hu2-00E6xP-DR for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 16:38:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25239D6E; Wed, 14 Jul 2021 09:38:26 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6B3083F7D8; Wed, 14 Jul 2021 09:38:25 -0700 (PDT) From: Sudeep Holla To: Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Sudeep Holla Subject: Re: [PATCH] firmware: arm_scmi: Avoid padding in sensor message structure Date: Wed, 14 Jul 2021 17:38:21 +0100 Message-Id: <162628065273.2615991.7447656949078196138.b4-ty@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210628170042.34105-1-cristian.marussi@arm.com> References: <20210628170042.34105-1-cristian.marussi@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_093830_536566_9E5EF8DA X-CRM114-Status: UNSURE ( 6.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 28 Jun 2021 18:00:42 +0100, Cristian Marussi wrote: > Structure scmi_resp_sensor_reading_complete is meant to represent an SCMI > asynchronous reading complete message: representing the readings field with > a 64bit type forces padding and breaks reads in scmi_sensor_reading_get. > > Split it in two adjacent 32bit readings_low/high subfields to avoid padding > or the need to make it packed. Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/1] firmware: arm_scmi: Avoid padding in sensor message structure https://git.kernel.org/sudeep.holla/c/187a002b07 -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel