[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915/step: Add macro magic for handling steps

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: series starting with [CI,1/4] drm/i915/step: Add macro magic for handling steps
URL   : https://patchwork.freedesktop.org/series/92849/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c0b839cec037 drm/i915/step: Add macro magic for handling steps
-:24: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#24: FILE: drivers/gpu/drm/i915/intel_step.c:186:
+#define STEP_NAME_CASE(name)	\
+	case STEP_##name:	\
+		return #name;

-:24: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#24: FILE: drivers/gpu/drm/i915/intel_step.c:186:
+#define STEP_NAME_CASE(name)	\
+	case STEP_##name:	\
+		return #name;

-:47: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#47: FILE: drivers/gpu/drm/i915/intel_step.h:20:
+#define STEP_NAME_LIST(func)		\
+	func(A0)			\
+	func(A1)			\
+	func(A2)			\
+	func(B0)			\
+	func(B1)			\
+	func(B2)			\
+	func(C0)			\
+	func(C1)			\
+	func(D0)			\
+	func(D1)			\
+	func(E0)			\
+	func(F0)			\
+	func(G0)			\
+	func(H0)			\
+	func(I0)			\
+	func(I1)			\
+	func(J0)

-:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#47: FILE: drivers/gpu/drm/i915/intel_step.h:20:
+#define STEP_NAME_LIST(func)		\
+	func(A0)			\
+	func(A1)			\
+	func(A2)			\
+	func(B0)			\
+	func(B1)			\
+	func(B2)			\
+	func(C0)			\
+	func(C1)			\
+	func(D0)			\
+	func(D1)			\
+	func(E0)			\
+	func(F0)			\
+	func(G0)			\
+	func(H0)			\
+	func(I0)			\
+	func(I1)			\
+	func(J0)

total: 2 errors, 1 warnings, 1 checks, 71 lines checked
ef7c2d172b12 drm/i915/dmc: Change intel_get_stepping_info()
4a8d375d3242 drm/i915/firmware: Update to DMC v2.12 on TGL
-:10: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Madhumitha Pradeep <'
#10: 
Reviewed-by: Madhumitha Pradeep <

total: 1 errors, 0 warnings, 0 checks, 10 lines checked
55698bd418a0 drm/i915/firmware: Update to DMC v2.03 on RKL
-:12: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Madhumitha Pradeep <'
#12: 
Reviewed-by: Madhumitha Pradeep <

total: 1 errors, 0 warnings, 0 checks, 10 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx